export of Calc functions to OOXML

2014-07-15 Thread Winfried Donkers
Hi, The Calc function GAMMADIST has an optional 4th argument (cumulative), whereas this argument is mandatory for Excel. When saving a document with function GAMMADIST as xls, this argument is added if necessary (in /sc/source/filter/excel/xeformula.cxx). When saving this document as xlsx, this

RE: export of Calc functions to OOXML

2014-07-21 Thread Winfried Donkers
Hi Eike, >> The Calc function GAMMADIST has an optional 4th argument (cumulative), >> whereas this argument is mandatory for Excel. >> When saving a document with function GAMMADIST as xls, this argument is >> added if necessary (in /sc/source/filter/excel/xeformula.cxx). >> When saving this doc

RE: export of Calc functions to OOXML

2014-07-21 Thread Winfried Donkers
Hi Eike, >> It seems to me that re-implementing the OOXML export functionality is rather >> a complex business, i.e. not something suitable for me. Shall I create a bug >> report for this? > [ ... ] > If you want to take a stab at this just tell me, otherwise I'll do. > A bug report might be g

RE: export of Calc functions to OOXML

2014-07-29 Thread Winfried Donkers
Hi Eike, > There are already entry points that do something similar for the old non-ODFF > (aka PODF) OOo-XML format, i.e. in formula/source/core/api/FormulaCompiler.cxx > FormulaCompiler::CreateStringFromTokenArray() and in > formula/source/core/api/token.cxx all functions with *Rewrite*() >

RE: export of Calc functions to OOXML

2014-07-31 Thread Winfried Donkers
Hi Eike, (re-introducing the mailing list I left out in my previous reply) >> FormulaGrammar::isOOXML( meGrammar ) only returns true when saving as >> OOXML, and FormulaGrammar::isODFF( meGrammar ) only returns true when saving >> as ODFF. >> Is that correct? > Yes, that's correct. Also note th

RE: fdo77985 Calc function NETWORKDAYS

2014-05-09 Thread Winfried Donkers
Hi Eike, >Rather implement an ODFF compliant NETWORKDAYS function at the interpreter >that shares implementation with ScNetWorkdays_MS() (syntax and semantics are >equal, aren't they? I didn't look up now) and rename the Add-In one to >NETWORKDAYS_ADD, note that this will also need adapting the

[Libreoffice-commits] core.git: sc/source

2014-05-12 Thread Winfried Donkers
sc/source/ui/app/inputhdl.cxx | 76 +- sc/source/ui/inc/inputhdl.hxx |2 + 2 files changed, 48 insertions(+), 30 deletions(-) New commits: commit 5b0b7553241bb5150b12bbf7625b4b0b36970272 Author: Winfried Donkers Date: Tue Feb 25 08:14:55 2014

RE: Additional predefined label formats #fdo79068

2014-05-22 Thread Winfried Donkers
Hi Regina, Having added/changed a lot of the labels already, I'm willing to add these too (if that's what you mean). Or do you intend to add them yourself? Winfried -Oorspronkelijk bericht- Van: LibreOffice [mailto:libreoffice-boun...@lists.freedesktop.org] Namens Regina Henschel Verz

RE: Sort and copy results

2014-06-05 Thread Winfried Donkers
Hi Kohei, > > Yes. I'm almost certain that some enterprise users actually use this > > feature. > I'd like to know they still exist though, rather than speculating that they > still do. I hate to disappoint you, but the company I work with does. And I would think that LibreOffice would aim to

RE: loperf: performance regressions

2014-06-05 Thread Winfried Donkers
Hi Matus, > Btw, loperf already helped me once to notice regression caused by my commit > [3], fixed later [4], so it's quite useful I'd say. > Do you think it makes sense to let you know if I notice any regressions as in > this e-mail? > Presumably yes, hopefully people are interested in fixin

RE: Sort and copy results

2014-06-06 Thread Winfried Donkers
Hi Kohei, > Good. Now I have someone real I can ask. > Can I ask in what use case this feature is used? Why does your use case > require that copying and sorting have to be done in one step, rather than in > two separate steps? Well, we're talking of a company, I don't use it personally. O

RE: GAMMA.DIST

2014-06-23 Thread Winfried Donkers
Hi Olivier, GAMMA.DIST and quite a lot of other renamed and new Excel 2010 functions have been added, all connected to metabug fdo70798. This will at least give information which function have been added. In the metabug is also a link to a MS-page which describes all these new and renamed functi

how to cope with Calc functions that have an optional argument, which is mandatory in Excel?

2014-06-26 Thread Winfried Donkers
Hi, Currenty I am looking at fdo#40835, which mentions the problem that Excel function F.DIST has 4 required arguments and that ODF1.2 function FDIST has the same arguments, only the last argument is optional. I have found in classes FormulaParser and FormulaFinalizer (/core/sc/source/filter/i

RE: how to cope with Calc functions that have an optional argument, which is mandatory in Excel?

2014-06-27 Thread Winfried Donkers
Hi, >Currently I am looking at fdo#40835, which mentions the problem that Excel >function F.DIST has 4 required arguments and that ODF1.2 function FDIST has >the same arguments, only the last argument is optional. >Is there code that handles my case? Otherwise I may have to introduce an extra

[Libreoffice-commits] core.git: sc/source

2014-04-09 Thread Winfried Donkers
sc/source/core/inc/interpre.hxx |8 sc/source/core/tool/interpr2.cxx | 64 +-- 2 files changed, 35 insertions(+), 37 deletions(-) New commits: commit 8facc14e88251d9356995d9e8e213084212e88a5 Author: Winfried Donkers Date: Fri Apr 4 13:56:07 2014

[Libreoffice-commits] core.git: formula/source include/formula sc/inc sc/qa sc/source

2014-04-11 Thread Winfried Donkers
/filter/oox/formulabase.cxx |2 + sc/source/ui/src/scfuncs.src | 46 + 12 files changed, 99 insertions(+), 3 deletions(-) New commits: commit 56deaabb32346e0cc9c6946d7d53ba251f4450b2 Author: Winfried Donkers Date: Fri Apr 11 09:46:51 2014

fdo70798 Add Excel 2010 functions to Calc

2014-04-14 Thread Winfried Donkers
Hi Eike, AFAICS there's only one Excel 2010 function left to be added to Calc: AGGREGATE. I can add this function with partial functionality: all aggregate functions will be available, but the various filter options will not all be implemented. I think this way most of the functionality will be a

(not) getting a backtrace with WinDbg

2014-04-16 Thread Winfried Donkers
Hi, I'm trying to get a useful backtrace for a 'hang' problem with Writer and using Visio for embedded objects. However, in WinDbg '!analyze -v' produces no proper backtrace and reports 'Symbol file could not be found' (see attachment). The Symbol file path has been filled explained as in http

RE: (not) getting a backtrace with WinDbg

2014-04-16 Thread Winfried Donkers
Hi Christian, >You don't state what version of LO you're trying with, you don't state version >of Windows, etc., whether it worked for you before, .. version 4.2.3.3, Windows 7 professional, it never worked before. I followed the steps in the wiki ( https://wiki.documentfoundation.org/How_to_ge

[Libreoffice-commits] core.git: formula/source include/formula sc/inc sc/qa sc/source

2014-04-25 Thread Winfried Donkers
: Winfried Donkers Date: Thu Apr 17 21:58:26 2014 +0200 fdo#73148 (partial patch) Add Excel 2010 function AGGREGATE Change-Id: If8fc8608699a14e573456af2e1180342be942dd1 Reviewed-on: https://gerrit.libreoffice.org/8475 Reviewed-by: Eike Rathke Tested-by: Eike Rathke diff

fdo77985 Calc function NETWORKDAYS

2014-04-29 Thread Winfried Donkers
Hi Eike, all, Calc function NETWORKDAYS is an add-in function and compatible with Excel's function NETWORKDAYS, but _not_ with Oasis ODFF 1.2 (http://docs.oasis-open.org/office/v1.2/cos01/OpenDocument-v1.2-cos01-part2.html#__RefHeading__1018198_715980110) . My first impression is that I could

RE: fdo77985 Calc function NETWORKDAYS()

2014-04-29 Thread Winfried Donkers
2014 16:24 Aan: Winfried Donkers Onderwerp: NETWORKDAYS() Hi Winfried, maybe I'm wrong but reading in ODF definition I think the third parameter it's the same as excel. It's a fourth parameter for ODF about what weekdays are the workdays. "The optional 3rd parameter Hol

RE: fdo77985 Calc function NETWORKDAYS

2014-05-07 Thread Winfried Donkers
Hi Eike, >I'd avoid changing existing Add-In functions, it's a source of hassle ;-) Fine, I prefer to keep away from the add-in code, too. >Rather implement an ODFF compliant NETWORKDAYS function at the interpreter >[...] OK, then there will be 3 NETWORKDAYS functions: Add-in, OOXML and ODFF:

make error

2013-03-20 Thread Winfried Donkers
I upgraded my machine to openSUSE 12.3, did a ./g pull --rebase and ran make dev-install, resulting in the following error: […] [build CXX] codemaker/source/commonjava/commonjava.cxx [build LNK] StaticLibrary/libcodemaker_java.a [build CXX] codemaker/source/javamaker/classfile.cxx [build CXX] cod

RE: make error

2013-03-20 Thread Winfried Donkers
Hi Michael, > that is very odd, your javac does not understand -source and -target > parameters. can you try installing OpenJDK instead? I have java-1_6_0-openjdk installed. I also trried with java-1_7_0-openjdk, but that had the same result, so I switched backup to 1_6. Should I remove java-

RE: make error

2013-03-20 Thread Winfried Donkers
Hi Michael, > try removing gcj instead. I did; autogen.sh went fine, make is now running. Thank you for your advise, I will report when it doesn't help in the end :) Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.

RE: Build failures of LO master on openSUSE

2012-11-29 Thread Winfried Donkers
Hi Stephan, >Found some lines: > >: WARNING: Source for shared_en-US.zip not found! > ... >Looks to me like some i18n files are missing. Anyone have an idea how to solve >this? Did you use git pull -r to update or ./g pull -r? The latter also updates submodules such as the language packs. It so

RE: Change in core[master]: fdo#56124 add calc functions IFERROR and IFNA as in ODFF1.2

2012-12-06 Thread Winfried Donkers
This time to the ML as well... Winfried > -Oorspronkelijk bericht- > Van: Winfried Donkers > Verzonden: donderdag 6 december 2012 12:52 > Aan: 'er...@redhat.com' > Onderwerp: RE: Change in core[master]: fdo#56124 add calc functions > IFERROR and IFN

RE: Change in core[master]: fdo#56124 add calc functions IFERROR and IFNA as in ODFF1.2

2012-12-09 Thread Winfried Donkers
Hi Eike > > To finally find out what goes wrong, I copied the contents of SCIfJump() > > into > > ScIfError(), made ocIfError do the same as ocIf (except in lotus/excel > > filter > > files) and gave IFERROR() 3 arguments (just as IF()). > > It still doesn't work: IFERROR(X;Y;Z) always returns Y

fdo57180 add function NUMBERVALUE() to calc as defined in ODFF1.2

2012-12-13 Thread Winfried Donkers
Hi Eike, The coding of this function seems to be going nicely, but for the string to double conversion I would like some pointers/interpretations. 1. ODFF1.2 refers to 'xsd:float' and conversion 'according to the definition provided in XML Schema, Part 2, Section 3.2.4'. I don't think I found th

additional calc functions produce warnings

2012-12-14 Thread Winfried Donkers
Hi Tino, AFAIR you recently added the pricing functions. When running calc to test my code changes, I get lots of: warn:legacy.osl:11918:1:/home/w.donkers/git/libo/tools/source/rc/resmgr.cxx:773: file:///home/w.donkers/git/libo/solver/unxlngi6/installation/opt/program/../program/resource/pricin

RE: additional calc functions produce warnings

2012-12-14 Thread Winfried Donkers
Hi Tino, > Also, what did you change, and did you get the same warnings before? I didn't have these warnings before you submitted the pricing functions, naturally :) My changes have to do with adding new calc functions lwhich are defined in ODFF1.2, but not yet present in calc. These include IFE

RE: additional calc functions produce warnings

2012-12-17 Thread Winfried Donkers
> . ./ooenv > gdb ./soffice.bin > break tools/source/rc/resmgr.cxx:773 > run --calc > and get the backtrace of that warning. That'll help indicate what's going on. > These are indeed the .res file parser and so its fairly "mundane" code. e.g. > missing resources of double freeresource of some such

RE: fdo57180 add function NUMBERVALUE() to calc as defined in ODFF1.2

2012-12-17 Thread Winfried Donkers
Hi Eike, > http://www.w3.org/TR/xmlschema-2/#float > Note however that our data type is double, not float, so > http://www.w3.org/TR/xmlschema-2/#double > [...] > See above ;-) and sal/inc/rtl/math.hxx Thank you! I will use your information and probaly submit a patch soon :) Winfried __

RE: additional calc functions produce warnings

2012-12-17 Thread Winfried Donkers
sktop.org] > Namens Winfried Donkers > Verzonden: maandag 17 december 2012 11:39 > Aan: Caolán McNamara > CC: tino; libreoffice@lists.freedesktop.org > Onderwerp: RE: additional calc functions produce warnings > > > . ./ooenv > > gdb ./soffice.bin > > break

lots of .tests output during make hides error messages

2013-01-28 Thread Winfried Donkers
Recently, when building a lot of output from typedef.tests, polystruct.tests, methodoverload.tests, published.tests and more is produced. Ufortunately, when there is an error in the code to be compiled, it gets hidden between the test-output. The tests-output continues after a compile error. 'Lo

RE: lots of .tests output during make hides error messages

2013-01-28 Thread Winfried Donkers
> Michael Stahl wrote on maandag 28 januari 2013 12:37 > > that annoying test spew is fixed on master with > 7cf3b1ffcb8dc6dbb643e12febe5415972a7c2fa > Great, I'll git pull --rebase inmediately :) Winfried ___ LibreOffice mailing list LibreOffice@list

RE: lots of .tests output during make hides error messages

2013-01-28 Thread Winfried Donkers
> Lubos Lunak wrote on maandag 28 januari 2013 12:49 > > build_error.log used to be a file with build output from the module where > build failed. Given that today pretty much everything is built from > tail_build, > it would be equivalent to 'make 2>&1 | tee build_error.log' . > Thank you for

fdo#40465 code pointers wanted (writer: page jumps when number of pages next to each other on screen changes)

2013-02-01 Thread Winfried Donkers
Hi all, I have been working on and off at bug fdo#40465. The problem is that when the width of the window showing the document changes to an extend that the number of pages next to each other (the number of columns) changes, the visible page jumps. If in a multi-page document that shows 2 pages

[Libreoffice-commits] .: formula/inc sc/qa sc/source sc/util

2013-02-02 Thread Winfried Donkers
/filter/oox/formulabase.cxx |2 sc/source/ui/src/scfuncs.src | 16 - sc/util/hidother.src |1 8 files changed, 171 insertions(+), 6 deletions(-) New commits: commit 06b8f15c8dd23504b8e087451ee5c82eb74edd81 Author: Winfried Donkers Date: Mon Jan 28 16:19:00

add more ODFF v1.2 functions to calc

2013-02-07 Thread Winfried Donkers
Hi Eike, I propose that I add the LEGACY.XXX functions to calc next. They seem to be mathematical variations of the XXX functions, which are already present in calc. I intend to use as much common methods as possible. Do you have objections against this (e.g. these functions being in an AOOo pa

[Libreoffice-commits] core.git: formula/inc formula/source sc/inc sc/qa sc/source

2013-02-08 Thread Winfried Donkers
/source/filter/oox/formulabase.cxx |2 - sc/source/ui/src/scfuncs.src | 24 ++ 12 files changed, 74 insertions(+), 4 deletions(-) New commits: commit df931a5b0f48707e34ebfacb695996198ece8f44 Author: Winfried Donkers Date: Wed Feb 6 19:09:00 2013

RE: add more ODFF v1.2 functions to calc

2013-02-08 Thread Winfried Donkers
Hi Regina, > > I'm not aware, that any LEGACY.XXX function is missing. FDIST (the new > one) is still missing, because there is still no decision how to handle > incompatibility with older documents and versions. Remember, that the > ODF1.2 spec contains the function names for the file format, no

RE: fdo#40465 code pointers wanted (writer: page jumps when number of pages next to each other on screen changes)

2013-02-08 Thread Winfried Donkers
Hi Caolán, > Is it any use to you to put a breakpoint in SwView::SetVisArea and step into > SwCrsrShell::VisPortChgd -> ViewShell::VisPortChgd to see what looks like > relevant calculations and/or a breakpoint on SwViewImp::SetFirstVisPage. Thank you, I will do that and hopefully get to the cause

[Libreoffice-commits] core.git: sw/source

2013-02-09 Thread Winfried Donkers
sw/source/core/view/viewsh.cxx | 214 ++--- 1 file changed, 96 insertions(+), 118 deletions(-) New commits: commit c1e3943ceac62209b78e13a42ea67044383f4798 Author: Winfried Donkers Date: Fri Feb 8 19:32:39 2013 +0100 translate German comments, remove

[Libreoffice-commits] core.git: sw/source

2013-02-09 Thread Winfried Donkers
sw/source/core/view/viewimp.cxx | 132 +++- 1 file changed, 10 insertions(+), 122 deletions(-) New commits: commit 65e0bf7c4760c51b2357d9c57dd23e6c61b116cb Author: Winfried Donkers Date: Fri Feb 8 16:37:09 2013 +0100 translate German comments, remove

[Libreoffice-commits] core.git: sc/source

2013-02-09 Thread Winfried Donkers
sc/source/ui/view/cellsh1.cxx | 74 ++ 1 file changed, 54 insertions(+), 20 deletions(-) New commits: commit 5fe7b7561aa78e87f90e8a9436cb674e53ef8f4e Author: Winfried Donkers Date: Mon Jan 28 18:42:38 2013 +0100 fdo#56098 paste special shift

RE: [PUSHED] patch removing Labels.xcu out of configuration

2013-02-14 Thread Winfried Donkers
Hi Matus, > > I've finished my first patch on reducing configuration data > > There were a few corner-case packaging pieces of interest that > needed fixing on a from-clean build but it's pushed now :-) A great improvement! If there are any leftovers (like perhaps the not being able to sav

RE: [PUSHED] patch removing Labels.xcu out of configuration

2013-02-14 Thread Winfried Donkers
Hi Matus, > Well, overwriting existing labels does not work I think, but it did not before > either, so.. I think that's fine. > If you would like to fix this, poke IMPL_LINK_NOARG(SwSaveLabelDlg, > OkHdl) in sw/source/ui/envelp/labfmt.cxx Maybe if(RET_YES != eRet) makes > it return before saving

RE: patch removing Labels.xcu out of configuration

2013-02-17 Thread Winfried Donkers
Hi Matus, Michael, > Well, overwriting existing labels does not work I think, but it did not before > either, so.. I think that's fine. > If you would like to fix this, poke IMPL_LINK_NOARG(SwSaveLabelDlg, > OkHdl) in sw/source/ui/envelp/labfmt.cxx Maybe if(RET_YES != eRet) makes > it return befor

[REVIEW 4.0] fdo #56098, calc Paste Special Options incorrect

2013-04-05 Thread Winfried Donkers
I forget to ask for a review when it was pushed, but could the patch for this bug, pushed with https://gerrit.libreoffice.org/1671 and https://gerrit.libreoffice.org/1903 be cherry-picked for 4.0? Thanks! Winfried ___ LibreOffice mailing list LibreOff

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - 2 commits - sc/source

2013-04-05 Thread Winfried Donkers
sc/source/ui/view/cellsh1.cxx | 77 +- 1 file changed, 54 insertions(+), 23 deletions(-) New commits: commit e8ff6eeb29c89f4dd7c0c088ad4eb8e6fbeb Author: Winfried Donkers Date: Mon Jan 28 18:42:38 2013 +0100 fdo#56098 paste special shift

build failure

2013-04-05 Thread Winfried Donkers
After a ./g pull --rebase, I can't build anymore: ... [build MOD] cppu [build MOD] cppuhelper [build MOD] cui [build MOD] dbaccess [build CXX] helpcompiler/source/HelpLinker.cxx /home/w.donkers/git/libo/helpcompiler/source/HelpLinker.cxx:38:19: fatal error: expat.h: File or directory does not exis

RE: build failure

2013-04-05 Thread Winfried Donkers
Hi Michael, > :-) any chance of: > > cd helpcompiler > make > > which should show all the include paths for that compilation, and > then I guess we should be able to easily see the missing -I/path/ line needed. S=/home/w.donkers/git/libo && O=$S/solver/unxlngi6 && W=$S

RE: build failure

2013-04-08 Thread Winfried Donkers
> The bit that should include expat is: > > -I$O/inc/external/expat > > Where $O=/home/w.donkers/git/libo/solver/unxlngi6 > > Do you really not have an expat.h in there ? I do :-) No, I don't :-( > > You said: > > > The file expat.h does exist in lots of locatio

RE: build failure

2013-04-08 Thread Winfried Donkers
Hi Michael, > > have taken the drastic step of removing the entire codebase locally > > Sounds like that should help, or a 'git clean -d -f' or something might > save some downloading ;-) though it is a bit drastic too. Guess what: removing my entire local repository, using git clone to cr

RE: build failure

2013-04-09 Thread Winfried Donkers
Hi David, > Pull :-) It should be fixed by commit > 35c53bbcc8f0a7b8627a8d5a2e167d76dc52d1c4 . I pulled :-) and am building now. I will report the result (which will take a lot of hours on this machine). > > What happened is that gb_LinkTarget__use_expat for internal expat only > depended on t

RE: hints asked for fdo#59727

2013-05-17 Thread Winfried Donkers
Hi Eike, >The correct place would be a duplicate of saFuncTableOdf[], say >saFuncTableOOoLO[], just to keep things cleanly separated because the >functions are only known to LO and not defined in OpenFormula. The >saFuncTableOOoLO also needs to be added to >FunctionProviderImpl::FunctionProviderIm

RE: fdo#59727 calc add-in functions and xlsx im/export

2013-05-21 Thread Winfried Donkers
Hi Eike, A contribution to your post-vacation pile of mails... > Let's postpone this. I'll be on vacation now anyway and couldn't investigate > or help. I may have to take over when I return. I'll leave the bug as it is, we'll communicate again when you're back and have time. Winfried

[UX advice] fdo#64626, changing borders of cells in calc

2013-05-21 Thread Winfried Donkers
Hi, In calc one can place inner and outer borders on (a range of) cells. The current behaviour is that one cannot remove these borders, unless all inner or outer borders are removed. Example: Select cell and put right, bottom, left and top borders around it. Now change that to top and bottom on

RE: build failure

2013-04-10 Thread Winfried Donkers
It tok > > Pull :-) It should be fixed by commit > > 35c53bbcc8f0a7b8627a8d5a2e167d76dc52d1c4 . > > I pulled :-) and am building now. I will report the result (which will take a > lot > of hours on this machine). It took some ours of hard work (for the machine) and it finished the build success

[PATCH] fdo#40100 correct result of calc function YEARFRAC

2013-04-12 Thread Winfried Donkers
opnions on that further improvement, Eike, you will certainly have something to say about that. WinfriedFrom a897334a5d183d24a2ec2dacfe50bf21239b78a6 Mon Sep 17 00:00:00 2001 From: Winfried Donkers Date: Thu, 11 Apr 2013 17:37:33 +0200 Subject: [PATCH] fdo#40100 correct result of calc functio

[ABANDONED] fdo#40100 correct result of calc function YEARFRAC

2013-04-13 Thread Winfried Donkers
I have access to gerrit again, I will submit there. >Verzonden: vrijdag 12 april 2013 17:19 >Onderwerp: [PATCH] fdo#40100 correct result of calc function YEARFRAC >For some reason I can't connect with gerrit, so I submit this patch in the >classic way. >T

[Libreoffice-commits] core.git: scaddins/source

2013-04-17 Thread Winfried Donkers
scaddins/source/analysis/analysishelper.cxx | 206 +--- scaddins/source/analysis/analysishelper.hxx |5 2 files changed, 130 insertions(+), 81 deletions(-) New commits: commit 275e68d141179272258d03194d799495fa3dec4a Author: Winfried Donkers Date: Sat Apr 13 19

RE: Trouble creating logerrit account

2013-04-18 Thread Winfried Donkers
> 18 april 2013 12:23, Bjoern Michaelsen wrote > > On Thu, Apr 18, 2013 at 08:54:52AM +0100, Wols Lists wrote: > > My old key didn't work so I created a new key (this one) using the > > instructions on the website that logerrit sent me to. > > Just googling around a bit, this might be that your

[REVIEW 4.0] fdo#40100 YEARFRAC function returns incorrect results for some dates

2013-04-21 Thread Winfried Donkers
Can this fix be cherry-picked for 4.0 releases (4.0.3 would be extremely nice)? The fix solves various small erroneous results of the calc function YEARFAC. BTW, http://wiki.services.openoffice.org/wiki/Documentation/How_Tos/Calc:_YEARFRAC_function now no lnger applies for LibreOffice ;-) Wi

[REVIEW 4.0] fdo#40100 YEARFRAC function returns incorrect results for some dates

2013-04-21 Thread Winfried Donkers
Can this fix be cherry-picked for 4.0 releases (4.0.3 would be extremely nice)? The fix solves various small erroneous results of the calc function YEARFAC. Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freede

RE: [REVIEW 4.0] fdo#40100 YEARFRAC function returns incorrect results for some dates

2013-04-22 Thread Winfried Donkers
Please disregard thuis second review proposal; I accidentily sent the request twice... Winfried Van: Winfried Donkers Verzonden: maandag 22 april 2013 08:45 Aan: libreoffice@lists.freedesktop.org Onderwerp: [REVIEW 4.0] fdo#40100 YEARFRAC function returns incorrect results for some dates

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - scaddins/source

2013-04-22 Thread Winfried Donkers
scaddins/source/analysis/analysishelper.cxx | 208 +--- scaddins/source/analysis/analysishelper.hxx |5 2 files changed, 131 insertions(+), 82 deletions(-) New commits: commit bd9238f3fe4bd004cb77e89813eb730e1e865667 Author: Winfried Donkers Date: Sat Apr 13 19

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0-3' - scaddins/source

2013-04-24 Thread Winfried Donkers
scaddins/source/analysis/analysishelper.cxx | 208 +--- scaddins/source/analysis/analysishelper.hxx |5 2 files changed, 131 insertions(+), 82 deletions(-) New commits: commit 73623e57b50c461ab3df95065d56908825144009 Author: Winfried Donkers Date: Sat Apr 13 19

hints asked for fdo#59727

2013-04-24 Thread Winfried Donkers
Hi, Bug fdo59727 is about addin function MONTHS() that is not interpreted correctly when read from an xlsx file. That is, an xlsx file with the function "MONTHS(...)" opened with calc shows "com.sun.star.sheet.addin.datefunctions.getdiffmonths(...)" and understandably results to #NAME? . The p

[REVIEW] fdo#59405 rregression: insert of Visio objects

2013-02-25 Thread Winfried Donkers
First of all: big kudo for Michael Stahl! Secondly, could it be possible to cherry-pick this to version 4.0.1 as well? Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

RE: [PUSHED 4-0, 4-0-1] fdo#59405 rregression: insert of Visio objects

2013-02-26 Thread Winfried Donkers
Hi Petr, > > Secondly, could it be possible to cherry-pick this to version 4.0.1 as > > well? > > I see this pushed in both 4-0 and 4-0-1 branches now. I noticed it too :) Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http:

RE: The mouse-centered zooming work from last year

2013-03-04 Thread Winfried Donkers
Hi Tor, Tim, > > Last year there was work by Tim Hardeck to implement mouse-centered > > zooming. See > > http://nabble.documentfoundation.org/Libreoffice-ux-advise-PATCH- > Mouse > > -centered-zooming-td3906261.html for instance. For some reason that > > work never got included in the sources, I

RE: The mouse-centered zooming work from last year

2013-03-04 Thread Winfried Donkers
Hi Tor, > Tim's patch provides some pointers. > > To avoid overlapping efforts, please post comments in that bug whenever > you have some progress. I will look at the patch and keep posting comments in fdo#40465. Winfried ___ LibreOffice mailing list

[Libreoffice-commits] core.git: extras/source sw/source

2013-03-06 Thread Winfried Donkers
files changed, 155 insertions(+), 164 deletions(-) New commits: commit 2d66aad26750c47659e3445e18d9a385658e3328 Author: Winfried Donkers Date: Thu Feb 28 18:05:52 2013 +0100 some refinements on label configurations in writer Change-Id: I94ad02972b0fae1327f72a41373f34962452b8ef

RE: Killing the gerrit to dev-list spam ...

2013-05-01 Thread Winfried Donkers
> So, is there anyone who is _not_ a sponsored developer opposing to kill the > mail spammage? If so: > > - could this be mitigated by a separate gerrit-patches mailing list? > - could this be mitigated by a daily digest of "gerrit news"? > - could this be mitigated by other means? I would be hap

RE: Killing the gerrit to dev-list spam ...

2013-05-01 Thread Winfried Donkers
>>I would be happy with a daily digest. >Next question to ask though with daily digests how many times a day will they >be sent out? would they be sent out every hour every few hours once to twice a >day? I had once a day in my mind, but every 8 hours might be better, given the world wide comm

RE: hints asked for fdo#59727

2013-05-02 Thread Winfried Donkers
Hi Eike, > Only if the .xlsx was saved with Calc 4.0, then the file contains > com.sun.star.sheet.addin.DateFunctions.getDiffMonths, an original file > containing MONTHS() also does not work though, the MONTHS is not > recognized hence displayed as lowercase months. Seems to be a specific > proble

RE: hints asked for fdo#59727

2013-05-07 Thread Winfried Donkers
Hi Eike, > > There are more problems with the add-in functions, see attachments with > bug 59727. > > I assumed so.. > > There are several places where things could go wrong.. > [...] > I'd start by setting a breakpoint in > formula/source/core/api/FormulaCompiler.cxx > FormulaCompiler::CreateStr

RE: hints asked for fdo#59727

2013-05-14 Thread Winfried Donkers
Hi Eike, > > There are more problems with the add-in functions, see attachments with > > bug 59727. > I'd start by setting a breakpoint in > formula/source/core/api/FormulaCompiler.cxx > FormulaCompiler::CreateStringFromToken() for case svExternal and step > through to see what is actually execut

RE: hints asked for fdo#59727

2013-05-15 Thread Winfried Donkers
Hi Eike, > They are implemented in scaddins/source/datefunc/ I wouldn't have looked for ROT13 there... Is that a location to be maintained or should it be moved to scaddins/source/analysis? > It seems they are missing from sc/source/filter/oox/formulabase.cxx so > adding them there should solve

[Libreoffice-commits] core.git: sc/qa sc/source

2017-09-06 Thread Winfried Donkers
sc/qa/unit/data/functions/text/fods/findb.fods | 225 - sc/source/core/tool/interpr1.cxx |2 2 files changed, 81 insertions(+), 146 deletions(-) New commits: commit 1683f9848c3bd89fff430330a500756c4b130457 Author: Winfried Donkers Date: Tue Sep 5 21

[Libreoffice-commits] core.git: sc/qa sc/source

2017-09-07 Thread Winfried Donkers
sc/qa/unit/data/functions/financial/fods/nper.fods | 36 +++-- sc/source/core/tool/interpr2.cxx |2 - 2 files changed, 27 insertions(+), 11 deletions(-) New commits: commit 003c2cfaa258e204402a366a105366da74e220a2 Author: Winfried Donkers Date: Wed Sep

[Libreoffice-commits] core.git: formula/inc include/formula sc/inc sc/qa sc/source

2017-09-07 Thread Winfried Donkers
Author: Winfried Donkers Date: Mon Sep 4 16:00:59 2017 +0200 tdf#107135 Add missing ODFF function SEARCHB. Change-Id: Ic72693ad8f33fb94c171751f82680eabad1d3d6d Reviewed-on: https://gerrit.libreoffice.org/41900 Tested-by: Jenkins Reviewed-by: Eike Rathke diff --git a

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/qa sc/source

2017-09-07 Thread Winfried Donkers
sc/qa/unit/data/functions/financial/fods/nper.fods | 36 +++-- sc/source/core/tool/interpr2.cxx |2 - 2 files changed, 27 insertions(+), 11 deletions(-) New commits: commit 085768b2a0dd1fc6371e8b2ba4e2418ba96cdb21 Author: Winfried Donkers Date: Wed Sep

[Libreoffice-commits] core.git: sc/qa sc/source

2017-09-13 Thread Winfried Donkers
sc/qa/unit/data/functions/statistical/fods/geomean.fods | 83 ++-- sc/source/core/tool/interpr3.cxx| 50 + 2 files changed, 124 insertions(+), 9 deletions(-) New commits: commit 65ea925d173db0f319a8ca78855587d089e5270d Author: Winfried Donkers

RE: ODFF1.2 GEOMEAN

2017-09-14 Thread Winfried Donkers
Hi Eike, As we now have changed GEOMEAN, I think it would be wise to try to improve ODFF1.2 as well for GEOMEAN. Winfried Van: LibreOffice [mailto:libreoffice-boun...@lists.freedesktop.org] Namens Winfried Donkers Verzonden: woensdag 26 juli 2017 12:06 Aan: libreoffice@lists.freedesktop.org

ODFF1.2 interpretation of function WEEKNUM

2017-09-18 Thread Winfried Donkers
Hi Eike, I'm working on tdf112320 and I think that ODFF1.2 may be ambiguous with respect to WEEKNUM (http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part2.html#WEEKNUM) My interpretation of the Semantics for Mode 1,2,11-17 was that 'every week starts on Sunday..Saturday, depe

[Libreoffice-commits] core.git: sc/source

2016-10-13 Thread Winfried Donkers
sc/source/core/inc/interpre.hxx |2 +- sc/source/core/tool/interpr3.cxx |5 +++-- sc/source/core/tool/interpr4.cxx |4 ++-- 3 files changed, 6 insertions(+), 5 deletions(-) New commits: commit 52c79bbd1b4c58124738b59214a3f2b111ff0191 Author: Winfried Donkers Date: Wed Sep 21 17

[Libreoffice-commits] core.git: sc/source

2016-10-13 Thread Winfried Donkers
sc/source/core/tool/interpr8.cxx | 37 + 1 file changed, 13 insertions(+), 24 deletions(-) New commits: commit ad707a3dafd020949cfd94098dc51c69466dafb8 Author: Winfried Donkers Date: Tue Sep 20 08:04:50 2016 +0200 tdf#94635 follow up; correct

[Libreoffice-commits] core.git: sc/qa sc/source

2016-10-13 Thread Winfried Donkers
sc/qa/unit/data/functions/fods/forecast.ets.mult.fods | 4060 +- sc/source/core/tool/interpr8.cxx | 19 2 files changed, 2093 insertions(+), 1986 deletions(-) New commits: commit fb790880eb11552b2e7d1dcf6c09d2663712290f Author: Winfried Donkers Date

[Libreoffice-commits] core.git: sc/qa sc/source

2016-10-13 Thread Winfried Donkers
sc/qa/unit/data/functions/fods/mod.fods | 1702 +--- sc/source/core/tool/interpr2.cxx| 23 2 files changed, 1169 insertions(+), 556 deletions(-) New commits: commit d8257535e348fa0b0a5c269d1aafa710585421d6 Author: Winfried Donkers Date: Wed Sep 28 16:34

Add arguments to Calc functions when exporting to xls

2016-10-13 Thread Winfried Donkers
Hi Eike, Currently I'm working on tdf103186, LOGINV, which has optional arguments that are mandatory in Excel. There is a class MissingConventionOOXML, so adding arguments for export to OOXML is no problem. But I don't see a similar class for xls, probably because that export/saving mechanism i

Re: Add arguments to Calc functions when exporting to xls

2016-10-14 Thread Winfried Donkers
Hi Eike, Appending parameters is done in sc/source/filter/excel/xeformula.cxx XclExpFmlaCompImpl::AppendTrailingParam() Thanks! :-) Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listin

[Libreoffice-commits] core.git: sc/qa sc/source

2016-10-14 Thread Winfried Donkers
sc/qa/unit/data/functions/fods/binom.inv.fods | 2698 +++--- sc/source/core/tool/interpr3.cxx |6 2 files changed, 1660 insertions(+), 1044 deletions(-) New commits: commit f613f6e6973b2069c5f4c5b56efa4c355118387e Author: Winfried Donkers Date: Thu Sep 15

[Libreoffice-commits] core.git: formula/source sc/source

2016-10-14 Thread Winfried Donkers
changed, 38 insertions(+), 33 deletions(-) New commits: commit cf43ff5262a111f9fbebe58d254b704ec057cbf6 Author: Winfried Donkers Date: Thu Oct 13 13:49:18 2016 +0200 tdf#102948 Make HYPGEOMDIST ODFF1.2 compliant. Also reduce duplicate code. On Export to OOXML, HYPGEOMDIST is

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source

2016-10-14 Thread Winfried Donkers
sc/source/core/tool/interpr8.cxx | 37 + 1 file changed, 13 insertions(+), 24 deletions(-) New commits: commit f617d9466632f656811474cd49311e13ab950753 Author: Winfried Donkers Date: Tue Sep 20 08:04:50 2016 +0200 tdf#94635 follow up; correct

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source

2016-10-14 Thread Winfried Donkers
sc/source/core/tool/interpr8.cxx | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) New commits: commit aaa38fd34faab3108245f8fa8c13642919ff0c95 Author: Winfried Donkers Date: Thu Sep 15 13:39:35 2016 +0200 tdf#94635 follow up; handle linear data properly when

[Libreoffice-commits] core.git: sc/source

2016-09-16 Thread Winfried Donkers
sc/source/core/tool/interpr3.cxx | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) New commits: commit 46f09cb1252078ef23ed93a3551acbdcca9d31cd Author: Winfried Donkers Date: Fri Sep 2 11:03:11 2016 +0200 tdf#101855 BETA.DIST: apply same constraints as

  1   2   3   4   5   6   7   8   9   >