Re: [Libreoffice] [PUSHED] Re: [PATCH 11/12] RTL_CONSTASCII_USTRINGPARAM components - zipapi

rds On 11/17/2010 05:39 PM, Caolán McNamara wrote: > On Tue, 2010-11-16 at 22:50 +0100, Pierre-André Jacquod wrote: >> regards > > heh, I had a bit of a moment when I saw file:///d:/777/Encrypted/picture > in there before I realized this is someones debugging code with an if > (0

Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

Hello, Sharp eyes.. Just to keep you trainded..:-( No really sorry, Despite reviewing diff, I did not catch this one. Will take more care On 11/17/2010 05:18 PM, Caolán McNamara wrote: > On Tue, 2010-11-16 at 22:39 +0100, Pierre-André Jacquod wrote: >> On 11/16/2010 10:37 PM, Pie

[Libreoffice] calc: some code deletion and comments translation

Hello, have done as well some small comment translations. regards >From c29ea5e11ccc679166b5a0c5be2df925328465fb Mon Sep 17 00:00:00 2001 From: pjacquod Date: Sun, 21 Nov 2010 12:06:01 +0100 Subject: [PATCH] remove dead code in calc core data and some comments translation --- sc/source/core/data

[Libreoffice] further removing of dead code

Hello, here in components some other pieces to delete. Again some small parts in case I was to generous in deleting. regards >From 1535d5e774e7d1ef08696344be8fcdfc6828f2c3 Mon Sep 17 00:00:00 2001 From: pjacquod Date: Sun, 21 Nov 2010 12:10:15 +0100 Subject: [PATCH 1/5] remove dead code componen

Re: [Libreoffice] Building problem, sc/source/ui/src/optdlg.src gives syntax error

On 11/22/2010 07:16 AM, Joost Eekhoorn wrote: > Hi, > > PROBLEM 1: > > I am trying to make again, but it fails on > > ./sc/source/ui/src/optdlg.src > > I did remove the unxlngx6.pro in the sc, and did > the build there locally and it gave: > > > Making:ui.srs > > {

Re: [Libreoffice] Building problem, sc/source/ui/src/optdlg.src gives syntax error

: > > On Mon, 2010-11-22 at 07:57 +0100, Pierre-André Jacquod wrote: >> hello, >> rm -rf * >> ./download > > Oh - that is going to waste a -lot- of time ;-) > > Just remove the build output, not the ( pristine ) git repos. > > 'm

Re: [Libreoffice] [Pushed] further removing of dead code

Hi, thanks. Left it back, if someone would have needed to know something was there. regards On 11/22/2010 01:14 PM, Michael Meeks wrote: > Hi Pierre, > > On Sun, 2010-11-21 at 15:28 +0100, Pierre-André Jacquod wrote: >> here in components some other pieces to delete. Again s

Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.

Hi, >> - Unused parameters in some methods are triggering compilation >> warnings. Should I fix them by removing the parameter name ? > > Sounds reasonable. > > Really though - the binfilter is not the best place to focus cleanups > (though I appreciate it is fugly old code ;-) Most

Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.

On 11/23/2010 09:23 AM, Joachim Trémouroux wrote: > Hi Michael, > I will work on this. I see two possible ways: > Ok Michael, then I will continue within binfilter... ::-)) But a additional question: >From Norbert Thiebaud: > > To be consistent, I rather see them commented out > i.e > > foo(in

[Libreoffice] warnig and coding, need a little help on C++

Hello, as I said, still in warm up phase and getting back familiar with C++.. So cleaning is a good exercise. I got a compiler warning: filters/binfilter/bf_sw/source/core/para/sw_paratr.cxx:214:26: warning: 'nTemp' may be used uninitialized in this function for this: case MID_DROPCAP_LINES : {

Re: [Libreoffice] C++0x and LibreOffice

Hello, thanks, will avoid some errors.. I guess this is not (yet ?) enabled per default / per configure choices? Since I am very weak with make and such tools: any possibility to enable it per option when running ./autogen.sh ? Activated if possible during the configure run? Or an other way to l

[Libreoffice] [PATCH 1/9] suppress warning in binfilters sc_token

Hello, here some patches in binfilter to remove warnings by compiling... Since some changes could (will) look strange, I submit it in little chunks, often with compiler warning in comment. This may help the reviewer. Hope I did no mistake regards Pierre-André >From c747a9dcc4af190aac1f216a93f7abd4

[Libreoffice] [PATCH 2/9] remove warnings in binfilter - sc_interpr2.cxx

regards >From 32814375a2999afaf0582a682975ae6ec769f6f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Tue, 23 Nov 2010 21:06:58 +0100 Subject: [PATCH 2/9] remove warnings in binfilter - sc_interpr2.cxx based on the following compiler warnings: sc_interpr2.cxx:1729:

[Libreoffice] [PATCH 3/9] warnings in binfilters sc_interpr4.cxx

regards >From 80d6aecfb78de0da70107bd87c4d101942b79d78 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Tue, 23 Nov 2010 21:48:11 +0100 Subject: [PATCH 3/9] warnings in binfilters sc_interpr4.cxx all changes based on debugger waring: sc_interpr4.cxx: warning: comparis

[Libreoffice] [PATCH 4/9] binfilter sc_interpr4.cxx further warnings removal

regards >From f6202b304ca7f0ffdd16cbd2886872465273852a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Tue, 23 Nov 2010 21:58:53 +0100 Subject: [PATCH 4/9] binfilter sc_interpr4.cxx further warnings removal --- binfilter/bf_sc/source/core/tool/sc_interpr4.cxx | 17

[Libreoffice] [PATCH 5/9] waring removal in binfilter core/para

regards >From 01e9e819f9dd8f1726ddff7672f27cfcbd44760c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Thu, 25 Nov 2010 20:09:15 +0100 Subject: [PATCH 5/9] waring removal in binfilter core/para --- binfilter/bf_sw/source/core/para/sw_paratr.cxx | 16 ---

[Libreoffice] [PATCH 6/9] waring cleaning in sw_sw3redln.cxx

regards >From 84e58630f70dc34f71ee34419d9843980b14b723 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Thu, 25 Nov 2010 20:18:10 +0100 Subject: [PATCH 6/9] waring cleaning in sw_sw3redln.cxx shadowing warning and unused parameters --- binfilter/bf_sw/source/core/sw3

[Libreoffice] [PATCH 7/9] warnings removal in binfilter sw_sw3redln.cxx

regards >From 13a33d71df128454159d0e911f55179cddac2d72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Thu, 25 Nov 2010 20:52:47 +0100 Subject: [PATCH 7/9] warnings removal in binfilter sw_sw3redln.cxx all code deletion due to compiler warning with message: sw_sw3red

[Libreoffice] [PATCH 8/9] waring cleaning in binfilter sw3io

regards >From a3757de1170fca97638be7e455b6602b9de228e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Thu, 25 Nov 2010 20:57:45 +0100 Subject: [PATCH 8/9] waring cleaning in binfilter sw3io code removed due to compiler warning: (for both if, that is not an error) sw

[Libreoffice] [PATCH 9/9] binfilter sw3io warning fixes

regards >From d8ca0db19fdc508ebc0bf0ee42107fdea2f498b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Thu, 25 Nov 2010 21:10:27 +0100 Subject: [PATCH 9/9] binfilter sw3io warning fixes use of not initialized variables --- binfilter/bf_sw/source/core/sw3io/sw_sw3fm

Re: [Libreoffice] [PATCH 3/9] warnings in binfilters sc_interpr4.cxx

> Quick question wouldn't it be better to have the comments in English > instead of German? Sorry, !! I translate then when I can, but I did not the job to the end for this one. Not_appropriate_handling_for_me++ regards ___ LibreOffice mailing list Li

Re: [Libreoffice] warnig and coding, need a little help on C++

Thanks for helping. > Heh, this also confuses cppcheck as well. cough... cough... ! I am not smarter than a machine... ! A professor I had told: this not a good point being too smart... I understand what he meant. For stepping in, not the easiest way. Once there is no waring any more when compil

Re: [Libreoffice] [PUSHED] Re: [PATCH 9/9] binfilter sw3io warning fixes

Hi, First thanks for reviewing, catching my errors and correcting. I have learned a lot. Next time I do so many errors, please reject and I will correct it myself. Michael, I will wait making less errors in changes before requesting an account, if you don't mind. Just a question for: > Err, you s

[Libreoffice] [PATCH 1/7] warning cleaing binfilter sw3io

Hi, further warning cleaning within binfilter. Whoever has written this liked shadowing. I got { var a< warning shadowing this { var a <--- warning shadowing a } } which are nice to sort out !!! I review twice these patches before sending, but I fear to have missed s

[Libreoffice] [PATCH 2/7] waring within binfilter - sw3io

regards >From 0735f42a61482b094d054266ea83781ee122c91e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Fri, 26 Nov 2010 21:04:20 +0100 Subject: [PATCH 2/7] waring within binfilter - sw3io delete some compiler warning, some of them due to shadowing. --- binfilter/bf_s

[Libreoffice] [PATCH 3/7] binfilter sw3io - further shadowing warnings

regards >From 2b6f503e9a8fc091dcfc216dc12175e646a76a68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Fri, 26 Nov 2010 22:44:38 +0100 Subject: [PATCH 3/7] binfilter sw3io - further shadowing warnings --- binfilter/bf_sw/source/core/sw3io/sw_sw3misc.cxx | 146 ++

[Libreoffice] [PATCH 4/7] binfilter - sw_sw3style.cxx (shadowing) warnings removal

regards >From 0b31675885126537da8351ba747cd6c6e7ad03fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 27 Nov 2010 00:06:37 +0100 Subject: [PATCH 4/7] binfilter - sw_sw3style.cxx (shadowing) warnings removal --- binfilter/bf_sw/source/core/sw3io/sw_sw3style.c

[Libreoffice] [PATCH 5/7] trivial warning fixes in binfilters - sw3io

regards >From 91fef4982a754b13cfb446a68165ec5957fcbb3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 27 Nov 2010 13:44:30 +0100 Subject: [PATCH 5/7] trivial warning fixes in binfilters - sw3io --- binfilter/bf_sw/source/core/sw3io/sw_sw3attr.cxx |6 +++-

[Libreoffice] [PATCH 6/7] waring - initializer fixes in sw3io

regards >From 84a04befffec32ae4c9922a833c4f9748ebae8cf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 27 Nov 2010 16:01:55 +0100 Subject: [PATCH 6/7] waring - initializer fixes in sw3io --- binfilter/bf_sw/source/core/sw3io/sw_sw3field.cxx | 181 ++---

[Libreoffice] [PATCH 7/7] remove shadowing warnings in binfilter - sw_sw3npool.cxx

regards >From 11f7dd715f9443f2d6e482bb345c78e1654b5742 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 27 Nov 2010 22:42:07 +0100 Subject: [PATCH 7/7] remove shadowing warnings in binfilter - sw_sw3npool.cxx --- binfilter/bf_sw/source/core/sw3io/sw_sw3npool.cxx

[Libreoffice] [PATCH 1/5] more shadowing fixed sw3io

Hello, here some patches trying to make the compiler less verbose within binfilter. Currently, I catch only warning produced without debugging regards >From a36afe0088b28590dc07e8da7a8d380810640ad0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sun, 28 Nov 2010 18

[Libreoffice] [PATCH 2/5] trivial warning fixes in binfilter

regards >From 29737dab0202b18c1326841e449e1640b9bd5561 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sun, 28 Nov 2010 19:40:04 +0100 Subject: [PATCH 2/5] trivial warning fixes in binfilter --- binfilter/bf_sw/source/core/attr/sw_calbck.cxx |2 +- binfilter/

[Libreoffice] [PATCH 3/5] trivial warning fixes within binfilter bf_sw doc

regards >From 94ae830669bfc1df7b4235c45d0a6a72def30be2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sun, 28 Nov 2010 21:09:30 +0100 Subject: [PATCH 3/5] trivial warning fixes within binfilter bf_sw doc --- .../bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx |2

[Libreoffice] [PATCH 5/5] trivial warning cleaning in binfilter - unocore (2)

regards >From 09642903881c193ff01f2801461dcddeae0931ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Mon, 29 Nov 2010 22:13:22 +0100 Subject: [PATCH 5/5] trivial warning cleaning in binfilter - unocore (2) --- binfilter/bf_sw/source/core/unocore/sw_unodraw.cxx |

[Libreoffice] [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1)

regards >From f5aac0dd10c586fbcdcd8e6a86e396601db8ad27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Mon, 29 Nov 2010 08:20:37 +0100 Subject: [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1) --- .../source/core/unocore/sw_SwXTextDefaults.cxx |

[Libreoffice] [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1)

regards >From f5aac0dd10c586fbcdcd8e6a86e396601db8ad27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Mon, 29 Nov 2010 08:20:37 +0100 Subject: [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1) --- .../source/core/unocore/sw_SwXTextDefaults.cxx |

Re: [Libreoffice] Script to find undocumented classes

Beware - I am a newcomer - maybe my point of view is quite wrong due to lack of understanding. But then at least I will understand something better :- ) My first remark: stepping in seems to me to be very difficult despite the very friendly behaviour of people here. > un-documented code-base is a

[Libreoffice] [PATCH] making binfilter compiling again

Thanks to review and push it quite quickly if possible. Changes have been done (for RTL_OUSTRING_...) without looking that the namespace rtl is not declared. I did not introduced it but just corrected the entries, since I am not enough familiar to know which is the prefered situation within the pro

[Libreoffice] binfilter and features...

Hi, currently trying to reduce the number of warning coming from binfilter, I found quite a lot functions like: func(var x) {} or func(var x) { ASSERT ("lksd") }. sometimes func (var x) {return false} Would someone mind if I track down the call of such functions, remove the calls and at the end re

[Libreoffice] crossing strange code: a little help

Hi within filters/binfilter/bf_sw/source/core/txtnode/sw_thints.cxx line 955, I crossed this code construct: if() { . while (TRUE) { DBG_BF_ASSERT(0, "STRIP"); } } With and without debugging option on, if the if is entered, then this is an endless loop? Does it m

Re: [Libreoffice] binfilter and features...

On 12/04/2010 09:49 PM, Caolán McNamara wrote: > I wouldn't like to see too much effort spent on binfilter though. I understand the point. On the other side, leting it behind generate a lot of - not very useful - job when wanting to do global changes, like the RTL_CONST... macro, or getting ride o

Re: [Libreoffice] binfilter and features...

On 12/05/2010 12:39 PM, Caolán McNamara wrote: > All true. It was just a note that it might be easier, if you have an > interest in binfilter, to just take the conservative approach and > silence warnings with e.g converting I was thinking of taking a 2 steps approach: first silent warning in a c

[Libreoffice] [PATCH 01/16] warning variable unused fix in binfilter bf_sw attr

Hi, here some patches to suppress warnings within binfilter. I took a - sometimes too - conservative approach for doing this. Hope I did not harm this module regards >From 3c2cd665fe8a344626265f6c8a2a3b195556441d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 D

[Libreoffice] [PATCH 02/16] warning fix unused variable in binfilter bf_sw bastyp

regards >From a03ec223cf70c17a1cd6bbf397dc954c8d9d13fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 10:25:53 +0100 Subject: [PATCH 02/16] warning fix unused variable in binfilter bf_sw bastyp --- binfilter/bf_sw/source/core/bastyp/sw_calc.cxx|

[Libreoffice] [PATCH 03/16] fix warning unused var in binfilter bf_sw crsr

regards >From fe0b41fe4378e18478263caf8d09af1f3adafa28 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 11:12:21 +0100 Subject: [PATCH 03/16] fix warning unused var in binfilter bf_sw crsr this is fixing warning, not optimizing. This means, some functio

[Libreoffice] [PATCH 04/16] warning fix for unused var in binfilter bf_sw doc

regards >From 76026a3ef610c3b348f2fa514591e452eff3cd8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 14:56:23 +0100 Subject: [PATCH 04/16] warning fix for unused var in binfilter bf_sw doc This is warning removing, not code optimization => minimum ri

[Libreoffice] [PATCH 05/16] warning fix unused var in binfilter bf_sw docnode

regards >From dafaabb2c38990bf4141c6074e15f0ca35d7e160 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 15:19:44 +0100 Subject: [PATCH 05/16] warning fix unused var in binfilter bf_sw docnode only warning removal, not code optimization, hence some funct

[Libreoffice] [PATCH 06/16] warning fix unused var in binfilter bf_sw draw

regards >From eac219396edebdf58deba912b02edac9a7999554 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 15:30:11 +0100 Subject: [PATCH 06/16] warning fix unused var in binfilter bf_sw draw --- binfilter/bf_sw/source/core/draw/sw_dcontact.cxx | 75 +++

[Libreoffice] [PATCH 07/16] fix warning unused var in binfilter bf_sw fields

regards >From 0049d6aa3dd25887c742b51a764776103e67daf8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 15:44:52 +0100 Subject: [PATCH 07/16] fix warning unused var in binfilter bf_sw fields still only fixes, no optimization has been done. On purpose, a

[Libreoffice] [PATCH 08/16] fix warning unused var in binfilter bf_sw layout

regards >From 86062da5291cc62d4f378fb8adb366d696ee11b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 17:32:49 +0100 Subject: [PATCH 08/16] fix warning unused var in binfilter bf_sw layout --- binfilter/bf_sw/source/core/layout/sw_atrfrm.cxx | 22

[Libreoffice] [PATCH 09/16] fix warning unused var in binfilter bf_sw ole

regards >From 5a619e9399713a488eeadc484617e630ed9d06ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 20:02:57 +0100 Subject: [PATCH 09/16] fix warning unused var in binfilter bf_sw ole --- binfilter/bf_sw/source/core/ole/sw_ndole.cxx |2 +- 1 fi

[Libreoffice] [PATCH 10/16] fix warning unused var in binfilter bf_sw sw3io

regards >From 18b052aa37f4adb95f3250de4967b739bd14be11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 20:07:52 +0100 Subject: [PATCH 10/16] fix warning unused var in binfilter bf_sw sw3io --- binfilter/bf_sw/source/core/sw3io/sw_sw3field.cxx |2 +

[Libreoffice] [PATCH 11/16] fix warning unused var in binfilter bf_sw swg

regards >From c8861cfc5de23428356c1a5cf6aaed6d2a0eced3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 20:13:44 +0100 Subject: [PATCH 11/16] fix warning unused var in binfilter bf_sw swg --- binfilter/bf_sw/source/core/swg/sw_rdflds.cxx |2 +- bin

[Libreoffice] [PATCH 12/16] fix warning unused var binfilter bf_sw text

regards >From 22f6a25fcbba5eb41b73436f36a9542b2f898ef4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 20:38:53 +0100 Subject: [PATCH 12/16] fix warning unused var binfilter bf_sw text --- binfilter/bf_sw/source/core/text/sw_atrstck.cxx |5 ++---

[Libreoffice] [PATCH 13/16] fix warning in binfilter bf_sw tox

regards >From 239641e4b675424de81e45cb455e66b8127f9ff3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 21:01:39 +0100 Subject: [PATCH 13/16] fix warning in binfilter bf_sw tox --- binfilter/bf_sw/source/core/tox/sw_txmsrt.cxx |2 +- 1 files change

[Libreoffice] [PATCH 14/16] fix warning unused param in binfilter bf_sw txtnode

regards >From 1a50712d282fd282ab53deb2fd7fb2e5acfa3807 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 21:23:38 +0100 Subject: [PATCH 14/16] fix warning unused param in binfilter bf_sw txtnode --- binfilter/bf_sw/source/core/txtnode/sw_atrfld.cxx |

[Libreoffice] [PATCH 15/16] fix warning unused var in binfilter - bf_sw unocore

regards >From 151194c8a68754f9521bd485a9124f6e08f36239 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 21:58:35 +0100 Subject: [PATCH 15/16] fix warning unused var in binfilter - bf_sw unocore trying to stay on the safe side, means not always removing

[Libreoffice] [PATCH 16/16] removing code due to endless loop

regards >From 6551d69a5fbc85f3af92cada84bf543a083d4453 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= Date: Sat, 4 Dec 2010 22:05:10 +0100 Subject: [PATCH 16/16] removing code due to endless loop these part of code have been removed. The While(true) loop means either that

[Libreoffice] [PATCH 01/16] warning variable unused fix in binfilter bf_sw attr

Hello again, can't figure where the first patch is, currently only 2 -> 16 are on the list. Here again the first one. But if this is as last time, tomorrow you will have this mail twice.. regards Hi, here some patches to supp

Re: [Libreoffice] binfilter and features...

Hi, > There is alright, a phonecon typically once a week or so. maybe we can > put this topic on the agenda would be great > and you could dial in if its at a suitable time. doing this during free time, I may really depend if the possibility arise or not. But basically, we could think of a kind

[Libreoffice] fighting with debug macros...

Hello, still trying to learn a bit the code. Compiling without DEBUG on gives some new warnings:- ) This lead me to look at some code construct. Here is in pseudo-code a typical construct I am crossing: var y = ; var x = ; code if ( y > MAXVALUE) { ASSERT(x, "out of range"); // only u

[Libreoffice] making binfilter aka StarOffice FileFormat read-only

Hello, these days, I have tried (and not really with full success) to understand how binfilter works... My goal: since it is an old legacy format, make StarOffice formats read-only, and clean binfilter component of all code used for writing files. Reason: with read-only, you will still be able to

Re: [Libreoffice] making binfilter aka StarOffice FileFormat read-only

Hi, >> in binfilter as read-only filters (using as filter flag >> SFX_FILTER_OPENREADONLY defined as 0x0001L) This will make the >> opening read-only. By this way, this is not possible any more to save > IIRC the resolution was a bit different ;-) you are right:-) > This way the user will

Re: [Libreoffice] starmath / cppunit breakage in master

Hi, > Does setting > #define MDDS_HASH_CONTAINER_STLPORT 1 > before > #include > > help? > > I also saw someone having a similar issue in the same exact spot, which > I haven't been able to reproduce. Maybe this is related. I had also a problem after having upgraded to mds 0.4.0 with an up to d

Re: [Libreoffice] making binfilter aka StarOffice FileFormat read-only

Hi Jan / Hi Michael, some more testing and code reading. Here some answers. [I was writing this mail while testing, mostly written before Michael's mail. Hence this will answers both mails. ] > This is a good point - as you say, I agree we can omit the creation of > the lock file. It would be go

Re: [Libreoffice] making binfilter aka StarOffice FileFormat read-only

Hi, On 01/14/2011 07:33 PM, Regina Henschel wrote: > Hi all, > > there is something wrong actually. Removing *Export*-filter is > reasonable, but now in LibO RC3 I cannot *read* my SO5 files. > > Kind regards > Regina Up to now, nothing has been committed. On trunk master, all is OK, I just teste

[Libreoffice] error compiling in libs-gui/canevas

hello, there is an error compiling canevas: the reason: in vcl/inc/vcl/sysdata.hxx there has been a change at line 125: -void* pRenderFormat; // render format for drawable +void* pXRenderFormat; // render format for drawable This produce the error (see below) in canevas compilation. Si

[Libreoffice] Announcement: StarOffice file-format not available any more for saving

Hello, from now I have started to delete within binfilter the code allowing to *save* using the StarOffice file format. The import (read) is still possible and will remain. Bye bye saving sdw, sxw This will of course not happens in one go... With this push, I have done the following changes:

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

Hello, On 01/24/2011 03:43 PM, Caolán McNamara wrote: > > You also needed to adjust the smoketest "make check" because that has a > save as staroffice binary file format test in it. I noticed this failed > this morning and bodged it up to work again. Oops, sorry, I was not aware of it. Could you

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

Hello, > Wonderful :-) do you want help with this ? we could add an easy hack, > and ask people to contact you, for impress / calc etc. > Thanks for this point. I will think if this is easily feasible. But I am still myself on the (intensive) learning part, so I currently do not feel me yet

[Libreoffice] [patch] unused variable in Windows build

Hello, a small patch to suppress an unused variable (within a WNT define) according cppchecker Since I can not build on Windows, if someone could review / compile it for me before pushing ? Thanks and regards Pierre-André 0001-unused-variable-in-Windows-build.patch Description: applicatio

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM cleaning in base

hello, short presentation: have some C++ and java programming skills, but not used it intensively since 4-5 years... Need some refresh, hence I am starting with easy hacks... Will allow me to refresh knowledge and have a look at LibreOffice Hope I am in line with the patch policy. PS: I will alway

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM in base

hello, it seems base in now clear (this one had spaces,...) I will do a full grep regards pjacquod >From 08cfa904d88460a8f90bb6c6ea87095c522e7123 Mon Sep 17 00:00:00 2001 From: pjacquod Date: Sun, 14 Nov 2010 17:23:18 +0100 Subject: [PATCH] RTL_CONSTASCII_USTRINGPARAM in base --- reportdesign/

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM in components - customize

regards MPL/ GPLv3+ / LGPLv3+ pjacquod >From c747bbc166d3637a37638b969908f6392cb793a0 Mon Sep 17 00:00:00 2001 From: pjacquod Date: Sun, 14 Nov 2010 19:55:57 +0100 Subject: [PATCH] RTL_CONSTASCII_USTRINGPARAM in components cleaning in components/cui/source/customize --- cui/source/customize/accc

[Libreoffice] remove some comments / dead code in calc

find it by chance... regards pjacquod MPL/ GPLv3+ / LGPLv3+ >From 0ad93f729c3141c0f40125b04c79a2891c51bece Mon Sep 17 00:00:00 2001 From: pjacquod Date: Sun, 14 Nov 2010 20:36:43 +0100 Subject: [PATCH] bogus comment / code in calc.. testvba --- sc/source/ui/vba/testvba/testvba.cxx |3 --- 1

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM cleaning in components - dialogs

regards MPL/ GPLv3+ / LGPLv3+ pjacquod >From 6b4b3c28474ab96a8d938c3a5e0e1dc86415da22 Mon Sep 17 00:00:00 2001 From: pjacquod Date: Sun, 14 Nov 2010 21:27:39 +0100 Subject: [PATCH] RTL_CONSTASCII_USTRINGPARAM cleaing in components - dialogs /home/pjacquod/LibO_dev/build/clone/components/cui/sour

[Libreoffice] [PATCH 01/12] RTL_CONSTASCII_USTRINGPARAM in components/cui/...option

Hello, being off for some days, here the collection of patches I produced in between. Each patch concern the cleaning of directory, this will allow to review / descard some parts if needed. best regards pjacquod >From c3b35d242fc9973d198571e19d37e7e12b746d97 Mon Sep 17 00:00:00 2001 From: pjacquod

[Libreoffice] [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

On 11/16/2010 10:37 PM, Pierre-André Jacquod wrote: > Hello, > being off for some days, here the collection of patches I produced in > between. Each patch concern the cleaning of directory, this will allow > to review / descard some parts if needed. > best reg

[Libreoffice] [PATCH 03/12] RTL_CONSTASCII_USTRINGPARAM in components - forms

regards >From f749c776fb979ee6700ce9477ae5b70b3b49d77c Mon Sep 17 00:00:00 2001 From: pjacquod Date: Mon, 15 Nov 2010 23:38:11 +0100 Subject: [PATCH 03/12] RTL_CONSTASCII_USTRINGPARAM in components - forms the whole directory components/forms/source/component should now be OK --- forms/source

[Libreoffice] [PATCH 04/12] RTL_CONSTASCII_USTRINGPARAM in components - inc

regards >From 35e91cd08c4ba6fb1078a347d8736670fe6faf13 Mon Sep 17 00:00:00 2001 From: pjacquod Date: Mon, 15 Nov 2010 23:44:15 +0100 Subject: [PATCH 04/12] RTL_CONSTASCII_USTRINGPARAM in components - inc components/forms/source/inc should be OK now --- forms/source/inc/FormComponent.hxx |

[Libreoffice] [PATCH 05/12] RTL_CONSTASCII_USTRINGPARAM in components .. submission

regards >From ae0569887c2f327499ff060a12594f50035319ac Mon Sep 17 00:00:00 2001 From: pjacquod Date: Mon, 15 Nov 2010 23:52:56 +0100 Subject: [PATCH 05/12] RTL_CONSTASCII_USTRINGPARAM in components .. submission components/forms/source/xforms/submission should be OK now --- forms/source/xforms/s

[Libreoffice] [PATCH 06/12] RTL_CONSTASCII_USTRINGPARAM components xpathlib

regards >From 2bf8ae72c9787a733cb2992d8c409593fb1f7bab Mon Sep 17 00:00:00 2001 From: pjacquod Date: Mon, 15 Nov 2010 23:57:03 +0100 Subject: [PATCH 06/12] RTL_CONSTASCII_USTRINGPARAM components xpathlib components/forms/source/xforms/xpathlib should now be OK --- forms/source/xforms/xpathlib/ex

[Libreoffice] [PATCH 07/12] RTL_CONSTASCII_USTRINGPARAM components in runtime

regards >From ab42a6a840da58f039398b7f64eaa68c4560b3cd Mon Sep 17 00:00:00 2001 From: pjacquod Date: Mon, 15 Nov 2010 23:59:34 +0100 Subject: [PATCH 07/12] RTL_CONSTASCII_USTRINGPARAM components in runtime components/forms/source/runtime should be OK now --- forms/source/runtime/formoperations.

[Libreoffice] [PATCH 08/12] RTL_CONSTASCII_USTRINGPARAM in components misc

regards >From b82fc44186adb943a95eeaa369d49719ea47fd6c Mon Sep 17 00:00:00 2001 From: pjacquod Date: Tue, 16 Nov 2010 00:09:27 +0100 Subject: [PATCH 08/12] RTL_CONSTASCII_USTRINGPARAM in components misc components/forms/source/misc should be OK now --- forms/source/misc/InterfaceContainer.cxx |

[Libreoffice] [PATCH 09/12] RTL_CONSTASCII_USTRINGPARAM in components - xstor

regards >From 14c040c9a7e20c49c2edb9fdc9185a2fda93362f Mon Sep 17 00:00:00 2001 From: pjacquod Date: Tue, 16 Nov 2010 00:36:35 +0100 Subject: [PATCH 09/12] RTL_CONSTASCII_USTRINGPARAM in components - xstor components/package/source/xstor should be OK now --- package/source/xstor/owriteablestream

[Libreoffice] [PATCH 10/12] RTL_CONSTASCII_USTRINGPARAM components - zippackage

regards >From 2f86aef63beb00992aa720ddf86c5236c6fecc26 Mon Sep 17 00:00:00 2001 From: pjacquod Date: Tue, 16 Nov 2010 00:40:44 +0100 Subject: [PATCH 10/12] RTL_CONSTASCII_USTRINGPARAM components - zippackage components/package/source/zippackage should be OK now --- package/source/zippackage/Zi

[Libreoffice] [PATCH 11/12] RTL_CONSTASCII_USTRINGPARAM components - zipapi

regards >From 10ef6191861dab201993db7c01e5adf4d12fc415 Mon Sep 17 00:00:00 2001 From: pjacquod Date: Tue, 16 Nov 2010 00:43:12 +0100 Subject: [PATCH 11/12] RTL_CONSTASCII_USTRINGPARAM components - zipapi components/package/source/zipapi should be OK now --- package/source/zipapi/XUnbufferedStrea

[Libreoffice] [PATCH 12/12] RTL_CONSTASCII_USTRINGPARAM in components - xmlsecurity- helpd

regards >From ed5503c8a32a6fa2d41b73e199e6184eb9e0b15b Mon Sep 17 00:00:00 2001 From: pjacquod Date: Tue, 16 Nov 2010 20:26:46 +0100 Subject: [PATCH 12/12] RTL_CONSTASCII_USTRINGPARAM in components - xmlsecurity- helpd remove rtl::oustring::createfromascii("foo") and code clean up: suppression of

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

Hello, after quite a long time, I have done a push again concerning this topic. Sorry, I was very busy at work and had barely the time to go ahead. Here is the following work in cleaning within binfilter/bf_sw the code allowing to write in StarWriter format. Without touching dependencies outside

Re: [Libreoffice] Patch handling guideline

Hello, if you do not mind, I wanted to propose the following points: patch submission: creating patches with >> git format-patch or sending them directly with git send-email I suggest the following options: --thread and --no-chain-reply-to if there are several patches, which results in: [PATCH 0/

[Libreoffice] binfilter, filter & co: some questions

Hello, still working on this %&@#filter removing and I am crossing within binfilter/bf_sc a lot of "if" statement, testing if the current handled format is StarOffice, Excel95, Execl97 etc... A lot of theses "if" are typically like: else if (aFltName.EqualsAscii(pFilterLotus)) { D

Re: [Libreoffice] Comment-translation of writer/sw/source/ui/config

On 02/24/2011 08:33 PM, Kohei Yoshida wrote: > On Thu, 2011-02-24 at 19:46 +0100, Jonathan Aquilina wrote: >> Martin i think it would be easier as well as not to end up having ur >> email black listed for sending out large amounts of emails, but if its >> for a single module i would attach them

Re: [Libreoffice] Nonsense comments?

On 02/25/2011 09:46 PM, Caolán McNamara wrote: > po files can have translator-comments in them to help translators > about ambiguous terms/words, while the .src/.sdf format doesn't though, translation with gettext would support this with comment using key-words / tags. Key words are configurable,

Re: [Libreoffice] [PUSHED][PATCH]Cleanup comments

Hello, pushed, thanks, Maybe not forgetting the [patch] tag in subject will help not to miss your submission. best regards On 02/27/2011 04:51 PM, Arnaud Versini wrote: > Hi, > > This patch remove some useless comments in msfilter. > > Thanks > > -- > Arnaud Versini > > > > ___

Re: [Libreoffice] Remove "using namespace ::rtl"

Hello, > Even if binfilters is going to be "extracted" from LO, doesn't it worth I am doing, this, leting it be only an "import" filter. > to purge "using namespace ::rtl" from it (I think about the people I think that when "cross-module" cleaning is done, this is worth to do it also within binfi

Re: [Libreoffice] Remove "using namespace ::rtl"

Hello, > Finally since I'm not sure for the moment about what must be done on > "using namespace com::sun::star::uno", I did the work on binfilters. Thanks regards Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.

Re: [Libreoffice] [PATCH] [PUSHED] Easy Hacks: Translation of Comments from German to English

Hello, thanks, just changed a typo best regards Pierre-André On 03/06/2011 04:10 PM, Daniel Di Marco wrote: > Hi, > > I translated some more comments. The patch is attached. > > > Cheers, > Daniel > > > > ___ > LibreOffice mailing list > LibreOffic

Re: [Libreoffice] [PUSHED] [PATCH] Remove commented out code

Hello, all seems to me OK, then I pushed. Thanks regards Pierre-André On 03/08/2011 12:19 PM, Bálint Dózsa wrote: > Hi, > > I have removed some commented out code form// //xmloff/. > My code is under the LGPLv3+/MPL dual license. > > Regards, > Balint Dozsa > > > > ___

Re: [Libreoffice] [PATCH] [PUSHED] Translate Comments

Hello, looks good, pushed. Thanks Pierre-André On 03/23/2011 11:19 PM, Rob Snelders wrote: Hi, I have translated some comments in the libs-core/connectivity-directory. I submit this patch under LGPLv3+/MPL-Licence. ___ LibreOffice mailing list Lib

[Libreoffice] .fodt format broken

Hello, after having made a full compile, I have seen that the support for .fodt file format (plain xml) is broken. I tested this file format (created a file,...) about one month ago, and all was well, but now you just get a general I/O error, by reading or saving it. I do not know it this is

  1   2   >