[PATCH] Introducing compiler plugin support

2012-10-05 Thread Lubos Lunak
sh it. -- Lubos Lunak l.lu...@suse.cz From 6c63f9809ecaa63e2db6fb606b573ab12f09752f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?= Date: Fri, 5 Oct 2012 18:17:13 +0200 Subject: [PATCH] initial support for clang compiler plugins The plugin is intentionally built using a custom Mak

Re: OUString's buffer is not mutable (was: Re: OUString is mutable?)

2012-10-05 Thread Lubos Lunak
On Friday 05 of October 2012, Michael Stahl wrote: > On 04/10/12 15:29, Lubos Lunak wrote: > > On Wednesday 03 of October 2012, Michael Stahl wrote: > hmm i am not really familiar with "D" and just believed the first > sentence on its string documentation page :) >

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-09 Thread Lubos Lunak
visual noise is worth it. What about class private methods, for example? According to the logic of this, they should be lcl_ too, but they can't be file static. In general, either you'll have a number of methods that should be named lcl_ but aren't, or we&#

Re: [PATCH] Introducing compiler plugin support

2012-10-09 Thread Lubos Lunak
On Friday 05 of October 2012, Lubos Lunak wrote: > Hello, > > attached is my implementation of basic build support for using Clang > compiler plugin during building LO. I'm posting it here first in case our > build system people have different ideas to how I have integrat

Re: the inevitable C formatting/brace style flamewar

2012-10-09 Thread Lubos Lunak
ve a warning for that? Or does it > have? ;-) > > If it does not, and yet these errors happen so often - it might be > useful to create a check for that based on the recent Lubos' clang > magic. EasyHack, maybe? For the record, the warning is now

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-12 Thread Lubos Lunak
ions that actually had extern declarations in headers, so much for there being much point in this convention). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Introducing compiler plugin support

2012-10-12 Thread Lubos Lunak
On Tuesday 09 of October 2012, Lubos Lunak wrote: > On Friday 05 of October 2012, Lubos Lunak wrote: > > Hello, > > > > attached is my implementation of basic build support for using Clang > > compiler plugin during building LO. I'm posting it here first in case

FYI: Cleanup of debug options

2012-10-22 Thread Lubos Lunak
esktop.org/libreoffice/core/commit/?id=a0320a908875f42bab9983ffe4db5b49fe7ba2f6 -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Tinderbox failure, Win-x86@6, MASTER, last success: 2012-10-20 18:35:26

2012-10-22 Thread Lubos Lunak
unusual. I cannot imagine how it could happen. Could > someone on Windows run > > cd tail_build; make -pqr > > and send the output to me? http://ge.tt/2zraAzP/v/0 . It's from this tinderbox right after the tinderbox build failed. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] rtl::OUString to OUString and some questions

2012-10-26 Thread Lubos Lunak
c cleanup - the classes are already in practice namespaced by the O prefix and so not explicitly adding the rtl:: prefix is avoiding the nuisance of the extra writing and also, since these are very commonly uses classes, makes the code more readable. -- Lubos Lunak l.lu...@suse.cz __

Re: ENABLE_SYMBOLS=true does nothing

2012-10-30 Thread Lubos Lunak
On Tuesday 30 of October 2012, Kohei Yoshida wrote: > Hi there, > > Just noticed this today that, on master, the ENABLE_SYMBOLS=true doesn't > seem to turn on symbols. > > Does this ring a bell to anyone? http://lists.freedesktop.org/archives/libreoffice/2012-October/

Re: ENABLE_SYMBOLS=true does nothing

2012-10-30 Thread Lubos Lunak
to > the linker flag in my wrapper script, but so far I'm a bit lost. It's > easier to add an additional flag but is very hard to remove flag manually. > > Any clever ideas? make CFLAGS='-O -g' CXXFLAGS='-O -g' LDFLAGS='' If that doe

Re: ENABLE_SYMBOLS=true does nothing

2012-10-31 Thread Lubos Lunak
On Tuesday 30 of October 2012, Markus Mohrhard wrote: > 2012/10/30 Kohei Yoshida : > > On 10/30/2012 05:27 PM, Lubos Lunak wrote: > >> > >> make CFLAGS='-O -g' CXXFLAGS='-O -g' LDFLAGS='' > >> > >> If that doesn'

Re: no functional TinderBox for master/3-7 full Windows builds

2012-10-31 Thread Lubos Lunak
Or could a master/3-7 build > be added to TB 9? #6 has been temporarily stopped so that I can debug a smoketest failure that prevents the build from completing successfully anyway. I'll be up again whenever I nail it down. I don't know why #7 was temporarily dow

Re: ENABLE_SYMBOLS=true does nothing

2012-10-31 Thread Lubos Lunak
On Wednesday 31 of October 2012, Norbert Thiebaud wrote: > On Wed, Oct 31, 2012 at 8:34 AM, Lubos Lunak wrote: > > I'd prefer to not bring it back because of a special use case that's > > already easily doable as it is. > > Well tinderbox works nicely and

Re: ENABLE_SYMBOLS=true does nothing

2012-10-31 Thread Lubos Lunak
t against --enable-symbols, this just seemed the simplest solution given the circumstances. If you manage to get the story right about what these 3 options do (4 options, if the story doesn't include moving --enable-selective-debuginfo functionality to --

Re: ww8export tinderbox failure ?

2012-10-31 Thread Lubos Lunak
successful builds in a row on that previously > intermittently failing gentoo build box. The SLED11 tinderbox has not failed yet since that change either, so I guess you got the ugly bug. Congratulations and thanks :). -- Lubos Lunak l.lu...@suse.cz _

Re: FYI: Cleanup of debug options

2012-11-06 Thread Lubos Lunak
only thing that doesn't understand -Os is probably MSVC, and who here actually develops using that (in addition to something else)? See? It's not so simple. But anyway, as I said, I'll gladly pass having all the fun to whoever manages to put the option back without breaking something else. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Change in core[master]: restore --enable-symbols option again -- was FYI: Cleanup of debug options

2012-11-07 Thread Lubos Lunak
gb_SYMBOL being true as well, which globally sets the -g flag, overriding any selective use. I suggest you just drop the gb_DEBUGLEVEL -> gb_SYMBOL setting, that'll keep --enable-symbols separate from --enable-debug, so it shouldn't break anything else. That'

Re: Change in core[master]: restore --enable-symbols option again -- was FYI: Cleanup of debug options

2012-11-08 Thread Lubos Lunak
se has a different view of how this all should work, I'm still waiting for somebody else to suddenly realize something else should be changed), I feel like passing on that, sorry. But feel free to ask, I now know a lot more about that part of code than the plan ever was. --

Re: gbuild, deps and ccache

2012-11-09 Thread Lubos Lunak
ps the whole time, so this doesn't matter. Developers doing development without deps are asking for trouble, so they would get it. Why would anyone actually need this? -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Line height depending on characters in that line

2012-11-20 Thread Lubos Lunak
way of fixing this? -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-commits] .: configure.ac

2012-11-20 Thread Lubos Lunak
ry_vclplug_gtk.mk > +test_cairo=yes > +fi > ENABLE_GTK="TRUE" > R="gtk $R" > fi Does this actually make sense? Isn't it rather that we only ever build gtk if test "$GUIBASE" = "unx" -a "$enable_headless" != "yes" ? -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Tinderbox failure, Win-x86@7-MinGW, MASTER, last success: 2012-11-20 19:54:45

2012-11-21 Thread Lubos Lunak
On Wednesday 21 of November 2012, ke...@suse.cz wrote: > Hi folks, > > One of you broke the build of LibreOffice with your commit :-( > Please commit and push a fix ASAP! > > Full log available at http://tinderbox.libreoffice.org/MASTER/status.html > > Tinderbox info: > > Box name: Win-x86@7-MinG

Re: ANN: renaming of master branch to "main" for core repository and submodules (dictionaries, help, translations)

2021-03-18 Thread Lubos Lunak
roblematic word, which would be way simpler and actually do something related to the topic? The way I see it, if this is supposed to fix something, then it actually doesn't, and it can create technical problems. If it's supposed to do something else, it's not up

Re: ANN: renaming of master branch to "main" for core repository and submodules (dictionaries, help, translations)

2021-03-18 Thread Lubos Lunak
not be taking sides in such politics, especially given that the problem does not appear to be resolved or even having a consensus. On Thursday 18 of March 2021, Thorsten Behrens wrote: > Lubos Lunak wrote: > > I disagree with the plan. Git uses master, so we should stick with > >

<    3   4   5   6   7   8