[Libreoffice-commits] .: xmloff/source

2012-07-13 Thread Lubos Lunak
xmloff/source/style/fonthdl.cxx |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) New commits: commit fc508908f55cc1fe5a22adcba710cebb75fc979c Author: Luboš Luňák Date: Fri Jul 13 15:15:57 2012 +0200 fix a crash with empty string If it's named nLast, then it's sup

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - xmloff/source

2012-07-13 Thread Lubos Lunak
xmloff/source/style/fonthdl.cxx |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) New commits: commit 0054c76b0f3d5bdbaef73a696ce3cf930be9c16b Author: Luboš Luňák Date: Fri Jul 13 15:15:57 2012 +0200 fix a crash with empty string If it's named nLast, then it's sup

[Libreoffice-commits] .: sw/qa

2012-07-13 Thread Lubos Lunak
sw/qa/extras/odftok/data/empty-svg-family-name.odt |binary sw/qa/extras/odftok/odftok.cxx |8 2 files changed, 8 insertions(+) New commits: commit f7f4e9a823adc20cb4136d7ff6f83b943f23b3b6 Author: Luboš Luňák Date: Fri Jul 13 16:06:56 2012 +0200 add tes

[Libreoffice-commits] .: 2 commits - sw/source

2012-07-13 Thread Lubos Lunak
sw/source/filter/ww8/docxattributeoutput.cxx |7 ++- sw/source/filter/ww8/docxexport.cxx |6 ++ sw/source/filter/ww8/docxexport.hxx |5 +++-- sw/source/filter/ww8/wrtww8.hxx |2 +- sw/source/filter/ww8/ww8atr.cxx |2 +- 5 file

[REVIEW 3-6] Do not write default tab stop as custom in .docx

2012-07-13 Thread Lubos Lunak
Hello, can somebody please backport http://cgit.freedesktop.org/libreoffice/core/commit/?id=15af925c25 to 3-6? It's consistent with what the RTF export does and otherwise the default style ends up with a custom tab stop. -- Lubos Lunak l.lu...@su

[REVIEW 3-6] Use paragraph's numbering if explicitly specified (.docx)

2012-07-13 Thread Lubos Lunak
PROP_NUMBERING_RULES is set for the paragraph. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sw/qa

2012-07-13 Thread Lubos Lunak
sw/qa/extras/ooxmlexport/data/empty.odt |binary sw/qa/extras/ooxmlexport/ooxmlexport.cxx | 15 +++ 2 files changed, 15 insertions(+) New commits: commit d74b14892486a401682a2b33cd12812354220e59 Author: Luboš Luňák Date: Fri Jul 13 19:20:06 2012 +0200 testcase for the re

[Libreoffice-commits] .: 2 commits - sw/qa

2012-07-13 Thread Lubos Lunak
sw/qa/extras/README | 19 +++ sw/qa/extras/ooxmlexport/ooxmlexport.cxx |4 - sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 75 +-- sw/qa/extras/swmodeltestbase.hxx | 35 ++ sw/qa/extras/ww8export/ww8export.cxx |

Re: Question about OUString::compareToAscii

2012-07-13 Thread Lubos Lunak
> - more meaningful > - doing some ! on sal_Int32 is not as clean as using sal_Bool directly Yes, except again, just == will do. > Do you think that such a clean-up is interesting ? Yes, if it's interesting to you to do it :). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Code documentation

2012-07-16 Thread Lubos Lunak
ce is headers. See also https://wiki.documentfoundation.org/Development/Doxygen . -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 2 commits - cppu/CppunitTest_cppu_checkapi.mk cppu/CustomTarget_cppu_allheaders.mk cppuhelper/CppunitTest_cppuhelper_checkapi.mk cppuhelper/CustomTarget_cppuhelper_allheaders.

2012-07-16 Thread Lubos Lunak
cppu/CppunitTest_cppu_checkapi.mk| 55 +++ cppu/CustomTarget_cppu_allheaders.mk | 49 cppu/Module_cppu.mk |2 cppu/qa/checkapi/strings.cxx | 30 cppuhelper/

Re: Automatic using ::rtl::OUString etc.

2012-07-16 Thread Lubos Lunak
On Thursday 12 of April 2012, Lubos Lunak wrote: > Hello, > > would somebody see a problem with this? > > sal/inc/rtl/ustring.hxx : > +#ifdef RTL_AUTOMATIC_USING > +using ::rtl::OUString; > +using ::rtl::OStringToOUString; > +using ::rtl::OUStringToOString; > +#endi

[Libreoffice-commits] .: cppuhelper/CppunitTest_cppuhelper_checkapi.mk cppuhelper/CustomTarget_cppuhelper_allheaders.mk

2012-07-16 Thread Lubos Lunak
cppuhelper/CppunitTest_cppuhelper_checkapi.mk| 24 +++ cppuhelper/CustomTarget_cppuhelper_allheaders.mk | 22 ++--- 2 files changed, 23 insertions(+), 23 deletions(-) New commits: commit 437dc5384985c97d6b59e91ab5280a840a387731 Author: Luboš Luňák D

[Libreoffice-commits] .: configmgr/source framework/inc framework/source sd/source vcl/unx xmloff/inc xmloff/source

2012-07-16 Thread Lubos Lunak
configmgr/source/components.cxx |2 +- framework/inc/services/frameloaderfactory.hxx|2 +- framework/source/inc/loadenv/targethelper.hxx|4 ++-- framework/source/services/substitutepathvars.cxx |2 +- sd/source/filter/ppt/pptinanimations.cxx |4

[Libreoffice-commits] .: RepositoryExternal.mk

2012-07-16 Thread Lubos Lunak
RepositoryExternal.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e13cda114264670413fe9f799491266b99601df3 Author: Luboš Luňák Date: Mon Jul 16 21:50:59 2012 +0200 fix --with-system-openldap Change-Id: Ifb70bf8277659b942ef05f55f483e1407814958f

Re: C++11 in LibreOffice

2012-07-17 Thread Lubos Lunak
gating ctors, are not there at all. So, as long as we require to build LO with MSVC, we can revisit the question of hard-depending on C++11 in, uhm, let's be optimistic and say 3 years. IOW, we can probably get there faster by ditching backwards ABI compatibility with LO4 and switching

Re: Code documentation - doxygen

2012-07-17 Thread Lubos Lunak
that > > which would be great to change to > > int m_nSomething; //< this counts this and that That is actually not doxygen markup either, it should be ///< . See http://wiki.documentfoundation.org/Development/Doxyg

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - vcl/source

2012-07-17 Thread Lubos Lunak
vcl/source/fontsubset/cff.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 733d07a79a46a551e1eba443a81f3cc851d4cb25 Author: Caolán McNamara Date: Tue Jul 17 16:20:43 2012 +0100 Resolves: fdo#51957 typo, endash entered twice, 2nd should be emdash A

[PUSHED 3-6] Re: [REVIEW 3-6] fdo#51957 opentype emdash exported to pdf as endash

2012-07-17 Thread Lubos Lunak
0d2778397 >b6b08583149e39022e692 > > proposing for 3-6 as payback for the qa-volunteering time the reporter > puts in :-) Looks ok, pushed to 3-6. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org h

FYI: Using the Clang compiler

2012-07-17 Thread Lubos Lunak
y a big part are political reasons (BSD-like license). PS: In case you'll ever feel like posting a patch to the Clang mailing list, be warned that they can be really anal about details and may have no problem with holding your patch just because of silly details like temporary

Re: [Libreoffice-commits] .: 3 commits - basctl/source chart2/source cppcanvas/source cui/source dbaccess/source editeng/source filter/source framework/source package/source reportdesign/source scp2/s

2012-07-18 Thread Lubos Lunak
of the data Isn't sal_uLong deprecated? -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: sorted_vector, constness, pointers, and structs

2012-07-18 Thread Lubos Lunak
se with a pointer is flagged as an error as well, I think a template specialization should be able to handle it (I think I can do that if it's too much of voodoo magic for you). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: sorted_vector, constness, pointers, and structs

2012-07-18 Thread Lubos Lunak
On Wednesday 18 of July 2012, Noel Grandin wrote: > On Wed, Jul 18, 2012 at 7:23 PM, Lubos Lunak wrote: > > But it is correct that you get an error in the second case and you > > ideally should be getting one in the first case as well. You cannot > > modify the elements

Re: sorted_vector, constness, pointers, and structs

2012-07-19 Thread Lubos Lunak
On Wednesday 18 of July 2012, Noel Grandin wrote: > On Wed, Jul 18, 2012 at 8:09 PM, Lubos Lunak wrote: > > You didn't read further than that part above, did you? > > > > What you want is broken. It is definitely broken from the theoretical > > point of vie

Re: sorted_vector, constness, pointers, and structs

2012-07-19 Thread Lubos Lunak
On Thursday 19 of July 2012, Stephan Bergmann wrote: > On 07/18/2012 08:09 PM, Lubos Lunak wrote: > > What you want is broken. It is definitely broken from the theoretical > > point of view, since modifying the items may change the sort order. > > While one can argue

Re: [REVIEW: 3-6-0] fdo#55241 updating of indexes is broken

2012-07-19 Thread Lubos Lunak
n't done anything more than this +1. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2012-07-19 Thread Lubos Lunak
sw/source/core/fields/authfld.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit 48d61f4ad1eb4f8a031e65c3fcbebc5023d600e9 Author: David Tardon Date: Thu Jul 19 14:00:55 2012 +0200 fdo#52241 remove just one entry Change-Id: Ida7920c3196105f7f8aab

Re: [REVIEW: 3-6 3-6-0] fdo#55241 updating of indexes is broken

2012-07-19 Thread Lubos Lunak
On Thursday 19 of July 2012, David Tardon wrote: > On Thu, Jul 19, 2012 at 02:36:48PM +0200, Lubos Lunak wrote: > > On Thursday 19 of July 2012, David Tardon wrote: > > > Hi all, > > > > > > commit 859018061956b1937c7be3809a9858cbd610fa9c fixes yet another

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - writerfilter/source

2012-07-19 Thread Lubos Lunak
writerfilter/source/rtftok/rtfdocumentimpl.cxx |4 +++- writerfilter/source/rtftok/rtfdocumentimpl.hxx |2 +- writerfilter/source/rtftok/rtfsdrimport.cxx| 10 ++ 3 files changed, 10 insertions(+), 6 deletions(-) New commits: commit 0c1de6d3d6320f91770967d1b23c8dd57d168fe7 Au

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 3 commits - sw/source writerfilter/source

2012-07-19 Thread Lubos Lunak
sw/source/filter/ww8/rtfattributeoutput.cxx | 10 -- sw/source/filter/ww8/rtfattributeoutput.hxx |5 + sw/source/filter/ww8/rtfexport.cxx|4 +++- writerfilter/source/dmapper/DomainMapper_Impl.cxx |3 ++- writerfilter/source/rtftok/rtfdocumentim

Changes needed for "LibreOffice 4"

2012-07-20 Thread Lubos Lunak
what we expect from "LibreOffice4" (how much we are actually going to change, how much we care about extensions, etc.). So for that, we should first decide on what "LibreOffice4" will mean. Summary: - it needs to be said what we expect from "LibreOffice4" - the wiki p

Re: Changes needed for "LibreOffice 4"

2012-07-20 Thread Lubos Lunak
u ages to get anywhere near to what LibreOffice is now. I didn't mention it explicitly, but since this is a development list, I expect discussion about what _realistically_ can be done. If you want just to post some random unfounded ideas on which you are not going to actually work, ple

Re: Changes needed for "LibreOffice 4"

2012-07-20 Thread Lubos Lunak
On Friday 20 of July 2012, Michael Meeks wrote: > On Fri, 2012-07-20 at 17:20 +0200, Lubos Lunak wrote: > > Now, if you look at > > http://wiki.documentfoundation.org/Development/LibreOffice4 , a lot of > > the stuff there does not belong to the page at all, as it has absolut

Re: Changes needed for "LibreOffice 4"

2012-07-20 Thread Lubos Lunak
On Friday 20 of July 2012, Lubos Lunak wrote: > On Friday 20 of July 2012, Michael Meeks wrote: > > On Fri, 2012-07-20 at 17:20 +0200, Lubos Lunak wrote: > > > Now, if you look at > > > http://wiki.documentfoundation.org/Development/LibreOffice4 , a lot of > > >

Re: Changes needed for "LibreOffice 4"

2012-07-20 Thread Lubos Lunak
On Friday 20 of July 2012, Thorsten Behrens wrote: > Lubos Lunak wrote: > > Hmm. That makes it something we should take into consideration then, but > > that consideration may be quickly over with saying that it's internal API > > and as such we don't care about p

Re: Changes needed for "LibreOffice 4"

2012-07-20 Thread Lubos Lunak
On Friday 20 of July 2012, Lubos Lunak wrote: > And after all this is done, it should be easier to actually talk about > LO4, because we'll know what the talk is actually about. As for the > technical details (i.e. c) ), we'll need to decide how to handle the > bre

Re: [Libreoffice-commits] .: 3 commits - sc/source tubes/inc tubes/Library_tubes.mk tubes/source

2012-07-20 Thread Lubos Lunak
loadComponentFromURL( rStr, "_blank", 0, args ), > +css::uno::UNO_QUERY_THROW ); > +} > +catch ( css::uno::Exception& e ) > +{ > +fprintf( stderr, "exception when loading '%s' !\n", > + rt

[Libreoffice-commits] .: 2 commits - solenv/gbuild sw/source

2012-07-22 Thread Lubos Lunak
solenv/gbuild/platform/unxgcc.mk |2 ++ sw/source/filter/ww8/docxattributeoutput.cxx |5 - sw/source/filter/ww8/docxexport.cxx |3 --- sw/source/filter/ww8/docxexportfilter.cxx|1 - sw/source/filter/ww8/rtfattributeoutput.cxx |6 -- sw/source/f

[Libreoffice-commits] .: Makefile.top

2012-07-22 Thread Lubos Lunak
Makefile.top |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 1bdb0801eb9315a3f844aa0200f001e667953483 Author: Luboš Luňák Date: Sun Jul 22 16:26:29 2012 +0200 'make build' again generates .msi on windows This is a partial revert of 0ec45dc41dd4

Tinderbox nightlies broken (was Re: No Win builds?)

2012-07-22 Thread Lubos Lunak
dev-install, but this whole 'build' target looks broken to me. What's the point of building a .msi archive there? Especially now with dev-install that looks completely pointless and it should have its own target. Does somebody understand this perl install cruft? -- Lubos Lunak l

[Libreoffice-commits] .: Makefile.top

2012-07-22 Thread Lubos Lunak
Makefile.top |1 + 1 file changed, 1 insertion(+) New commits: commit 1ca7d3432c288f86710fff53674a021ef5e8e8ed Author: Luboš Luňák Date: Sun Jul 22 16:48:23 2012 +0200 install-tb target has meanwhile started using the .zip archive too diff --git a/Makefile.top b/Makefile.top index

Re: C++11 in LibreOffice

2012-07-23 Thread Lubos Lunak
making (well, that also includes one year of just > thinking about it idly with no code), I'm glad I've finally got this one > off my shoulder. :-) > > But no doubt more work is ahead to further optimize this structure. Where's the ben

Re: C++11 in LibreOffice

2012-07-23 Thread Lubos Lunak
with MSVC. It would be quite worth trying that one out with LO. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Tinderbox failure, W2008R2@16-minimal_build, MASTER, last success: 2012-07-22 13:36:59

2012-07-23 Thread Lubos Lunak
failing again, but I think it's just a side effect. Looks like scp2 needs to be modified too to make this file really only optional. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: gbuild deps: removed header

2012-07-23 Thread Lubos Lunak
we want to hack contac-deps and add @true there ? No. That should not make any difference AFAIK. Your problem should be elsewhere. See also the -MP option in gcc manpage. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOf

Re: Tinderbox nightlies broken (was Re: No Win builds?)

2012-07-23 Thread Lubos Lunak
y has updated after this, please pull again. > I added the push of LibO*.zip files in push_nightlies.sh. Is there any point in uploading a .zip file with a Windows build? -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@list

[Libreoffice-commits] .: sw/source

2012-07-24 Thread Lubos Lunak
sw/source/filter/ww8/ww8par.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f0460881e7a60d2852d6314991cd3627623d6be8 Author: Luboš Luňák Date: Tue Jul 24 16:23:27 2012 +0200 ++aIter++ is quite funny, but it's in practice the same like ++aIter C

Re: Tinderbox nightlies broken (was Re: No Win builds?)

2012-07-24 Thread Lubos Lunak
On Monday 23 of July 2012, Norbert Thiebaud wrote: > On Mon, Jul 23, 2012 at 4:30 AM, Lubos Lunak wrote: > > On Sunday 22 of July 2012, Norbert Thiebaud wrote: > >> ... but I used a simple grep + > >> sed to extract INPATH= simpler and most importantly avoid using

[Libreoffice-commits] .: embedserv/Library_emser.mk

2012-06-06 Thread Lubos Lunak
embedserv/Library_emser.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 34dfde55762e48e174f04895d40b9f08918efc4a Author: Luboš Luňák Date: Wed Jun 6 12:42:06 2012 +0200 fix linking after 0fcd1a73f0e1ec564f3c6da1ccd890183d3c18db diff --git a/embedserv/Library_emser.mk b

[Libreoffice-commits] .: sw/source

2012-06-06 Thread Lubos Lunak
sw/source/core/unocore/unodraw.cxx | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) New commits: commit dfc4832049c140b7442c085062599aef1953e8fd Author: Luboš Luňák Date: Wed Jun 6 18:17:50 2012 +0200 fix incorrect OSL_ENSURE -> SAL_WARN_IF conversion (conditi

Incorrect OSL_ENSURE -> SAL_WARN_IF conversions (Re: [Libreoffice-commits] .: sw/source)

2012-06-06 Thread Lubos Lunak
to be false and warns on true. On Wednesday 06 of June 2012, Lubos Lunak wrote: > sw/source/core/unocore/unodraw.cxx | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > New commits: > commit dfc4832049c140b7442c085062599aef1953e8fd > Author: L

[Libreoffice-commits] .: 3 commits - oox/source sw/qa sw/source

2012-06-07 Thread Lubos Lunak
oox/source/vml/vmlshape.cxx |4 ++ sw/qa/extras/ooxmltok/data/n764745-alignment.docx |binary sw/qa/extras/ooxmltok/ooxmltok.cxx| 19 + sw/source/core/unocore/unodraw.cxx| 31 ++ 4 files changed, 44 inser

[Libreoffice-commits] .: 2 commits - configure.in oox/inc oox/source

2012-06-08 Thread Lubos Lunak
configure.in |6 ++ oox/inc/oox/vml/vmlformatting.hxx |5 +++-- oox/source/vml/vmlformatting.cxx |3 +++ 3 files changed, 8 insertions(+), 6 deletions(-) New commits: commit 106d638e6cd4dceffc0aa98a7772d69488ae0a39 Author: Luboš Luňák Date: Fri Jun 8 16

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - oox/inc oox/source

2012-06-08 Thread Lubos Lunak
oox/inc/oox/vml/vmlformatting.hxx |5 +++-- oox/source/vml/vmlformatting.cxx |3 +++ 2 files changed, 6 insertions(+), 2 deletions(-) New commits: commit 069bf1bd90142c6cde41e5fefdb99a275bf798a1 Author: Luboš Luňák Date: Thu Jun 7 18:10:20 2012 +0200 handle f suffix (1/65536th

[Libreoffice-commits] .: 2 commits - oox/source sw/qa

2012-06-11 Thread Lubos Lunak
oox/source/vml/vmlshape.cxx| 15 --- sw/qa/extras/ooxmltok/ooxmltok.cxx |5 + 2 files changed, 17 insertions(+), 3 deletions(-) New commits: commit 0016757efef898205452a586ba5927e5d11fdabe Author: Luboš Luňák Date: Fri Jun 8 19:31:32 2012 +0200 attempt to

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sdext/source xmloff/source

2012-06-12 Thread Lubos Lunak
sdext/source/pdfimport/test/tests.cxx |3 ++- sdext/source/pdfimport/tree/pdfiprocessor.cxx |3 ++- xmloff/source/core/DomExport.cxx |3 ++- xmloff/source/text/txtlists.cxx |9 ++--- 4 files changed, 12 insertions(+), 6 deletions(-) New commi

[PUSHED-3-5]Re: [REVIEW-3-5] Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage.

2012-06-12 Thread Lubos Lunak
blem? > > no, because there's no iterator involved: back() returns a reference to > the value_type. It technically could, by checking in every method that can invalidate references that the passed argument is not such a reference (to one of the elements). -- Lubos Lunak l.lu...@suse.

Re: probabilistic approach to tinderboxing

2012-06-14 Thread Lubos Lunak
ich are needed anyway (for direct commits, some other seemingly unrelated commit breaking the patch meanwhile, etc.). [*] Speaking of which, when will we get told about this gerrit thing, besides random remarks, or have I missed it? -- Lubos Lunak l.lu...@suse.cz _

[Libreoffice-commits] .: 6 commits - oox/inc oox/source svtools/source sw/qa vcl/source writerfilter/source

2012-06-19 Thread Lubos Lunak
oox/inc/oox/vml/vmlshapecontainer.hxx | 21 ++-- oox/source/shape/ShapeContextHandler.cxx | 13 +++- oox/source/vml/vmlshapecontainer.cxx | 22 - svtools/source/graphic/grfmgr2.cxx|7 ++ sw/

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 3 commits - oox/inc oox/source

2012-06-19 Thread Lubos Lunak
oox/inc/oox/vml/vmlshapecontainer.hxx| 31 --- oox/source/shape/ShapeContextHandler.cxx | 13 - oox/source/vml/vmlshapecontainer.cxx | 22 +- 3 files changed, 53 insertions(+), 13 deletions(-) New commits: commit a8d062de88

[Libreoffice-commits] .: sw/qa

2012-06-19 Thread Lubos Lunak
sw/qa/extras/ooxmltok/ooxmltok.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1eb52e99b1bb20616d91142e71f6e535bb8eb13f Author: Luboš Luňák Date: Tue Jun 19 12:12:23 2012 +0200 treat for tinderbox with obsolete gcc and -Werror *sigh* diff --git a/sw/qa

[Libreoffice-commits] .: vcl/source

2012-06-19 Thread Lubos Lunak
vcl/source/gdi/outdev2.cxx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit ad08216f8f489ad36c8def71ae4f27a64d89 Author: Luboš Luňák Date: Tue Jun 19 13:47:42 2012 +0200 match properly the type in the extern declaration Change-Id: Iaad

Precompiled headers?

2012-06-19 Thread Lubos Lunak
reason, but only without PCH). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW-3-5-5] Use after delete in oox

2012-06-19 Thread Lubos Lunak
x27;t feel confident enough about the rewrite for a backport at this point, so the patch is just a band-aid. The current 3-5 code has a use-after-delete problem caused by the fact that it's not possible to take out a pointer out of a shared_ptr based container. -- Lubos Lunak l.lu...@su

Re: [ANN] Please use Gerrit from now on for Patch Review

2012-06-19 Thread Lubos Lunak
urprised people who actually had a look at what is coming before. Sorry, but I think you got this backwards. If we run out of smart unsurprised people to look at what's coming, it's not coming. Simple as that. Tools are there for people, not people for tools. > So I guess the lesson is

Re: [Libreoffice-commits] .: sw/source

2012-06-20 Thread Lubos Lunak
"Wrong TxtFlyCnt-Hint." ); > -const_cast(pHnt->GetFlyCnt()).SetFlyFmt(); > +if (pHnt) > +const_cast(pHnt->GetFlyCnt()).SetFlyFmt(); I think this is a sign of internal inconsiste

Re: [ANN] Please use Gerrit from now on for Patch Review

2012-06-20 Thread Lubos Lunak
On Tuesday 19 of June 2012, Bjoern Michaelsen wrote: > On Tue, Jun 19, 2012 at 05:04:58PM +0200, Lubos Lunak wrote: > > Which is the problem. Besides asking just to do that it should have also > > said why one should do that. I'm one of the people who haven't done that, &

Re: Precompiled headers?

2012-06-20 Thread Lubos Lunak
On Tuesday 19 of June 2012, Bjoern Michaelsen wrote: > On Tue, Jun 19, 2012 at 02:32:23PM +0200, Lubos Lunak wrote: > > does somebody know why support for precompiled headers has been removed > > from LibreOffice? > > So back in the days: > - lack of an insanely fast wi

Re: [ANN] Please use Gerrit from now on for Patch Review

2012-06-20 Thread Lubos Lunak
On Wednesday 20 of June 2012, Bjoern Michaelsen wrote: > On Wed, Jun 20, 2012 at 02:55:53PM +0200, Lubos Lunak wrote: > > If you don't want people to miss important information, you need to > > announce it properly and not as some offhand remark. > > A mail with "

Re: Precompiled headers?

2012-06-20 Thread Lubos Lunak
On Wednesday 20 of June 2012, Norbert Thiebaud wrote: > On Tue, Jun 19, 2012 at 7:32 AM, Lubos Lunak wrote: > >[...] PCH with > > MSVC avoid the performance hit of using many -I options (adding -I for > > each /inc adds 25% time for whatever reason, but only without > &g

[Libreoffice-commits] .: 9 commits - svtools/inc svtools/source

2012-06-22 Thread Lubos Lunak
svtools/inc/svtools/grfmgr.hxx |4 svtools/source/filter/wmf/enhwmf.cxx |8 svtools/source/filter/wmf/winwmf.cxx |2 svtools/source/graphic/grfcache.cxx | 312 +-- svtools/source/graphic/grfmgr2.cxx | 271 +++--- 5 f

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - canvas/source cui/source filter/source framework/source sd/source sfx2/source svx/source toolkit/source vcl/inc vcl/source

2012-06-22 Thread Lubos Lunak
canvas/source/vcl/canvasbitmaphelper.cxx |2 +- canvas/source/vcl/canvashelper.cxx |2 +- cui/source/dialogs/cuigrfflt.cxx |2 +- filter/source/graphicfilter/eps/eps.cxx|2 +- fr

[Libreoffice-commits] .: canvas/source cui/source filter/source framework/source sd/source sfx2/source svtools/source svx/source toolkit/source vcl/inc vcl/source

2012-06-22 Thread Lubos Lunak
canvas/source/vcl/canvasbitmaphelper.cxx |2 +- canvas/source/vcl/canvashelper.cxx |2 +- cui/source/dialogs/cuigrfflt.cxx |2 +- filter/source/graphicfilter/eps/eps.cxx|2 +- fr

[Libreoffice-commits] .: vcl/unx

2012-08-01 Thread Lubos Lunak
vcl/unx/kde4/KDE4FilePicker.cxx |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) New commits: commit e62c67d8d47231e3ff0df440642dfcabac4f3f81 Author: Luboš Luňák Date: Wed Aug 1 11:11:44 2012 +0200 do not let LO's autoextension handling interfere with KFileDialog's(fd

[Libreoffice-commits] .: vcl/unx

2012-08-01 Thread Lubos Lunak
vcl/unx/kde4/KDE4FilePicker.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit 78f1e95df4b8bd1fbc32ed4192676fd4f176f5bf Author: Luboš Luňák Date: Wed Aug 1 12:08:03 2012 +0200 workaround for KFileDialog remembering its settings Change-Id: I6f473c246408684c5d

Using compiler plugins

2012-08-03 Thread Lubos Lunak
ctually use it for. Some EasyHacks are a good start, but the list might get quite long. -- Lubos Lunak l.lu...@suse.cz loplugin.tar.gz Description: application/tgz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Static src analysis of LibreOffice

2012-08-03 Thread Lubos Lunak
g as #18 is the only tinderbox for that "platform", I'd like it to run fast. If needed, a separate tinderbox elsewhere should do. Especially given that the static analysis doesn't really need to be run several times a day. -- Lubos Lunak l.lu...@suse.cz __

Re: Using compiler plugins

2012-08-03 Thread Lubos Lunak
On Friday 03 of August 2012, Caolán McNamara wrote: > On Fri, 2012-08-03 at 15:05 +0200, Lubos Lunak wrote: > > - Find out what we can actually use it for. Some EasyHacks are a good > > start, but the list might get quite long. > > I'd be interested to know it'd be

Re: [Libreoffice-commits] .: sc/source

2012-08-05 Thread Lubos Lunak
rExpr2 = ScXMLConditionHelper::getExpression( pStart, pEnd, ')'); It's usually better to just write strlen( "foo" ) rather than hardcode numbers, compilers can optimize away calls to strlen with string literals anyway. -- Lubos Lunak l.lu...@suse.cz __

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-08-05 Thread Lubos Lunak
sc/source/filter/xml/xmlcondformat.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 38d7b11915c9c4e5fcebcb7eb3ae1b2846b26267 Author: Markus Mohrhard Date: Sun Aug 5 11:47:19 2012 +0200 use correct string length for "between", fdo#53010 Change-Id: I

[PUSHED-3-6] Re: [REVIEW-3-6] fix for fdo#53010, use correct length for string

2012-08-05 Thread Lubos Lunak
. Note that, as I already said in a reply to the master commit before noticing this mail, it's much better to simply write strlen( "foo" ). It'll get optimized away and not only that's more likely to get the number right, but here it's also completely non-obvious t

Re: Static src analysis of LibreOffice

2012-08-07 Thread Lubos Lunak
produced by ccc-analyzer/c++-analyzer. It doesn't make much sense to analyze with Clang but compile with GCC. Configure detects various features of the compiler and if you actually use GCC, certain things will not be set up properly for Clang. Use Clang for compiling too. -- Lubos Lunak

Re: [Libreoffice-commits] -Werror=format-security

2012-08-07 Thread Lubos Lunak
idea of something in this codebase being well-documented, but this stuff is, see sal/inc/sal/log.hxx . -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 7 commits - sw/qa sw/source writerfilter/inc writerfilter/source

2012-08-08 Thread Lubos Lunak
sw/qa/extras/ooxmlexport/ooxmlexport.cxx |4 - sw/qa/extras/ooxmlimport/data/bnc773061.docx |binary sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 17 + sw/qa/extras/rtfimport/rtfimport.cxx |2 sw/qa/extras/swmodeltestbase.hxx |8

[Libreoffice-commits] .: tools/inc

2012-08-08 Thread Lubos Lunak
tools/inc/tools/ref.hxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 320117aba7061de0b062f8894d8685a073b0c6bd Author: Luboš Luňák Date: Wed Aug 8 16:33:34 2012 +0200 adding missing typename Change-Id: I2bc828cdb636e84257311135ce7204bc6500b

Re: compareToAscii( RTL_CONSTASCII_STRINGPARAM( "something" ) )

2012-09-06 Thread Lubos Lunak
ready covered by the various existing > match... functions, with a default fromIndex = 0. Which is rather non-obvious both when writing and reading code, as 'str.match( "foo" )' intuitively suggests 'str == "foo"', so it's not really good API eithe

Re: Tinderbox failure, Linux-x86-64@8-SLED11, libreoffice-3-5, last success: 2012-08-29 21:47:46

2012-09-10 Thread Lubos Lunak
; with this time-to-time breakage, or should I stop tinderboxing 3.5? [I > so far prefer the former, but... ;-)] If all you want is to hide a specific error, the error can be added to the blacklist of the tinderbox. -- Lubos Lunak l.lu...@suse.cz ___

Added fonts while LO is running - propagating the changes

2012-09-10 Thread Lubos Lunak
ont list. Does somebody have any idea about any of these? -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Tinderbox failure, Linux-x86-64@8-SLED11, libreoffice-3-5, last success: 2012-08-29 21:47:46

2012-09-11 Thread Lubos Lunak
On Tuesday 11 of September 2012, Jan Holesovsky wrote: > Hi Lubos, > > Lubos Lunak píše v Po 10. 09. 2012 v 12:12 +0200: > > > Yes, and "something" has fixed that in master; so I wonder - OK to live > > > with this time-to-time breakage, or should I stop tind

Re: sal/config.g sal/types.h and sal/osl/rtl includes in general

2012-09-17 Thread Lubos Lunak
ne and -include for #include at the beginning of files. > > I could understand the desire for some lo.h from the point of view of > > performance (though the relevant sub-headers will probably manage to stay > > in main memory anyway) And this, I think, is called either precompiled

Re: Automatic using ::rtl::OUString etc.

2012-09-18 Thread Lubos Lunak
On Tuesday 18 of September 2012, Stephan Bergmann wrote: > On 07/16/2012 04:03 PM, Lubos Lunak wrote: > > FYI, this is now in. The stable modules (sal/, salhelper/, cppu/, > > cppuhelper/) build without it and there's additionally a check including > > all their .hxx&

Re: sal/config.g sal/types.h and sal/osl/rtl includes in general

2012-09-19 Thread Lubos Lunak
down. > --enable-apps-only="base sw" > if someone is working on one or two apps there is no reason to rebuild > the whole suite all the time. This one would be nice to have (although presumably non-trivial to implement). And I'd support the make target not involving tests

Re: getting started

2012-09-19 Thread Lubos Lunak
ation.org/Development should be a good starting point - the page links to pages explaining how to do a build, how to submit patches, etc. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freede

Re: sal/config.g sal/types.h and sal/osl/rtl includes in general

2012-09-20 Thread Lubos Lunak
/include-what-you-use/ . I haven't tried it though. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: uninitialized member warnings ?

2012-09-26 Thread Lubos Lunak
gt; > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=2972 > > Doesn't seem to be going anywhere in the last month, but - you can but > hope :-) I don't think it can go anywhere practical: class A { bool foo; void init(); public: A() { init(); } }; How should the c

Re: ww8export tinderbox failure ?

2012-09-26 Thread Lubos Lunak
e OLE stream is rubbish. I got rather lost at that point and gave up in the hope somebody else would fix it. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: OUString is mutable?

2012-10-03 Thread Lubos Lunak
a normally mutable OUString with the same abilities. As such, as far as I can tell, immutable OUString is only a complication with no practical advantages. > > So it's really not any safer than using an OUStringBuffer. > > It just gives the ill

Re: using bool in rtl::OUStringBuffer::append

2012-10-04 Thread Lubos Lunak
hat there is also const char* that should not be used this way, and adding such an overload would break the string literal overloads. I suppose this all could be solved using bool and _rtl_uString* overloads, and by making a tinderbox use a comp

Re: OUString is mutable?

2012-10-04 Thread Lubos Lunak
On Wednesday 03 of October 2012, Michael Stahl wrote: > On 03/10/12 18:19, Lubos Lunak wrote: > > As such, as far as I can tell, immutable OUString is only a complication > > with no practical advantages. > > please read my other mail for other benefits... I assume you me

Re: [Libreoffice-commits] update string copy semantics to be undefined in a non-crashing way

2012-10-04 Thread Lubos Lunak
quentcheck on > dbgutl, right?)? How would this be different from a plain assert()/abort() in practice? -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

<    2   3   4   5   6   7   8   >