[PATCH libreoffice-4-0] fdo#61564 when WrappedTargetException not in specification, ...

2013-03-12 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2684 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/2684/1 fdo#61564 when WrappedTargetException not in specification, do not throw it! Change-Id: Id3c995557f320b1d0241f0e

[PATCH] WIP: time datatypes to nanosecond precision

2013-03-17 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2783 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/2783/1 WIP: time datatypes to nanosecond precision Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6 --- M basic/sou

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-03-23 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#10). Change subject: WIP: date/time IDL datatypes incompatible change .

[PATCH] Change in core[libreoffice-3-6]: fdo#57611 do not crash when setting too small size

2012-11-29 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1197 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/1197/1 fdo#57611 do not crash when setting too small size The caller's exception specifications are lacking, but fixing

[PATCH] Do not override the message of an underlying PropertyVetoExc...

2012-11-29 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1198 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/1198/1 Do not override the message of an underlying PropertyVetoException Change-Id: I9c1026ad87f3031f1c56066ab24d23d3a

[PATCH] Change in core[libreoffice-3-6]: Catch all exceptions to respect specification

2012-12-02 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1226 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/1226/1 Catch all exceptions to respect specification In particular, getMaxRows() can throw SQLException Change-Id: I1f

[PATCH] Change in core[libreoffice-3-6]: fdo#42165 make nested joins as per strict ANSI SQL

2012-12-02 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1225 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/1225/1 fdo#42165 make nested joins as per strict ANSI SQL Change-Id: I605d3811b27c33e35670306bb03b5a796ab72bc0 --- M db

[PATCH] Change in core[libreoffice-4-0]: OSQLParser::RuleIDToRule should not silently change s_aRever...

2013-01-25 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1826 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/1826/1 OSQLParser::RuleIDToRule should not silently change s_aReverseRuleIDLookup Change-Id: I2b408a23162b1200bbcd530be

[PATCH] Change in core[libreoffice-4-0]: fix handling of subqueries in query design

2013-01-25 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1827 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/1827/1 fix handling of subqueries in query design - don't remove parentheses around subqueries (without the parenth

[PUSHED] ORowSetValue: clean up sign/unsigned union member

2013-02-05 Thread Lionel Elie Mamane (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1164 Objections: Luboš Luňák: Do not submit -- To view, visit https://gerrit.libreoffice.org/1164 To unsubscribe, visit https://gerrit.libreof

[PATCH libreoffice-4-0] fdo#47951 work around underlying cause

2013-05-19 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3959 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/3959/1 fdo#47951 work around underlying cause The true cause is that the flat text file database driver mishandles the

[PATCH libreoffice-4-0] fdo#47951 flat text table: update m_nRowPos when moving by b...

2013-05-19 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3961 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/3961/1 fdo#47951 flat text table: update m_nRowPos when moving by bookmark Change-Id: Iac154020b4b6309f92b1f68fa5bf7961

[PATCH libreoffice-3-6] fdo#47951 flat text table: update m_nRowPos when moving by b...

2013-05-19 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3962 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/3962/1 fdo#47951 flat text table: update m_nRowPos when moving by bookmark Change-Id: Iac154020b4b6309f92b1f68fa5bf7961

[PATCH libreoffice-3-6] fdo#47951 work around underlying cause

2013-05-19 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3963 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/3963/1 fdo#47951 work around underlying cause The true cause is that the flat text file database driver mishandles the

[PATCH libreoffice-4-1] setPropertyValue can throw PropertyVetoException

2013-05-30 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4095 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/4095/1 setPropertyValue can throw PropertyVetoException fixes abort in report design when entering e.g. invalid positio

[PATCH libreoffice-4-0] setPropertyValue can throw PropertyVetoException

2013-05-30 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4096 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/4096/1 setPropertyValue can throw PropertyVetoException fixes abort in report design when entering e.g. invalid positio

[PATCH] fdo#63391 deadlock on opening .odb file that auto-connects t...

2013-04-10 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3310 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/3310/1 fdo#63391 deadlock on opening .odb file that auto-connects to the database Let foo.odb be a database file that h

[PATCH libreoffice-4-0] work around fdo#62147

2013-04-10 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3311 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/3311/1 work around fdo#62147 don't emit string-value attribute Change-Id: I3668b88437451523f2b6bb3c2c82e1929f7ba3d8 --

[PATCH libreoffice-4-0] reportbuilder: do not use empty tablename

2013-04-11 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3341 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3341/1 reportbuilder: do not use empty tablename Change-Id: I03ed5e810468ee206820a250c740b80c0ceda432 --- M reportbuild

[PATCH libreoffice-4-0] pgsql-sdbc: set tablename even if we do not know the schema

2013-04-11 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3342 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/3342/1 pgsql-sdbc: set tablename even if we do not know the schema Change-Id: I74c04e1262cc413696a12aca9af603beded7b07f

[PATCH libreoffice-4-0] pgsql-sdbc: ResultSetMetaData::getTableName return tablename...

2013-04-11 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3343 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/3343/1 pgsql-sdbc: ResultSetMetaData::getTableName return tablename (without schema) Change-Id: I319ba91045fa43922d7b69

[PATCH] gcc -dumpversion has only MAJOR.MINOR, not MAJOR.MINOR.PATCH...

2013-04-12 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3362 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/3362/1 gcc -dumpversion has only MAJOR.MINOR, not MAJOR.MINOR.PATCHLEVEL Change-Id: I94ea73628d8aac107e3ada1dc5a63e51e7

[PATCH libreoffice-4-0] fdo#36858

2013-04-12 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3363 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/3363/1 fdo#36858 1) No valueType (Format/Number/General) is like float valueType (Format/Number/any other) 2) We use 1

[ABANDONED] gcc -dumpversion has only MAJOR.MINOR, not MAJOR.MINOR.PATCH...

2013-04-13 Thread Lionel Elie Mamane (via Code Review)
Lionel Elie Mamane has abandoned this change. Change subject: gcc -dumpversion has only MAJOR.MINOR, not MAJOR.MINOR.PATCHLEVEL .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/3362 To unsubscribe, v

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-13 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#11). Change subject: WIP: date/time IDL datatypes incompatible change .

[PATCH libreoffice-4-0] fdo#52179 on copy kb-shortcut, from *current* row, not last ...

2013-04-14 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3378 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/3378/1 fdo#52179 on copy kb-shortcut, from *current* row, not last painted row (!) Change-Id: I39be862abb7c72234adad9c5

[PATCH libreoffice-3-6] fdo#52179 on copy kb-shortcut, from *current* row, not last ...

2013-04-14 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3379 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/3379/1 fdo#52179 on copy kb-shortcut, from *current* row, not last painted row (!) Change-Id: I39be862abb7c72234adad9c5

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#12). Change subject: WIP: date/time IDL datatypes incompatible change .

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#13). Change subject: WIP: date/time IDL datatypes incompatible change .

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#14). Change subject: WIP: date/time IDL datatypes incompatible change .

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#15). Change subject: WIP: date/time IDL datatypes incompatible change .

[PATCH libreoffice-4-0] fdo#61142 mixup between size and length

2013-04-14 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3385 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/3385/1 fdo#61142 mixup between size and length Change-Id: Ia2903d5139378e97bb2e8d00ccb2c213d3e1dee6 --- M connectivity/

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#16). Change subject: WIP: date/time IDL datatypes incompatible change .

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#17). Change subject: WIP: date/time IDL datatypes incompatible change .

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#18). Change subject: WIP: date/time IDL datatypes incompatible change .

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-15 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#19). Change subject: WIP: date/time IDL datatypes incompatible change .

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-16 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#20). Change subject: WIP: date/time IDL datatypes incompatible change .

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-16 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#21). Change subject: WIP: date/time IDL datatypes incompatible change .

[PATCH] fdo#61725 workaround

2013-04-18 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3462 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/3462/1 fdo#61725 workaround Change-Id: I7d25f293020f366b20ddb9cade1854013857bed2 --- M vcl/source/app/dbggui.cxx 1 file

[PATCH] date/time IDL datatypes incompatible change

2013-04-18 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#22). Change subject: date/time IDL datatypes incompatible change ..

[ABANDONED] fdo#61725 workaround

2013-04-18 Thread Lionel Elie Mamane (via Code Review)
Lionel Elie Mamane has abandoned this change. Change subject: fdo#61725 workaround .. Patch Set 1: Abandoned not intended to be committed; pushed to gerrit by error. -- To view, visit https://gerrit.libreoffice.org/3462 To un

[PATCH] date/time IDL datatypes incompatible change

2013-04-18 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#23). Change subject: date/time IDL datatypes incompatible change ..

[PUSHED] date/time IDL datatypes incompatible change

2013-04-18 Thread Lionel Elie Mamane (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2783 -- To view, visit https://gerrit.libreoffice.org/2783 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

[PATCH] date/time IDL datatypes incompatible change

2013-04-18 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#24). Change subject: date/time IDL datatypes incompatible change ..

[PATCH] date/time IDL datatypes incompatible change

2013-04-19 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2783 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/2783/24 date/time IDL datatypes incompatible change - nanosecond precision - signed (allowed negative) year Also: as

[PATCH libreoffice-4-0] Base: fix incorrect field removal in criterion inside query ...

2013-04-22 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3564 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/3564/1 Base: fix incorrect field removal in criterion inside query design view Includes following master commits: comm

[PATCH libreoffice-4-0] fdo#330191 a NULL value of float type is not NaN

2013-04-24 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3599 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/3599/1 fdo#330191 a NULL value of float type is not NaN but it is *still* NULL. This was initially done to "fix" i#108

[PATCH] Add new dialog to Query Design View

2013-03-04 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2508 to look at the new patch set (#3). Change subject: Add new dialog to Query Design View .. Add new dialog t

[PATCH] Add new dialog to Query Design View

2013-03-04 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2508 to look at the new patch set (#4). Change subject: Add new dialog to Query Design View .. Add new dialog t

[PUSHED] Add new dialog to Query Design View

2013-03-04 Thread Lionel Elie Mamane (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2508 -- To view, visit https://gerrit.libreoffice.org/2508 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

[PATCH libreoffice-4-0] fdo#61166 text format: correctly chain the formatter->getOut...

2013-03-06 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2570 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/2570/1 fdo#61166 text format: correctly chain the formatter->getOutputString calls cf commit 271b11a3d56ba0c5f542a142ab

[PUSHED] pgsql-sdbc: conninfo keywords as static table instead of ser...

2013-04-29 Thread Lionel Elie Mamane (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3614 Objections: Tor Lillqvist: Do not merge -- To view, visit https://gerrit.libreoffice.org/3614 To unsubscribe, visit https://gerrit.libreo

[ABANDONED] Change j type to size_t

2013-04-29 Thread Lionel Elie Mamane (via Code Review)
Lionel Elie Mamane has abandoned this change. Change subject: Change j type to size_t .. Patch Set 1: Abandoned Squashed into change 3614 -- To view, visit https://gerrit.libreoffice.org/3616 To unsubscribe, visit https://ger

[ABANDONED] Rewrite as a static table of keywords and loop over them

2013-04-29 Thread Lionel Elie Mamane (via Code Review)
Lionel Elie Mamane has abandoned this change. Change subject: Rewrite as a static table of keywords and loop over them .. Patch Set 1: Abandoned Squashed into change 3614 -- To view, visit https://gerrit.libreoffice.org/3615

[PATCH libreoffice-4-0] fdo#48056 revert part of return "correct name for shapetype"

2013-05-03 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3766 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/3766/1 fdo#48056 revert part of return "correct name for shapetype" Keep hardcoded values as *fallback* only, but trust

[PATCH libreoffice-4-0] fdo#64150 don't segfault when there is no line

2013-05-03 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3765 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/3765/1 fdo#64150 don't segfault when there is no line Change-Id: Iab36de3d407925cdb0e092afae457907f0261b3e --- M editen

[PATCH libreoffice-4-0] fdo#48056 treat report chart as draw chart

2013-05-03 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3767 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3767/1 fdo#48056 treat report chart as draw chart Change-Id: I0a716b4339747f1994e5c8710e15474807aea4a2 --- M comphelper

[PATCH libreoffice-3-6] fdo#64150 don't segfault when there is no line

2013-05-03 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3768 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/3768/1 fdo#64150 don't segfault when there is no line Change-Id: Iab36de3d407925cdb0e092afae457907f0261b3e --- M editen

[PATCH libreoffice-3-6] fdo#48056 revert part of return "correct name for shapetype"

2013-05-03 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3769 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/3769/1 fdo#48056 revert part of return "correct name for shapetype" Keep hardcoded values as *fallback* only, but trust

[PATCH libreoffice-3-6] fdo#48056 treat report chart as draw chart

2013-05-03 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3770 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/3770/1 fdo#48056 treat report chart as draw chart Change-Id: I0a716b4339747f1994e5c8710e15474807aea4a2 --- M comphelper

[PATCH libreoffice-4-0] fdo#63398 hardcode former list of oneway method

2013-05-11 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3863 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/3863/1 fdo#63398 hardcode former list of oneway method adapt to disappearance of oneway qualifier for method by hardcod

[PATCH libreoffice-4-0] fdo#63695 revert hackish fix to i#51621

2013-05-11 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3864 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/3864/1 fdo#63695 revert hackish fix to i#51621 Change-Id: I688a659207c4b95cc98ff5dc5c5622d4592b3f89 (cherry picked from

[PATCH libreoffice-4-0] commit subforms before moving in parent form

2013-05-11 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3865 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/3865/1 commit subforms before moving in parent form else, all pending changes in the subforms are lost (cherry picked

[PATCH] Change in core[libreoffice-4-0]: mark *all* tables of a nested join as added

2013-01-18 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1756 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/1756/1 mark *all* tables of a nested join as added Else, if the n^{th} (with n>2) table also appears in a (non-NATURAL)

[PATCH] Change in core[libreoffice-3-6]: mark *all* tables of a nested join as added

2013-01-18 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1764 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/1764/1 mark *all* tables of a nested join as added Else, if the n^{th} (with n>2) table also appears in a (non-NATURAL)

[PATCH] i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.

2013-07-14 Thread Lionel Elie Mamane (via Code Review)
Lionel Elie Mamane has uploaded a new patch set (#3). Change subject: i#108348 API CHANGE: add IsUTC to css.util.DateTime etc. .. i#108348 API CHANGE: add IsUTC to css.util.DateTime etc. Add IsUTC member to: com.sun.star.util.D

[PATCH] i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.

2013-07-14 Thread Lionel Elie Mamane (via Code Review)
Lionel Elie Mamane has uploaded a new patch set (#4). Change subject: i#108348 API CHANGE: add IsUTC to css.util.DateTime etc. .. i#108348 API CHANGE: add IsUTC to css.util.DateTime etc. Add IsUTC member to: com.sun.star.util.D

[PATCH libreoffice-4-1] Revert "fdo#65653, fdo#65619, fdo#65216: Missing check"

2013-06-18 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4337 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/4337/1 Revert "fdo#65653, fdo#65619, fdo#65216: Missing check" This reverts commit 10777b37536be16c6d2e167b59e9e31e37ba

[PUSHED libreoffice-4-1] Revert "fdo#65653, fdo#65619, fdo#65216: Missing check"

2013-06-18 Thread Lionel Elie Mamane (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4337 -- To view, visit https://gerrit.libreoffice.org/4337 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

[PATCH libreoffice-4-1] fdo#65653 make columnMatchP safer

2013-06-18 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4338 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/4338/1 fdo#65653 make columnMatchP safer Change-Id: Id994ab5aed6172d8a93fd331a366fca10a663a48 --- M connectivity/source

[PATCH] fdo#67235 adapt form control code to time nanosecond API cha...

2013-08-02 Thread Lionel Elie Mamane (via Code Review)
Lionel Elie Mamane has created a new patch set by issuing a rebase in Gerrit (#2). Change subject: fdo#67235 adapt form control code to time nanosecond API change .. fdo#67235 adapt form control code to time nanosecond API chang

[PUSHED] fdo#67235 adapt form control code to time nanosecond API cha...

2013-08-02 Thread Lionel Elie Mamane (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5149 Approvals: Lionel Elie Mamane: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/5149 To unsubscribe,

[PATCH] fdo#67235 adapt form control code to time nanosecond API cha...

2013-08-04 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/5270 to look at the new patch set (#2). Change subject: fdo#67235 adapt form control code to time nanosecond API change, step 3 ...

[PUSHED] fdo#67235 adapt form control code to time nanosecond API cha...

2013-08-04 Thread Lionel Elie Mamane (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5270 Approvals: Lionel Elie Mamane: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/5270 To unsubscribe,

[PATCH] Change in core[libreoffice-3-6]: fdo#37529 clear DataColumns read-only information when we cl...

2012-09-13 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/608 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/608/1 fdo#37529 clear DataColumns read-only information when we clear DataColumns Change-Id: I6f3b4f1646df1244d97ae98f56

[PATCH] Change in core[libreoffice-3-6]: fdo#44721 protect against negative calculated height value

2012-09-14 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/622 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/622/1 fdo#44721 protect against negative calculated height value Change-Id: I4faedd535421eaf1e3e425f4731b3bb8831e7360 --

[PATCH] Change in core[libreoffice-3-5]: fdo#44721 protect against negative calculated height value

2012-09-14 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/623 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/623/1 fdo#44721 protect against negative calculated height value Change-Id: I4faedd535421eaf1e3e425f4731b3bb8831e7360 --

[PATCH] Change in core[libreoffice-3-6-2]: fdo#44721 protect against negative calculated height value

2012-09-14 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/624 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/624/1 fdo#44721 protect against negative calculated height value Change-Id: I4faedd535421eaf1e3e425f4731b3bb8831e7360 --

[PATCH] Change in core[libreoffice-3-6]: fdo#52392 dbase: correctly NULL out non-filled in fields in ...

2012-10-26 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/923 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/923/1 fdo#52392 dbase: correctly NULL out non-filled in fields in inserted rows Change-Id: Id2e8ad5b6bed1c184de6dccf7fa4

[PATCH] detect even more memory mismanagement on glibc

2012-10-30 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/940 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/940/1 detect even more memory mismanagement on glibc Change-Id: Idba21b12582e9ae7d240d9d3527f9ac5893252f7 --- M solenv/b

[PUSHED] detect even more memory mismanagement on glibc

2012-11-02 Thread Lionel Elie Mamane (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/940 -- To view, visit https://gerrit.libreoffice.org/940 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: me

[PATCH] Change in core[libreoffice-3-6]: Don't abort when column has no (Catalog|Schema|Table)Name

2012-11-02 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/968 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/968/1 Don't abort when column has no (Catalog|Schema|Table)Name Especially since the rest of the function is prepared to

[PATCH] detect even more memory mismanagement on glibc

2012-11-02 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/969 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/969/1 detect even more memory mismanagement on glibc Change-Id: I3a06e5970638c755e89f8ffdf96b68d3c6cdbe61 --- M solenv/b