[Libreoffice] [PATCH][REVIEW] Fix for fdo#36673: corrupt date formats of cells

2011-05-10 Thread Katarina Machalkova
ely, if we want to retain the two new fraction formats (and I gather we do, because of Excel compatibility), they can be added into locale XML files. But that would mean editing ... uhm ... ~200 files, so it's certainly nothing for 3.4 Thx for feedback frozenB. -- \ K

Re: [Libreoffice] [REVIEW] [PUSHED] Crasher fix for fdo#37252

2011-05-18 Thread Katarina Machalkova
> Shoot. I didn't realize we already branched. Can I get two more > sign-offs for the -3-4-0 branch too? +1 from me (provided that sign-off folks don't have to be from different organizations, as Tor says) B. ___ LibreOffice mailing list LibreOffic

[Libreoffice] [REVIEW] Fix for fdo#37322: Calc binary import crasher

2011-05-19 Thread Katarina Machalkova
same no. of defined names as we imported and it seems to have passed. Thx (for all the fish) frozenB. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter From 96b9a924fa75be562a2d81834b777ce91fd30326 Mon Sep 17 00:0

Re: [Libreoffice] [REVIEW] pptx export on 3-4[-0] branches

2011-05-19 Thread Katarina Machalkova
> Hi, > > I would like to push fixes for pptx export for 3-4 and 3-4-0 branches. > The pptx export is currently broken as the export component is not > instantiated. Ack from me frozenB. -- \ Katarina Machalkova \\\__o

Re: [Libreoffice] Bug in new LINEST implementation

2011-05-19 Thread Katarina Machalkova
On Thursday, May 19, 2011 22:12:14 Markus Mohrhard wrote: > I think this patch is fine too. So if my sign counts you have a second. +1 from me, which makes it third. B. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesk

Re: [Libreoffice] [last REVIEW needed] trivial PPTX import crash fix

2011-05-20 Thread Katarina Machalkova
> To avoid a NULL pointer de-reference, don't de-reference a null > pointer :-) I'd like to get this into 3.4.0 You've my '+1 ' frozenB. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_

Re: [Libreoffice] [Review][PUSHED] patch for disappearing autofilter when inserting/deleting sheets

2011-05-24 Thread Katarina Machalkova
y-picked & pushed to 3-4-0 (the good, the bad & the ugly) B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a digitally signed message part. ___

[Libreoffice] [REVIEW] fdo#35345: more Calc (auto)filter evilness

2011-05-24 Thread Katarina Machalkova
for the presence of autofilter or query params. Please review & comment. /me doesn't know this particular pieces of code so well. frozenB. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter From 6b4c2666b8c413137

[Libreoffice] [REVIEW] OOXML 2010 xlsx export

2011-05-30 Thread Katarina Machalkova
Hey there, can some1 please review & cherry-pick for 3.4 the following patch: http://cgit.freedesktop.org/libreoffice/filters/commit/?id=6603c30f910b1fb5674a28988304dfcd14c11ecb Seems that it somehow fell through the cracks and never made it to 3.4 branch :-( Sadly, saving spreadsheet docs wi

Re: [Libreoffice] [REVIEW] [PUSHED] Fix for fdo#37622

2011-06-10 Thread Katarina Machalkova
c. This lookup > behavior was accidentally altered during ScfDefList removal. Reviewed, cherry-picked & pushed. Thanks for fixing this, I was pretty close to finding the root cause of the last font in the list not being applied, but not quite there yet. B. -- \

[Libreoffice] [REVIEW] fdo#38154: Invalid xls export of docs with split/frozen window

2011-06-13 Thread Katarina Machalkova
variables holding the row number on import & export. Thanks B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter From eb82695e19d8f25b41c9b00f791e105176f7a151 Mon Sep 17 00:00:00 2001 From: Katarina Machal

Re: [Libreoffice] Status of unlimited conditional formatting

2011-06-15 Thread Katarina Machalkova
b93f332abe045fd0740667 http://cgit.freedesktop.org/libreoffice/calc/commit/?id=e03bcc5ee9b0a4db6456592c43134d473160c735 http://cgit.freedesktop.org/libreoffice/libs- core/commit/?id=f30f842206ac113ae198e6faed9b882075b25c01 B. -- \ Katarina Machalkova \\\__o LibO

[Libreoffice] [REVIEW] fdo#38457: Crash in DataPilot on moving the fields

2011-06-27 Thread Katarina Machalkova
x27;s baby. Consequently, some further code cleanup could be needed (i.e. nCollAdd param can be completely removed from lcl_FillOldFields() ), but that's more a material for master branch hB. -- \ Katarina Machalkova \\\__o

Re: [Libreoffice] [REVIEW] [PUSHED] fdo#38457: Crash in DataPilot on moving the fields

2011-06-30 Thread Katarina Machalkova
row3, col2. It used to crash on field move before, doesn't crash anymore now. B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a digitally signed message part.

Re: [Libreoffice] [REVIEW] [PUSHED] patch for fdo#36963: name box always select cell on first sheet

2011-06-30 Thread Katarina Machalkova
ith current table number as a fallback for the parser if no table is > specified. > The parser already expected the current position as input but we did not > initialize it correctly. Makes lotta sense, signed-off & pushed B. -- \ Katarina Machalkova

Re: [Libreoffice] [PATCH] fix for fdo#30800: Option to display calc gridlines on colored cells

2011-06-30 Thread Katarina Machalkova
> Hi, > > this is a patch to fix fdo#30800. I'm taking this one for review ... Stay tuned :) B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a digita

Re: [Libreoffice] [PATCH] fix for fdo#30800: Option to display calc gridlines on colored cells

2011-07-04 Thread Katarina Machalkova
e cells filled by some colour. Something along "Show always on top" or "Show in the foreground" line would imao describe its function much better ... Consequently, the option name would become GridOnTop, or GridInForeground, but that's just nitpicking ...

Re: [Libreoffice] [PATCH] fix for fdo#30800: Option to display calc gridlines on colored cells

2011-07-06 Thread Katarina Machalkova
Hey there, > > Also, before I really push the patch -- may I suggest some change to the > > wording being used? > This had been discussed at some point (actually I did prefer "on top" as > you see in the implementation). But comments showed that "on top" or "in > foreground" is not a much better

Re: [Libreoffice] [REVIEW] [PUSHED] patch for fdo#38380: update local range names

2011-07-06 Thread Katarina Machalkova
On Thursday, June 30, 2011 06:20:00 Markus Mohrhard wrote: > Hello, > > I would like to get this patch into 3.4. I pushed a similar patch to > master( master and 3-4 diverged in this area a bit): > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=cacc32f86fa18cb8262 > f5597b381c099117a3344

Re: [Libreoffice] [REVIEW] [PUSHED] patch for fdo#38963: crash in number format dialog

2011-07-08 Thread Katarina Machalkova
iewed & pushed. Thx (for all the fish) hB. -- \\\\\ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a digitally signed message part. ___

Re: [Libreoffice] Review Request: fdo#39023 for 3.4.* branch

2011-07-19 Thread Katarina Machalkova
mula(s) would not be imported correctly in > > builds from 3.4 branches. +1 Need 1 more review B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature

Re: [Libreoffice] Help regarding build from source

2011-02-21 Thread Katarina Machalkova
Hey, > I'm a computer science student and want to get into the libre office > development. I went on to IRC # libre office channel for sometime and got > help regarding the git repository cloning and have fetched the source code. Welcome on board! :-) > I already have Libreoffice installed on my

Re: [Libreoffice] [PATCH] conditional formatting with an unlimited number of rules

2011-04-05 Thread Katarina Machalkova
g into it. Please stay tuned B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a digitally signed message part. ___ Libre

Re: [Libreoffice] [PATCH] conditional formatting with an unlimited number of rules

2011-04-06 Thread Katarina Machalkova
ain, thanks a lot for the patch and keep up good work. Should you have any questions, please don't hesitate to poke any of Calc hackers (me, kohei, muthusuba etc.) on IRC B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ &

Re: [Libreoffice] [PATCH] conditional formatting with an unlimited number of rules

2011-04-11 Thread Katarina Machalkova
On Monday, April 11, 2011 01:09:00 Robert Dargaud wrote: > Hi Katarina & Christoph (& All), > > I have improved code like you suggest. > Lovely :) Before I push the improved code to git repo, can you please confirm that you're submitting this patch under LGPLv3+/MPL dual license? Thanks B. ___

Re: [Libreoffice] [PUSHED] Easy Hack completed - All bogus comments removed

2011-04-22 Thread Katarina Machalkova
e big one from bugzilla). Keep up good work. B. -- \\\\\ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a digitally signed message part. ___

Re: [Libreoffice] [PATCH] Initial steps to support extras - download

2011-04-22 Thread Katarina Machalkova
Hey, > Please review the attached stuffs. I would like to add it to master and > libreoffice-3-4. Not affecting LibreOffice. It adds support to download > extra stuffs. Didn't you forget to actually attach something? :) ;) B. ___ LibreOffice mailing li

Re: [Libreoffice] [PATCH] Remove SV_DECL_REF macro

2011-04-27 Thread Katarina Machalkova
Pushed, thanks B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffice mai

Re: [Libreoffice] [PATCH][PUSHED] Remove SV_DECL_REF macro

2011-04-27 Thread Katarina Machalkova
... really pushed, I mean :) B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffic

Re: [Libreoffice] [PATCH][PUSHED] Remove deprecated List container in FontCollection

2011-04-27 Thread Katarina Machalkova
Looks good, thanks. Pushed B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffic

Re: [Libreoffice] [PATCH][PUSHED] Remove List from ZoomList class

2011-04-28 Thread Katarina Machalkova
Pushed, thanks B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffice mai

Re: [Libreoffice] [PATCH][PUSHED] Remove deprecated List container

2011-04-28 Thread Katarina Machalkova
> They all related to the same files, try to apply them in the same order, > thanks All pushed, thanks. Good work, esp. replacing home-grown Dictionary struct with std::map, which is much more appropriate in this case. B. -- \ Katarina Machalkova

Re: [Libreoffice] [PATCH][PUSHED] Remove List usage in SdPublishingDlg

2011-04-28 Thread Katarina Machalkova
... pushed also this one ... Thanks! B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a digitally signed message part. ___ Li

Re: [Libreoffice] [PATCH][PUSHED] Remove DECLARE_TABLE( SwRTFCharStyleTbl, SwCharFmt* )

2011-04-28 Thread Katarina Machalkova
Pushed this + the one from the previous mail (removing similar usage of DECLARE_TABLE from rtf filter). Thanks :) B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a

Re: [Libreoffice] [PATCH][PUSHED] Remove DECLARE_TABLE( SwRTFStyleTbl, SwTxtFmtColl* )

2011-04-28 Thread Katarina Machalkova
( ... see below ... ) :) -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffice mai

Re: [Libreoffice] [PATCH][PUSHED] Remove deprecated List container

2011-04-28 Thread Katarina Machalkova
Pushed. Good catch, thanks B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffic

Re: [Libreoffice] [PATCH][PUSHED] Fix cppcheck warnings in components (easy hack)

2011-04-28 Thread Katarina Machalkova
good work! :) B. -- \\\\\ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOf

Re: [Libreoffice] [PATCH] Remove tools/list.hxx include

2011-04-28 Thread Katarina Machalkova
t, but maybe I just lack some information/knowledge/context here ... B. -- \\\\\ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description: This i

Re: [Libreoffice] [PATCH] Remove DECLARE_LIST(DdeServices, DdeService*) [Windows only]

2011-04-28 Thread Katarina Machalkova
Hey Rafael, > Windows only patch, please compile and check that theres no errors, thanks Didn't you actually forget to attach something? :) B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painte

Re: [Libreoffice] [Patch] [PUSHED] Support export of anonymous db data to OOXML

2011-04-29 Thread Katarina Machalkova
e of OOXML. After re-introducing the code, all works again. Pushed the fix to master B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter signature.asc Description

[Libreoffice] [PATCH] Export of docs with images/charts into xlsx (possibly pptx)

2011-05-04 Thread Katarina Machalkova
f module (source/draw/shapeexport2.cxx, XMLShapeExport::ImpExportPresentationAttribute method) Thx B. -- \\\\\ Katarina Machalkova \\\__o LibO developer __\\\'/_ & hedgehog painter diff --git a/oox/source/export/shapes.cxx b/oox/source/exp

Re: [Libreoffice] [PATCH] [PUSHED] Export of docs with images/charts into xlsx (possibly pptx)

2011-05-04 Thread Katarina Machalkova
return sal_True; > } Thanks for review, adjusted the patch according to the above. Pushed then (into master, cherry-picked for 3.4). Fixed one more silly copy&paste error on the way :) B. -- \ Katarina Machalkova \\\_

License statement ...

2012-03-04 Thread Katarina Machalkova
Hullo *, I don't really feel the need to write this, as I haven't changed my mind wrt. licensing my patches since I became un-affiliated with SUSE, but my significant 1/2 says it's necessary, so here we go: All of my past and future contributions to LibreOffice may be licensed under the MPL/LG