[Libreoffice] [PATCH] some cppcheck cleaning in ucb

2011-01-16 Thread Julien Nabet
to know that in this case ?). Julien (LGPLv3+ / MPL) commit 58679f0ace3e80cf5302e1a92c083b0df6b34d2a Author: Julien Nabet Date: Sun Jan 16 12:05:38 2011 +0100 some cppcheck cleaning diff --git a/ucb/source/sorter/sortresult.cxx b/ucb/source/sorter/sortresult.cxx index 44c87c3..c18535d 1

[Libreoffice] [PATCH] Cppcheck cleaning on oox

2011-01-16 Thread Julien Nabet
Hello, Here is a patch for some cppcheck cleaning on oox In the file : oox/source/drawingml/chart/objectformatter.cxx in the line 930, there is this function void EffectFormatter::convertFormatting( PropertySet& /*rPropSet*/, const ModelRef< Shape >& /*rxShapeProp*/, sal_Int32 /*nSeriesIdx*/ )

Re: [Libreoffice] [PUSHED] Re: [Patch] Cppcheck cleaning on dbaccess

2011-01-16 Thread Julien Nabet
Le 15/01/2011 18:16, Caolán McNamara a écrit : On Sat, 2011-01-15 at 00:03 +0100, Julien Nabet wrote: Question : In the last "git-updated" cppcheck I use, i found this in core part of dbaccess : [./api/query.cxx:310]: (error) instance of "OAutoActionReset" object d

Re: [Libreoffice] [PUSHED, partial] Re: [PATCH] some cppcheck cleaning in ucb

2011-01-17 Thread Julien Nabet
Le 17/01/2011 13:16, Caolán McNamara a écrit : On Sun, 2011-01-16 at 12:07 +0100, Julien Nabet wrote: Hello, Here is a patch for some cppcheck cleaning in ucb Compiling was ok Pushed the first part. For the second one, that one in gio is a false positive, it's only compiled

Re: [Libreoffice] [PUSHED, partial] Re: [PATCH] some cppcheck cleaning in ucb

2011-01-17 Thread Julien Nabet
Le 17/01/2011 22:15, Caolán McNamara a écrit : On Mon, 2011-01-17 at 21:57 +0100, Julien Nabet wrote: Ok. And to respond to Jesse Adelman, there is now the tracker 2479 on cppcheck for this. Oops I stepped on your toes there. I was also logging the test-case as http://sourceforge.net

[Libreoffice] Compilation failed in sw

2011-01-18 Thread Julien Nabet
Hello, Here what I get after a git update, an autogen.sh + rm -rf unxlng* in sw when I try to build on my Debian (testing updated) Compiling: sw/source/core/doc/docsort.cxx /home/maryline/libreoffice-source/libo/clone/writer/sw/source/core/doc/docsort.cxx: In member function 'virtual double S

[Libreoffice] 2 questions

2011-01-20 Thread Julien Nabet
Hello, I' ve got these 2 questions : 1) After a make, make dev-install. If I found a problem with LO, can I just do this : - source Linux... - go to the module I suppose there's the pb - make the change - build && deliver - make dev-install ? Or must I : - remove the directory of the install -

[Libreoffice] dev-install fail for branch feature/gnumake2.1

2011-01-22 Thread Julien Nabet
Hello, After compiling the usual way (so without the USE_GMAKE set to 1), I've got this error with dev-install : ... languages en-US ... ... analyzing files ... ERROR: The following files could not be found: ERROR: File not found: svlen-US.res ... cleaning the output tree ... ... removing directo

Re: [Libreoffice] dev-install fail for branch feature/gnumake2.1

2011-01-23 Thread Julien Nabet
Hello, I use no arguments so my autogen.last is empty. Julien. Le 22/01/2011 21:38, Norbert Thiebaud a écrit : On Sat, Jan 22, 2011 at 2:19 PM, Julien Nabet wrote: Hello, After compiling the usual way (so without the USE_GMAKE set to 1), I've got this error with dev-in

[Libreoffice] compilation fail for branch feature/gnumake2.1

2011-01-25 Thread Julien Nabet
Hello, I made a make clean yesterday evening. I "git updated" even today followed with an autogen.sh and the compilation fails with this : build -- version: 275224 = Building module libwpd = Entering /home/maryline/gnumakelibreoffice/libo/libwpd dmake: Error: -- `.

[Libreoffice] [PATCH] some cppcheck cleaning in basctl

2011-01-26 Thread Julien Nabet
Hello, Here is a patch for some cppcheck cleaning in basctl Compiling was ok My git account is now created but I don't know what to do next to push my commit. If someone could help me, ideally i need a quick tutorial step by step. I do this : ssh serval2...@git.freedesktop.org but I don't know

Re: [Libreoffice] compilation fail for branch feature/gnumake2.1

2011-01-27 Thread Julien Nabet
Le 27/01/2011 07:07, Norbert Thiebaud a écrit : On Tue, Jan 25, 2011 at 3:51 PM, Julien Nabet wrote: Hello, I made a make clean yesterday evening. I "git updated" even today followed with an autogen.sh and the compilation fails with this : build -- versi

[Libreoffice] Compilation failed in vcl module (warning treated as errors)

2011-05-10 Thread Julien Nabet
Hello, I get this : Compiling: vcl/source/gdi/gdimtf.cxx /home/maryline/compile-libreoffice/libo/clone/libs-gui/vcl/source/gdi/gdimtf.cxx:296:13: error: prototype for 'MetaAction* GDIMetaFile::ReplaceAction(MetaAction*, size_t)' does not match any in class 'GDIMetaFile' ../../inc/vcl/gdimtf.hx

[Libreoffice] Cppcheck Same expression on both sides of '<'

2011-05-16 Thread Julien Nabet
Hello, Here a line I get in cppcheck (updated today) : [source/core/layout/flycnt.cxx:1194] -> [source/core/layout/flycnt.cxx:1194]: (style) Same expression on both sides of '<'. I checked the file git history, it's there since the beginning. while ( pDownFrm && ( ( nDown.nMai

[Libreoffice] Impossible to launch Presentation and Database in debug mode on Debian x86

2011-05-16 Thread Julien Nabet
Hello, I compiled in debug mode and I can launch some modules and not others. When I launch soffice, i get this : Error: not initialized properly From File /home/maryline/compile-libreoffice/libo/comphelper/source/misc/componentmodule.cxx at Line 130 Error: ComponentContext::getContextValueBy

Re: [Libreoffice] Impossible to launch Presentation and Database in debug mode on Debian x86

2011-05-16 Thread Julien Nabet
Le 16/05/2011 20:52, Julien Nabet a écrit : Hello, I compiled in debug mode and I can launch some modules and not others. When I launch soffice, i get this : Error: not initialized properly From File /home/maryline/compile-libreoffice/libo/comphelper/source/misc/componentmodule.cxx at Line

Re: [Libreoffice] Cppcheck Same expression on both sides of '<'

2011-05-17 Thread Julien Nabet
Le 17/05/2011 15:04, Michael Meeks a écrit : ... nDownLst< nDownLst So - this is the guy. sal_Bool operator<( const SwDistance& rTwo ) { return nMain< rTwo.nMain || ( So - we end up with: that equating to: nDownLst.nSub&& nDownLst.nSub&& nDownLst.n

Re: [Libreoffice] Variable 'bFreePixmap' is not assigned a value in vcl/unx/source/gdi/salbmp.cxx

2011-05-19 Thread Julien Nabet
Le 19/05/2011 12:42, Michael Meeks a écrit : On Sun, 2011-05-08 at 15:09 +0200, Julien Nabet wrote: I found this with cppcheck : [vcl/unx/source/gdi/salbmp.cxx:795]: (style) Variable 'bFreePixmap' is not assigned a value Ho hum - I beg to differ: bool bFreePixm

[Libreoffice] Bug fdo36158 - EasyHack: UI:Find&Replace dialog "Notes" instead of "Comments"

2011-05-21 Thread Julien Nabet
Hello, 1) I found that "Notes" was in svx/source/dialog/srchdlg.src, the text of "CheckBox CB_NOTES" (line 310) So, it could be changed there except that CB_NOTES should be changed in CB_COMMENTS With Opengrok, I searched all the CB_NOTES, there are some in svx, 1 in testautomation and 1 in he

Re: [Libreoffice] Bug fdo36158 - EasyHack: UI:Find&Replace dialog "Notes" instead of "Comments"

2011-05-22 Thread Julien Nabet
Le 22/05/2011 07:35, Andras Timar a écrit : Hi, 2011/5/22 Julien Nabet: 2) The pb is CB_NOTES and the translations should be changed in l10n too. a) I don't know how to change CB_NOTES from l10n module (they don't appear in the "dev repository") b) Except French translation,

Re: [Libreoffice] Bug fdo36158 - EasyHack: UI:Find&Replace dialog "Notes" instead of "Comments"

2011-05-22 Thread Julien Nabet
Le 22/05/2011 11:29, Andras Timar a écrit : 2011/5/22 Julien Nabet: I only put a comment for this fdo in the tracker, I didn't change the status : neither at "Assigned" (to whom ?) nor at "Closed" (I don't know when translations will be updated). Assigned: to yo

[Libreoffice] Writer, errors in debug mode

2011-05-22 Thread Julien Nabet
Hello, Here are some errors I have in debug mode. 1) Once LO is opened, when I select Writer to launch it, I have : FcPreMatchSubstititution "Thorndale AMT" bipw=5020 -> "Liberation Serif" bipw=5025 FcPreMatchSubstititution "Albany AMT" bipw=5020 -> "Liberation Sans" bipw=5025 FcPreMatchSubsti

[Libreoffice] Warning in basic/source/runtime/runtime.cxx

2011-05-29 Thread Julien Nabet
Hello, Since the last merging, I've got this : Compiling: basic/source/runtime/runtime.cxx cc1plus: warnings being treated as errors /home/maryline/compile-libreoffice/libo/clone/libs-core/basic/source/runtime/runtime.cxx: In member function 'SbiForStack* SbiRuntime::FindForStackItemForCollecti

Re: [Libreoffice] Warning in basic/source/runtime/runtime.cxx

2011-05-29 Thread Julien Nabet
Le 29/05/2011 14:47, Julien Nabet a écrit : I think pCollection must be tested against NULL but perhaps it needs something else. Of course, if you're ok, I can commit and push on master. I forgot to tell 2 things : - I talked about it in IRC yesterday but if the pb of "undefined

Re: [Libreoffice] smoketest fail, N12_GLOBAL__N_14TestE::test

2011-06-02 Thread Julien Nabet
Hello, I runned the smoketest as Caolán advised me. I've attached the result cause there are some red boxes. I'm going to take a look at it but if someone want to help, welcome ! :-) Julien. smoketestdoc_result.odt Description: application/vnd.oasis.opendocument.text ___

[Libreoffice] Lotuswordpro : Found duplicate if expressions in xfbookmarkref.cxx:75:85

2011-06-04 Thread Julien Nabet
Hello, Here is the part of code : if( m_eRefType == enumXFBookmarkNone ) return; else if( m_eRefType == enumXFBookmarkPage )// <-- Line 75 { pAttrList->AddAttribute( A2OUSTR("text:reference-format"), A2OUSTR("page") ); pAttrList->AddAttribute( A2OUSTR

[Libreoffice] Master fails to build in vcl with --enable-kde4 flag

2011-06-05 Thread Julien Nabet
Hello, Perhaps try to delete the repertory /home/thuswa/work/tmp/libo/solver/350/unxlngi6.pro then compile. If it doesn't work, clean all the unxlng* with a make clean then recompile the whole thing. Julien. ___ LibreOffice mailing list LibreOffice@l

Re: [Libreoffice] Lotuswordpro : Found duplicate if expressions in xfbookmarkref.cxx:75:85

2011-06-08 Thread Julien Nabet
Le 07/06/2011 11:18, Caolán McNamara a écrit : On Sun, 2011-06-05 at 00:59 +0200, Julien Nabet wrote: Hello, Just a guess, perhaps it needs this patch : ... Someone to comment ? If it's ok, I can, of course, commit this and push it in master. Your patch seems sane to me, I reckon you s

[Libreoffice] warning: the use of `tmpnam' is dangerous, better use `mkstemp'

2011-06-09 Thread Julien Nabet
Hello, I had this warning by compiling hwpfilter during some cppcheck cleaning. I knew nothing about it so I read some links given by Google. It seems mkstemp is safer since it permits "to avoid race conditions". In the Unix man of tmpnam, we can read this : " BUGS Never use this functi

[Libreoffice] Fwd: warning: the use of `tmpnam' is dangerous, better use `mkstemp'

2011-06-11 Thread Julien Nabet
r Unix/Linux/BSD and Mac only part, mkstemp/mktemp should be used (to avoid overhead) So tmpnam shouldn't be used at all. Is this ok ? Julien. Message original Sujet: warning: the use of `tmpnam' is dangerous, better use `mkstemp' Date : Thu, 09 Jun 2011 23

[Libreoffice] Question about sal/qa/osl/process/osl_Thread.cxx

2011-06-18 Thread Julien Nabet
Hello, Last "git version" of cppcheck says this : [sal/qa/osl/process/osl_Thread.cxx:1099]: (warning) Redundant assignment of "sPrioStr" in switch Here is the switch : switch (_aPriority) { case osl_Thread_PriorityHighest: sPri

Re: [Libreoffice] [Patch] [Pushed] Question about sal/qa/osl/process/osl_Thread.cxx

2011-06-18 Thread Julien Nabet
Le 18/06/2011 13:12, Norbert Thiebaud a écrit : On Sat, Jun 18, 2011 at 5:39 AM, Julien Nabet wrote: Hello, Last "git version" of cppcheck says this : [sal/qa/osl/process/osl_Thread.cxx:1099]: (warning) Redundant assignment of "sPrioStr" in switch Here is the switch :

[Libreoffice] Debug compilation fails in sal module

2011-06-19 Thread Julien Nabet
Hello, I recreated from scratch my local repository and here is what I get : -- - start unit test #2 on library ../../../unxlngi6/lib/libosl_process.so -- : && LD_LIBRARY_PATH=/hom

Re: [Libreoffice] Debug compilation fails in sal module

2011-06-20 Thread Julien Nabet
Le 20/06/2011 15:19, Caolán McNamara a écrit : On Mon, 2011-06-20 at 10:08 +0100, serv serva wrote: It happens each time. I don't know what element has triggered this. I tried gdb but when I runned it, it makes the first which is ok. I don't know how to go to this specific test. Could you see

Re: [Libreoffice] Debug compilation fails in sal module

2011-06-21 Thread Julien Nabet
Le 20/06/2011 21:42, Julien Nabet a écrit : Le 20/06/2011 21:32, Julien Nabet a écrit : Le 20/06/2011 15:19, Caolán McNamara a écrit : On Mon, 2011-06-20 at 10:08 +0100, serv serva wrote: It happens each time. I don't know what element has triggered this. I tried gdb but when I runned i

Re: [Libreoffice] [SOLVED] Debug-mode getline-using sal unittest crashes, triggered by _GLIBCXX_DEBUG

2011-06-24 Thread Julien Nabet
Le 24/06/2011 14:19, Caolán McNamara a écrit : On Thu, 2011-06-23 at 19:57 +0100, serv serva wrote: Your theory was right, I commented out all that concerns _GLIBCXX_DEBUG in : - sal/inc/unxgcc.mk - sal/gbuild/platform/unxgcc.mk Then remove sal/unxlng* and build again. Everything is ok. Excell

Re: [Libreoffice] [SOLVED] Debug-mode getline-using sal unittest crashes, triggered by _GLIBCXX_DEBUG

2011-06-27 Thread Julien Nabet
Le 27/06/2011 16:57, Caolán McNamara a écrit : On Fri, 2011-06-24 at 20:02 +0200, Julien Nabet wrote: But when i use the test file, nothing as you can see below : $ g++ -D_GLIBCXX_DEBUG attachment.cxx $ echo hello world | ./a.out Line is: "hello world" Hmm, hard to track down a re

Re: [Libreoffice] Debug compilation fails in sal module

2011-06-27 Thread Julien Nabet
Le 27/06/2011 22:06, Arnaud Versini a écrit : Hello, I've the same problem with this autogen on Ubuntu 10.04 64 too: --without-junit --enable-debug --enable-symbols We're 3 (3 "declared" :-) ) but for the moment it seems to concern only Debian/Ubuntu (32 or 64 bits). Have other Linux or BSD d

Re: [Libreoffice] Debug compilation fails in sal module

2011-06-27 Thread Julien Nabet
Le 27/06/2011 22:47, Markus Mohrhard a écrit : Hello Julien, Error: File /home/maryline/compile-libreoffice/libo/clone/ure/sal/cpprt/operators_new_delete.cxx, Line 96: operator delete mismatch /usr/include/c++/4.6/debug/safe_iterator.h:193:error: attempt to dereference

Re: [Libreoffice] Debug compilation fails in sal module

2011-06-27 Thread Julien Nabet
Hello, With the help of moggi in IRC, i got this : Reading symbols from /home/maryline/compile-libreoffice/libo/clone/ure/sal/unxlngi6/bin/cppunittester...done. (gdb) run Starting program: /home/maryline/compile-libreoffice/libo/clone/ure/sal/unxlngi6/bin/cppunittester ../../../unxlngi6/lib/

Re: [Libreoffice] [SOLVED] Debug-mode getline-using sal unittest crashes, triggered by _GLIBCXX_DEBUG

2011-06-28 Thread Julien Nabet
Le 28/06/2011 16:18, Nigel Hawkins a écrit : On Tue, 2011-06-28 at 13:45 +0100, Caolán McNamara wrote: So, for a hackaround, I guess we might be looking at a mismatch between how the internal cppunit is built and the outside world, so to test that theory, try this patch to the internal cppunit m

Re: [Libreoffice] [SOLVED] Debug-mode getline-using sal unittest crashes, triggered by _GLIBCXX_DEBUG

2011-06-28 Thread Julien Nabet
Le 28/06/2011 14:45, Caolán McNamara a écrit : ... I reckon this is basically a libstdc++ bug, so we're just looking for either a reproducer we can submit a bug for, and/or a hackaround for ourselves in the interim. ... Could it be a cppunit bug ? I think about this one : http://sourceforge.ne

Re: [Libreoffice] [SOLVED] Debug-mode getline-using sal unittest crashes, triggered by _GLIBCXX_DEBUG

2011-06-28 Thread Julien Nabet
Hello, I tried the patch attached. In fact, I remarked by reading some forums (sorry i don't remember the specific link I read) that getline could need some extra precaution. I don't know if this patch is correct but there's no more memory error. However there's now an assertion failure becau

Re: [Libreoffice] [SOLVED] Debug-mode getline-using sal unittest crashes, triggered by _GLIBCXX_DEBUG

2011-06-29 Thread Julien Nabet
Le 29/06/2011 08:44, Julien Nabet a écrit : Hello, I tried the patch attached. In fact, I remarked by reading some forums (sorry i don't remember the specific link I read) that getline could need some extra precaution. I don't know if this patch is correct but there's no mo

Re: [Libreoffice] [REVIEW] Debug-mode getline-using sal unittest crashes, triggered by _GLIBCXX_DEBUG

2011-07-01 Thread Julien Nabet
Le 30/06/2011 14:26, Nigel Hawkins a écrit : On Wed, 2011-06-29 at 23:26 +0200, Julien Nabet wrote: diff --git a/sal/qa/osl/process/osl_process.cxx b/sal/qa/osl/process/osl_process.cxx index 2535c4c..8695d79 100644 --- a/sal/qa/osl/process/osl_process.cxx +++ b/sal/qa/osl/process

[Libreoffice] debug compile failed on automation module

2011-07-30 Thread Julien Nabet
Hello, After having recreate my local repository. i've got a pb in automation and the rm -rf followed by build doesn't work (master branch on Debian x86 32 bits) Here is what I get : Making:testtool ../unxlngi6/obj/testbasi.o: In function `SbxBase::SetFlag(unsigned short)': /home/maryline/c

[Libreoffice] Vcl module compilation failed

2011-08-02 Thread Julien Nabet
Hello, Here is what I get if I try to compile vcl : maryline@maryline:~/compile-libreoffice/libo/vcl$ rm -rf unxlngi6/ && make -r CxxObject/vcl/source/salmain/salmain.o is linked in by Library/libvcllo.so StaticLibrary/libvclmain.a /home/maryline/compile-libreoffice/libo/solenv/gbuild/extension

Re: [Libreoffice] Vcl module compilation failed

2011-08-03 Thread Julien Nabet
Le 03/08/2011 14:10, Matúš Kukan a écrit : On 3 August 2011 14:03, serv serva wrote: De: Caolán McNamara Objet: Re: [Libreoffice] Vcl module compilation failed À: "Julien Nabet" Cc: libreoffice@lists.freedesktop.org Date: Mercredi 3 août 2011, 11h40 On Wed, 2011-08-03 at 08:06 +02

[Libreoffice] va_start without va_end

2011-08-03 Thread Julien Nabet
Hello, In svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx, I noticed the use of va_start without va_end. I read it could create undefined behaviour, so I propose this simple patch. I propose this patch : diff --git a/svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx index

Re: [Libreoffice] va_start without va_end

2011-08-04 Thread Julien Nabet
Le 04/08/2011 10:33, Caolán McNamara a écrit : On Wed, 2011-08-03 at 23:56 +0200, Julien Nabet wrote: Hello, In svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx, I noticed the use of va_start without va_end. I read it could create undefined behaviour, so I propose this simple patch

[Libreoffice] make check fails.

2011-08-04 Thread Julien Nabet
Hello, I just had this (I'm certainly not the only one). I'm gonna try to debug but I thought it might interest users who compile with less verbose information. LOG> Execute: removeResetListener() LOG> starting required method: reset() LOG> Testing removeResetListener ... com.sun.star.lang.Dis

[Libreoffice] cppcheck detects division by 0 in sw/source/ui/vba/vbarows.cxx

2011-08-13 Thread Julien Nabet
Hello, cppcheck detects division by 0 in sw/source/ui/vba/vbarows.cxx, line 266 I discussed this with Norbert on IRC, here what we propose to add before this line : if ((nNewWidth <= 0) || (nWidth <= 0)) { OSL_ASSERT(!((nNewWidth <= 0) || (nWidth <= 0))); return; } (we supposed "indent

Re: [Libreoffice] java LO part with Eclipse

2011-08-13 Thread Julien Nabet
Le 13/08/2011 22:29, Jenei Gábor a écrit : well,I've never tried, you should make a new clean project and then add the module folder to the build path, also you have to set it in debug settings, but I advise you to simply do a make -sr debug=true dbglevel=2 in the module folder, it's easier tha

[Libreoffice] [PATCH] +question RTL_CONSTASCII_USTRINGPARAM for calc_core_tools

2010-11-11 Thread Julien Nabet
Hello, Here's a patch for calc/sc/source/core/tools I compiled it and it's ok. Hope it's ok ! How can we replace createFromAscii in this kind of line : OUString::createFromAscii(aPropNames[i]) Is it possible with another trick than RTL_CONSTASCII_USTRINGPARAM ? Julien. (LGPLv3+ / MPL) calc_

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for calc_filter

2010-11-11 Thread Julien Nabet
Hello, Here's a patch for calc/sc/source/filter Julien. (LGPLv3+ / MPL) calc_filter.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for calc_unoobj

2010-11-11 Thread Julien Nabet
Hello, Here's a patch for calc/sc/source/ui/unoobj Julien. (LGPLv3+ / MPL) calc_unoobj.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for calc_ui

2010-11-11 Thread Julien Nabet
Hello, Here's a patch for calc/sc/source/ui (except unoobj previously sent). Julien. (LGPLv3+ / MPL) calc_ui.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/lis

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for calc (datefunc, analysis and solver)

2010-11-12 Thread Julien Nabet
Hello, Here's a patch for calc I think it's the last one for "calc" since i haven't seen other "createFromAscii" to remove which concerned litterals. In datefunc, i tried to use the syntax : rtl::OUString foo(RTL_CONSTASCII_STRINGPARAM("foo")); -OUString aImpl = OUString::createF

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for writer_starmath

2010-11-12 Thread Julien Nabet
Hello, Here's a small patch as there was only 1 file in the starmath part which needed modifications. Julien. (LGPLv3+ / MPL) diff --git a/starmath/source/smdetect.cxx b/starmath/source/smdetect.cxx index a7404eb..8fe1dbd 100644 --- a/starmath/source/smdetect.cxx +++ b/starmath/source/smdetect

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for writer_sw

2010-11-12 Thread Julien Nabet
Hello, Here's a less small patch for the sw part. Julien. (LGPLv3+ / MPL) writer_sw.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for impress

2010-11-12 Thread Julien Nabet
Hello, Here's again a small patch for the last changes to do that I've seen in Impress. Julien. (LGPLv3+ / MPL) impress.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.or

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity

2010-11-13 Thread Julien Nabet
Hello, Here's again a small patch for the last changes to do that I've seen in libs-core/connectivity Julien. (LGPLv3+ / MPL) libs_core_connectivity.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.or

[Libreoffice] [PATCH] + question RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/source/drivers/adabas/

2010-11-14 Thread Julien Nabet
Hello, Here's a patch (LGPLv3+ / MPL) for libs-core/connectivity/source/drivers/adabas/ Concerning the file connectivity/source/drivers/adabas/Buser.cxx, in the function : ::rtl::OUString OAdabasUser::getPrivilegeString(sal_Int32 nRights) const from the file : connectivity/source/drivers/ad

[Libreoffice] Question about cppcheck "unused private"

2011-02-12 Thread Julien Nabet
Hello With the last git version of cppcheck, I've got in the master branch writer/sw/source/ui/dbui this : [./dbmgr.cxx:222]: (style) Unused private function 'SwConnectionDisposedListener_Impl::disposing' I tried to comment the following lines : - (222) virtual void SAL_CALL disposing( const

[Libreoffice] [PATCH] Remove Xine

2011-02-12 Thread Julien Nabet
n. commit 9073e930ebd8b2868e654e159d22fe1d67770aab Author: Julien Nabet Date: Sat Feb 12 18:01:06 2011 +0100 Remove xine diff --git a/avmedia/prj/build.lst b/avmedia/prj/build.lst index 9e3f9ea..025e850 100644 --- a/avmedia/prj/build.lst +++ b/avmedia/prj/build.lst @@ -6,7 +6,6 @@ av avmedia\sou

Re: [Libreoffice] [PATCH] Remove Xine

2011-02-13 Thread Julien Nabet
Le 13/02/2011 22:19, Caolán McNamara a écrit : On Sat, 2011-02-12 at 18:07 +0100, Julien Nabet wrote: Hello, Here is a patch to remove xine. I think that was an Easy Hack, can you remove it from that list and move it to the "completed" one, stick you name on it ther

[Libreoffice] [REVIEW] fdo#32552 (alt key opens "File"-menu)

2011-02-15 Thread Julien Nabet
PLv3+ / MPL) commit 92ec3bb031d94cfc8658ee7e5136e15acafa0987 Author: Julien Nabet Date: Tue Feb 15 22:05:49 2011 +0100 fdo 32552 diff --git a/vcl/unx/source/window/salframe.cxx b/vcl/unx/source/window/salframe.cxx index f52f780..56b4b54 100644 --- a/vcl/unx/source/window/salframe.cxx +++ b/vcl/unx/source

[Libreoffice] Need translation and to define the expected behaviour for fdo#34072

2011-02-16 Thread Julien Nabet
Hello, This pb is about "Protected cells can not be modified" using Replace on unprotected cell. I try to understand the process and I found that this error message comes from : sc/source/ui/view/viewfun2.cxx in the function SearchAndReplace. It could be helpful to have the english translation

[Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc

2011-02-24 Thread Julien Nabet
Hello, Here is the first try with this easyhack. Could you tell me 1) if my patch is ok ? (I can push it myself) 2) must we remove all the "rtl::" stuff ? Julien. commit 9c2bd745cde4a6d635b0f0083d40f702ce1e66cc Author: Julien Nabet Date: Thu Feb 24 15:22:42 2011 +0100 Rem

[Libreoffice] Compilation failed in libs-gui/toolkit

2011-02-27 Thread Julien Nabet
Hello, I've got a compilation error in libs-gui/toolkit. Entering /home/maryline/compile-libreoffice/libo/toolkit/uiconfig/layout dmake: Warning: -- Found file corresponding to virtual target [message-box.xml]. dmake: Warning: -- Found file corresponding to virtual target [tab-dialog.xml].

[Libreoffice] Remove "using namespace ::rtl"

2011-03-03 Thread Julien Nabet
Hello, I finished the removing of "using namespace ::rtl" except in binfilters. (there were no compilation pb with my Linux env, hope it's the case with Windows and Mac envs). Even if binfilters is going to be "extracted" from LO, doesn't it worth to purge "using namespace ::rtl" from it (I th

[Libreoffice] Question about using namespace ::com::sun::star::uno

2011-03-04 Thread Julien Nabet
Hello, I just finished the removing of using reference ::rtl:: in each directory (binfilters included). I'd like to be sure of what has to be done for "::com::sun::star::uno" part 1) remove "using namespace ::com::sun::star::uno" ok 2) replace "Reference" by "uno::Reference" ok 3) But what abou

Re: [Libreoffice] Remove "using namespace ::rtl"

2011-03-05 Thread Julien Nabet
Le 05/03/2011 22:17, Pierre-André Jacquod a écrit : Hello, Even if binfilters is going to be "extracted" from LO, doesn't it worth I am doing, this, leting it be only an "import" filter. to purge "using namespace ::rtl" from it (I think about the people I think that when

[Libreoffice] Compilation failed in sd part.

2011-03-06 Thread Julien Nabet
Hello, After this command today : make clean && ./autogen.sh && make I've got an error in sd part. After building the specific part, I've got this : Entering /home/maryline/compile-libreoffice/libo/sd/util Making:libsdli.so ../unxlngi6.pro/slo/outlview.o: In function `sd::OutlineView::Prepa

Re: [Libreoffice] Question about using namespace ::com::sun::star::uno

2011-03-06 Thread Julien Nabet
Le 04/03/2011 23:48, Julien Nabet a écrit : Hello, I just finished the removing of using reference ::rtl:: in each directory (binfilters included). I'd like to be sure of what has to be done for "::com::sun::star::uno" part 1) remove "using namespace ::com::sun::star

Re: [Libreoffice] Question about using namespace ::com::sun::star::uno

2011-03-07 Thread Julien Nabet
Le 07/03/2011 16:45, Kohei Yoshida a écrit : On Sun, 2011-03-06 at 23:14 +0100, Julien Nabet wrote: Le 04/03/2011 23:48, Julien Nabet a écrit : Hello, I just finished the removing of using reference ::rtl:: in each directory (binfilters included). I'd like to be sure of what h

[Libreoffice] Compiled still failed in instsetoo_native after compiling a brand new local repository

2011-03-09 Thread Julien Nabet
Hello, After having removed all my local repository, refetch (from master) and rebuild the whole thing, i still got this in instsetoo_native : Package format: archive msi templatepath: /home/maryline/compile-libreoffice/libo/instsetoo_native/util/../unxlngi6.pro/misc/openoffice/msi_templates

[Libreoffice] Review needed for Python part patch

2011-03-12 Thread Julien Nabet
) original line (885) " Julien. commit 2b065784e0b8f4790e43ba9ce1460da46c5baa4b Author: Julien Nabet Date: Sat Mar 12 11:21:45 2011 +0100 Fix pychecker warning/error diff --git a/scripting/source/pyprov/mailmerge.py b/scripting/source/pyprov/mailmerge.py index 8fd697f..1d76e6d 100644

Re: [Libreoffice] Review needed for Python part patch

2011-03-12 Thread Julien Nabet
Le 12/03/2011 14:36, Christian Lohmaier a écrit : Hi Julien, *, On Sat, Mar 12, 2011 at 11:29 AM, Julien Nabet wrote: Here is a patch for fixing warning/error pychecker in the .py files of libs-core/scripting/source/pyprov Could anybody tell me if this is ok (and i can push it myself) or

[Libreoffice] Rewiew needed for pythonscript.py patch (new try)

2011-03-12 Thread Julien Nabet
Hello, Here is a new try for fixing warning/error pychecker in the .py files of libs-core/scripting/source/pyprov Could anybody tell me if this is ok (and i can push it myself) or not ? This time I used this to check there is no tabs and spaces mixed. python -tt ppythonscript.py This one has on

Re: [Libreoffice] Rewiew needed for pythonscript.py patch (new try)

2011-03-12 Thread Julien Nabet
Le 12/03/2011 23:38, Christian Lohmaier a écrit : On Sat, Mar 12, 2011 at 11:37 PM, Julien Nabet wrote: Here is a new try for fixing warning/error pychecker in the .py files of libs-core/scripting/source/pyprov Could anybody tell me if this is ok (and i can push it myself) or not

Re: [Libreoffice] [Pushed] Rewiew needed for pythonscript.py patch (new try)

2011-03-17 Thread Julien Nabet
Le 17/03/2011 11:41, Jan Holesovsky a écrit : Hi Julien, On 2011-03-14 at 13:20 +, Caolán McNamara wrote: I added this because of a warning (error) with pychecker. On the contrary of the other blocks, the variable uri "wasn't" declared and initialized whereas it was used in this block.

[Libreoffice] Compiled failed in sw

2011-03-21 Thread Julien Nabet
Hello, I replaced my repository with a fresh one. With no arguments passed at autogen.sh, I've got this : /home/maryline/compile-libreoffice/libo/sw/source/filter/ww8/docxattributeoutput.cxx: In member function ‘virtual void DocxAttributeOutput::SectionLineNumbering(sal_uLong, const SwLineNumb

[Libreoffice] Review needed to try to resurrect "add slide thumbnails to HTML export" part

2011-03-24 Thread Julien Nabet
his patch is ok, i can of course push it. Julien. commit a60dd719453536a559801619f0c5a5af0cfc2701 Author: Julien Nabet Date: Fri Mar 25 00:11:37 2011 +0100 Try to resurrect "add slide thumbnails to HTML export" part diff --git a/sd/source/filter/html/htmlex.cxx b/sd/source/f

Re: [Libreoffice] [Pushed] Review needed to try to resurrect "add slide thumbnails to HTML export" part

2011-03-25 Thread Julien Nabet
Le 25/03/2011 07:37, Michael Meeks a écrit : Hi Julien, On Fri, 2011-03-25 at 00:25 +0100, Julien Nabet wrote: .. I don't know if it's what was expected but i'm sure it needs some reviewing since I added, changed and removed 1 or 2 things from the original patch.

[Libreoffice] Need a little help with the easyhack "Strip include guards in idl files"

2011-03-26 Thread Julien Nabet
Hello, Concerning the easyhack "Strip include guards in idl files", I pushed 2 patches for the directory "ure/udkapi". For the first patch I only used the strip-guards script with just a change to apply for idl + remove of the "includes" block between the 2 final "Find". Then to check it

Re: [Libreoffice] Need a little help with the easyhack "Strip include guards in idl files"

2011-03-27 Thread Julien Nabet
, Christina Roßmanith a écrit : Sorry, Please move my last e-mail to /dev/null...only .idl files were changed Christina Am 27.03.2011 00:20, schrieb Julien Nabet: Hello, Concerning the easyhack "Strip include guards in idl files", I pushed 2 patches for the directory "ure/udkapi&qu

[Libreoffice] Missing NoSuchElementException.idl ?

2011-03-30 Thread Julien Nabet
Hello, Several idl files use NoSuchElementException.idl example the file ure/offapi/com/sun/star/xml/input/XNamespaceMapping.idl has this : #include First I thought it was an unused include but there is this in the file : string getUriByUid( [in] long uid ) raises (com::sun::star:

[Libreoffice] Fwd: Missing NoSuchElementException.idl ?

2011-03-30 Thread Julien Nabet
Oups, forget about this message. The file is in ./ure/udkapi/com/sun/star/container/NoSuchElementException.idl Sorry. Message original Sujet: Missing NoSuchElementException.idl ? Date : Wed, 30 Mar 2011 22:45:28 +0200 De :Julien Nabet Pour : LibreOffice ML Hello

[Libreoffice] compilation scp part failed

2011-04-02 Thread Julien Nabet
Hello, With an empty autogen.lastrun, it compiles ok (make check ok too). With this autogen.lastrun : '--enable-ext-barcode' '--enable-ext-diagram' '--enable-ext-google-docs--enable-ext-hunart' '--enable-ext-lightproof' '--enable-ext-lightproof' '--enable-ext-mysql-connector' '--enable-ext-nlpsol

Re: [Libreoffice] compilation scp part failed, remark

2011-04-02 Thread Julien Nabet
Just a remark. When I investigated about the scp compilation pb, I found this kind of things in the scp2/inc/macros.inc #define STD_FONTUNX_FILE(id,name,fontname) \ File id \ TXT_FILE_BODY; \ Dir = gid_Dir_Fonts_Truetype; \ Styles= (PACKED, FONT_WARN_IF_EXIS

[Libreoffice] Autogen.sh pb with junit

2011-04-02 Thread Julien Nabet
Hello, Since 2 days, i've been got this pb when I call ./autogen.sh : checking for JUnit 4... no configure: error: cannot find JUnit 4 jar; please install one in the default location (/usr/share/java), specify its pathname via --with-junit=..., or disable it via --without-junit On my config, the

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-03 Thread Julien Nabet
Le 04/04/2011 15:00, Jonathan Aquilina a écrit : On 03/04/2011 14:57, Julien wrote: Hello, Maybe, we can help. Could you tell us more about your config ? What's the result of this command ? which java Julien. i usually pass --without-junit switch which it tells us we can pass and dont even co

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-03 Thread Julien Nabet
Le 04/04/2011 15:14, Jonathan Aquilina a écrit : On 03/04/2011 15:07, Julien Nabet wrote: Le 04/04/2011 15:00, Jonathan Aquilina a écrit : On 03/04/2011 14:57, Julien wrote: Hello, Maybe, we can help. Could you tell us more about your config ? What's the result of this command ? which

[Libreoffice] Need a little help with the easyhack "Strip include guards in idl files"

2011-04-03 Thread Julien Nabet
Hello, After I finally found a way to change the script for the ure/offapi and its 3700 idl files, I put this task as completed. I saw the lines you mentionned with pcregrep but I didn't know if I had to change these files too and they're in test directories. Thank you for your help and to th

[Libreoffice] About the easyhack "expunge duplicate enumerations in vcl"

2011-04-07 Thread Julien Nabet
Hello, I'd like to work on the easyhack "expunge duplicate enumerations in vcl". By reading the description of this task and by taking a quick look at the quoted files, I understood this but i hope not misunderstood : The file vcl/inc/vcl/fontmanager.hxx must be removed at the end and all its e

[Libreoffice] Compilation failed in slideshow/source/engine

2011-04-07 Thread Julien Nabet
Hello, On a Debian testing x86 32 bits, here is my autogen.lastrun : --enable-ext-barcode --enable-ext-diagram --enable-ext-google-docs--enable-ext-hunart --enable-ext-lightproof --enable-ext-lightproof --enable-ext-mysql-connector --enable-ext-nlpsolver --enable-ext-numbertext --enable-ext-ooobl

[Libreoffice] [REVIEW] Easy hack: expunge duplicate enumerations in vcl

2011-04-10 Thread Julien Nabet
lien. commit 23c62205b008c946f8334dd2dc628fccdf75e46e Author: Julien Nabet Date: Sun Apr 10 22:45:20 2011 +0200 some elements to change for "expunge duplicate enumerations in vcl" diff --git a/padmin/source/fontentry.cxx b/padmin/source/fontentry.cxx index dbaf372..a661379 100

[Libreoffice] Compilation failed with ct2n

2011-04-10 Thread Julien Nabet
Hello, I've got this problem : maryline@maryline:~/compile-libreoffice/libo$ make -r clean && make * * Running the post download checks. * checking build sys

Re: [Libreoffice] Compilation failed with ct2n

2011-04-12 Thread Julien Nabet
Le 10/04/2011 23:42, Julien Nabet a écrit : Hello, I've got this problem : maryline@maryline:~/compile-libreoffice/libo$ make -r clean && make * * Running the post do

<    1   2   3   4   5   6   7   8   9   10   >