[PATCH] Translate german comments in sw/source/filter/ww8/wrtww8.cxx

2013-03-09 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2617 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/2617/1 Translate german comments in sw/source/filter/ww8/wrtww8.cxx Please, only apply this patch if you are a native s

[PATCH] Minor improvements and UX-advice related to fdo#46718 delete...

2013-03-09 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2618 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/2618/1 Minor improvements and UX-advice related to fdo#46718 delete multi style UX advice see: http://lists.freedeskto

[PATCH] fdo#62075 Hierarchical filter hard to find

2013-03-10 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2638 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/2638/1 fdo#62075 Hierarchical filter hard to find See UX-advice http://lists.freedesktop.org/archives/libreoffice-ux-a

[PATCH libreoffice-4-0] fdo#62075 Hierarchical filter hard to find

2013-03-10 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2639 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/2639/1 fdo#62075 Hierarchical filter hard to find See UX-advice http://lists.freedesktop.org/archives/libreoffice-ux-a

[PATCH] Return true or false instead of a 1 or 0 in this function

2013-03-15 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2761 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/2761/1 Return true or false instead of a 1 or 0 in this function Change-Id: I223a342aa9496674714929e0dc78bc53b30273a2 -

[PATCH libreoffice-4-0] fdo#34800 Comments added to footer are placed at the right t...

2013-03-16 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2777 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/2777/1 fdo#34800 Comments added to footer are placed at the right top of the page. I also merged (manually) the changes

[PATCH libreoffice-3-6] fdo#34800 Comments added to footer are placed at the right t...

2013-03-17 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2788 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/2788/1 fdo#34800 Comments added to footer are placed at the right top of the page. I also merged (manually) the changes

[PATCH] resolve fdo#57905 - Autocorrect Options can not be closed us...

2013-03-17 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2809 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/2809/1 resolve fdo#57905 - Autocorrect Options can not be closed using 'Close-X' Change-Id: I0421253d363fbe82a833011d22

[PATCH libreoffice-4-0] resolve fdo#57905 - Autocorrect Options can not be closed us...

2013-03-17 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2810 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/2810/1 resolve fdo#57905 - Autocorrect Options can not be closed using 'Close-X' Change-Id: I0421253d363fbe82a833011d22

[PATCH libreoffice-4-0-2] resolve fdo#57905 - Autocorrect Options can not be closed us...

2013-03-17 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2811 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/2811/1 resolve fdo#57905 - Autocorrect Options can not be closed using 'Close-X' Change-Id: I0421253d363fbe82a833011d22

[PATCH] fdo#60462 - Small errors in the layout margins of the text b...

2013-03-24 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2970 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/2970/1 fdo#60462 - Small errors in the layout margins of the text boxes As you can see on this screenshot https://bugs.

[PATCH libreoffice-4-0-2] fdo#60462 - Small errors in the layout margins of the text b...

2013-03-24 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2971 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/2971/1 fdo#60462 - Small errors in the layout margins of the text boxes As you can see on this screenshot https://bugs.

[PATCH libreoffice-4-0] fdo#60462 - Small errors in the layout margins of the text b...

2013-03-24 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2972 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/2972/1 fdo#60462 - Small errors in the layout margins of the text boxes As you can see on this screenshot https://bugs.

[PATCH libreoffice-3-6-6] fdo#60462 - Small errors in the layout margins of the text b...

2013-03-24 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2973 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/2973/1 fdo#60462 - Small errors in the layout margins of the text boxes As you can see on this screenshot https://bugs.

[PATCH libreoffice-3-6] fdo#60462 - Small errors in the layout margins of the text b...

2013-03-24 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2974 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/2974/1 fdo#60462 - Small errors in the layout margins of the text boxes As you can see on this screenshot https://bugs.

Change in core[master]: delete unused strings

2013-02-01 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1955 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/1955/1 delete unused strings Change-Id: Ic24e0453786d64b8c082c4d7ca4a22b853827d0e --- M fpicker/source/office/OfficeFil

[PATCH] delete double entry (see line 345)

2013-02-02 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1956 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/1956/1 delete double entry (see line 345) Change-Id: I5be1d34ae5de4e9e2b49b97dc161d2ba06204cd5 --- M svx/source/dialog/

[PATCH] fix if statement and translate German OSL_ENSURE

2013-02-02 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1960 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/1960/1 fix if statement and translate German OSL_ENSURE Change-Id: I3eefa563e00e6a4dcb3f1e5726bdf6d27f536624 --- M sw/s

[PATCH] Move close button to most left of the findbar

2013-02-07 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2025 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/2025/1 Move close button to most left of the findbar I had a conversation with some UX-members, they all agree the clos

[PATCH] resolve fdo#60379 Impress Remote: Options look disabled

2013-02-07 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2029 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/2029/1 resolve fdo#60379 Impress Remote: Options look disabled Change-Id: Ifb760fd0a0fa1430b77838a0340cc0956a0201a7 ---

[PATCH libreoffice-4-0] resolve fdo#60379 Impress Remote: Options look disabled

2013-02-07 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2030 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/2030/1 resolve fdo#60379 Impress Remote: Options look disabled Change-Id: Ifb760fd0a0fa1430b77838a0340cc0956a0201a7 Rev

[PATCH] resolve fdo#60450 - Printer list is missing its border in Pr...

2013-02-08 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2042 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/2042/1 resolve fdo#60450 - Printer list is missing its border in Print dialog Change-Id: I756788a003d4c57612c1752f1b47d

[PATCH] resolve fdo#60450 - Printer list is missing its border in Pr...

2013-02-08 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2043 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/2043/1 resolve fdo#60450 - Printer list is missing its border in Print dialog Change-Id: I2e28b9f9d52bcb01b04f98d39d12b

[PATCH] add 6 width border to toplevel widgets of printdialog

2013-02-09 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2067 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/2067/1 add 6 width border to toplevel widgets of printdialog Change-Id: I415769aeda335d65a4a5dc03be56e26a860046e3 --- M

[PATCH] Add findbar close icons to other icon-themes as well

2013-02-13 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2127 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/2127/1 Add findbar close icons to other icon-themes as well So far I only add an icon to the galaxy theme. Therefore I

[ABANDONED] fdo#62670 table splitting a table options are mixed

2013-03-25 Thread Joren De Cuyper (via Code Review)
Joren De Cuyper has abandoned this change. Change subject: fdo#62670 table splitting a table options are mixed .. Patch Set 1: Abandoned pushed to early -- To view, visit https://gerrit.libreoffice.org/3038 To unsubscribe, vi

[PATCH] fdo#62670 table splitting a table options are mixed

2013-03-25 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3038 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/3038/1 fdo#62670 table splitting a table options are mixed Change-Id: Ied6ab0d3f8dce7092e1ea50b3a1838b170649334 --- M s

[PATCH] fix fdo#62670 - TABLE: Splitting a table options are mixed

2013-03-25 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3041 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3041/1 fix fdo#62670 - TABLE: Splitting a table options are mixed Change-Id: I1ba647844aaae3a57ee91d5785c82ca082d3e10b

[PATCH libreoffice-4-0] fix fdo#62670 - TABLE: Splitting a table options are mixed

2013-03-25 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3042 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/3042/1 fix fdo#62670 - TABLE: Splitting a table options are mixed Change-Id: I1ba647844aaae3a57ee91d5785c82ca082d3e10b

[PATCH libreoffice-4-0-2] fix fdo#62670 - TABLE: Splitting a table options are mixed

2013-03-25 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3043 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/3043/1 fix fdo#62670 - TABLE: Splitting a table options are mixed Change-Id: I1ba647844aaae3a57ee91d5785c82ca082d3e10b

[PATCH] Cleanup comments and some translations in style.cxx

2013-03-26 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3062 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/3062/1 Cleanup comments and some translations in style.cxx Change-Id: I18f0a3d9e9c97164691233e3c997f978d339e401 --- M s

[PATCH] Convert starmath/ fontdialog to .ui

2013-04-02 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3181 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/3181/1 Convert starmath/ fontdialog to .ui Status: Draft !Please do not submit yet! Reason: Some questions/problems Th

[PATCH] fdo#51615 replace button in Find&Replace Dialog not search f...

2013-04-03 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3197 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/3197/1 fdo#51615 replace button in Find&Replace Dialog not search for the next item Change-Id: Ia1735ae39618fb8b0e4749e

[ABANDONED] Convert starmath/ fontdialog to .ui

2013-04-04 Thread Joren De Cuyper (via Code Review)
Joren De Cuyper has abandoned this change. Change subject: Convert starmath/ fontdialog to .ui .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/3181 To unsubscribe, visit https://gerrit.libreoffice.or

[PATCH] fdo#63290 UI: Goal Seek - incorrect term "current cell"

2013-04-09 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3291 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/3291/1 fdo#63290 UI: Goal Seek - incorrect term "current cell" Change-Id: I0542d9918d9dbbfdc002b7fadec1bb461cbd2831 ---

[PATCH] fdo#62483 missing default button in format -> aligment dialo...

2013-05-21 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3994 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/3994/1 fdo#62483 missing default button in format -> aligment dialog at math The default button was missing because the

[PATCH libreoffice-4-0] fdo#62483 missing default button in format -> aligment dialo...

2013-05-21 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3995 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/3995/1 fdo#62483 missing default button in format -> aligment dialog at math The default button was missing because the

[PATCH libreoffice-4-1] fdo#62483 missing default button in format -> aligment dialo...

2013-05-21 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3996 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/3996/1 fdo#62483 missing default button in format -> aligment dialog at math The default button was missing because the

[PATCH] fdo#64870 Duplicate shortcut on Text Import dialogue

2013-05-22 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4004 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/4004/1 fdo#64870 Duplicate shortcut on Text Import dialogue Accelerator 'o' is used for Open as well as Other, 'r' isn'

[PATCH libreoffice-4-0] fdo#64870 Duplicate shortcut on Text Import dialogue

2013-05-22 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4006 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/4006/1 fdo#64870 Duplicate shortcut on Text Import dialogue Accelerator 'o' is used for Open as well as Other, 'r' isn'

[PATCH libreoffice-4-1] fdo#64870 Duplicate shortcut on Text Import dialogue

2013-05-22 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4005 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/4005/1 fdo#64870 Duplicate shortcut on Text Import dialogue Accelerator 'o' is used for Open as well as Other, 'r' isn'

[PATCH] Delete double whitespace in optsecuritypage.ui

2013-05-26 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4040 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/4040/1 Delete double whitespace in optsecuritypage.ui Found this double whitespace during translations. So lets fix it

[PATCH libreoffice-4-1] Delete double whitespace in optsecuritypage.ui

2013-05-26 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4041 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/4041/1 Delete double whitespace in optsecuritypage.ui Found this double whitespace during translations. So lets fix it

[PATCH] Typo in optsecuritypage.ui

2013-05-27 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4056 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/4056/1 Typo in optsecuritypage.ui Thanks to Lionel. Change-Id: Ib37c3cf9d8f53e941fc557dc9d4a4ba9b00e486d --- M cui/uic

[PATCH libreoffice-4-1] Typo in optsecuritypage.ui

2013-05-27 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4057 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/4057/1 Typo in optsecuritypage.ui Thanks to Lionel. Change-Id: Ib37c3cf9d8f53e941fc557dc9d4a4ba9b00e486d --- M cui/uic

[PATCH] Add Dutch OpenTaal Thesaurus

2013-05-31 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4121 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/dictionaries refs/changes/21/4121/1 Add Dutch OpenTaal Thesaurus Change-Id: I0b063b59e4d8b1b91fed30ded83710070bf09bf0 --- A nl_NL/README_th

[ABANDONED] Add Dutch OpenTaal Thesaurus

2013-06-02 Thread Joren De Cuyper (via Code Review)
Joren De Cuyper has abandoned this change. Change subject: Add Dutch OpenTaal Thesaurus .. Patch Set 1: Abandoned Thanks Timar! Back to the sketchboard :-) -- To view, visit https://gerrit.libreoffice.org/4121 To unsubscribe,

[PATCH] fdo#63290 - UI: Goal Seek - incorrect term "current cell"

2013-04-11 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3338 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/3338/1 fdo#63290 - UI: Goal Seek - incorrect term "current cell" Previous patch was a review patch I submitted to send

[PATCH] fdo#31082 cursor visible during impress presentation

2013-04-13 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3376 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/3376/1 fdo#31082 cursor visible during impress presentation Change-Id: I8983676244d0b996c237cbfc487ed68a535803d1 --- M

[PATCH libreoffice-4-0] resolve fdo#54335 type an existing style name into Style box...

2013-02-27 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2440 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/2440/1 resolve fdo#54335 type an existing style name into Style box changes hierarchy Change-Id: If2fd4eecec4f6f031b264

[PATCH] Delete double condition check

2013-02-27 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2453 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/2453/1 Delete double condition check We don't need to check if aNextPostIt != aVisiblePostItList.end() because we can't

[PATCH] It is safer to uncomment these checks in the postithelper

2013-03-06 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2567 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/2567/1 It is safer to uncomment these checks in the postithelper Change-Id: I84d96224dbe51ff25fcb6d96e0be9a8dff89b0a1 -

[PATCH] WaE: return a value if the checks does not succeed in GetAnc...

2013-03-06 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2568 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/2568/1 WaE: return a value if the checks does not succeed in GetAnchorPosition Change-Id: Id9a9f5ba2299f103804b8f66c7dc

[ABANDONED] WaE: return a value if the checks does not succeed in GetAnc...

2013-03-06 Thread Joren De Cuyper (via Code Review)
Joren De Cuyper has abandoned this change. Change subject: WaE: return a value if the checks does not succeed in GetAnchorPosition .. Patch Set 1: Abandoned to risky to return a NULL because of a NULL < NULL check. Will fix it

[PATCH] delete previous uncommented comments in positionhelper.cxx

2013-03-06 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2571 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/2571/1 delete previous uncommented comments in positionhelper.cxx Change-Id: I0f177a078b915c1220423ea583e749de4d02e384

[PATCH] Bug 34800 Comments added to footer are placed at the right t...

2013-03-06 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2572 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/2572/1 Bug 34800 Comments added to footer are placed at the right top of the page. The problem is that the nodes in the

[PATCH] Translate german comments in wrtw8sty.cxx

2013-03-06 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2575 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/2575/1 Translate german comments in wrtw8sty.cxx Please, only apply this patch if you are native speaking German. I'm n

[PATCH] Translate german comments in sw/source/filter/ww8/wrtww8.cxx

2013-03-07 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2589 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/2589/1 Translate german comments in sw/source/filter/ww8/wrtww8.cxx Please, only apply this patch if you are a native s

[PATCH] Partially translate german comments in sw/source/filter/ww8/

2013-05-04 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3788 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/3788/1 Partially translate german comments in sw/source/filter/ww8/ Please, only apply this patch if you are a native s

[PATCH] Solve fdo#64359 Duplicate template in list when overwriting ...

2013-05-08 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3825 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/3825/1 Solve fdo#64359 Duplicate template in list when overwriting existing template This patch just ensures an updates

[PATCH] Solve fdo#64406 Missing right closing parenthesis

2013-05-10 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3837 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/3837/1 Solve fdo#64406 Missing right closing parenthesis Change-Id: I3812b60f097b1daf554bf2d337b126e8a8067573 --- M wiz

[ABANDONED] Solve fdo#64359 Duplicate template in list when overwriting ...

2013-05-10 Thread Joren De Cuyper (via Code Review)
Joren De Cuyper has abandoned this change. Change subject: Solve fdo#64359 Duplicate template in list when overwriting existing template .. Patch Set 1: Abandoned wrong way to fix this (thanks to Rafael' review) -- To view,

[PATCH libreoffice-4-0] Solve fdo#64406 Missing right closing parenthesis

2013-05-10 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3840 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/3840/1 Solve fdo#64406 Missing right closing parenthesis Change-Id: I3812b60f097b1daf554bf2d337b126e8a8067573 Reviewed-

[PATCH] resolve fdo#64446 Repeat shortcut isn't showed correctly in ...

2013-05-10 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3850 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/3850/1 resolve fdo#64446 Repeat shortcut isn't showed correctly in menu entry Change-Id: I991185f6b4efd305dc55c9ad85f92

[PATCH] fdo#32368 - Link both Ctrl+Y as Ctrl+Shift+Z as shortcut key...

2013-05-11 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3853 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/3853/1 fdo#32368 - Link both Ctrl+Y as Ctrl+Shift+Z as shortcut keys for Redo As discussed on the UX-advice and bug rep

[PATCH] fdo#30715 Several commands are under the wrong category

2013-05-11 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3854 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/3854/1 fdo#30715 Several commands are under the wrong category Placing "insert" commands under category "insert" is mor

[PATCH] add close option to findbar in Writer

2013-01-06 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1557 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/1557/1 add close option to findbar in Writer Change-Id: Ie42da7ecc7f3cb59bb6f1fb798e72a6862eb1f67 --- M dictionaries A

[PATCH] remove some ::rtl:: prefixes

2013-01-06 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1558 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/1558/1 remove some ::rtl:: prefixes Change-Id: Ia31f1b5ae3c940861d72598aff54be85e2ad33dd --- M accessibility/inc/access

[PATCH] typo fix

2013-01-07 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1563 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/1563/1 typo fix Change-Id: I7530e477a6cf4ab52772b7ba1c5e3d41dc2d6fae --- M officecfg/registry/data/org/openoffice/Offic

[PATCH] fdo#59090 clean up memory leaks

2013-01-07 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1569 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/1569/1 fdo#59090 clean up memory leaks Change-Id: Ifbade82383694ebac0e82920014cddfff5b12fcb --- M basic/source/classes/

[PATCH] delete style when pressing DEL + fix type

2013-01-14 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1681 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/1681/1 delete style when pressing DEL + fix type Change-Id: I6748aad9f9214bb9ef1ec84d35db731c756056a3 --- M sfx2/source

delete style when pressing DEL + fix type

2013-01-14 Thread Joren De Cuyper (via Code Review)
Joren De Cuyper has abandoned this change. Change subject: delete style when pressing DEL + fix type .. Patch Set 1: Abandoned isn't a bug, my bad -- To view, visit https://gerrit.libreoffice.org/1681 To unsubscribe, visit ht

[PATCH] Add close findbar button also on other LO components

2013-01-16 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1727 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/1727/1 Add close findbar button also on other LO components Change-Id: I8a18d0459d9584d00b8d7c747b0bb500e02988d9 --- M

[PATCH] fdo#46718 Delete multiple styles at once

2013-01-17 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1737 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/1737/1 fdo#46718 Delete multiple styles at once Change-Id: I5f5982b2a2768d021f24693a285274544e07e40f --- M sfx2/source/

fdo#59090 clean up memory leaks

2013-01-17 Thread Joren De Cuyper (via Code Review)
Joren De Cuyper has abandoned this change. Change subject: fdo#59090 clean up memory leaks .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/1569 To unsubscribe, visit https://gerrit.libreoffice.org/se

[PATCH] fdo#59101 - [Feature Request] Make Find hotkey (Ctrl+F) a to...

2013-01-17 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1751 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/1751/1 fdo#59101 - [Feature Request] Make Find hotkey (Ctrl+F) a toggle command Change-Id: I8cf518a18e4846f9e687d05c7f7

[PATCH] Change in core[libreoffice-4-0]: Add close findbar button also on other LO components

2013-01-18 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1759 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/1759/1 Add close findbar button also on other LO components Change-Id: I8a18d0459d9584d00b8d7c747b0bb500e02988d9 Review

[PATCH] Change in core[libreoffice-4-0]: add close option to findbar in Writer

2013-01-18 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1758 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/1758/1 add close option to findbar in Writer Change-Id: Ie42da7ecc7f3cb59bb6f1fb798e72a6862eb1f67 Reviewed-on: https://

Change in core[libreoffice-4-0]: add close option to findbar in Writer

2013-01-18 Thread Joren De Cuyper (via Code Review)
Joren De Cuyper has abandoned this change. Change subject: add close option to findbar in Writer .. Patch Set 1: Abandoned Sorry, didn't know about string freeze -- To view, visit https://gerrit.libreoffice.org/1758 To unsubs

Change in core[libreoffice-4-0]: Add close findbar button also on other LO components

2013-01-18 Thread Joren De Cuyper (via Code Review)
Joren De Cuyper has abandoned this change. Change subject: Add close findbar button also on other LO components .. Patch Set 1: Abandoned related to abandoned change because of string freeze -- To view, visit https://gerrit.l

[PATCH] resolve fdo#59240 - FORMATTING: Thai number shown as Arabic ...

2013-01-19 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1769 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/1769/1 resolve fdo#59240 - FORMATTING: Thai number shown as Arabic numerals Change-Id: I6123f8924d7502d3b97b3254ce4e5df

[PATCH] Change in core[libreoffice-4-0]: resolve fdo#59240 - FORMATTING: Thai number shown as Arabic ...

2013-01-19 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1770 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/1770/1 resolve fdo#59240 - FORMATTING: Thai number shown as Arabic numerals Change-Id: Ia0d1089d90a6b2196d45da63afbb7d8

[PATCH] resolve fdo#59619 Spelling error - heigth

2013-01-20 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1782 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/1782/1 resolve fdo#59619 Spelling error - heigth Change-Id: Ice59129d20c6b7e3aa0dbabfefabd14bad8199b6 --- M svx/uiconfi

[PATCH] Change in core[libreoffice-4-0]: resolve fdo#59619 Spelling error - heigth

2013-01-20 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1783 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/1783/1 resolve fdo#59619 Spelling error - heigth Change-Id: Ice59129d20c6b7e3aa0dbabfefabd14bad8199b6 --- M svx/uiconfi