[Libreoffice] [PUSHED] Re: [PATCH] making binfilter compiling again

Hi, sorry for that, I just changed lines as : -/*N*/ aOutProps[1].Name = OUSTRING::createFromAscii( PROP_SCRIPT ); +/*N*/ aOutProps[1].Name = OUString(RTL_CONSTASCII_USTRINGPARAM( PROP_SCRIPT )); /*N*/ aOutProps[1].Value <<= aScript; -/*N*/ aOutProps[2].Name

[Libreoffice] Enable build of ure and extension

Hi, Still working on the 'RTL_CONSTASCII_USTRINGPARAM' task and I have some problems. I've some changes left in : 'clone/ure', 'clone/extension', 'clone/filters/binfilter/bf_sd', 'clone/filters/binfilter/bf_svx' and 'clone/filters/binfilter/bf_xmloff' The problem is that, build is disabled in th

[Libreoffice] (no subject)

Hi, @Wol thanks for your answer. I've already configured with '--enable-binfilter'. binfilter builds except some sub-dirs 'bf_sd', 'bf_svx' and 'bf_xmloff' (and some others) and I have changes ready in there but not tested. For 'extension', make simply answers 'Presenter Screen build disabled' a

Re: [Libreoffice] Enable build of ure and extension

Hi, well I've enabled many things, but no, 'make' does not see anything. Wathever, I've pushed two patches in binfilter (checked many times manually and with cppcheck) because with those two terminate 'RTL_CONSTASCII_USTRINGPARAM in filters'. For 'ure' and 'extentions' I will try to enable build

Re: [Libreoffice] Enable build of ure and extension

Hi, thank you very much for checking them. Well, after a good night of sleep, I have just realized that since the change to the new build system my root directory is a real mess. For sure, I did not do it the right way and then focussed on the patches ready before the upgrade. Thanks for your pa

Re: [Libreoffice] Export OLE objects as PDF / graphics

Hi, it seems that the RTL_CONSTASCII_USTRINGPARAM is (completly ? mostly ?) finished so I'm back to PDF Export > * Misc issues > + Formula objects > + no PDF exported :-) In fact they do export as do other objects. But none of them exports when anchor is

Re: [Libreoffice] First try

Selon Michael Meeks : > Hi there, > > On Mon, 2010-10-25 at 20:05 +0200, gertfal...@aliceadsl.fr wrote: > > just a first test. > > Drat, and I really wanted to merge it quickly, but it seems git wants > your real name (if you can share it) ? > > Nice patch though ! :-) [ better as an a

[Libreoffice] Cppcheck

Hi, I've been running 'Cppcheck 1.44' on the whole source 27/10/10 10 GTM (I have a slow machine) : I join the raw output sorted by 'Error Type'. I run it too with '--enable=unusedFunctions' : I got 3195 matches... looks enormous. I'll check part of this output. Do I send the file ? I've been

[Libreoffice] Styles and Formatting

Hi, I've been working on the "Styles and Formatting window does not remember hierarchical view" bug. It seems I got it. I've noticed that, the window does not remember the Frame Styles but reverts to Paragraph Styles. Is that an another bug or a feature ? (The same in openoffice) Regards.

[Libreoffice] Styles and Formatting

Hi, well so here's a patch for Styles and Formatting window does not remember hierarchical view" bug. I don't modify the main class so there's a local variable in constructor... Regards. templdlg.txt.patch Description: Binary data ___ LibreOffice m

[Libreoffice] Styles and Formatting

Hi, the patch... Regardsdiff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx index 9b443e8..5027e7b 100644 --- a/sfx2/source/dialog/templdlg.cxx +++ b/sfx2/source/dialog/templdlg.cxx @@ -875,8 +875,6 @@ void SfxCommonTemplateDialog_Impl::ReadResource() pStyleF

[Libreoffice] Export OLE objects as PDF / graphics

Hi, I'm studying the "Export OLE objects as PDF / graphics" feature and it reminds me of an other... When you import a picture in writer : you can't rotate it. It's a picture : style "Graphics". When you import a picture in draw : you can't rotate it. If you copy it back in writer, it's a "Draw

[Libreoffice] [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro

Hi, a first try on that. Not sure if I let the original source (for control) Regards. createFromAscii_1.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreo

[Libreoffice] [PATCH] cppcheck "Common realloc mistake"

Hi, The two cppcheck warnings in 'libs-core' about 'realloc'. Not sure about that : what to do on NULL ? There are others, for example in : 'sdk/odk/source/unoapploader/unx/unoapploader.c' but with 'exit(EXIT_FAILURE)' on NULL. Regards. libs-gui.patch Description: Binary data _

Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro

Selon Caolán McNamara : > You have two typos in there however, i.e. > > - com.sun.star.chart.BarDiagram > + com.sun.star.chart.BarDiagra > > - com.sun.star.chart2.ScatterChartType > + com.sun.star.chart2.ScatterChartTyp > > in those two cases the trailing letter of the original string got > remo

[Libreoffice] [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro bis

Hi, here are some more of them. Regards. createFromAscii_2.patch Description: Binary data createFromAscii_3.patch Description: Binary data createFromAscii_4.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedeskto

Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro

OK, thanks. > > Now, this only works when you can compute the length of the string at > compile time, i.e. its a string literal, so > OUString::createFromAscii("foo") can be trivially replaced, while > OUString::createFromAscii(pSomething) should be left alone. > > C. > Yes, of course, I was just

[Libreoffice] [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM 3

Hi, I'am not sure of my previous mail... Regards. createFromAscii_5.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM 3

Hi, Quote : "I'am not sure of my previous mail." I sent it 3 hours ago but it did not appear (and it's in my 'sent-mail' directory) : maybe some problem with my ISP because of the end of DST this night... Regards. ___ LibreOffice mailing list LibreOff

Re: [Libreoffice] [PATCH] cppcheck "Common realloc mistake"

Hi, a second try. Making cppcheck happy is not easy... The first file may be ok. The second no : but what to do ? loose memory or risk a fail ? /* very strange case, but have to believe it: reduce the * full qualified name to the unqualified host name */ if ( !bHostsAreE

Re: [Libreoffice] [PUSHED, partially] Re: [PATCH] cppcheck "Common realloc mistake"

Selon Caolán McNamara : > 2. The other possible solution is to take advantage that in this case I > can see that the string is bring shrunk, so (double-checking man > realloc) on failure "the original block is left untouched". Right before > the realloc a NULL char is entered at the point where

Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 4

Selon Caolán McNamara : > Mostly good, though createFromAscii_7.patch has... > > OUString::createFromAscii( GetWindowState( WINDOWSTATE_MASK_POS ).GetBuffer() > ) ); > > that one can't be changed to use RTL_CONSTASCII_USTRINGPARAM because > GetWindowState is a method rather than a string literal,

[Libreoffice] (no subject)

Hi, a little bit more... regards. createFromAscii_8.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 5

Hi, forgot subject... Regards. createFromAscii_8.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 6

Hi, some more in impress Regards. createFromAscii_9.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] sc: fix parenthesis mixup

Hi, On Tue, Nov 02, 2010 at 03:10:49PM +0100, Sebastian Spaeth wrote: > Commit cab7e33c4ff6067486b745ebfc0b37ed1d6d18b7 broke parentheses. Fixing > My fault, sorry. Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.fr

[Libreoffice] Some hints about git please...

Hi, I'am very new to git (only have used sometimes 'git clone' before) , and I don't get it very well... 1) I update the 'clone' directory often. No problem with that. 2) I've read that when updating 'clone', 'bin/g' must be run. I don't find any 'g' in ./bin/. 3) I don't know how to update ea

[Libreoffice] Styles and Formatting

Hi, > Do we want the Hierarchical view to be the default one for all apps? > Should we enhance the filters values to make it configurable for the > different apps? Well, in fact, there were some changes remaining from my previous attempts. Maybe something simpler is enough ? Regards templd

Re: [Libreoffice] Some hints about git please...

Selon Sebastian Spaeth : > > If you work in rawbuild and "make" from there, you can directly go into > the directory, make changes, git add , git > commit, and extract the patch with git format-patch HEAD^1. > > Hope that helps, I am sure there are even more efficient workflows. > > Sebastian > Hi

[Libreoffice] Some hints about git please...

Hi, with "http://wiki.documentfoundation.org/Development/How_to_build";, linux part, all is ok. Very complete howto. Thanks. Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoff

[Libreoffice] [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 8

Hi, this may be the last for module 'writer'. Remains 'sw/source/ui/vba/vbacheckbox.cxx:78'. When I google I find : #define ECMA_FORMCHECKBOX_CHECKED "checked" in '/xmloff/inc/xmloff/ecmaflds.hxx' but don't find it in clone. So I let that one. Regards. createFromAscii_11.patch Description: Bin

[Libreoffice] Styles and Formatting

Hi, I have erased the line : "m_aActionTbL.SetHelpId( HID_TEMPLDLG_TOOLBOX_LEFT );" in the patch file 2. A paste© error... Regards. templdlg_3.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.

Re: [Libreoffice] Styles and Formatting

Selon Cedric Bosdonnat : > > So Hierarchical as default would not be my choice. > > Default is more then enough. Hi, I must admit that even if I been using OpenOffice for nearly 10 years, I never use that dialog so I've maybe not made a good choice for my first jump in the source... I have to un

[Libreoffice] Duplicate ids in 'writer/sw/inc/cmdid.h'

Hi, just wondering if someone knows why there are duplicate ids in 'writer/sw/inc/cmdid.h' (FN_FORMAT + 129) , (FN_FORMAT + 130), (FN_FORMAT + 131) at line 537. Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.fre

[Libreoffice] [PATCH] Easy Hacks : RTL_CONSTASCII_USTRINGPARAM in libs-core 3

HI, here are some more in libs-core Regards. 10_libs-core.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Duplicate ids in 'writer/sw/inc/cmdid.h'

Selon Caolán McNamara : > Hmm, one of the + 129 is FN_NEW_PAGE_STYLE and appears (according to > opengrok) unused the FN_PAGE_STYLE_SET_LR_MARGIN and > FN_PAGE_STYLE_SET_UL_MARGIN i.e. one version of the + 130 and + 131 are > only mentioned in basesh.cxx as "false not implemented". > > So I recko

[Libreoffice] Export OLE objects as PDF / graphics

Hi, Following the hints of Michael Meeks in : 'https://bugs.freedesktop.org/show_bug.cgi?id=30944', here a first try in writer. It's 'raw code' : just wondering if it satisfies the required functionality. Regards. export_4.patch Description: Binary data

Re: [Libreoffice] Export OLE objects as PDF / graphics

Selon Caolán McNamara : > It looks good to me anyway. Just need to handle more gracefully hitting > "cancel" IMO and I reckon we could pretty much stuff it in as is. > > C. Hi, yes of course, checks must be added, it's just 'raw code'. Whatever,this function is expected in calc to. I'm coding i

[Libreoffice] SW build error

Hi, I get a build error in sw : with : 'sw/source/filter/rtf/rtffly.cxx' 1311 error: 'PictPropertyNameValuePairs' has not been declared PictPropertyNameValuePairs is only a typedef in ' libs-core/editeng/inc/editeng/svxrtf.hxx' It seems it due to the last commit in writer. Regards.