gerrit changes depending one on another (was: Maarten Bosmans license statement)

2016-09-01 Thread Eike Rathke
Hi Maarten, On Wednesday, 2016-08-31 10:49:11 +0200, Maarten Bosmans wrote: > What is the correct way to submit a patch series to gerrit? I'd like > to avoid squashing all patches into one commit, but there also has to > be a way for reviewers to see that all patches in a series are > related. I

Re: Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion

2016-09-01 Thread Eike Rathke
Hi Alex, On Wednesday, 2016-08-31 19:30:35 +0100, Alex McMurchy wrote: > When compiling LibreOffice I get a failed Unit test. The problem occurs in > sc/qa/unit/functions_test.cxx with > > > CPPUNIT_ASSERT_DOUBLES_EQUAL(1.0, rDoc.GetValue(1, 2, 0), 1e-14); > > whilst testing sc/qa/unit/data/fun

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source

2016-09-01 Thread Eike Rathke
sc/source/ui/app/inputhdl.cxx | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) New commits: commit d8879103a152c7db6ba420af9cda87790996fee8 Author: Eike Rathke Date: Thu Sep 1 12:17:36 2016 +0200 exclude also single quoted strings from function name suggestion

Re: gerrit changes depending one on another

2016-09-02 Thread Eike Rathke
Hi, On Friday, 2016-09-02 12:24:54 +0200, Norbert Thiebaud wrote: > On Fri, Sep 2, 2016 at 11:12 AM, Stephan Bergmann wrote: > > On 09/01/2016 06:01 PM, Eike Rathke wrote: > >> > >> Or plain git: git push gerrit HEAD:refs/for/master/mytopic > > > > i

Re: Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion

2016-09-02 Thread Eike Rathke
Hi Alex, On Friday, 2016-09-02 09:03:29 +0100, Alex McMurchy wrote: > I've replicated the problem on - > > Lubuntu 1404LTS (up to date as off a few days ago) - gcc (Ubuntu > 4.8.4-2ubuntu1~14.04.3) 4.8.4 > > Slackware-Current (1402) hasn't been updated for a few months - gcc (GCC) > 4.9.3 Good

Re: Failing tinderboxes spam

2016-09-05 Thread Eike Rathke
Hi, On Sunday, 2016-09-04 19:37:54 +0200, Bjoern Michaelsen wrote: > And indeed the volume of tinderbox mails is a problem, but fixing them > requires > work. Anyone volunteering for that? I'll try to look after the Calc function test failures on Linux-rpm_deb-x86_71-TDF and Linux-rpm_deb-x86_7

[Libreoffice-commits] core.git: xmloff/source

2016-09-07 Thread Eike Rathke
xmloff/source/style/xmlnumfi.cxx | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) New commits: commit 95c91f098e8974c41c8d403a351fe53db6822165 Author: Eike Rathke Date: Wed Sep 7 21:04:43 2016 +0200 Resolves: tdf#101963 loading zh-TW ROC calendar use EE|E instead of

Re: Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion

2016-09-07 Thread Eike Rathke
Hi Alex, On Wednesday, 2016-08-31 19:30:35 +0100, Alex McMurchy wrote: > When compiling LibreOffice I get a failed Unit test. The problem occurs in > sc/qa/unit/functions_test.cxx with You could do us a favour, are you willing to invest some machine time and try if passing either -msse or -msse2

Re: Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion

2016-09-08 Thread Eike Rathke
Hi Alex, On Thursday, 2016-09-08 13:28:46 +0100, Alex McMurchy wrote: > > [... -msse ...] > > Both failed for the same reason. Pity.. ok, thanks for trying, we'll have to further investigate. > Is the problem just a 32bit issue? Yes. Only two tinderbox 32-bit builds (and your's) have the prob

Re: Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion

2016-09-09 Thread Eike Rathke
Hi Alex, On Friday, 2016-09-09 08:46:20 +0100, Alex McMurchy wrote: > Will it helpful if I installed Lubuntu 14.04 64bit and see if I get the same > problem? Unlikely. The problem so far only showed up in 32-bit builds. But thanks for offering. Eike -- LibreOffice Calc developer. Number for

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - xmloff/source

2016-09-09 Thread Eike Rathke
xmloff/source/style/xmlnumfi.cxx | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) New commits: commit 7f037e2230d059320aff8610b6d24c0a44a71e41 Author: Eike Rathke Date: Wed Sep 7 21:04:43 2016 +0200 Resolves: tdf#101963 loading zh-TW ROC calendar use EE|E instead of

[Libreoffice-commits] core.git: 3 commits - include/unotools unotools/source xmloff/source

2016-09-13 Thread Eike Rathke
f882555332fffbd3ea82c3a25a05ebebe3884415 Author: Eike Rathke Date: Tue Sep 13 12:46:21 2016 +0200 switch to using LocaleDataWrapper::doesSecondaryCalendarUseEC() Change-Id: I6621e82249feeed3d88ee463447d08c4f812259c diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx index

[Libreoffice-commits] core.git: unotools/source

2016-09-13 Thread Eike Rathke
unotools/source/i18n/localedatawrapper.cxx | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) New commits: commit 6f8ea7e89ea190b9462c945d55a3ad8777b2f3ef Author: Eike Rathke Date: Tue Sep 13 13:03:27 2016 +0200 avoid loading all calendars of a locale

[Libreoffice-commits] core.git: include/formula

2016-09-13 Thread Eike Rathke
include/formula/errorcodes.hxx |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) New commits: commit 4ef10fce39575ec0bd3793b5fdf731c0b9af25a3 Author: Eike Rathke Date: Tue Sep 13 15:26:09 2016 +0200 recognize NaN with no bits set in lower word as error Which can

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - include/formula

2016-09-13 Thread Eike Rathke
include/formula/errorcodes.hxx |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) New commits: commit ca19404c254c306d31a332958da5dde5d69a8d20 Author: Eike Rathke Date: Tue Sep 13 15:26:09 2016 +0200 recognize NaN with no bits set in lower word as error Which can

[Libreoffice-commits] core.git: 2 commits - include/xmloff xmloff/source

2016-09-13 Thread Eike Rathke
include/xmloff/xmlnumfi.hxx |2 - xmloff/source/style/xmlnumfi.cxx | 41 +-- 2 files changed, 28 insertions(+), 15 deletions(-) New commits: commit e12c9b41012e44275761b35795b83ec4bc838d42 Author: Eike Rathke Date: Tue Sep 13 19:33:11 2016 +0200

[Libreoffice-commits] core.git: xmloff/source

2016-09-13 Thread Eike Rathke
xmloff/source/style/xmlnumfi.cxx |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) New commits: commit ccfbc9d3ac83fa238d6240b5365dc7572c64d241 Author: Eike Rathke Date: Tue Sep 13 22:05:09 2016 +0200 unconditionally replacing Y after G (era) with E was always wrong

Re: Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion

2016-09-13 Thread Eike Rathke
Hi Alex, On Monday, 2016-09-12 20:09:27 +0100, Alex McMurchy wrote: > Is there anything else I can usefully do? Like > > 1. either stepping through the code Well, you can try, but it's a more general problem not restricted to just one or two functions. Entry point for the CHIINV function would

Re: Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion

2016-09-14 Thread Eike Rathke
Hi slacka, On Sunday, 2016-09-11 01:09:30 -0700, slacka wrote: > This may be a regression, but I'm not seeing it with the 32-bit 5.1.4.2 > official LibreOffice for Ubuntu 16.04. With minverse.fods, C10 changes to > FALSE after pressing Shift+Ctrl+F9. With vdb.fods, C11 changes to FALSE > after a

Re: [ANN] mdds 1.2.2 hits master

2016-09-14 Thread Eike Rathke
Hi Markus, On Sunday, 2016-09-11 05:39:05 +0200, Markus Mohrhard wrote: > On Sat, Sep 10, 2016 at 4:28 PM, Kohei Yoshida wrote: > > I'd recommend backporting this to a stable branch, since in theory > > these crashers have probably existed for several releases at least. > > I absolutely agree.

[Libreoffice-commits] core.git: sc/Module_sc.mk

2016-09-14 Thread Eike Rathke
sc/Module_sc.mk |9 + 1 file changed, 9 insertions(+) New commits: commit b9a27d5856f60688456762bfcc29c38670009254 Author: Eike Rathke Date: Wed Sep 14 12:56:31 2016 +0200 sc: disable function test documents for 32-bit PLATFORMID=linux_x86 Change-Id

Re: Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion

2016-09-14 Thread Eike Rathke
Hi Alex, On Wednesday, 2016-09-14 08:56:21 +0200, Eike Rathke wrote: > > 1. either stepping through the code > > Well, you can try, but it's a more general problem not restricted to > just one or two functions. Entry point for the CHIINV function would be > in sc/source

[Libreoffice-commits] core.git: Branch 'distro/collabora/lov-5.2' - 63 commits - configure.ac cui/source cui/uiconfig download.lst editeng/source extensions/source external/lcms2 external/liborcus ext

2016-09-15 Thread Eike Rathke
|1 101 files changed, 637 insertions(+), 222 deletions(-) New commits: commit d60dff922b4dba1064cc3a06bc7365e111ddc8a2 Author: Eike Rathke Date: Tue Sep 13 15:26:09 2016 +0200 recognize NaN with no bits set in lower word as error Which can happen for example for

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2-2' - include/formula

2016-09-16 Thread Eike Rathke
include/formula/errorcodes.hxx |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) New commits: commit 9c4fb18ba92265910d9c837d83c28926242b7915 Author: Eike Rathke Date: Tue Sep 13 15:26:09 2016 +0200 recognize NaN with no bits set in lower word as error Which can

[Libreoffice-commits] core.git: 5 commits - sc/qa

2016-09-16 Thread Eike Rathke
/data/functions/fods/mod.fods | 3714 5 files changed, 24771 insertions(+) New commits: commit cfde267f21b047bc19fe77dbd7ce52bdd7a1141d Author: Eike Rathke Date: Fri Sep 16 19:18:19 2016 +0200 Revert "Revert "add MOD test case""

[Libreoffice-commits] core.git: sc/source

2016-09-19 Thread Eike Rathke
sc/source/core/tool/interpr4.cxx | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) New commits: commit 388014fc19b2a785f887cdfee91100fc9ab8d58d Author: Eike Rathke Date: Mon Sep 19 18:04:54 2016 +0200 Resolves: tdf#100409 do not return coded double error

[Libreoffice-commits] core.git: sc/source

2016-09-19 Thread Eike Rathke
sc/source/core/tool/interpr4.cxx | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) New commits: commit aa51bf1e17dfb4a0a95a24e7de7f55d2b44b9472 Author: Eike Rathke Date: Mon Sep 19 18:49:03 2016 +0200 in GetInt...() check !isFinite() instead of isNan

[Libreoffice-commits] core.git: sc/inc sc/source

2017-11-02 Thread Eike Rathke
sc/inc/mtvelements.hxx |2 ++ sc/source/core/data/column.cxx |4 sc/source/core/data/mtvelements.cxx |5 + 3 files changed, 11 insertions(+) New commits: commit 423df1fa929784c14e3a133c06468589fe9269cd Author: Eike Rathke Date: Thu Nov 2 12:53:14 2017

[Libreoffice-commits] core.git: sc/qa

2017-11-02 Thread Eike Rathke
sc/qa/unit/ucalc.hxx |2 ++ sc/qa/unit/ucalc_formula.cxx | 28 2 files changed, 30 insertions(+) New commits: commit 782f34ae2f214674fc871ece348ba5dd11c4a8d6 Author: Eike Rathke Date: Thu Nov 2 16:59:36 2017 +0100 Unit test for CellStoreEvent

[Libreoffice-commits] core.git: sc/inc sc/source

2017-11-03 Thread Eike Rathke
sc/inc/mtvelements.hxx |2 -- sc/source/core/data/column.cxx |1 - sc/source/core/data/mtvelements.cxx |5 - 3 files changed, 8 deletions(-) New commits: commit 911e2aff3cc37cb7410292728ffea05fffbfb0b3 Author: Eike Rathke Date: Fri Nov 3 14:43:21 2017 +0100

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4-3' - sc/source

2017-11-03 Thread Eike Rathke
sc/source/core/data/column.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit f80ec94e75a9257504135bc32793c5eb37914bbe Author: Eike Rathke Date: Thu Nov 2 12:53:14 2017 +0100 Resolves: tdf#111428 swap ScColumn::mnBlkCountFormula This is a combination of 2

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/source

2017-11-03 Thread Eike Rathke
sc/source/core/data/column.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 76c54edc8ee972c63da8ed1f5d6ab75ea552da46 Author: Eike Rathke Date: Thu Nov 2 12:53:14 2017 +0100 Resolves: tdf#111428 swap ScColumn::mnBlkCountFormula This is a combination of 2

[Libreoffice-commits] core.git: 2 commits - sc/source

2017-11-03 Thread Eike Rathke
sc/source/ui/docshell/docsh.cxx | 14 ++ sc/source/ui/docshell/impex.cxx | 27 --- 2 files changed, 38 insertions(+), 3 deletions(-) New commits: commit 12f09377b91b6d70efb3448d098f4dbd677a67d1 Author: Eike Rathke Date: Fri Nov 3 23:10:01 2017 +0100

[Libreoffice-commits] core.git: sc/inc sc/source

2017-11-06 Thread Eike Rathke
sc/inc/document.hxx | 18 + sc/source/core/data/documen7.cxx | 71 +-- 2 files changed, 87 insertions(+), 2 deletions(-) New commits: commit efdf57aa44bd22a799d76ec67c805bc5c2d91678 Author: Eike Rathke Date: Mon Nov 6 19:39:26 2017

[Libreoffice-commits] core.git: sc/source

2017-11-07 Thread Eike Rathke
sc/source/core/data/documen7.cxx |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) New commits: commit 8b7551fb5c5416670b8ab70c2252d35bfaace3fa Author: Eike Rathke Date: Tue Nov 7 14:34:41 2017 +0100 LimitRangeToAvailableSheets: check ValidTab() first That already

Re: how to configure formula track?

2017-11-07 Thread Eike Rathke
Hi jaeseok, On Sunday, 2017-10-29 23:15:13 -0700, jaeseok wrote: > What is difference of formula track and formula tree? When a cell is changed the change is broadcasted to listeners (cell listeners and range listeners) and dependent cells (if not already in the track) are appended to the track

[Libreoffice-commits] core.git: external/icu

2017-11-08 Thread Eike Rathke
external/icu/UnpackedTarball_icu.mk|1 + external/icu/icu4c-changeset-40324.patch.1 | 11 +++ 2 files changed, 12 insertions(+) New commits: commit cebe1279665960b732c9cb05c18e481c33e778bb Author: Eike Rathke Date: Wed Nov 8 17:17:44 2017 +0100 Add ICU changeset

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - external/icu

2017-11-09 Thread Eike Rathke
external/icu/UnpackedTarball_icu.mk|1 + external/icu/icu4c-changeset-40324.patch.1 | 11 +++ 2 files changed, 12 insertions(+) New commits: commit 7637c1534b81e58459292d202c49b58f50ab7688 Author: Eike Rathke Date: Wed Nov 8 17:17:44 2017 +0100 Add ICU changeset

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sc/source

2017-11-09 Thread Eike Rathke
sc/source/core/data/column.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 7f1297d9b4f449eb9ada8008fb21b7046d1a8f19 Author: Eike Rathke Date: Thu Nov 2 12:53:14 2017 +0100 Resolves: tdf#111428 swap ScColumn::mnBlkCountFormula This is a combination of 2

[Libreoffice-commits] core.git: sc/source

2017-11-09 Thread Eike Rathke
sc/source/filter/inc/tokstack.hxx | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) New commits: commit cf36b5d5f598d9b5528b273858584e2b419b23e9 Author: Eike Rathke Date: Thu Nov 9 20:12:34 2017 +0100 Make this breakable in a debugger Change

[Libreoffice-commits] core.git: sc/source

2017-11-09 Thread Eike Rathke
sc/source/filter/inc/tokstack.hxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 7f603dd111afcc30eec8bbec97efc16ad8b4c4d1 Author: Eike Rathke Date: Thu Nov 9 23:33:50 2017 +0100 Add values to SAL_WARN output Change-Id

[Libreoffice-commits] core.git: 2 commits - sc/source

2017-11-10 Thread Eike Rathke
sc/source/filter/inc/formel.hxx | 30 +- sc/source/filter/inc/tokstack.hxx | 10 -- 2 files changed, 33 insertions(+), 7 deletions(-) New commits: commit 047cc1d976516c527f4c7051a98aade59c7494d9 Author: Eike Rathke Date: Fri Nov 10 10:58:44 2017 +0100

[Libreoffice-commits] core.git: chart2/source dbaccess/source include/svtools include/svx sc/source sd/source svtools/source svx/source sw/source

2017-11-10 Thread Eike Rathke
sw/source/uibase/inc/swdtflvr.hxx |2 +- 19 files changed, 55 insertions(+), 48 deletions(-) New commits: commit 38f4d4ca02cdc2fd4656e3a72def94da1df89650 Author: Eike Rathke Date: Fri Nov 10 23:18:52 2017 +0100 A user object id is *NOT* a SotClipboardFormatId

[Libreoffice-commits] core.git: include/sot include/svtools sot/source svtools/source

2017-11-13 Thread Eike Rathke
: Eike Rathke Date: Mon Nov 13 12:57:53 2017 +0100 SotClipboardFormatId::STRING_TSVC "Unformatted text [TSV-Calc]", tdf#113571 In preparation to solve tdf#113571 *AND* keeping tdf#32213 fixed we need two separate unformatted text formats to distinguish between

[Libreoffice-commits] core.git: sc/source

2017-11-13 Thread Eike Rathke
commits: commit f435cdba5b4ea98dc30b4b4879de21a542c8a84d Author: Eike Rathke Date: Mon Nov 13 16:41:49 2017 +0100 Resolves: tdf#113571 paste-special "Unformatted text [TSV-Calc]", tdf#32213 For intra-Calc on-cell pastes using the paste special toolbar button the SotClipboa

[Libreoffice-commits] core.git: offapi/com

2017-11-14 Thread Eike Rathke
offapi/com/sun/star/util/XTextSearch2.idl |6 ++ 1 file changed, 6 insertions(+) New commits: commit dee307cbc903caa6ec7141fb4d69949133963af3 Author: Eike Rathke Date: Tue Nov 14 15:54:53 2017 +0100 Add comment and @since LibreOffice 5.2 Change-Id

[Libreoffice-commits] core.git: sc/source

2017-11-14 Thread Eike Rathke
sc/source/ui/app/transobj.cxx | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) New commits: commit 329eeefcbd65ea88f0c8c3f034d49ba73045d059 Author: Eike Rathke Date: Tue Nov 14 17:39:41 2017 +0100 Distinguish single/multiple cell copy for plain text, tdf

[Libreoffice-commits] core.git: i18nlangtag/source include/i18nlangtag svtools/inc

2017-11-14 Thread Eike Rathke
i18nlangtag/source/isolang/isolang.cxx |1 + include/i18nlangtag/lang.h |1 + svtools/inc/langtab.hrc|3 ++- 3 files changed, 4 insertions(+), 1 deletion(-) New commits: commit a6259d1a9572f766d01d573d3d5bdf80d43df762 Author: Eike Rathke Date: Tue Nov

[Libreoffice-commits] core.git: helpcontent2

2017-11-14 Thread Eike Rathke
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 82b25c22819e84d2ec6d92cf8e9c0ee4a0b3723e Author: Eike Rathke Date: Tue Nov 14 19:59:10 2017 +0100 Updated core Project: help 008c845819cd34a02fba16ee89c784d02d6740fa Related: tdf

[Libreoffice-commits] help.git: source/text

2017-11-14 Thread Eike Rathke
source/text/scalc/01/04060118.xhp |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 008c845819cd34a02fba16ee89c784d02d6740fa Author: Eike Rathke Date: Tue Nov 14 19:59:10 2017 +0100 Related: tdf#113768 VDB change Type parameter opposite to NoSwitch

Re: [Libreoffice-commits] core.git: include/svl sc/qa sc/sdi sc/source sc/uiconfig sfx2/source

2017-11-14 Thread Eike Rathke
Hi Henry, On Sunday, 2017-10-22 15:18:38 +, Henry Castro wrote: > include/svl/hint.hxx |1 > sc/qa/unit/tiledrendering/tiledrendering.cxx | 51 +++ > sc/sdi/docsh.sdi |1 > sc/source/ui/docshell/docsh4.cxx

[Libreoffice-commits] core.git: formula/source

2017-11-15 Thread Eike Rathke
formula/source/core/api/token.cxx | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) New commits: commit 48dcf7837e0ac32c939a499c59aba82f97b4a612 Author: Eike Rathke Date: Wed Nov 15 17:41:05 2017 +0100 Assert all FormulaToken::Set...() virtual dummy methods

[Libreoffice-commits] core.git: Branch 'feature/calc-parallel' - formula/source

2017-11-15 Thread Eike Rathke
formula/source/core/api/token.cxx | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) New commits: commit bc41b7030082e6699a4cfcad56d76ef0fb3d60a2 Author: Eike Rathke Date: Wed Nov 15 17:41:05 2017 +0100 Assert all FormulaToken::Set...() virtual dummy methods

[Libreoffice-commits] core.git: Branch 'feature/calc-parallel' - formula/source

2017-11-15 Thread Eike Rathke
formula/source/core/api/token.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0e9facd67e8460b7059e6e877195f6c4ef63e24e Author: Eike Rathke Date: Wed Nov 15 18:08:30 2017 +0100 Assert also new FormulaToken::SetDoubleType() virtual dummy Change-Id

Re: [Libreoffice-commits] core.git: include/svl sc/qa sc/sdi sc/source sc/uiconfig sfx2/source

2017-11-15 Thread Eike Rathke
Hi Henry, On Tuesday, 2017-11-14 16:44:18 -0400, Henry Castro wrote: > > Spell checking in Calc does not work this way with a global document > > language or paragraph language, language is a cell attribute (or in-cell > > EditEngine text portion attribute). > > Indeed, after reading code they a

Re: calc parallel review call minutes

2017-11-15 Thread Eike Rathke
Hi, On Wednesday, 2017-11-15 16:10:17 +, Michael Meeks wrote: > Avoid SvTokenArray thrash > in concept ok – but need to only re-using the same type (Eike) Fwiw, all FormulaToken::Set...() virtual dummy methods now assert(), cherry-picked to feature/calc-parallel and also

[Libreoffice-commits] core.git: sc/inc sc/source

2017-11-16 Thread Eike Rathke
sc/inc/compiler.hxx |4 ++-- sc/source/core/tool/compiler.cxx | 30 +++--- sc/source/core/tool/token.cxx|4 ++-- 3 files changed, 19 insertions(+), 19 deletions(-) New commits: commit 280a5166ad4032a618c5e29db701330f7dbdfbff Author: Eike Rathke

[Libreoffice-commits] core.git: 2 commits - configure.ac download.lst external/icu i18npool/source i18nutil/source include/svl include/svx svl/source svx/source

2017-11-16 Thread Eike Rathke
| 23 ++ 18 files changed, 87 insertions(+), 335 deletions(-) New commits: commit eb8bd7f21103ed2349b44c954db977709de2e4ec Author: Eike Rathke Date: Fri Nov 17 00:16:17 2017 +0100 Resolves: tdf#113889 no date particle reordering when exporting to Excel Change-Id

[Libreoffice-commits] core.git: configure.ac download.lst external/icu i18npool/source i18nutil/source include/svx svx/source

2017-11-16 Thread Eike Rathke
/charmap.cxx | 23 -- 14 files changed, 329 insertions(+), 73 deletions(-) New commits: commit 0f73433b13ba9e3f38193ddd86f4b9b767a36bb2 Author: Eike Rathke Date: Fri Nov 17 02:24:52 2017 +0200 Revert "Upgrade to ICU 60.1" This reve

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/source

2017-11-17 Thread Eike Rathke
sc/source/filter/inc/formel.hxx | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) New commits: commit 6ba9b72cff5a761f36b2b9b892b572bc7cb5ae18 Author: Eike Rathke Date: Fri Nov 10 10:52:19 2017 +0100 ofz#4123 do not read past end of file

Re: Regarding subscription to mailing list

2017-11-17 Thread Eike Rathke
Hi Yash, On Friday, 2017-11-17 00:07:51 +0530, Yash Bansal wrote: > I am not able to subscribe to mailing list of Libre office. I have given my > email but got no response. Can anyone help me regarding this. Check your gmail account for spam/hidden mails. If nothing else helps then use another e

[Libreoffice-commits] core.git: sc/inc

2017-11-17 Thread Eike Rathke
sc/inc/compiler.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2337797936eb53ac088ad7b5243d5fd8dfbfa31e Author: Eike Rathke Date: Fri Nov 17 12:30:11 2017 +0100 coverity#1422192 include param field in string field Change-Id

Re: New Defects reported by Coverity Scan for LibreOffice

2017-11-17 Thread Eike Rathke
Hi, On Friday, 2017-11-17 11:11:07 +, scan-ad...@coverity.com wrote: > ** CID 1422192: Memory - corruptions (OVERRUN) > /sc/source/core/tool/token.cxx: 361 in ScRawToken::SetExternal(const char16_t > *)() A fallout from https://cgit.freedesktop.org/libreoffice/core/commit/?id=280a5166ad40

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/source

2017-07-06 Thread Eike Rathke
sc/source/ui/formdlg/formula.cxx | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) New commits: commit 9c9954570519f2607cf261ff19801e4a167d607b Author: Eike Rathke Date: Wed Jul 5 18:52:14 2017 +0200 Display string results in the Function Wizard quoted To

[Libreoffice-commits] core.git: sc/source

2017-07-06 Thread Eike Rathke
sc/source/core/data/document.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d5020f35aec54f0241fa58557dc6caadc149f5a9 Author: Eike Rathke Date: Thu Jul 6 17:06:14 2017 +0200 Attempt to blind fix tdf#108612 explicitly checking for clipboard document

[Libreoffice-commits] core.git: sc/source

2017-07-06 Thread Eike Rathke
sc/source/ui/app/scmod.cxx |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit 432f766892478f4693ca830e7d07bd195637fae0 Author: Eike Rathke Date: Thu Jul 6 17:26:15 2017 +0200 Assert that GetClipDoc() is indeed a clipboard document, tdf#108612 related

[Libreoffice-commits] core.git: formula/source

2017-07-10 Thread Eike Rathke
formula/source/ui/dlg/formula.cxx | 10 +- formula/source/ui/dlg/structpg.cxx | 16 +--- formula/source/ui/dlg/structpg.hxx |8 3 files changed, 18 insertions(+), 16 deletions(-) New commits: commit 5bb46252cc89b82d9579eb15068e6f01fb06f737 Author: Eike

[Libreoffice-commits] core.git: 2 commits - formula/source

2017-07-10 Thread Eike Rathke
formula/source/ui/dlg/formula.cxx | 286 ++--- formula/source/ui/dlg/structpg.cxx | 32 ++-- 2 files changed, 162 insertions(+), 156 deletions(-) New commits: commit c8c12a75d5a5cd4b191702cb12dd792c76b8f68c Author: Eike Rathke Date: Mon Jul 10 14:57:15 2017

[Libreoffice-commits] core.git: formula/source

2017-07-10 Thread Eike Rathke
formula/source/ui/dlg/formula.cxx | 184 +++--- 1 file changed, 92 insertions(+), 92 deletions(-) New commits: commit 963a49a4684d1f012c547bb7a626c394abc27dcc Author: Eike Rathke Date: Mon Jul 10 15:12:40 2017 +0200 Spaces are cheap ... and really help to

[Libreoffice-commits] core.git: 3 commits - formula/source include/formula reportdesign/source sc/source

2017-07-10 Thread Eike Rathke
/ui/formdlg/formula.cxx |7 +++ sc/source/ui/inc/formula.hxx |6 -- 7 files changed, 36 insertions(+), 14 deletions(-) New commits: commit e8fcb1fbd365b7c6104c7941abee07a612ba7813 Author: Eike Rathke Date: Mon Jul 10 20:04:08 2017 +0200 Make

[Libreoffice-commits] core.git: reportdesign/source

2017-07-11 Thread Eike Rathke
reportdesign/source/ui/inc/Formula.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4f41e8810d67bd3d82e1ff40b23a9131921674a2 Author: Eike Rathke Date: Tue Jul 11 11:21:18 2017 +0200 Add missing override Change-Id

[Libreoffice-commits] core.git: 2 commits - formula/source include/formula reportdesign/source sc/source

2017-07-11 Thread Eike Rathke
/inc/formula.hxx |1 + 6 files changed, 31 insertions(+), 4 deletions(-) New commits: commit c5cb46b45b69b03e5a6735b9c59bf686069ad401 Author: Eike Rathke Date: Tue Jul 11 16:44:40 2017 +0200 Instanciate FormulaCompiler using createCompiler() So this actually obeys

[Libreoffice-commits] core.git: 2 commits - formula/source

2017-07-11 Thread Eike Rathke
formula/source/ui/dlg/formula.cxx | 49 -- 1 file changed, 42 insertions(+), 7 deletions(-) New commits: commit e3b82542f2454a78d2013d4bbab4c801625d11da Author: Eike Rathke Date: Tue Jul 11 18:22:40 2017 +0200 Use proper non-/array context to

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - cui/source

2017-07-11 Thread Eike Rathke
cui/source/inc/backgrnd.hxx |1 + cui/source/tabpages/backgrnd.cxx | 12 ++-- 2 files changed, 7 insertions(+), 6 deletions(-) New commits: commit 1096d1c237a2c4fc7497dd073d0f62bb01ffe925 Author: Eike Rathke Date: Tue Jun 20 23:56:44 2017 +0200 Resolves: tdf#105740

[Libreoffice-commits] core.git: formula/source

2017-07-11 Thread Eike Rathke
formula/source/ui/dlg/formula.cxx | 13 + 1 file changed, 13 insertions(+) New commits: commit ebbde0b6930d2a08106953cf250bcecc3f906361 Author: Eike Rathke Date: Tue Jul 11 19:18:19 2017 +0200 Buy some newlines Author's Enter key must had been broken as well

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - 15 commits - accessibility/source connectivity/source cui/source hwpfilter/source include/sfx2 include/svx include/vcl sc/source sd/s

2017-07-12 Thread Eike Rathke
/SettingsTable.hxx |1 36 files changed, 289 insertions(+), 64 deletions(-) New commits: commit 891f6cd2008e71c9c515f2f7b3ab5f22e377b548 Author: Eike Rathke Date: Tue Jun 20 23:56:44 2017 +0200 Resolves: tdf#105740 select without selecting.. tdf#101588 b0rk The initial

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-5.3-19'

2017-07-12 Thread Eike Rathke
Tag 'cp-5.3-19' created by Andras Timar at 2017-07-12 08:56 + cp-5.3-19 Changes since cp-5.3-18-39: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listi

[Libreoffice-commits] core.git: i18nutil/source

2017-07-12 Thread Eike Rathke
i18nutil/source/utility/paper.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit d65567230f283a6ed228755a3be85e95cde2d677 Author: Eike Rathke Date: Wed Jul 12 12:56:51 2017 +0200 Turn OSL_ENSURE() into static_assert() for NUM_PAPER_ENTRIES enum match

[Libreoffice-commits] core.git: sc/source

2017-07-12 Thread Eike Rathke
sc/source/ui/src/scfuncs.src | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) New commits: commit b392208dde22edbcba36fe516ac114284a111728 Author: Eike Rathke Date: Wed Jul 12 20:35:54 2017 +0200 Eliminate trailing blanks from descriptions and some parameter names

[Libreoffice-commits] core.git: sc/source

2017-07-14 Thread Eike Rathke
sc/source/core/tool/address.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 62ee21cb463d80a28c4c41a488f85e07abafbc69 Author: Eike Rathke Date: Fri Jul 14 14:34:28 2017 +0200 Fix export test crash of ooo95715-1.xls Negative sheet number injected

Re: .src and .ui gettext migration

2017-07-14 Thread Eike Rathke
Hi Caolán, On Thursday, 2017-07-13 10:43:24 +0100, Caolán McNamara wrote: > So, I'm pretty happy with my latest iteration of migrating to gettext > and I've got it up and running on all supported platforms. First: yay \ó/ > Is there any outstanding concerns or questions. Questions: * where doe

[Libreoffice-commits] core.git: 2 commits - formula/source sc/source

2017-07-14 Thread Eike Rathke
formula/source/ui/dlg/formula.cxx | 506 ++ sc/source/core/tool/address.cxx |1 2 files changed, 253 insertions(+), 254 deletions(-) New commits: commit 34e556a97cfa3ee3cea4d393689f749e89bfbef3 Author: Eike Rathke Date: Fri Jul 14 19:33:55 2017

[Libreoffice-commits] core.git: formula/source

2017-07-14 Thread Eike Rathke
formula/source/ui/dlg/formula.cxx |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) New commits: commit d6a16aedca28ad5a907104c02174abd88fb03aed Author: Eike Rathke Date: Fri Jul 14 19:43:02 2017 +0200 Turn m_nEdFocus into local variable, it's not read else

[Libreoffice-commits] core.git: formula/source

2017-07-16 Thread Eike Rathke
formula/source/ui/dlg/formula.cxx | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) New commits: commit bf1ffc64128f5b96d7c2fcc7adc81cbc25e232fd Author: Eike Rathke Date: Sun Jul 16 15:18:09 2017 +0200 FormulaDlg_Impl::UpdateValues: evaluate in force

[Libreoffice-commits] core.git: sc/source

2017-07-17 Thread Eike Rathke
sc/source/ui/view/viewfunc.cxx | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) New commits: commit 1c1783864a356a4394f80dec28db939f4cf572cd Author: Eike Rathke Date: Mon Jul 17 11:36:29 2017 +0200 Resolves: tdf#75650 reset boolean number format to

[Libreoffice-commits] core.git: sc/source

2017-07-17 Thread Eike Rathke
sc/source/ui/view/viewfunc.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit cc6c5ae6333ccff08d0d82b36c269112cf55d89b Author: Eike Rathke Date: Mon Jul 17 12:15:47 2017 +0200 ScRange has a col,row,tab ctor, use it instead of a temporary ScAddress

[Libreoffice-commits] core.git: sc/qa sc/source

2017-07-17 Thread Eike Rathke
|3 +-- 5 files changed, 5 insertions(+), 8 deletions(-) New commits: commit fe6af0a260301f50a83c0b14a7fabad9fffe78cf Author: Eike Rathke Date: Mon Jul 17 12:30:18 2017 +0200 Temporary ScAddress is unnecessary when constructing ScRange Change-Id

[Libreoffice-commits] core.git: sc/source

2017-07-17 Thread Eike Rathke
sc/source/ui/view/viewfunc.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 89805d2846298cfa7345aef267349a42773b Author: Eike Rathke Date: Mon Jul 17 12:35:01 2017 +0200 ScAddress aPos is already available, use it Change-Id

[Libreoffice-commits] core.git: formula/source

2017-07-17 Thread Eike Rathke
formula/source/core/api/FormulaCompiler.cxx | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) New commits: commit 7232980be6a4d67ed28a21b74ef3544cacb29d6a Author: Eike Rathke Date: Mon Jul 17 20:13:07 2017 +0200 Resolves: tdf#104186 spaces between

[Libreoffice-commits] core.git: include/svl

2017-07-17 Thread Eike Rathke
include/svl/ondemand.hxx | 12 1 file changed, 8 insertions(+), 4 deletions(-) New commits: commit 21394b08475d1d869aa62c1dbb46c3dcc93ae3f0 Author: Eike Rathke Date: Mon Jul 17 21:59:38 2017 +0200 Defer also loading of the English CalendarWrapper, tdf#109045 follow-up

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - include/svl

2017-07-18 Thread Eike Rathke
include/svl/ondemand.hxx | 12 1 file changed, 8 insertions(+), 4 deletions(-) New commits: commit edc2ba3bddf2d9a4c72a4ca90579c66f229a6a47 Author: Eike Rathke Date: Mon Jul 17 21:59:38 2017 +0200 Defer also loading of the English CalendarWrapper, tdf#109045 follow-up

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4-0' - include/svl

2017-07-18 Thread Eike Rathke
include/svl/ondemand.hxx | 12 1 file changed, 8 insertions(+), 4 deletions(-) New commits: commit ee052d7fb032c2b571cdb825d4e73a3715790ef0 Author: Eike Rathke Date: Mon Jul 17 21:59:38 2017 +0200 Defer also loading of the English CalendarWrapper, tdf#109045 follow-up

[Libreoffice-commits] core.git: sc/source

2017-07-18 Thread Eike Rathke
Author: Eike Rathke Date: Tue Jul 18 13:29:12 2017 +0200 Address b0210c34dcaa5fc44956078ffa1dfe734d379224 nitpicks, tdf#43157 follow-up Change-Id: I3c70225f4d19ea85a54026e8eb78ba729acd6dfd diff --git a/sc/source/filter/dif/difexp.cxx b/sc/source/filter/dif/difexp.cxx index

[Libreoffice-commits] core.git: chart2/source cui/source editeng/source extensions/source include/svl sc/source svl/source sw/source uui/source

2017-07-18 Thread Eike Rathke
, 96 insertions(+), 101 deletions(-) New commits: commit 038063a352f59bad1ecdeeb63016e37f6945a420 Author: Eike Rathke Date: Tue Jul 18 19:43:05 2017 +0200 Change nonsense non-const Date* GetNullDate() to const Date& * first, a non-const Date* may leave the impression that one c

[Libreoffice-commits] core.git: sc/source

2017-07-18 Thread Eike Rathke
deletions(-) New commits: commit a4283e5b7b4397bfdad3605f1cd490961c28c0de Author: Eike Rathke Date: Tue Jul 18 20:10:15 2017 +0200 Eliminate some unnecessary temporary Date instances Change-Id: Idede71608458acf4d23504b3a6a1cba557f370d1 diff --git a/sc/source/core/data/dputil.cxx b

[Libreoffice-commits] core.git: basic/source chart2/source connectivity/source sc/source sc/workben

2017-07-19 Thread Eike Rathke
commits: commit 772b846c462e6465955769ed93cde046603073bb Author: Eike Rathke Date: Tue Jul 18 23:23:24 2017 +0200 Change the most obvious Date+=(long)... to Date+=static_cast(...) Simple search git grep -l 'Date.*[+-].*[(<] *long *[>)]' Since

[Libreoffice-commits] core.git: 2 commits - sc/source

2017-07-19 Thread Eike Rathke
sc/source/core/data/conditio.cxx | 60 ++- 1 file changed, 35 insertions(+), 25 deletions(-) New commits: commit 667aa6ade94a4dee441868d21db037e42c871932 Author: Eike Rathke Date: Wed Jul 19 19:10:32 2017 +0200 Avoid temporary Date and normalization

[Libreoffice-commits] core.git: sc/source

2017-07-19 Thread Eike Rathke
sc/source/ui/unoobj/filtuno.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 22ae038a56b85e86219922c2759544545f2d813d Author: Eike Rathke Date: Wed Jul 19 21:24:06 2017 +0200 Fix crash when saving new spreadsheet as dBase/.dbf, tdf#108789 follow-up

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/source

2017-07-20 Thread Eike Rathke
sc/source/ui/unoobj/filtuno.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e059303c2dc6ecac5247c315f5b452d346512c12 Author: Eike Rathke Date: Wed Jul 19 21:24:06 2017 +0200 Fix crash when saving new spreadsheet as dBase/.dbf, tdf#108789 follow-up

[Libreoffice-commits] core.git: sc/source

2017-07-20 Thread Eike Rathke
sc/source/core/data/document.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 52e09f2c03f7cc024b2973c4806283c324fc23df Author: Eike Rathke Date: Thu Jul 20 10:18:50 2017 +0200 Another attempt to blind fix tdf#108612 Oddly in that scenario on Windows there are

<    3   4   5   6   7   8   9   10   11   12   >