Re: class SdrResId never used

2013-02-18 Thread Eike Rathke
Hi Rodolfo, On Saturday, 2013-02-16 19:44:11 -0200, Rodolfo wrote: > I discovered class SdrResId is never used... Indeed, all functionality is encapsulated in svx/source/svdraw/svdetc.cxx Ditched. http://cgit.freedesktop.org/libreoffice/core/commit/?id=4090979ce0502d808b540305c89030fb9b59eeb9

[Libreoffice-commits] core.git: 7 commits - connectivity/Library_hsqldb.mk connectivity/source desktop/unx vcl/source vcl/unx

2013-02-18 Thread Eike Rathke
+++-- vcl/unx/generic/app/wmadaptor.cxx |1 6 files changed, 53 insertions(+), 36 deletions(-) New commits: commit 40dc6c3a97c9f40617e2258f0f0cf866bcb13c8a Author: Eike Rathke Date: Mon Feb 18 20:00:30 2013 +0100 added language tags comment Change-Id

[Libreoffice-commits] core.git: i18npool/source

2013-02-18 Thread Eike Rathke
i18npool/source/languagetag/languagetag.cxx | 48 +++- 1 file changed, 41 insertions(+), 7 deletions(-) New commits: commit 6c89f2e74aa9b202d6d6a41a178ba9aadb2b10e4 Author: Eike Rathke Date: Mon Feb 18 23:22:17 2013 +0100 prepare LanguageTag(rtl_Locale) for

[Libreoffice-commits] core.git: i18npool/source

2013-02-18 Thread Eike Rathke
i18npool/source/languagetag/languagetag.cxx | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) New commits: commit 2c36a832b85eeff6b4a2f6c6aab599e4b10b8886 Author: Eike Rathke Date: Tue Feb 19 00:27:04 2013 +0100 for now convert using MsLangId

[Libreoffice-commits] core.git: 2 commits - i18npool/inc i18npool/source vcl/generic

2013-02-18 Thread Eike Rathke
6e6af9943ca72f0b2b27726b7051db2ddbf378dd Author: Eike Rathke Date: Tue Feb 19 01:14:31 2013 +0100 really, don't obtain the process locale 500 times Twice for each font ... Change-Id: Ib4589f8a11e0c14f0c5235e17d0c68e67d93b0b4 diff --git a/vcl/generic/fontmanager/fontconfig.cxx b/vcl/ge

Re: [PATCH] upgrade icu to 51.1

2013-03-25 Thread Eike Rathke
Hi Peter, On Saturday, 2013-03-23 21:01:45 +, Peter Foley (via Code Review) wrote: > --- a/RepositoryExternal.mk > +++ b/RepositoryExternal.mk > @@ -1081,9 +1081,11 @@ > endif > > define gb_LinkTarget__use_icu_headers > -$(call gb_LinkTarget_use_package,$(1),icu) > +$(call gb_LinkTarget_u

[Libreoffice-commits] core.git: i18npool/source

2013-03-25 Thread Eike Rathke
i18npool/source/calendar/calendar_gregorian.cxx | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) New commits: commit 6013fe19a40dd16ce435a2428f7405b51930689e Author: Eike Rathke Date: Mon Mar 25 21:21:41 2013 +0100 resolved fdo#44286 some historical dates were

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - i18npool/source

2013-03-26 Thread Eike Rathke
i18npool/source/calendar/calendar_gregorian.cxx | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) New commits: commit 6f9b1eb8611ad706725388b15038a6673143fe34 Author: Eike Rathke Date: Mon Mar 25 21:21:41 2013 +0100 resolved fdo#44286 some historical dates were

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0-2' - i18npool/source

2013-03-26 Thread Eike Rathke
i18npool/source/calendar/calendar_gregorian.cxx | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) New commits: commit 7d7c4aa9f07e309e9185bab77a197b3dbe1f2dd1 Author: Eike Rathke Date: Mon Mar 25 21:21:41 2013 +0100 resolved fdo#44286 some historical dates were

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - i18npool/source

2013-03-26 Thread Eike Rathke
i18npool/source/calendar/calendar_gregorian.cxx | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) New commits: commit 9dfdb7955c1f5781340dc688cc0229dea9cb4c2d Author: Eike Rathke Date: Mon Mar 25 21:21:41 2013 +0100 resolved fdo#44286 some historical dates were

[Libreoffice-commits] core.git: sc/source

2013-03-26 Thread Eike Rathke
sc/source/ui/dbgui/csvgrid.cxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 58d3e62455416f4bfa71719f09dd8c3938cd8053 Author: Eike Rathke Date: Tue Mar 26 20:42:24 2013 +0100 fixed some 7d1f4cdec307bb1e761bb5dd3d8231bba5833e10 brokenness

[Libreoffice-commits] core.git: vcl/source

2013-03-26 Thread Eike Rathke
vcl/source/gdi/outdev3.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 909de9de9fce6a2e8a5c4e859038d00ce3e88c15 Author: Eike Rathke Date: Tue Mar 26 21:01:52 2013 +0100 fixed some 7d1f4cdec307bb1e761bb5dd3d8231bba5833e10 brokenness

[Libreoffice-commits] core.git: vcl/unx

2013-03-26 Thread Eike Rathke
vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit b39975bc01a7a25393ff8ee95d8c9f453d2dfdd7 Author: Eike Rathke Date: Tue Mar 26 21:21:49 2013 +0100 fixed out of bounds substring access assuming is not good

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 30/441cd652260941ade8f3e6898205ab2a1d0cdf

2013-03-26 Thread Eike Rathke
30/441cd652260941ade8f3e6898205ab2a1d0cdf |1 + 1 file changed, 1 insertion(+) New commits: commit 35453eaa913f1d5c81bf362f9405419cd095c7d8 Author: Eike Rathke Date: Tue Mar 26 21:56:05 2013 +0100 Notes added by 'git notes add' diff --git a/30/441cd652260941ade8f3e6898205

[Libreoffice-commits] core.git: 7 commits - comphelper/README i18npool/inc i18npool/qa i18npool/source

2013-03-27 Thread Eike Rathke
c3763ef570e1c6aba53bc23ba3c03429891ad473 Author: Eike Rathke Date: Wed Mar 27 20:35:43 2013 +0100 rtl::OUString to OUString Change-Id: I546132fbd8dbb621a8b436648d1e21a4dea79591 diff --git a/i18npool/inc/i18npool/mslangid.hxx b/i18npool/inc/i18npool/mslangid.hxx index 1f959ad..b3d04ec 100644 --- a/i18npool

[Libreoffice-commits] core.git: i18npool/inc i18npool/source

2013-03-27 Thread Eike Rathke
i18npool/inc/i18npool/languagetag.hxx | 40 +++ i18npool/source/languagetag/languagetag.cxx | 47 2 files changed, 87 insertions(+) New commits: commit a1554c121f5f810c77b70ece3d11522a48091d0f Author: Eike Rathke Date: Wed Mar 27 22

[Libreoffice-commits] core.git: 2 commits - i18npool/source solenv/bin

2013-03-28 Thread Eike Rathke
i18npool/source/languagetag/languagetag.cxx |6 -- solenv/bin/create-tags |2 +- 2 files changed, 5 insertions(+), 3 deletions(-) New commits: commit 4fb6281270302e26664c2aa09e63b6838dc67d87 Author: Eike Rathke Date: Thu Mar 28 13:27:42 2013 +0100

[Libreoffice-commits] core.git: 2 commits - i18npool/inc i18npool/source vcl/unx

2013-03-28 Thread Eike Rathke
0b0f22311b0cf24e795d3f8eb12f19c357485fed Author: Eike Rathke Date: Thu Mar 28 14:58:49 2013 +0100 use LanguageTag::getGlibcLocaleString() Change-Id: I86a5aad4c1a024861c82d44a3f67a2cbe00e7c2f diff --git a/vcl/unx/gtk/fpicker/SalGtkPicker.cxx b/vcl/unx/gtk/fpicker/SalGtkPicker.cxx index b4c08b5

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6-6' - i18npool/source

2013-03-28 Thread Eike Rathke
i18npool/source/calendar/calendar_gregorian.cxx | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) New commits: commit 947a54caa1bf830b986775c18d77a98482b12db4 Author: Eike Rathke Date: Mon Mar 25 21:21:41 2013 +0100 resolved fdo#44286 some historical dates were

[Libreoffice-commits] core.git: extensions/Library_updatecheckui.mk

2013-03-29 Thread Eike Rathke
extensions/Library_updatecheckui.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 3f9239e8ed7a80e88c8e436e32d704023eeb1820 Author: Eike Rathke Date: Fri Mar 29 15:13:38 2013 +0100 i18nisolang1 needed Change-Id: Id422219593b2604d441b32f55dd365840bfecbf1 diff --git

[Libreoffice-commits] core.git: vcl/generic

2013-03-30 Thread Eike Rathke
vcl/generic/fontmanager/fontmanager.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2cd4e55bb36a9a3d13971b530469188e3fb59dfe Author: Eike Rathke Date: Sat Mar 30 19:23:55 2013 +0100 certainly this was not meant to be _PC_NAME_MAX _PC_NAME_MAX is

[Libreoffice-commits] core.git: extensions/source

2013-03-30 Thread Eike Rathke
extensions/source/plugin/unx/unxmgr.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5813cb01c76404a61e3c8082630b4cfafa91de7d Author: Eike Rathke Date: Sat Mar 30 19:38:27 2013 +0100 certainly this was not meant to be _PC_NAME_MAX _PC_NAME_MAX is

Re: [Libreoffice-commits] core.git: use LanguageTag instead of comphelper::Locale

2013-04-02 Thread Eike Rathke
Hi Stephan, On Thursday, 2013-03-28 18:28:30 +0100, Stephan Bergmann wrote: > >--- a/configmgr/source/configurationprovider.cxx > >+++ b/configmgr/source/configurationprovider.cxx > >@@ -337,20 +339,10 @@ void Service::setLocale(css::lang::Locale const & > >eLocale) > >-if ( locale_ == "*" )

[Libreoffice-commits] core.git: desktop/Library_deployment.mk desktop/source

2013-04-02 Thread Eike Rathke
/source/deployment/misc/dp_resource.cxx| 21 --- desktop/source/deployment/registry/package/dp_package.cxx | 41 -- 6 files changed, 57 insertions(+), 119 deletions(-) New commits: commit da5adeada29b51dd0a65582cff9f0913e556f770 Author: Eike Rathke Date: Wed Apr 3 01:16:18 2013

[Libreoffice-commits] core.git: 5 commits - i18npool/inc i18npool/qa i18npool/source rsc/source svtools/langsupport svtools/source svx/source

2013-04-03 Thread Eike Rathke
(-) New commits: commit 1fa455b396c8d0ae1686f2f9e4c0ee04f503081f Author: Eike Rathke Date: Wed Apr 3 21:16:01 2013 +0200 ditch unused LANGUAGE_USER[1-9] Change-Id: I5a3b2b27fa2a7ad22cab2ae6d833707f9e490f27 diff --git a/i18npool/inc/i18npool/lang.h b/i18npool/inc/i18npool/lang.h index

[Libreoffice-commits] core.git: i18npool/source

2013-04-03 Thread Eike Rathke
i18npool/source/localedata/data/es_PE.xml | 36 +++--- 1 file changed, 18 insertions(+), 18 deletions(-) New commits: commit bd4b06fcd84c0f7f3ad82c1a3fe7f91740c5c3c5 Author: Eike Rathke Date: Wed Apr 3 22:47:42 2013 +0200 decimal and group separators were

[Libreoffice-commits] core.git: 2 commits - i18npool/source

2013-04-03 Thread Eike Rathke
i18npool/source/localedata/data/es_PY.xml |2 +- i18npool/source/localedata/data/es_VE.xml |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 640b57dd5fcd7aaeeb334d27fd0982bb516129a7 Author: Eike Rathke Date: Wed Apr 3 23:20:05 2013 +0200 use matching

[Libreoffice-commits] core.git: i18npool/inc

2013-04-03 Thread Eike Rathke
i18npool/inc/i18npool/mslangid.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a123975e4bfcad4f18fa4b336def8e4b8e8577b4 Author: Eike Rathke Date: Wed Apr 3 23:51:39 2013 +0200 let's try if this satisfies MSVC Chan

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - i18npool/source

2013-04-04 Thread Eike Rathke
i18npool/source/localedata/data/es_PE.xml | 36 +++--- 1 file changed, 18 insertions(+), 18 deletions(-) New commits: commit be46a7db926c281a5409dd213716fd3ade344255 Author: Eike Rathke Date: Wed Apr 3 22:47:42 2013 +0200 decimal and group separators were

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - i18npool/source

2013-04-04 Thread Eike Rathke
i18npool/source/localedata/data/es_PY.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 530de50950b5336331ce823c264eac858c53ab0d Author: Eike Rathke Date: Wed Apr 3 23:10:16 2013 +0200 use es_AR separators when using es_AR formats Noticed due to

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - i18npool/source

2013-04-04 Thread Eike Rathke
i18npool/source/localedata/data/es_VE.xml |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 668f96a802c23a81bf230d9c035254394c23545f Author: Eike Rathke Date: Wed Apr 3 23:20:05 2013 +0200 use matching separators and format codes of es_AR Noticed

[Libreoffice-commits] core.git: comphelper/Library_comphelper.mk

2013-04-04 Thread Eike Rathke
comphelper/Library_comphelper.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 1d073a3b48d2d5387992a6868dcdd601b80838b7 Author: Eike Rathke Date: Thu Apr 4 19:39:44 2013 +0200 -I$(SRCDIR)/comphelper/inc before solver/*/inc Change-Id

[Libreoffice-commits] core.git: 2 commits - i18npool/inc i18npool/qa i18npool/source svl/source

2013-04-05 Thread Eike Rathke
+ i18npool/source/languagetag/languagetag.cxx |9 +++-- svl/source/numbers/zforfind.hxx |4 7 files changed, 42 insertions(+), 8 deletions(-) New commits: commit d526e48912deeb44061ff570d715c31ca45f77b8 Author: Eike Rathke Date: Fri Apr 5 14:41:46 2013 +0200

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - svl/source

2013-04-05 Thread Eike Rathke
svl/source/numbers/zforfind.hxx |4 1 file changed, 4 insertions(+) New commits: commit ec1c30d34d9c9445ab6e22e280a9868cf910a3bc Author: Eike Rathke Date: Fri Apr 5 14:41:46 2013 +0200 resolved fdo#63161 out of bounds string access Introduced with

[Libreoffice-commits] core.git: RepositoryModule_build.mk

2013-04-05 Thread Eike Rathke
RepositoryModule_build.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 4ac1c8c369ea826809f0929c844d3c73450b9d79 Author: Eike Rathke Date: Fri Apr 5 19:42:13 2013 +0200 re-add i18npool to cross_toolset Change-Id: I8d82da2ff8ea24ffa5b68954946251e275ae5bdd diff

[Libreoffice-commits] core.git: RepositoryFixes.mk

2013-04-06 Thread Eike Rathke
RepositoryFixes.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d70e690e57397f3819e84264a7a0949e0ff8e9b2 Author: Eike Rathke Date: Sat Apr 6 12:40:27 2013 +0200 just a % missing ... Change-Id: I9fb66679725bb61ffcd5abc0f45a08e9e1960e6a diff --git

[Libreoffice-commits] core.git: 2 commits - sc/inc sc/source

2013-04-10 Thread Eike Rathke
sc/inc/addincol.hxx | 54 + sc/source/core/tool/addincol.cxx | 225 ++- 2 files changed, 136 insertions(+), 143 deletions(-) New commits: commit c979adad481bd41bff90047b1e59ce1741e642e1 Author: Eike Rathke Date: Tue Apr 9 23:37:14

[Libreoffice-commits] core.git: svl/README

2013-05-16 Thread Eike Rathke
svl/README |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit 5e9fe0ff4dfaec04ad821c4347fd8adcb5dfcb5a Author: Eike Rathke Date: Thu May 16 16:25:16 2013 +0200 some details Change-Id: I22b7bef8106dc52a5f1d393805021318ea3d9f07 diff --git a/svl

[Libreoffice-commits] core.git: include/svtools svtools/source

2013-05-16 Thread Eike Rathke
include/svtools/parhtml.hxx |2 ++ svtools/source/svhtml/parhtml.cxx | 22 ++ 2 files changed, 20 insertions(+), 4 deletions(-) New commits: commit bb7360ca9929e9b395b3c903f460c9ed5efdce4d Author: Eike Rathke Date: Thu May 16 23:53:30 2013 +0200 resolved

[Libreoffice-commits] core.git: sc/source

2013-05-16 Thread Eike Rathke
sc/source/filter/html/htmlpars.cxx | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) New commits: commit 93ceaadd6e40c458385471445e644f82815d9249 Author: Eike Rathke Date: Thu May 16 20:49:26 2013 +0200 no number format mumbo-jumbo needed on empty format

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - svtools/inc svtools/source

2013-05-17 Thread Eike Rathke
svtools/inc/svtools/parhtml.hxx |2 ++ svtools/source/svhtml/parhtml.cxx | 22 ++ 2 files changed, 20 insertions(+), 4 deletions(-) New commits: commit 2d4e570f9d6e6464cf597a1a90e84ccb3b232b5a Author: Eike Rathke Date: Thu May 16 23:53:30 2013 +0200 resolved

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - svtools/inc svtools/source

2013-05-17 Thread Eike Rathke
svtools/inc/svtools/parhtml.hxx |2 ++ svtools/source/svhtml/parhtml.cxx | 22 ++ 2 files changed, 20 insertions(+), 4 deletions(-) New commits: commit 9cedf500f2299022641bb774549a6600e1af43d1 Author: Eike Rathke Date: Thu May 16 23:53:30 2013 +0200 resolved

Re: minutes of ESC call ...

2013-05-17 Thread Eike Rathke
Hi, On Thursday, 2013-05-16 16:25:40 +0100, Michael Meeks wrote: > + double check Lionel's list-box / API change (Eike) Done. The two properties added to com.sun.star.form.component.DataBaseListBox are marked optional which doesn't harm existing clients. Eike -- LibreOffice Calc devel

[Libreoffice-commits] core.git: include/tools sc/source tools/source

2013-05-17 Thread Eike Rathke
include/tools/date.hxx |7 +++ sc/source/core/data/table4.cxx |3 +-- tools/source/datetime/tdate.cxx | 29 - 3 files changed, 28 insertions(+), 11 deletions(-) New commits: commit cd9d1bdf5e3351c929d5b651c009ee17b4d962c4 Author: Eike Rathke

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sc/source tools/inc tools/source

2013-05-17 Thread Eike Rathke
sc/source/core/data/table4.cxx |3 +-- tools/inc/tools/date.hxx|7 +++ tools/source/datetime/tdate.cxx | 29 - 3 files changed, 28 insertions(+), 11 deletions(-) New commits: commit 0b183466bcdf56c9221ab28be9c52ed8787fe4ea Author: Eike Rathke

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - sc/source tools/inc tools/source

2013-05-17 Thread Eike Rathke
sc/source/core/data/table4.cxx |3 +-- tools/inc/tools/date.hxx|7 +++ tools/source/datetime/tdate.cxx | 30 -- 3 files changed, 28 insertions(+), 12 deletions(-) New commits: commit 5e159b9834731a0282e45d8e5f5bbaedb624dc6b Author: Eike Rathke

[Libreoffice-commits] core.git: vcl/source

2013-05-17 Thread Eike Rathke
vcl/source/control/field2.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 59d6bde4045e928b5d68fb23e3340fa0e48f3e33 Author: Eike Rathke Date: Fri May 17 17:23:26 2013 +0200 obtain days in month from non-normalized date, fdo#63805 related Change-Id

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - vcl/source

2013-05-17 Thread Eike Rathke
vcl/source/control/field2.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 145d46663e2d9872b42cd7d4b8f6f76d672a883f Author: Eike Rathke Date: Fri May 17 17:23:26 2013 +0200 obtain days in month from non-normalized date, fdo#63805 related Change-Id

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - vcl/source

2013-05-17 Thread Eike Rathke
vcl/source/control/field2.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2c7f6b004cd04f427529968d004405b1a95f74bb Author: Eike Rathke Date: Fri May 17 17:23:26 2013 +0200 obtain days in month from non-normalized date, fdo#63805 related Change-Id

[Libreoffice-commits] core.git: vcl/source

2013-05-17 Thread Eike Rathke
vcl/source/control/field2.cxx | 15 +++ 1 file changed, 15 insertions(+) New commits: commit 8232eaf93f7f2837d049175a521ef05d68b12214 Author: Eike Rathke Date: Fri May 17 17:53:47 2013 +0200 ImplDateIncrementYear: handle February 29 Change-Id

[Libreoffice-commits] core.git: include/tools

2013-05-17 Thread Eike Rathke
include/tools/date.hxx | 40 ++-- 1 file changed, 34 insertions(+), 6 deletions(-) New commits: commit 3126793480c8c8759a991ff7f516ad7bf69d4ac8 Author: Eike Rathke Date: Fri May 17 18:25:32 2013 +0200 added documentation about non-normalized invalid

Re: hints asked for fdo#59727

2013-05-17 Thread Eike Rathke
Hi Winfried, On Friday, 2013-05-17 16:27:31 +0200, Winfried Donkers wrote: > >> If I understand you correctly, WEEKS in an ods should translate to > >> 'org.openoffice.weeks' when saving tp xlsx, which should be translated to > >> WEEKS when saving to ods. Am I correct? > >Yes. Respectively use

Re: [PATCH]fdo#55846 Comboboxes werent displayed in vertical toolbars

2013-05-17 Thread Eike Rathke
Hi Janit, On Wednesday, 2013-04-24 00:51:59 +0530, Janit Anjaria wrote: > I am hereby submitting my patch. Sorry, that was lingering on the list too long. I'd also suggest that you don't explicitly Cc a developer when submitting a patch on the mailing list if s/he didn't ask for it. It leaves th

Re: minutes of ESC call ...

2013-05-18 Thread Eike Rathke
Hi, On Thursday, 2013-05-16 17:55:11 +0200, Bjoern Michaelsen wrote: > > * Hamburg hack-fest (Thorsten) > AI: + connect to University of Hamburg (Eike, verbally commited to that > in a careless moment) Lol, contact initialized, Bjoern (was on Cc) will have to take over. Eike -- LibreOf

Re: moving global headers into one top-level location

2013-04-10 Thread Eike Rathke
Hi Bjoern, On Wednesday, 2013-04-10 12:59:02 +0200, Bjoern Michaelsen wrote: > > Writer has zero public headers, no code in a different module includes > > anything from sw/. there is however a distinction between headers in > > sw/inc used in all 3 "parts" of Writer (sw/source/*) vs. just one o

Re: plans with libmerged

2013-04-10 Thread Eike Rathke
Hi Peter, On Tuesday, 2013-04-09 17:29:14 -0400, Peter Foley wrote: > I was under the impression that the goal of libmerged was to eventually > include > most, if not all of the various libraries in libreoffice. > If this is incorrect, I'd like to know what libraries should and > should not be i

Re: discrepancy regarding fdo#61541

2013-04-10 Thread Eike Rathke
Hi, On Tuesday, 2013-04-09 18:05:18 +0530, Prashant Pandey wrote: > -- Forwarded message -- > From: Prashant Pandey > Date: Tue, Apr 9, 2013 at 3:27 AM > Subject: discrepancy regarding fdo#61541 > To: er...@redhat.com, michael.me...@suse.com For the records, attached is the answ

Re: moving global headers into one top-level location

2013-04-10 Thread Eike Rathke
Hi Bjoern, On Wednesday, 2013-04-10 15:40:29 +0200, Bjoern Michaelsen wrote: > - our we should introduce "submodules" properly I find submodules a nightmare to handle and the current situation with the three we have (though justified because of their optional character) is already bad enough, we

[Libreoffice-commits] core.git: unotools/source

2013-04-10 Thread Eike Rathke
unotools/source/i18n/localedatawrapper.cxx | 43 +++-- 1 file changed, 11 insertions(+), 32 deletions(-) New commits: commit a6f169433ada74a81b2e3421ea9c68a36c821fbb Author: Eike Rathke Date: Wed Apr 10 18:45:03 2013 +0200 use language tags Change-Id

[Libreoffice-commits] core.git: svtools/inc svtools/source unotools/inc unotools/source

2013-04-10 Thread Eike Rathke
+++--- 5 files changed, 13 insertions(+), 20 deletions(-) New commits: commit 0ed6aa49a88844c3da82c9d0f5b757108f3b090d Author: Eike Rathke Date: Wed Apr 10 21:24:04 2013 +0200 SvtPathOptions with LanguageTag Change-Id: I33f43c6d0249a6681d451a4be8c5548da4987f9c diff --git a

[Libreoffice-commits] core.git: sc/source

2013-04-10 Thread Eike Rathke
sc/source/core/tool/interpr1.cxx | 14 ++ sc/source/core/tool/scmatrix.cxx | 15 --- 2 files changed, 26 insertions(+), 3 deletions(-) New commits: commit 7c3ab3bc15cec211767490823539efcada4fe964 Author: Eike Rathke Date: Thu Apr 11 01:29:22 2013 +0200

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - sc/source

2013-04-10 Thread Eike Rathke
sc/source/core/tool/interpr1.cxx | 14 ++ sc/source/core/tool/scmatrix.cxx |2 +- 2 files changed, 15 insertions(+), 1 deletion(-) New commits: commit 6328c5b5b06f8c065a014b18f3c86fd8c24b91c2 Author: Eike Rathke Date: Thu Apr 11 01:29:22 2013 +0200 resolved fdo#63403 do

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sc/source

2013-04-10 Thread Eike Rathke
sc/source/core/tool/interpr1.cxx | 14 ++ sc/source/core/tool/scmatrix.cxx | 15 --- 2 files changed, 26 insertions(+), 3 deletions(-) New commits: commit 92b0c257cbe590d345adbaddbebebe95f977d8d5 Author: Eike Rathke Date: Thu Apr 11 01:29:22 2013 +0200

Re: moving global headers into one top-level location

2013-04-11 Thread Eike Rathke
Hi, On Wednesday, 2013-04-10 21:52:20 +0200, Bjoern Michaelsen wrote: > I was not suggesting "git submodules" -- keep everything in one repo, but > create some ~10 toplevel directories in which you find our current modules. My bad, I misunderstood. I plead for coining unambiguous terms :-/ * su

Re: fdo#61541: Count Number of selected Cells in calc

2013-04-11 Thread Eike Rathke
Hi Prashant, On Wednesday, 2013-04-10 04:40:31 +0530, Prashant Pandey wrote: > I was unable to push my commit to gerrit, [since i am having some ipmc and > ssh blockage problem], so I hereby attach the patch for review which solves > bug#61541-Count-Number-of-selected-Cells-in-calc ? Your patch

[Libreoffice-commits] core.git: sc/source

2013-04-11 Thread Eike Rathke
sc/source/core/data/dpoutput.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 58885eda4f15913fc46243dab726632f5904aab5 Author: Eike Rathke Date: Thu Apr 11 15:24:38 2013 +0200 prevent out of bounds vector access in ooo62493-1.xls recalculation The document

[Libreoffice-commits] core.git: sc/source

2013-04-11 Thread Eike Rathke
sc/source/core/data/dpoutput.cxx | 54 ++- 1 file changed, 42 insertions(+), 12 deletions(-) New commits: commit 8bd3be9915ff28458d010fc8f0a1a1ab66d730b0 Author: Eike Rathke Date: Thu Apr 11 16:50:15 2013 +0200 prevent vector and sequence out of

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sc/source

2013-04-11 Thread Eike Rathke
sc/source/core/data/dpoutput.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 86cb5a1d0f980633754fe250c636935c028f0f82 Author: Eike Rathke Date: Thu Apr 11 15:24:38 2013 +0200 prevent out of bounds vector access in ooo62493-1.xls recalculation The document

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - sc/source

2013-04-11 Thread Eike Rathke
sc/source/core/data/dpoutput.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 2f8b34c3777ad8ddc2eabafcbdfa6536360ab7e6 Author: Eike Rathke Date: Thu Apr 11 15:24:38 2013 +0200 prevent out of bounds vector access in ooo62493-1.xls recalculation The document

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sc/source

2013-04-11 Thread Eike Rathke
sc/source/core/data/dpoutput.cxx | 54 ++- 1 file changed, 42 insertions(+), 12 deletions(-) New commits: commit e58a8b6d7dc1b01af9f54bec8fdce718b1d8bccd Author: Eike Rathke Date: Thu Apr 11 16:50:15 2013 +0200 prevent vector and sequence out of

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - sc/source

2013-04-11 Thread Eike Rathke
sc/source/core/data/dpoutput.cxx | 54 ++- 1 file changed, 42 insertions(+), 12 deletions(-) New commits: commit 0ac18f7d54f22c0c0d40cc4b1cfe6059ef0b56c5 Author: Eike Rathke Date: Thu Apr 11 16:50:15 2013 +0200 prevent vector and sequence out of

Re: anyone else having unit test failures on master

2013-04-12 Thread Eike Rathke
Hi Noel, On Thursday, 2013-04-11 14:23:47 +0200, Noel Grandin wrote: > Now I seem to be having a reproducible failure in >make JunitTest_sw_unoapi > > It's trigger an assert in String::Len, see trace below. Presumably the underlying UniString::mpData is a dangling pointer, something called

Re: minutes of ESC call ...

2013-04-12 Thread Eike Rathke
Hi, On Thursday, 2013-04-11 18:19:08 +0100, Michael Meeks wrote: > + work on fixing automated load test issues (Kendy,Fridrich,Eike) > [ Kendy -8, Eike -2 so far ] All Calc crashers of that set seem to be fixed now. Eike -- LibreOffice Calc developer. Number formatter

[Libreoffice-commits] core.git: 4 commits - editeng/inc editeng/source sw/source

2013-04-12 Thread Eike Rathke
b88e5350ebbe5365cfd768aba0f42bc439d60898 Author: Eike Rathke Date: Fri Apr 12 20:40:05 2013 +0200 use EditView::CheckLanguage() instead of duplicated code Change-Id: I0ff75f1dc084f426846ac4f67db85a5d932d7bee diff --git a/sw/source/ui/lingu/olmenu.cxx b/sw/source/ui/lingu/olmenu.cxx index 4cd00b2

[Libreoffice-commits] core.git: editeng/source

2013-04-12 Thread Eike Rathke
editeng/source/editeng/editview.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 8e725c7fade01bdf36b11d8f313607971b826669 Author: Eike Rathke Date: Fri Apr 12 20:48:29 2013 +0200 added missing includes Change-Id: I3b77f544478ccdb166a9c7ebc82fb04458aa42df diff

[Libreoffice-commits] core.git: sc/source

2013-04-13 Thread Eike Rathke
sc/source/ui/Accessibility/AccessibleDataPilotControl.cxx | 91 +- 1 file changed, 64 insertions(+), 27 deletions(-) New commits: commit 26114dcdf9d55a5a2490de6de619337e9733b0e2 Author: Eike Rathke Date: Sat Apr 13 16:15:24 2013 +0200 resolved fdo#63421 crash in pivot table

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sc/source

2013-04-15 Thread Eike Rathke
sc/source/ui/Accessibility/AccessibleDataPilotControl.cxx | 91 +- 1 file changed, 64 insertions(+), 27 deletions(-) New commits: commit a580678e8719d08ef9355b714f840837e89bd5b3 Author: Eike Rathke Date: Sat Apr 13 16:15:24 2013 +0200 resolved fdo#63421 crash in pivot table

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - sc/source

2013-04-15 Thread Eike Rathke
sc/source/ui/Accessibility/AccessibleDataPilotControl.cxx | 91 +- 1 file changed, 64 insertions(+), 27 deletions(-) New commits: commit 1e2f42eaee187b655c06de877e7aab98a26ecc34 Author: Eike Rathke Date: Sat Apr 13 16:15:24 2013 +0200 resolved fdo#63421 crash in pivot table

Re: [Cygwin] [Master] failure when compiling liblangtag

2013-04-16 Thread Eike Rathke
Hi Mat, Cc'ing Peter Foley who did the gcc-wrapper. On Friday, 2013-04-12 23:49:16 +0200, Mat M wrote: > Command is : > C:\cygwin\opt\lo\bin\ccache.exe cl.exe -nologo -EHsc -MD -Gy > -Zc:wchar_t- -Ob1 -Oxs -Oy- -DHAVE_CONFIG_H -I. -I.. > -I../liblangtag/ -I.. -I../liblangtag/ -I.. -D__LANGTAG_CO

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - sc/source

2013-04-18 Thread Eike Rathke
sc/source/ui/condformat/condformatmgr.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit e7652ffc110f529734503621339f8a6b172be7e5 Author: Eike Rathke Date: Thu Apr 18 15:24:35 2013 +0200 resolved rhbz#918544 do not attempt to access non-existing

Re: Trying to locate who/what fixed fdo#53030

2013-04-18 Thread Eike Rathke
Hi Lior, On Wednesday, 2013-04-17 09:22:36 +0300, Lior Kaplan wrote: > Anyone ? > > On Sun, Mar 31, 2013 at 10:39 AM, Lior Kaplan wrote: > > > The good news is that fdo#53030 "Calc deletes current sheet, not > > right-clicked on sheet when trying to delete opposite directionality > > sheets" i

[Libreoffice-commits] core.git: basic/source

2013-04-18 Thread Eike Rathke
basic/source/runtime/runtime.cxx |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) New commits: commit 1ef2cce787df3d254a78ebdb469fb06668f350f4 Author: Eike Rathke Date: Thu Apr 18 22:53:00 2013 +0200 Revert "svformatter already accept OUString input",

[Libreoffice-commits] core.git: basic/source

2013-04-18 Thread Eike Rathke
basic/source/runtime/runtime.cxx | 14 +++--- basic/source/sbx/sbxdate.cxx | 12 ++-- 2 files changed, 13 insertions(+), 13 deletions(-) New commits: commit 29bfb507b39b84a788df66d91e23166a8cfa88f2 Author: Eike Rathke Date: Thu Apr 18 23:24:52 2013 +0200 get rid

[Libreoffice-commits] core.git: svl/source

2013-04-18 Thread Eike Rathke
svl/source/numbers/zforscan.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit fa72fc3eddbfabb82193452a4ba993b11d1584da Author: Eike Rathke Date: Fri Apr 19 00:47:57 2013 +0200 OUString::startsWith() is not equivalent to String::Match() String

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - basic/source

2013-04-18 Thread Eike Rathke
basic/source/runtime/runtime.cxx |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) New commits: commit f2fcd0aac530f0ff217304e1869f33d620087dff Author: Eike Rathke Date: Thu Apr 18 22:53:00 2013 +0200 Revert "svformatter already accept OUString input",

[Libreoffice-commits] core.git: editeng/inc editeng/source

2013-04-19 Thread Eike Rathke
editeng/inc/editeng/numitem.hxx |9 ++- editeng/source/items/numitem.cxx | 103 +-- 2 files changed, 104 insertions(+), 8 deletions(-) New commits: commit 721d0dfe70323d31e26394cfb32056a7ceec96c7 Author: Eike Rathke Date: Fri Apr 19 13:26:01 2013

[Libreoffice-commits] core.git: sc/source sw/source

2013-04-19 Thread Eike Rathke
sc/source/core/tool/autoform.cxx |5 - sw/source/core/doc/tblafmt.cxx |5 + 2 files changed, 9 insertions(+), 1 deletion(-) New commits: commit 8a6a940a469bac1c274b988dce713181f044d6c4 Author: Eike Rathke Date: Fri Apr 19 15:06:38 2013 +0200 just added a big red notice

Re: [PATCH] BUG#62096 Replace O(U)String compareTo with ==

2013-04-19 Thread Eike Rathke
Hi Janit, On Wednesday, 2013-04-17 00:00:39 +0530, Janit Anjaria wrote: > -if ( sInstModel.compareTo( pProps->Name ) == 0 ) > +if ( sInstModel == ( pProps->Name ) ) I'd prefer if you removed also the now extraneous parenthesis additionally to the .compareTo, so that would

Re: [PATCH] BUG#62096 Replace O(U)String compareTo with ==

2013-04-19 Thread Eike Rathke
Hi Janit, On Friday, 2013-04-19 02:09:55 +0530, Janit Anjaria wrote: > -if ( 0 == PropertyName.compareTo( FM_PROP_TEXTLINECOLOR ) ) > +if ( PropertyName == ( FM_PROP_TEXTLINECOLOR ) ) Same nitpick as in my previous mail, please remove the now extraneous () Eike -- LibreOffice Calc d

Re: [PATCH]BUG#55846 Comboboxes aren’t displayed when the toolbar is vertical

2013-04-19 Thread Eike Rathke
Hi Janit, On Wednesday, 2013-04-10 00:42:49 +0530, Janit Anjaria wrote: > I am hereby attaching my bug after making all the needed changes : I fail to see where this patch actually changes code (except two cases) and not just spacing or ordering of variables. If it was meant as an additional pat

Re: Regarding the Help for the bug

2013-04-19 Thread Eike Rathke
Hi Janit, On Wednesday, 2013-04-10 00:44:46 +0530, Janit Anjaria wrote: > I made code changes in the file svxacorr.cxx and what i did was that i > traversed the string by using *pStr(which points to the end of the string) > and henc echecked if second last character is a '.' ,in that case retur

Re: [PUSHED] BUG#62096 Replace O(U)String compareTo with ==

2013-04-19 Thread Eike Rathke
Hi Janit, On Saturday, 2013-04-20 01:17:28 +0530, Janit Anjaria wrote: > i am here by attaching my patch for fdo#62096. Thanks. Only the fmundo.cxx part applied, in the mean time the same changes were already done in fmundo.cxx Pushed http://cgit.freedesktop.org/libreoffice/core/commit/?id=f514

Re: [PUSHED] BUG#62096 Replace O(U)String compareTo with ==

2013-04-19 Thread Eike Rathke
Hi Janit, On Saturday, 2013-04-20 01:32:11 +0530, Janit Anjaria wrote: > I am hereby submitting my patches for review. Thanks. The changes to fmgridif.cxx did not apply as they were already done. I suggest you update your local repository and working tree more frequently with ./g pull -r and b

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - basic/source

2013-04-22 Thread Eike Rathke
basic/source/sbx/sbxscan.cxx | 202 +-- 1 file changed, 121 insertions(+), 81 deletions(-) New commits: commit 565c2dd3039a7c9aa1d82eadc4d5e54ea87cda9c Author: Eike Rathke Date: Tue Mar 19 23:23:16 2013 +0100 resolved rhbz#919020 Basic CDbl() and

Re: [REVIEW 4.0] fdo#40100 YEARFRAC function returns incorrect results for some dates

2013-04-22 Thread Eike Rathke
Hi Winfried, On Monday, 2013-04-22 08:00:02 +0200, Winfried Donkers wrote: > Can this fix be cherry-picked for 4.0 releases (4.0.3 would be extremely > nice)? A commit ID is usually helpful to identify the commit one wants to be reviewed.. so this is about 275e68d141179272258d03194d799495fa3dec

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0-3' - basic/source

2013-04-22 Thread Eike Rathke
basic/source/runtime/runtime.cxx |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) New commits: commit 6d9374ca1555a32b94735fc9f66589340a12407a Author: Eike Rathke Date: Thu Apr 18 22:53:00 2013 +0200 Revert "svformatter already accept OUString input",

[Libreoffice-commits] core.git: svl/source

2013-04-22 Thread Eike Rathke
svl/source/numbers/zformat.cxx | 63 ++--- 1 file changed, 40 insertions(+), 23 deletions(-) New commits: commit 5cd4300f7ffc24d6bc0ed5704f37a04852fd322b Author: Eike Rathke Date: Mon Apr 22 23:06:50 2013 +0200 fixed a mess of out of bounds string

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - svl/source

2013-04-22 Thread Eike Rathke
svl/source/numbers/zformat.cxx | 61 ++--- 1 file changed, 40 insertions(+), 21 deletions(-) New commits: commit 7ab63a1eff3ca8391dd1974cc0cf2b4c7ebb5273 Author: Eike Rathke Date: Mon Apr 22 23:06:50 2013 +0200 fixed a mess of out of bounds string

[Libreoffice-commits] core.git: svl/source

2013-04-23 Thread Eike Rathke
svl/source/numbers/zformat.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7a78461075ba4dbab803795f2cb1c7b27ca4f612 Author: Eike Rathke Date: Tue Apr 23 14:21:25 2013 +0200 eliminated another unnecessary rString.toString() Change-Id

[Libreoffice-commits] core.git: sc/source

2013-04-23 Thread Eike Rathke
sc/source/core/data/column2.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3874bad70ea48deed91b9966b3d35782b5584f7d Author: Eike Rathke Date: Tue Apr 23 18:09:43 2013 +0200 fixed out of bounds vector access in ScColumn

<    1   2   3   4   5   6   7   8   9   10   >