[Libreoffice-commits] core.git: 2 commits - sc/source

2014-04-25 Thread Eike Rathke
sc/source/core/tool/interpr1.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit ee75263f6c942c0a8f59beb84c21a98c141bc7f1 Author: Eike Rathke Date: Fri Apr 25 11:12:12 2014 +0100 we need to push a return value in any case, fdo#73148 related

[Libreoffice-commits] core.git: sc/qa

2014-04-25 Thread Eike Rathke
1652b8a552bb37524d6b5c8d65f77d28b3930ba6 Author: Eike Rathke Date: Fri Apr 25 18:10:43 2014 +0100 added .xlsx .xls .ods export/reimport tests for new spreadsheet functions Change-Id: I71baaf27a16e60eb11f80f61664fc09dcf047cf1 diff --git a/sc/qa/unit/helper/shared_test_impl.hxx b/sc/qa

upper case digits in OUString/OString::number() (was: [Libreoffice-commits] core.git: Change RGB "FFFF00" -> "ffff00" to keep roundtrip test happy)

2014-04-25 Thread Eike Rathke
Hi Stephan, On Friday, 2014-04-25 10:06:17 +0200, Stephan Bergmann wrote: > Would it be better to change > oox::drawingml::DrawingML::WriteColor(sal_uInt32, sal_Int32) > (oox/source/export/drawingml.cxx) to always write OOXML > ST_HexColorRGB values in W3C XML Schema hexBinaryCanonical form, > i.

[Libreoffice-commits] core.git: sc/qa

2014-04-28 Thread Eike Rathke
sc/qa/unit/subsequent_export-test.cxx |7 +++ 1 file changed, 7 insertions(+) New commits: commit f60d4c758ab94bfb55990ca0975de91e22f8265b Author: Eike Rathke Date: Mon Apr 28 18:11:16 2014 +0100 temporarily disable export to ODS due to derailed validator Change-Id

[Libreoffice-commits] core.git: external/icu

2014-04-29 Thread Eike Rathke
external/icu/icu4c-android.patch | 12 1 file changed, 12 deletions(-) New commits: commit f02c7cdbef595660703cce9359fe9eb71ceefacf Author: Eike Rathke Date: Tue Apr 29 20:32:17 2014 +0100 drop source/common/putilimp.h part of Android patch, fdo#77071 related ICU

[Libreoffice-commits] core.git: i18npool/source

2014-04-30 Thread Eike Rathke
i18npool/source/collator/collator_unicode.cxx | 98 -- i18npool/source/collator/gencoll_rule.cxx |2 2 files changed, 94 insertions(+), 6 deletions(-) New commits: commit a3c627fe38236e82bc6008075d862b3cbfbd9ce3 Author: Eike Rathke Date: Wed Apr 30 17:51:05

[Libreoffice-commits] core.git: i18npool/source

2014-04-30 Thread Eike Rathke
i18npool/source/collator/collator_unicode.cxx | 21 + 1 file changed, 21 insertions(+) New commits: commit dc7ba1af236ec28d399eff833d56608fde9fb70d Author: Eike Rathke Date: Wed Apr 30 19:54:04 2014 +0100 make DISABLE_DYNLOADING on Android happy, fdo#77071 related

[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sc/source

2014-04-30 Thread Eike Rathke
sc/source/ui/cctrl/checklistmenu.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 89c2637e5de1ef36858ddd84e858ea86594e5569 Author: Eike Rathke Date: Wed Apr 30 20:17:05 2014 +0100 actually both should be LIST_APPEND ... because SvTreeListBox

[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - i18npool/source

2014-05-01 Thread Eike Rathke
i18npool/source/collator/collator_unicode.cxx | 119 -- i18npool/source/collator/gencoll_rule.cxx |2 2 files changed, 115 insertions(+), 6 deletions(-) New commits: commit 1ce42d1001139a9168e9451dbd48a6daef95c691 Author: Eike Rathke Date: Wed Apr 30 17:51:05

[Libreoffice-commits] core.git: sc/source

2014-05-05 Thread Eike Rathke
sc/source/ui/docshell/docsh3.cxx |6 ++ 1 file changed, 6 insertions(+) New commits: commit 571cefca474e6b77d68f9fa31f805dcf692927fd Author: Eike Rathke Date: Mon May 5 18:18:57 2014 +0100 resolved fdo#78294 default null-date for document import is 1899-12-30 Change-Id

[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sc/source

2014-05-05 Thread Eike Rathke
sc/source/ui/docshell/docsh3.cxx |6 ++ 1 file changed, 6 insertions(+) New commits: commit 3efb6e5c35bb1129a78726b163f8fbf9bd94734a Author: Eike Rathke Date: Mon May 5 18:18:57 2014 +0100 resolved fdo#78294 default null-date for document import is 1899-12-30 Change-Id

[Libreoffice-commits] core.git: sd/source

2014-05-06 Thread Eike Rathke
sd/source/ui/docshell/docshel3.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9c66d0312f1f19b86fe3747b9c1ab6ee68b872fd Author: Eike Rathke Date: Tue May 6 14:02:08 2014 +0100 eliminate unnecessary temporary SvtLanguageTable instance Change-Id

[Libreoffice-commits] core.git: include/svtools svtools/source

2014-05-06 Thread Eike Rathke
include/svtools/langtab.hxx |2 ++ svtools/source/misc/langtab.cxx | 10 ++ 2 files changed, 12 insertions(+) New commits: commit a9ff01648ac19fa0f11ceaa2dfd2f4a475b4008c Author: Eike Rathke Date: Tue May 6 14:19:42 2014 +0100 provide static GetLanguageEntryCount() and

[Libreoffice-commits] core.git: svx/source

2014-05-06 Thread Eike Rathke
svx/source/dialog/langbox.cxx | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) New commits: commit fe3793e33af498d52f4b685bc22c426f081bd8ca Author: Eike Rathke Date: Tue May 6 14:30:07 2014 +0100 now these temporary SvtLanguageTable instances are moot Change-Id

[Libreoffice-commits] core.git: svtools/langsupport

2014-05-06 Thread Eike Rathke
svtools/langsupport/langsupport.cxx |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) New commits: commit 2d8694c2f9cef9eddeb2184b40045099dadbab90 Author: Eike Rathke Date: Tue May 6 14:36:33 2014 +0100 ditch the last temporary SvtLanguageTable instance Change-Id

[Libreoffice-commits] core.git: include/svtools

2014-05-06 Thread Eike Rathke
include/svtools/langtab.hxx | 20 1 file changed, 12 insertions(+), 8 deletions(-) New commits: commit 92e10ac194075fd0777256fa53f805581bb98931 Author: Eike Rathke Date: Tue May 6 15:34:53 2014 +0100 make all SvtLanguageTable non-static methods private

[Libreoffice-commits] core.git: include/svtools svtools/source

2014-05-06 Thread Eike Rathke
include/svtools/langtab.hxx | 19 ++- svtools/source/misc/langtab.cxx | 28 +--- 2 files changed, 23 insertions(+), 24 deletions(-) New commits: commit d80490e938ec0fcc876879a09062fccca321998e Author: Eike Rathke Date: Tue May 6 19:55:49 2014

Re: fdo77985 Calc function NETWORKDAYS

2014-05-06 Thread Eike Rathke
Hi Winfried, On Tuesday, 2014-04-29 10:26:03 +0200, Winfried Donkers wrote: > Calc function NETWORKDAYS is an add-in function and compatible with Excel's > function NETWORKDAYS, but _not_ with Oasis ODFF 1.2 > (http://docs.oasis-open.org/office/v1.2/cos01/OpenDocument-v1.2-cos01-part2.html#__Re

Re: [Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter

2011-07-20 Thread Eike Rathke
Hi Markus, On Wednesday, 2011-07-20 12:03:08 +0200, Markus Mohrhard wrote: > this patch removes the check for the upper bound of the second parameter of > TINV. I checked the algorithm of TINV but there seems to be no reason to > limit this number. > > The only problem is that for values greater

Re: [Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter

2011-07-21 Thread Eike Rathke
Hi Markus, On Wednesday, 2011-07-20 19:29:47 +0200, Markus Mohrhard wrote: > after a quick test it seems that excel allows values up to 1E10. I'm open > for suggestions but 1E5 is definitely much too low. We should choose a value > between 1E10 and 1E14 if we really want to add an upper limit. >

[Libreoffice] spurious compile errors

2011-07-21 Thread Eike Rathke
Hi, Building master on Debian Squeeze x86_64 unxlngx6.pro --with-num-cpus=2 --with-max-jobs=3 reported breakages in modules editeng and framework, unfortunately the real errors went out of sight of the scrollback buffer (I'll set that to 2000 lines..). cd'ing into the modules and running make did

Re: [Libreoffice] spurious build errors with make

2011-07-21 Thread Eike Rathke
Hi, On Thursday, 2011-07-21 14:00:26 +0200, Eike Rathke wrote: > Building master on Debian Squeeze x86_64 unxlngx6.pro --with-num-cpus=2 > --with-max-jobs=3 reported breakages in modules editeng and framework, Curious as I am ;-) I did make clean ; make and again there was a break

Re: [Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter

2011-07-22 Thread Eike Rathke
Hi Markus, On Thursday, 2011-07-21 19:54:14 +0200, Markus Mohrhard wrote: > it seems that the method is quite accurate up to 1E11 and with a bit more > difference up to 1E13 or 1E14 and above this goes badly wrong. But it > depends very much on the first paramter. Then I suggest to use the same

Re: [Libreoffice] compiling from source tarballs

2011-07-22 Thread Eike Rathke
Hi Olivier, On Friday, 2011-07-22 14:47:45 -0300, Olivier Hallot wrote: > I am behind a firewall and cannot use git directly. Corkscrew may comfort your grief.. see http://processors.wiki.ti.com/index.php?title=Git#Using_Git_Behind_a_Firewall for how to setup with git. netcat-openbsd should wor

Re: [Libreoffice] Inconsistencies in GoDownSel and GoUpSel (cell selection in Calc)

2011-07-27 Thread Eike Rathke
Hi Olivier, On Wednesday, 2011-07-27 14:50:33 -0300, Olivier Hallot wrote: > Investigating sc/sdi/cellsh.sdi > [...] > So it looks like GoDownSel has an argument "By", which seems to be "select > FN_PARAM_1 cells down", but GoUpSel (GoRightSel and GoLeftSel) does not have > this parameter. > > W

Re: [Libreoffice] Inconsistencies in GoDownSel and GoUpSel (cell selection in Calc)

2011-07-28 Thread Eike Rathke
Hi Olivier, On Wednesday, 2011-07-27 21:05:06 -0300, Olivier Hallot wrote: > I am not skilled in C++ (thanks for your patience), but scslots.hxx looks > different for GoUpSel and GoDownSel, if that matters, around the line that > starts with "73/*Offset*/" and "74/*Offset*/" The parameters are

[Libreoffice] My patches' license note

2011-07-29 Thread Eike Rathke
Hi, The following [PATCH] fix Kabyle_Algeria [kab_DZ] absent currency symbol is licensed under LGPLv3+ and MPL 1.1, as all further patches will be. Enjoy Eike ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/

[Libreoffice] [PATCH] fix Kabyle_Algeria [kab_DZ] absent currency symbol

2011-07-29 Thread Eike Rathke
* In locale data replaceTo must not be empty if replaceFrom isn't. + Also added check to locale data compiler to prevent this in future. * Fixed a currency format's group separator. * Marked LANGUAGE_USER_KABYLE (0x0659) obsolete as LANGUAGE_TAMAZIGHT_LATIN (0x085F) is used instead, actually com

Re: [Libreoffice] [PUSHED] Allow GoUpSel, GoDownSel, GoLeftsel, GoRightSel to use "By" property

2011-07-29 Thread Eike Rathke
Hi Caolán, On Friday, 2011-07-29 12:26:04 +0100, Caolán McNamara wrote: > > I left > > SID_CURSORBLKDOWN_SEL > > SID_CURSORBLKUP_SEL > > SID_CURSORBLKLEFT_SEL > > SID_CURSORBLKRIGHT_SEL > > > > untouched because repetitions makes no sense to them AFAIK > > I see that the pre-existing ::ExecuteC

Re: [Libreoffice] problems in number format dialog

2011-07-29 Thread Eike Rathke
Hi Markus, On Friday, 2011-07-29 00:54:19 +0200, Markus Mohrhard wrote: > can someone from the Thai community check whether these two patches cause > any problems. They remove some part of the bug fix for > https://bugs.freedesktop.org/show_bug.cgi?id=33089 with patch > http://cgit.freedesktop.or

Re: [Libreoffice] Ridiculous xml?

2011-07-29 Thread Eike Rathke
Hi Ryan, On Friday, 2011-07-29 11:30:43 +0100, Ryan Jendoubi wrote: > Recently noticed something very odd about the contents of > content.xml. It looks like a text span has been placed around every > individual word, with a different one around every individual space: > > text:style-name="T1">W

Re: [Libreoffice] svt::AcceleratorExecute duplication

2011-07-29 Thread Eike Rathke
Hi Kohei, On Friday, 2011-07-29 13:43:06 -0400, Kohei Yoshida wrote: > It seems that there are two places where svt::AcceleratorExecute is > implemented. One is in framework > > framework/source/accelerators/acceleratorexecute.hxx > framework/source/accelerators/acceleratorexecute.cxx > > and

Re: [Libreoffice] [PATCH] fix Kabyle_Algeria [kab_DZ] absent currency symbol

2011-07-30 Thread Eike Rathke
Hi Kohei, On Saturday, 2011-07-30 11:10:22 -0400, Kohei Yoshida wrote: > Just committed your patch to master. > > http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=2315d239302e4b2aa65971bcaf5909654973ab5e Thanks, but somehow svtools/source/misc/langtab.src is missing, only the changes

Re: [Libreoffice] problems in number format dialog

2011-07-30 Thread Eike Rathke
Hi Markus, On Friday, 2011-07-29 23:00:45 +0200, Eike Rathke wrote: > Not from the Thai community ;) but ... Good catch, though it occurs to > me that the patch cures only a symptom. I took a stab at this, the "Excel LCID removed" part may indeed be superfluous, need to step t

[Libreoffice] time flies like banana

2011-07-30 Thread Eike Rathke
Hi Alexander, On Saturday, 2011-07-30 19:45:03 +0200, Alexander Thurgood wrote: > I was going to say "Nice to see a familiar face", but the last picture I > recall seeing of you would've been in the Calc Easter Egg of the > StarOffice product way back in errr SO3 ;-) Heh :-) > which has since b

Re: [Libreoffice] [PATCH] fix Kabyle_Algeria [kab_DZ] absent currency symbol

2011-08-01 Thread Eike Rathke
Hi Michael, On Monday, 2011-08-01 10:17:24 +0100, Michael Meeks wrote: > > * In locale data replaceTo must not be empty if replaceFrom isn't. > > + Also added check to locale data compiler to prevent this in future. > > * Fixed a currency format's group separator. > > * Marked LANGUAGE_USER_KABYL

Re: [Libreoffice] problems in number format dialog

2011-08-01 Thread Eike Rathke
erred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD fdo#38956 related changes in split components repository to support LCID changes From: Eike Rathke --- cui/source/tabpages/numfmt.cxx |4 1 files changed, 4 insertions(+), 0 d

[Libreoffice] link error in comhelper with undefined references from ucbhelper

2011-08-03 Thread Eike Rathke
Hi, building master (as of this evening with origin 23f430a7dea74ee4eeb797ae5874384e34da362f in libs-gui) unxlngi6 gave a linker error in comphelper complaining about undefined references that should be provided by ucbhelper, for example ucbhelper::Content::Content() ucbhelper is built, libucbhel

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

2011-08-04 Thread Eike Rathke
Hi Caolán, On Thursday, 2011-08-04 09:19:37 +0100, Caolán McNamara wrote: > I don't think moving from dmake to gnumake should affect this. I think it did.. > I think the gnumake one gets copied out into the old solver hierarchy. > Nevertheless that's what I'd check. See how many libucbhelper4gc

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

2011-08-04 Thread Eike Rathke
Hi Caolán, On Thursday, 2011-08-04 21:22:54 +0200, Eike Rathke wrote: > > I don't think moving from dmake to gnumake should affect this. > I think it did.. > > But I was lying when I said before the symbols were there, well, they > are, but local, nm gives 't

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

2011-08-04 Thread Eike Rathke
Hi Bjoern, On Friday, 2011-08-05 00:02:53 +0200, Bjoern Michaelsen wrote: > Well, indeed gnumake should only care about the symbols marked via > UCBHELPER_DLLPUBLIC (from ucbhelper/inc/ucbhelper/ucbhelperdllapi.h) > which should expand to >__attribute__((visibility("default"))) > for linux v

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

2011-08-04 Thread Eike Rathke
Hi Bjoern, On Friday, 2011-08-05 00:02:53 +0200, Bjoern Michaelsen wrote: > UCBHELPER_DLLIMPLEMENTATION is set during the compiles. That seems to be the underlying cause: UCBHELPER_DLLIMPLEMENTATION is _not_ set during compilation, Library_ucbhelper.mk has $(eval $(call gb_Library_add_defs,ucbh

Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer

2011-08-04 Thread Eike Rathke
Hi Maciej, On Thursday, 2011-08-04 18:57:11 -0400, Kohei Yoshida wrote: > > If I see any sal_Bool (sal_True, sal_False), should I change it to > > standard bool? > > Absolutely! *But* take at least a cursory look to make sure that it is > really used as a boolean value. sal_Bool is a typedef t

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

2011-08-04 Thread Eike Rathke
Hi Bjoern, On Friday, 2011-08-05 00:49:57 +0200, Eike Rathke wrote: > note _SET_defs, so I changed that to > > $(eval $(call gb_Library_set_defs,ucbhelper,\ > $$(DEFS) \ > -DUCBHELPER_DLLIMPLEMENTATION \ > )) > > and that works. Apparently all modules newly

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

2011-08-04 Thread Eike Rathke
Hi, On Friday, 2011-08-05 01:12:03 +0200, Eike Rathke wrote: > Now I wonder whether gb_Library_add_defs was introduced newly and not > committed to solenv/gbuild/ or I should change all _add_ to _set_ and > add $$(DEFS) at all places. Mystery solved: working with stgit I forgot to inv

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

2011-08-05 Thread Eike Rathke
Hi Marc-André, On Friday, 2011-08-05 10:04:14 +0530, Marc-André Laverdière wrote: > I recall that some exploits in the past have been done by linking to a > symbol that wasn't hidden but should've... in other words the attackers > bypassed the method/function with the argument validity checks. N

Re: [Libreoffice] problems in number format dialog

2011-08-05 Thread Eike Rathke
Hi Samphan, On Monday, 2011-08-01 18:29:49 +0200, Eike Rathke wrote: > On Monday, 2011-08-01 11:54:31 +0700, Samphan Raruenrom wrote: > > We're reading this discussion and patches. > Great, could you please apply the attached patches and check if that > suits the needs of the

[Libreoffice] [REVIEW] proposing for 3-4: fix fdo#38956 [RED] and other number format prefixes lost

2011-08-05 Thread Eike Rathke
Hi, Please review and cherry-pick for 3-4 a fix for https://bugs.freedesktop.org/show_bug.cgi?id=38956 http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=fbe916fd7dc7ba22b8652bc0c5b8a0d9cb15cc9d http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=513e2e78a9bb0861064f73c17000afd7

Re: [Libreoffice] [PUSHED][REVIEW] proposing for 3-4: fix fdo#38956 [RED] and other number format prefixes lost

2011-08-05 Thread Eike Rathke
Hi Caolán, On Friday, 2011-08-05 12:20:39 +0100, Caolán McNamara wrote: > SkipNumberFormatterInStream is declared but not defined or used. Indeed, oversight in merge, removed that. Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4

[Libreoffice] [REVIEW] proposing for 3-4: fdo#39869 Fix memory exhaustion

2011-08-05 Thread Eike Rathke
Hi, Proposing to cherry-pick to 3-4: fdo#39869 Fix memory exhaustion https://bugs.freedesktop.org/show_bug.cgi?id=39869 http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=651568afad1a585c485384ab6d7b65780fb02256 Actually the bug may occur with any cell content of STRLEN_MAX (64k) charac

Re: [Libreoffice] [REVIEW] fix for fdo#39792: local range names are only written to the file if changes were made to the sheet

2011-08-06 Thread Eike Rathke
Hi Markus, On Saturday, 2011-08-06 03:51:04 +0200, Markus Mohrhard wrote: > this patch invalidates the input stream if we set the local range name. > Otherwise the changes to range names only get saved if we have some other > action that invalidated the stream. Looks good. Eike -- PGP/Open

Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1

2011-08-06 Thread Eike Rathke
Hi Maciej, On Saturday, 2011-08-06 15:32:52 +0200, Maciej Rumianowski wrote: > With this patch comes some questions: > > @@ -159,16 +159,10 @@ SvxNumberFormatShell::~SvxNumberFormatShell() > > // Hinzugefuegte Formate sind nicht gueltig: > > // => wieder entfernen: > > > > -

Re: [Libreoffice] existing clones using old system

2011-08-07 Thread Eike Rathke
Hi Jonathan, On Sunday, 2011-08-07 08:38:10 +0200, Jonathan Aquilina wrote: > Just out of curiosity those of us that have clones using the old > build system will need to re clone correct? Yes. Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C

Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1

2011-08-07 Thread Eike Rathke
Hi Maciej, On Saturday, 2011-08-06 19:59:40 +0200, Maciej Rumianowski wrote: > > > DBG_ASSERT( bFound, "Key not found" ); > > > -aDelList.Remove( nAt ); > > > +aDelList.erase( nAt ); > > > > Hmm.. I'd say the original code was wrong, when nAddKey was not foun

[Libreoffice] Build with --enable-werror

2011-08-07 Thread Eike Rathke
Hi, I'm trying to build with --enable-werror, in svtools I get /lo/core/svtools/source/misc/templatefoldercache.cxx: In member function ‘bool svt::TemplateContentEqual::operator()(const rtl::Reference&, const rtl::Reference&)’: /lo/core/svtools/source/misc/templatefoldercache.cxx:288: error: ‘

Re: [Libreoffice] Build with --enable-werror

2011-08-07 Thread Eike Rathke
Hi, On Sunday, 2011-08-07 14:23:20 +0200, Eike Rathke wrote: > I'm trying to build with --enable-werror Seems I'm hit by http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40146 Ok, I'll skip that file, wait for my new machine and install Debian wheezy that has gcc 4.6.1 Eike

Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1

2011-08-07 Thread Eike Rathke
Hi Maciej, On Sunday, 2011-08-07 17:04:49 +0200, Maciej Rumianowski wrote: > > You're right, the code is "suboptimal" ... in fact IsRemoved_Impl() > > and > > IsAdded_Impl() could also return the index of the element found so it > > wouldn't be needed to be searched again. Want to take care of it

Re: [Libreoffice] [PUSHED] Replace SvULongs with vector and code clean up part 1

2011-08-08 Thread Eike Rathke
Hi Maciej, On Sunday, 2011-08-07 17:04:49 +0200, Maciej Rumianowski wrote: > >From ba07b8f694f9736b9c43dc3f0a34d1248d8fcd77 Mon Sep 17 00:00:00 2001 > From: Maciej Rumianowski > Date: Sun, 7 Aug 2011 16:46:17 +0200 > Subject: [PATCH] Replace SvULongs with vector and code clean up > > Instead of

Re: [Libreoffice] [PUSHED] Replace SvULongs with vector and code clean up part 1

2011-08-08 Thread Eike Rathke
Hi Maciej, On Monday, 2011-08-08 11:41:20 +0200, Eike Rathke wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=c1be3dab3d37b74570b49d8534c4d2677a318286 Bad bad me, you'll also need http://cgit.freedesktop.org/libreoffice/core/commit/?id=2ccabe21ad789aa0bc2c3bd7834a1876

Re: [Libreoffice] va_start without va_end

2011-08-08 Thread Eike Rathke
Hi Julien, On Thursday, 2011-08-04 23:10:08 +0200, Julien Nabet wrote: > /libs-gui/i18npool/source/calendar/ > calendar_gregorian.cxx 62 va_start(ap, pat); > 59 static void debug_cal_msg(const char *pat, ...) > 60 { > 61 va_list ap; > 62 va_start(ap, pat); > 63

[Libreoffice] svx: successful linking of libsvxcore hides compile error

2011-08-08 Thread Eike Rathke
Hi, A very disturbing scenario: During make in svx if compiling svx/source/items/numfmtsh.cxx fails, Library/libsvxcorelo.so is still linked because it does not depend on it. So far so good, but there's no indication at the end whatsoever that something failed as the screen is filled with object f

Re: [Libreoffice] signed/unsigned comparison

2011-08-09 Thread Eike Rathke
Hi Stephan, On Tuesday, 2011-08-09 09:05:49 +0200, Stephan Bergmann wrote: > On Aug 6, 2011, at 3:32 PM, Maciej Rumianowski wrote: > >> @@ -1325,7 +1288,7 @@ String SvxNumberFormatShell::GetComment4Entry(short > >> nEntry) > >> if(nEntry < 0) > >> return String(); > >> > >> -if(

Re: [Libreoffice] [REVIEW] fix for fdo#37319: don't write invalid references to odf files

2011-08-09 Thread Eike Rathke
Hi Markus, On Tuesday, 2011-08-09 05:04:35 +0200, Markus Mohrhard wrote: > this patch removes entries like #REF! A1:A3 for named ranges when the sheet > referenced by the named range is no longer there. I didn't check lately, is the current compiler's ODFF grammar able to read a [#REF!] properly

[Libreoffice] .vimrc to compile source from within Vim

2011-08-09 Thread Eike Rathke
Hi, I took the wiki's Vim tip to build a module from within Vim and enhanced it to compile the current source file (and only that) in both, dmake and gbuild modules. If the current file is a Makefile, the entire module is built using make. If the current file is build.lst, the entire module is bui

Re: [Libreoffice] .vimrc to compile source from within Vim

2011-08-09 Thread Eike Rathke
Hi, On Tuesday, 2011-08-09 18:23:37 +0200, Eike Rathke wrote: > to compile the current source file (and only that) Hmm.. actually make continues to build if there there are more sources to compile, even if the target was given. How to make it stop after the specified target? Eike --

Re: [Libreoffice] [REVIEW] fix for fdo#37319: don't write invalid references to odf files

2011-08-10 Thread Eike Rathke
Hi, On Wednesday, 2011-08-10 01:30:06 -0400, Kohei Yoshida wrote: > $Sheet1.$A$1+$#REF!.$A$2 > > When you save this document at this point, what gets saved is > > table:expression="[$Sheet1.$A$1]+[$#REF!.$A$2]" > > The bug reported in fdo#37391 says that as of ODF 1.2 you must write > > table

Re: [Libreoffice] Does anyone use 'source_config' files for build.pl ???

2011-08-10 Thread Eike Rathke
Hi Tor, On Tuesday, 2011-08-09 22:03:46 -0600, Tor Lillqvist wrote: > deliver.pl also contains a fair amount of whatI assume is Hamburg-only > -related code. For instance the common_build and COMMON_DEST things. > Or what? Those common things are the common output directories if you build for di

Re: [Libreoffice] [PUSHED] Use STL find in SvxNumberFormatShell

2011-08-10 Thread Eike Rathke
Hi Maciej, On Wednesday, 2011-08-10 12:02:23 +0200, Maciej Rumianowski wrote: > My patch got lost on mailing list, so I am attaching it now against > actual master. Fine! Pushed to master http://cgit.freedesktop.org/libreoffice/core/commit/?id=45fdd31fb986214f1086fe548d99139204b7a460 Thanks E

Re: [Libreoffice] .vimrc to compile source from within Vim

2011-08-10 Thread Eike Rathke
Hi Bjoern, On Wednesday, 2011-08-10 00:05:40 +0200, Bjoern Michaelsen wrote: > > Hmm.. actually make continues to build if there there are more sources > > to compile, even if the target was given. How to make it stop after > > the specified target? > > does "make gb_FULLDEPS=" (setting gb_FULLD

[Libreoffice] XML pretty printer (was: Where did Setup.xcu go?)

2011-08-10 Thread Eike Rathke
Hi, On Wednesday, 2011-08-10 17:48:14 +0200, Stephan Bergmann wrote: > For performance reasons, it (like all the other xcu files, too) got > folded into a single large main.xcd. (Beware, very long lines. You > may want to pipe it through an XML pretty printer if you want to edit > it manually.)

Re: [Libreoffice] [PUSHED] Allow GoUpSel, GoDownSel, GoLeftsel, GoRightSel to use "By" property

2011-08-10 Thread Eike Rathke
Hi Kohei, On Wednesday, 2011-08-10 17:25:38 -0400, Kohei Yoshida wrote: > On Wed, 2011-08-10 at 18:06 -0300, Olivier Hallot wrote: > > I had to add this patch to prevent the table boudaries crash issue > > that raised when one use the By property for GoLeftSel and GoRightSel. > > I would put the

Re: [Libreoffice] All Sun/Oracle code upgraded to LGPLv3?

2011-08-11 Thread Eike Rathke
Hi, On Thursday, 2011-08-11 10:15:02 +0200, Thorsten Behrens wrote: > > And the libreoffice pre-commit hooks complain about that. I was > > wondering if by any chance there is a general authorisation by Sun / > > Oracle that relicenses *all* OpenOffice-related code to LGPLv3 that > > would apply

Re: [Libreoffice] Class Time and its funny ideas about time

2011-08-11 Thread Eike Rathke
Hi Lubos, On Thursday, 2011-08-11 14:43:28 +0200, Lubos Lunak wrote: > #include > ... > printf( "%d\n", Time( 25, 0, 0 ).GetHour()); > printf( "%d\n", ( Time( 1, 0, 10 ) - Time( 1, 0, 20 )).GetSec()); > > 25 > 10 > > As much as I don't like it, I can possibly see at least some reason for time

Re: [Libreoffice] [PUSHED] Allow GoUpSel, GoDownSel, GoLeftsel, GoRightSel to use "By" property

2011-08-11 Thread Eike Rathke
Hi Olivier, On Thursday, 2011-08-11 11:26:28 -0300, Olivier Hallot wrote: > I take note on the added value in optimizing code to squeeze CPU cycles. So > far I was coding caring on legibility and understandability. Bear in mind that usually micro-optimizing code isn't worth the time as modern op

Re: [Libreoffice] Class Time and its funny ideas about time

2011-08-13 Thread Eike Rathke
Hi Lubos, On Friday, 2011-08-12 20:25:26 +0200, Lubos Lunak wrote: > > 2) Why should GetSec() of a negative delta return a negative amount of > >seconds? > > I didn't say it should be negative, it just should be sane. Which in this > case should be ... uhm ... oh well, another botched API.

Re: [Libreoffice] Rebuild LO

2011-08-13 Thread Eike Rathke
Hi swagat, On Saturday, 2011-08-13 22:15:35 +0530, swagat sharma wrote: > Gives error in compiling tail_end module. > Also its says the error is because of threaded build. what is a threaded > build? Sounds like you're using make 3.81 that has problems with parallel builds where more than one ta

Re: [Libreoffice] .vimrc to compile source from within Vim

2011-08-13 Thread Eike Rathke
Hi, On Tuesday, 2011-08-09 23:56:52 +0200, Bjoern Michaelsen wrote: > http://cgit.freedesktop.org/libreoffice/contrib/dev-tools/ > is a cozy place for these. http://cgit.freedesktop.org/libreoffice/contrib/dev-tools/commit/?id=0904f09a9bcdcc30784a534b4f6a6e61ee13bd1b Eike -- PGP/OpenPGP/Gn

mail failure (was: Changing Color::IsDark() to match MS Word)

2013-03-08 Thread Eike Rathke
Hi Luke, On Friday, 2013-03-08 16:23:00 +0100, Eike Rathke wrote: > It might be because the original Return-Path header is different from > your From header and you may not have been subscribed to the list when > you sent the earlier messsage. > > Note luked@* in Return-Path vs.

[Libreoffice-commits] core.git: 3 commits - i18npool/source sw/source

2013-03-09 Thread Eike Rathke
i18npool/source/search/textsearch.cxx | 81 ++ sw/source/core/crsr/findtxt.cxx | 13 +++-- 2 files changed, 71 insertions(+), 23 deletions(-) New commits: commit ccc349d3abb70ef38cd2b7706da51b060a385908 Author: Eike Rathke Date: Sat Mar 9 18:47:29

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - c1/751ac443869698a4728811e287e22fa3143d71

2013-03-11 Thread Eike Rathke
c1/751ac443869698a4728811e287e22fa3143d71 |1 + 1 file changed, 1 insertion(+) New commits: commit 02c86ca5a4d7c36ec212890c5f3b026744e112a3 Author: Eike Rathke Date: Mon Mar 11 21:53:42 2013 +0100 Notes added by 'git notes add' diff --git a/c1/751ac443869698a4728811e287e2

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 51/bac3e464cdd4fb0afb9b7d1c2a2d7f85ec92ed

2013-03-11 Thread Eike Rathke
51/bac3e464cdd4fb0afb9b7d1c2a2d7f85ec92ed |1 + 1 file changed, 1 insertion(+) New commits: commit 9f0fa81cbdbd89928282daec07186b86ed047c29 Author: Eike Rathke Date: Mon Mar 11 22:26:10 2013 +0100 Notes added by 'git notes add' diff --git a/51/bac3e464cdd4fb0afb9b7d1c2a2d

[Libreoffice-commits] core.git: sw/source

2013-03-11 Thread Eike Rathke
sw/source/core/crsr/findtxt.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d8dcfa0e5dbecf77c4d6a8d49caf61b339cf9b43 Author: Eike Rathke Date: Mon Mar 11 22:49:54 2013 +0100 make forward replacement of $ work again, fdo#60259 related broken with

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - c1/751ac443869698a4728811e287e22fa3143d71

2013-03-12 Thread Eike Rathke
c1/751ac443869698a4728811e287e22fa3143d71 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b0cbcf28bad973b34c13e1a4ece283302173d83f Author: Eike Rathke Date: Tue Mar 12 13:01:04 2013 +0100 Notes added by 'git notes add' diff

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 51/bac3e464cdd4fb0afb9b7d1c2a2d7f85ec92ed

2013-03-12 Thread Eike Rathke
51/bac3e464cdd4fb0afb9b7d1c2a2d7f85ec92ed |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 21698f962e915d5f1d5a1f735135adc93a580bf4 Author: Eike Rathke Date: Tue Mar 12 13:01:34 2013 +0100 Notes added by 'git notes add' diff

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - i18npool/source sw/source

2013-03-12 Thread Eike Rathke
i18npool/source/search/textsearch.cxx | 99 -- sw/source/core/crsr/findtxt.cxx | 13 +++- 2 files changed, 79 insertions(+), 33 deletions(-) New commits: commit 5dd1542bb372627167b44f1b020eab5a405fa6fa Author: Eike Rathke Date: Fri Mar 8 21:36:44 2013

[Libreoffice-commits] core.git: vcl/aqua

2013-03-12 Thread Eike Rathke
vcl/aqua/source/gdi/atsui/salatsuifontutils.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit ba3f6551ce47c690267485f3f6f2b6004aae435c Author: Eike Rathke Date: Tue Mar 12 19:51:16 2013 +0100 maybe fix MacOSX build Change-Id

[Libreoffice-commits] core.git: 2 commits - i18npool/inc i18npool/source svl/source

2013-03-13 Thread Eike Rathke
dde0dcd553b676abcb41eaf3f9f1bf797907e22f Author: Eike Rathke Date: Wed Mar 13 16:41:34 2013 +0100 resolved fdo#62278 test for LanguageTag equality resolving system locale Change-Id: Ic50c6d02a3feaf72060defa50766b40b5dec1cf7 diff --git a/svl/source/numbers/zforlist.cxx b/svl/source/numbers/zforlist.cxx index c2d105d

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - i18npool/inc i18npool/source svl/source

2013-03-13 Thread Eike Rathke
1e81d7220990765c0cbc1bdede6ad96bbb399cff Author: Eike Rathke Date: Wed Mar 13 16:35:46 2013 +0100 resolved fdo#62278 test for LanguageTag equality resolving system locale added LanguageTag::equals(), fdo#62278 related (cherry picked from commit fb26196ce64979ab6dc6c82c0fbdeedb126a3433) Conflicts

Re: Pivot Table data provider extension framework (removal possibility)

2013-03-13 Thread Eike Rathke
Hi Kohei, On Tuesday, 2013-03-12 11:41:32 -0400, Kohei Yoshida wrote: > I'd like to ask whether someone actually uses this Pivot Table data > provider extension framework, because I'd like to remove this if > nobody is using it, or only few people are using it. From what I remember that can be u

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 2 commits - 80/f6af4a536a78f1dc86b4ff3d86d50191e30331

2013-03-14 Thread Eike Rathke
80/f6af4a536a78f1dc86b4ff3d86d50191e30331 |1 + 1 file changed, 1 insertion(+) New commits: commit f285e992e3b7c3d9787b20fa4344ec40996b7a02 Author: Eike Rathke Date: Thu Mar 14 12:57:14 2013 +0100 Notes added by 'git notes add' commit 2a8746773f56423ddc6b74575c50f0e6a14e7

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 69/1e2f97cbef743008b98126dbcd005838250f92

2013-03-14 Thread Eike Rathke
69/1e2f97cbef743008b98126dbcd005838250f92 |1 + 1 file changed, 1 insertion(+) New commits: commit 2dee371c28d8f4edbbfdfd1f7b3186f3143e1886 Author: Eike Rathke Date: Thu Mar 14 13:04:29 2013 +0100 Notes added by 'git notes add' diff --git a/69/1e2f97cbef743008b98126dbcd00

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 94/c9b8000518ac0e3be0396fec9d5544d51d1002

2013-03-14 Thread Eike Rathke
94/c9b8000518ac0e3be0396fec9d5544d51d1002 |1 + 1 file changed, 1 insertion(+) New commits: commit ec003f1ed9f75055fc0db39a43f0eb8a4f6817ed Author: Eike Rathke Date: Thu Mar 14 13:22:58 2013 +0100 Notes added by 'git notes add' diff --git a/94/c9b8000518ac0e3be0396fec9d55

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - a0/c83c1cf1b6ec8c3f0116315c8ab978ecf6b66f

2013-03-14 Thread Eike Rathke
a0/c83c1cf1b6ec8c3f0116315c8ab978ecf6b66f |1 + 1 file changed, 1 insertion(+) New commits: commit 8e7ba337be37769c2b82992fd2817766419858f5 Author: Eike Rathke Date: Thu Mar 14 13:52:29 2013 +0100 Notes added by 'git notes add' diff --git a/a0/c83c1cf1b6ec8c3f0116315c8ab9

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - d5/55b32ce5aff591537ef877b78e3db99c64812a

2013-03-14 Thread Eike Rathke
d5/55b32ce5aff591537ef877b78e3db99c64812a |1 + 1 file changed, 1 insertion(+) New commits: commit ed43cb09c5b1fdee4d55866c6c2adb74c73769f9 Author: Eike Rathke Date: Thu Mar 14 14:36:31 2013 +0100 Notes added by 'git notes add' diff --git a/d5/55b32ce5aff591537ef877b78e3d

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 07/2ec8831233cfd5e72eebd5afda3e25ca49d80d

2013-03-14 Thread Eike Rathke
07/2ec8831233cfd5e72eebd5afda3e25ca49d80d |1 + 1 file changed, 1 insertion(+) New commits: commit b9b21bad8121a935d4c96b36680c7b3847c9199d Author: Eike Rathke Date: Thu Mar 14 16:03:29 2013 +0100 Notes added by 'git notes add' diff --git a/07/2ec8831233cfd5e72eebd5afda3e

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - db/94cea2bfe75b1e52695a57fb98cc4b4c98b790

2013-03-14 Thread Eike Rathke
db/94cea2bfe75b1e52695a57fb98cc4b4c98b790 |1 + 1 file changed, 1 insertion(+) New commits: commit cc9a0c79f857225cc00dcf975b078c637fafd9b1 Author: Eike Rathke Date: Thu Mar 14 16:05:16 2013 +0100 Notes added by 'git notes add' diff --git a/db/94cea2bfe75b1e52695a57fb98cc

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - b9/8b9cb833e47eb27ad31ed42b394e17f9a1c4ba

2013-03-14 Thread Eike Rathke
b9/8b9cb833e47eb27ad31ed42b394e17f9a1c4ba |1 + 1 file changed, 1 insertion(+) New commits: commit cdbe803d54b7cca8b1b3739d243255189e63ce64 Author: Eike Rathke Date: Thu Mar 14 16:11:12 2013 +0100 Notes added by 'git notes add' diff --git a/b9/8b9cb833e47eb27ad31ed42b394e

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 7a/1751f37ec2203f76005b1b93ea39d5b2aba7f7

2013-03-14 Thread Eike Rathke
7a/1751f37ec2203f76005b1b93ea39d5b2aba7f7 |1 + 1 file changed, 1 insertion(+) New commits: commit ae4b0814ac12f9e903f501c27298367758e35c55 Author: Eike Rathke Date: Thu Mar 14 16:19:09 2013 +0100 Notes added by 'git notes add' diff --git a/7a/1751f37ec2203f76005b1b93ea39

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - d3/dbbeeeaaa7006e7f1bda592650957987145e6d

2013-03-14 Thread Eike Rathke
d3/dbbeeeaaa7006e7f1bda592650957987145e6d |1 + 1 file changed, 1 insertion(+) New commits: commit e26d35a13e50931cdbe53b429615387594967978 Author: Eike Rathke Date: Thu Mar 14 16:23:31 2013 +0100 Notes added by 'git notes add' diff --git a/d3/dbbeeeaaa7006e7f1bda59265095

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 23/ad78fe2d5c5c9d35e30964525b45f442458513

2013-03-14 Thread Eike Rathke
23/ad78fe2d5c5c9d35e30964525b45f442458513 |1 + 1 file changed, 1 insertion(+) New commits: commit 24eb4adf9140a5fa4762b78b09681b07f06b5909 Author: Eike Rathke Date: Thu Mar 14 17:41:36 2013 +0100 Notes added by 'git notes add' diff --git a/23/ad78fe2d5c5c9d35e30964525b45

<    1   2   3   4   5   6   7   8   9   10   >