Re: [Libreoffice] [PUSHED] RTL against comphelper

On Fri, Nov 19, 2010 at 03:23:19PM -0500, Kevin Hunter wrote: > Hullo List, > > Here's a quick RTL patch against comphelper/ . Hit some tests while > there as well. > > Kevin Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedeskt

Re: [Libreoffice] [PUSHED] RTL goodness against filters/

On Fri, Nov 19, 2010 at 03:04:52PM -0500, Kevin Hunter wrote: > Hullo List, > > Some more RTL goodness against filters/. > I corrected two obviously wrong changes: - OUString PathString=xCfgMgr->substituteVariables(OUString::createFromAscii("$(progurl)")); + OUString PathString(RTL_CONSTASCII_

Re: [Libreoffice] [PUSHED] RTL easy hack against bridges/

On Fri, Nov 19, 2010 at 10:11:49AM -0500, Kevin Hunter wrote: > Hullo List, > > A simple one against but test cases, but, as I said in the commit > message, they were in my (grep) road! > > Kevin Pushed. D. ___ LibreOffice mailing list LibreOffice@lis

Re: [Libreoffice] [PUSHED] RTL goodness against filters/

On Sat, Nov 20, 2010 at 10:17:11AM -0500, Kevin Hunter wrote: > At 2:22am -0500 Sat, 20 Nov 2010, David Tardon wrote: > >On Fri, Nov 19, 2010 at 03:04:52PM -0500, Kevin Hunter wrote: > >>Some more RTL goodness against filters/. > > > >I corrected two obviously wro

Re: [Libreoffice] Location of SfxPoolItem.Type() method

On Sun, Nov 21, 2010 at 12:21:08AM +1100, Mattias Johnsson wrote: > Hello all, > > I've been trying to fix a bug in the search and replace code, and > after a bit of hacking have discovered that in findattr.cxx there's a > function > > int CmpAttr( const SfxPoolItem& rItem1, const SfxPoolItem& rI

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for libs-core/framework

On Sun, Nov 21, 2010 at 08:39:42AM +0100, Julien Nabet wrote: > Hello, > > Here's a patch for libs-core/framework > > Julien. > (LGPLv3+ / MPL) Thanks, pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.

Re: [Libreoffice] [PUSHED] some cleanup #if 0 deletion

On Sat, Nov 20, 2010 at 11:20:34PM +0100, Pierre-André Jacquod wrote: > Hello, > was just tired to try reading code like: > #if 0 > read a lot here > #else > cool I will be compiled > #endif > > So I started to track it down systematically. Just hope I was not to > much aggressive. >

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx

On Sun, Nov 21, 2010 at 02:58:35PM +0100, Joost Eekhoorn wrote: > MPL 1.1 / GPLv3+ / LGPLv3+ > > Joost The patch contains duplicate changes for svx/source/fmcomp/fmgridif.cxx and svx/source/gengal/gengal.cxx .-) Otherwise good. D. ___ LibreOffice maili

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx

On Mon, Nov 22, 2010 at 07:37:28AM +0100, David Tardon wrote: > On Sun, Nov 21, 2010 at 02:58:35PM +0100, Joost Eekhoorn wrote: > > MPL 1.1 / GPLv3+ / LGPLv3+ > > > > Joost > > The patch contains duplicate changes for svx/source/fmcomp/fmgridif.cxx > an

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for libs-core/scripting + SAL_N_ELEMENTS (last one ?)

On Sun, Nov 21, 2010 at 04:20:26PM +0100, Julien Nabet wrote: > Hello, > > Here's a patch for libs-core/scripting + 1 patch for filter_msfilter > (I thought i did it before but i must have deleted it by mistake). > It seems, by reading the result of grep, it's the last > SAL_N_ELEMENTS macro to p

Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?

On Thu, Nov 18, 2010 at 01:08:49PM +0100, Sebastian Spaeth wrote: > On Thu, 18 Nov 2010 13:01:42 +0100, David Tardon wrote: > 1) > > one would just run build -- dbglevel=2 in the desired module similarly > > as one runs build -- debug=true today. > > 2) > > A

Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?

On Thu, Nov 18, 2010 at 01:01:42PM +0100, David Tardon wrote: > Hi all, > > currently, configuring with --enable-debug means that dbglevel is set to > 2, which in turns means that OSL_DEBUG_LEVEL is set to 2. This enables > all the OSL_ debugging stuff there is (well, maybe there

[Libreoffice] quickstarter causes crash on end of desktop session

Hi all, we have been getting quite a lot of crashes from abrt (crash catching and reporting tool) on Fedora that had been caused by XIOError. After some investigation, we have found that they are caused by quickstarter continuing to run after end of desktop session (see https://bugzilla.redhat.com

Re: [Libreoffice] quickstarter causes crash on end of desktop session

On Mon, Nov 22, 2010 at 11:45:16AM +, Michael Meeks wrote: > > On Mon, 2010-11-22 at 09:42 +, Caolán McNamara wrote: > > *I* think we should try and fix it in LibreOffice 3.3 seeing as we're > > flooded with these over in RH land. > > Agreed, if I never see the crash recovery dialog

Re: [Libreoffice] [PUSHED] Clean code at writer [source/filter/{rtf, writer, ww1}]

On Sun, Nov 21, 2010 at 09:21:37AM -0800, Kayo Hamid wrote: > One more patch to clean dead code covering files at [source/filter/]. And > have these two here in the waiting list for review: > - http://lists.freedesktop.org/archives/libreoffice/2010-November/002994.html- http://lists.freedesktop.or

Re: [Libreoffice] [PUSHED] Removed some commented out code

On Mon, Nov 22, 2010 at 06:52:47PM +0200, Timo Heino wrote: > Check attachment and comments please. (so i know can i search more these) Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailma

Re: [Libreoffice] Location of SfxPoolItem.Type() method

On Tue, Nov 23, 2010 at 04:14:01PM +1100, Mattias Johnsson wrote: > > On a semi-related note, I'm doing a lot of stepping through the search > and replace code trying to track the problem down. Because LO seems to > be compiled using -O2 and -O3, there's a lot of optimization which > means the way

Re: [Libreoffice] OSL_DEBUG_LEVEL question

On Mon, Nov 22, 2010 at 11:33:42PM +0100, Miklos Vajna wrote: > On Mon, Nov 22, 2010 at 10:38:31PM +0100, Miklos Vajna > wrote: > > Does anyone have an idea when (and why) this changed, and what's the new > > way of getting the OSL_TRACE() output? > > Oh, I guess this is related to David's recen

Re: [Libreoffice] [PUSHED] remove dead codes and undesired comments

On Tue, Nov 23, 2010 at 02:01:57PM +0900, Takeshi Abe wrote: > Hi, > > Easy Hacks on base, some of indentions are left unchanged for clarity. > Thanks! I pushed it except one hunk containing the magical word TODO :) D. ___ LibreOffice mailing list Lib

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for components/cui

On Tue, Nov 23, 2010 at 10:14:03PM +0100, Julien Nabet wrote: > Hello, > > Here's a patch for components/cui. > > I made this : > > git commit -a > git format-patch HEAD~1 > > Hope it's ok. > > > Julien. > (LGPLv3+ / MPL) Nice, pushed! D. ___ Libr

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for components

On Tue, Nov 23, 2010 at 10:44:08PM +0100, Julien Nabet wrote: > Hello, > > Here's a patch for components > > Julien. > (LGPLv3+ / MPL) I've removed the line: +m_sURL = rtl::OUString(); , as the member variable is initialized to empty string already, one commented out change and a stray } .

Re: [Libreoffice] timers in calc

On Wed, Nov 24, 2010 at 08:14:08AM +0100, Julien Nabet wrote: > Le 24/11/2010 08:11, Julien Nabet a écrit : > >Date: Tue, 23 Nov 2010 22:20:36 -0500 > >From: Kohei Yoshida > >Subject: Re: [Libreoffice] [PATCH] try to correct some timers in sc + > > question > >To:libreoffice@lists.freedesktop.o

Re: [Libreoffice] quick starter applet/systray defaults and various confusion

Yet another argument for quickstarter not being on by default is that it doesn't survive update, i.e., 1. start quickstarter 2. update OO.o (or LibO) 3. try to create new text document through quickstarter (or click on existing one, or... do whatever else) -> crash (see https://bugzilla.redhat.

Re: [Libreoffice] timers in calc

On Wed, Nov 24, 2010 at 11:37:53PM +0100, Julien Nabet wrote: > > You said that aSpellTimer is only restarted in SpellTimerHdl but i > saw line 1915 in the function IMPL_LINK( ScModule, IdleHandler, > Timer*, EMPTYARG ) > BOOL bSpell = pDoc->ContinueOnlineSpelling(); > if ( bSpell ) > aSpellTi

Re: [Libreoffice] [PUSHED] Clean code at writer [source/ui]

On Wed, Nov 24, 2010 at 12:52:19PM -0800, Kayo Hamid wrote: > Covering > source/ui/{app,cctrl,chrdlg,config,dbui,dialog,dochdll,docvw,envelp}, sending > for review. Curiously 'ui' is the most clean I have seen. > revol_ > Pushed with some changes. D. ___

Re: [Libreoffice] [PUSHED] Clean code at writer [source/ui]

On Thu, Nov 25, 2010 at 01:16:42PM -0800, Kayo Hamid wrote: > I can't see the commit at cgit, where is? I want to see the changes to > improve my skills, see the changes. What wrong I'm doing? Better, what are > wrong remove? > revol_ Sorry. Should be better now :) D. __

Re: [Libreoffice] Fwd: Extensions code cleanup with patch

On Thu, Nov 25, 2010 at 10:15:52PM +0200, Roth Robert wrote: > -- Forwarded message -- > From: Roth Robert > Date: Thu, Nov 25, 2010 at 9:27 PM > Subject: Extensions code cleanup > To: libreoffice@lists.freedesktop.org > > > Some more dead code and bogus comments removed from ext

Re: [Libreoffice] [PUSHED] cppcheck, Memory leak: fallback in shell/source/unix/misc/gnome-open-url.c

On Thu, Nov 25, 2010 at 11:30:20PM +0100, Julien Nabet wrote: > Hello, > > Here's a small patch for shell/source/unix/misc/gnome-open-url.c > > Julien. > (LGPLv3+ / MPL) > commit 6b768a031280d0c3ad23624dd3a6470c57395a56 > Author: serval > Date: Thu Nov 25 23:26:39 2010 +0100 > > correct

Re: [Libreoffice] [PUSHED] Fwd: Extensions code cleanup with patch

... add PUSHED to subject... D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Are ISC/BSD-licensed contributions acceptable?

On Thu, Nov 25, 2010 at 12:52:49PM +, Michael Meeks wrote: > > On Mon, 2010-11-22 at 09:47 +0100, Gioele Barabucci wrote: > > in bug #31633 I proposed a patch to one of the export filters. > > I've just committed it; sorry for delay. > > It's great to have you prodding at this pi

Re: [Libreoffice] [PUSHED] Remove dead codes and confusing comments

On Sat, Nov 27, 2010 at 01:56:33AM +0900, Takeshi Abe wrote: > Hi, > > More cleanup on base. > > Cheers, > -- Takeshi Abe Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/l

Re: [Libreoffice] Are ISC/BSD-licensed contributions acceptable?

On Sat, Nov 27, 2010 at 12:02:18AM +, Wols Lists wrote: > On 26/11/10 09:05, David Tardon wrote: > > I think that's not possible, because some of the filters (like > > WordprocessorML) use XSLT 2.0, which is not supported by libxslt (wasn't > > supported the la

Re: [Libreoffice] [PUSHED] Clean code at writer [source/ui]

On Fri, Nov 26, 2010 at 02:02:16PM -0800, Kayo Hamid wrote: > Covering {fldui,fmtui,frmdlg,globdoc,index,lingu,misc}, sending for review. > My patchs are ok? I see so many changes, I want to known if i'm doing > something wrong. > revol_ > > > Pushed. D. ___

Re: [Libreoffice] opening oxt from command line

On Mon, Nov 29, 2010 at 05:02:06PM -0500, Arno Teigseth wrote: > Hi > > I have > > LibreOffice 3.3.0 > > OOO330m9 (Build:1) > > libreoffice-build 3.2.99.2 > > > It hangs when I do "libreoffice extension.oxt" from the command line. No > error messages on stdout. > > Adding the extension fr

Re: [Libreoffice] [Crazy Ideas] Discuss

On Mon, Nov 29, 2010 at 08:21:08PM -0500, Kohei Yoshida wrote: > > If that's the problem, you can do it by configuring with > > --enable-debug, or if you're just building a single module you can do > > "build -- debug=t dbglevel=2" > > "build debug=t" alone should turn off compiler optimization, b

Re: [Libreoffice] [PATCH] Last patch to clean code at writer [source/ui]

I retained some hunks that IMHO have documentary value. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Last patch to clean code at writer [source/ui]

On Tue, Nov 30, 2010 at 04:46:47PM +0100, David Tardon wrote: > I retained some hunks that IMHO have documentary value. > ... and pushed the rest, too .-) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedeskt

Re: [Libreoffice] LO status bar annoyances

On Tue, Nov 30, 2010 at 11:26:54AM +0100, Sebastian Spaeth wrote: > - I have to single-click on the INSRT and STD->EXT->ADD->BLK and > language selection thingies, but to double-click on the Page 1/1 and > "Default" for something to happen. I just found out by coincidence > today that I can l

Re: [Libreoffice] [PUSHED] more SAL_N_ELEMENTS

On Fri, Dec 03, 2010 at 02:09:35AM +0100, Kenneth Venken wrote: > hey, > > more use of the SAL_N_ELEMENTS macro like replacing the > STATIC_TABLE_SIZE macro. > > -- Kenneth Noel pushed it, thanks. D. ___ LibreOffice mailing list LibreOffice@lists.free

Re: [Libreoffice] Deleting Java from Base

On Fri, Dec 03, 2010 at 02:40:07PM +0100, Christian Lohmaier wrote: > Hi Jonathan, *, > > On Fri, Dec 3, 2010 at 2:32 PM, Jonathan Aquilina > wrote: > > i was talking to kendy this morning on irc and i was told that java is > > eventually going to be phased out its a matter of porting the code fr

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

On Sun, Dec 05, 2010 at 02:09:05PM +, Christopher Backhouse wrote: > Hi, > > This is item 3.17 in the easy hacks list. > Seems to work fine here. I can turn the quickstarter on and off and > launch things from it. > > The code is simplified a little from the libegg version (partially > becaus

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

On Mon, Dec 06, 2010 at 02:08:36PM +, Michael Meeks wrote: > > On Mon, 2010-12-06 at 08:30 +0100, David Tardon wrote: > > The current impl. shutdowns LibO when desktop session is ended. Unless > > I'm missing something obvious, the new impl. cannot do that... > &

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

Hi, Michael, On Mon, Dec 06, 2010 at 03:59:17PM +, Michael Meeks wrote: > Hi David, > > On Mon, 2010-12-06 at 15:18 +0100, David Tardon wrote: > > On Mon, Dec 06, 2010 at 02:08:36PM +, Michael Meeks wrote: > > > Really ? as soon as the X server dies, we'

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

On Tue, Dec 07, 2010 at 09:34:52AM +0100, David Tardon wrote: > The problem is that SessionManagerClient is only initialized with the > first sal frame (IOW, GtkSalFrame::Show calls > SessionManagerClient::open). Obviously, if there has never been any > frame opened, which, I suppose,

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

problem with that), but there might be a cleaner solution. > What if we do this when SalSession is created? Does anyone see any problem with that approach? D. commit d1227b3d8b43ced1ef834bb00aec26a03d76c648 Author: David Tardon Date: Tue Dec 7 10:51:36 2010 +0100 initialize session clie

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

On Tue, Dec 07, 2010 at 12:39:19PM +, Michael Meeks wrote: > Hi David, > > On Tue, 2010-12-07 at 10:54 +0100, David Tardon wrote: > > > I think the simplest thing here is to run SessionManagerClient::open > > > when initializing the quickstarter (the fun

Re: [Libreoffice] libreoffice -quickstart

On Wed, Dec 08, 2010 at 02:19:02AM +0100, Miguel (ON) wrote: > Hi : ) > > I've noticed that a process is added at the startup when LibreOffice is > installed. The process is > > libreoffice -quickstart -nologo -nodefault > > and it must be removed in LibreOffice options ("enable quick start in S

Re: [Libreoffice] [PATCH] Remove DECLARE_LIST(TOXControlList, Control*)

On Sun, Dec 12, 2010 at 08:26:02PM -0800, Joseph Powers wrote: > > IMPL_LINK(SwTokenWindow, TbxFocusHdl, SwTOXEdit*, pEdit) > IMPL_LINK(SwTokenWindow, TbxFocusBtnHdl, SwTOXButton*, pBtn ) > > I played around in writer a little bit but couldn't figure out where this > code was being used. If some

[Libreoffice] what's SfxMenuControl::aHelpText good for?

Hi all, recently I've been looking at fdo#31716 and have found out that the reading of help indexes that seems to cause the slowdown serves to no purpose, because the result is then just ignored. To be more precise, the result is assigned (through SfxMenuControl::Bind) to SfxMenuControl::aHelpText

Re: [Libreoffice] Fix for pdfimport (fdo#32330) needs review

On Wed, Dec 15, 2010 at 02:36:56AM +0100, Thorsten Behrens wrote: > Hi, > > could someone quickly review attached patch - a fairly safe fix I'd > like to include in -3-3, since it quite spectacularly break graphics > on PDF import. > Hi Thorsten, looks fine to me. Simple and clear :) D. __

Re: [Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM

On Tue, Dec 14, 2010 at 11:10:07PM +0100, Julien Nabet wrote: > Hello, > > Here are patches for several directories. > I tried to correct all the createFromAscii with just a simple > string, ie "..." > here is the command i used to make the research : > grep -R 'createFromAscii[ ]*([ ]*"' * > test

Re: [Libreoffice] Failed while building module nss

On Thu, Dec 16, 2010 at 02:25:41AM +0800, imacat wrote: > Dear all, > > Hi. This is imacat from Taiwan. I try to compile LibreOffice on my > Debian Lenny 5.0.6 x86_64, gcc 4.3.2, glibc 2.7. It fails when building > module "nss": > > == > % make > Making

Re: [Libreoffice] Review needed - fix for 'wikihelp is not context sensitive'

On Wed, Dec 15, 2010 at 11:14:33PM +0100, Jan Holesovsky wrote: > Hi, > > https://bugs.freedesktop.org/show_bug.cgi?id=32338 > > Can you please review, sign-off and push the attached patch to > libreoffice-3-3? The root of the problem is that in case of the > built-in help, when a help-id is not

Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’

On Fri, Dec 17, 2010 at 02:18:04PM +0800, imacat wrote: > Dear all, > > Hi. This is imacat from Taiwan. I tried to compile LibreOffice > 3.3.0.1 on my Debian Lenny x86_64 5.0.6, gcc 4.3.2, glibc 2.7. It > failed at the "slideshow" module, and when I digged inside as suggested, > it complain

Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’

On Fri, Dec 17, 2010 at 09:27:40AM +0100, Rene Engelhard wrote: > On Fri, Dec 17, 2010 at 07:27:12AM +0100, David Tardon wrote: > > On Fri, Dec 17, 2010 at 02:18:04PM +0800, imacat wrote: > > > Dear all, > > > > > > Hi. This is imacat from Tai

Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’

On Fri, Dec 17, 2010 at 10:23:24AM +0100, Rene Engelhard wrote: > On Fri, Dec 17, 2010 at 09:27:40AM +0100, Rene Engelhard wrote: > > On Fri, Dec 17, 2010 at 07:27:12AM +0100, David Tardon wrote: > > > On Fri, Dec 17, 2010 at 02:18:04PM +0800, imacat wrote

Re: [Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for framework properties

On Sun, Dec 19, 2010 at 09:40:19AM +0100, Julien Nabet wrote: > Le 18/12/2010 13:47, Caolán McNamara a écrit : > >On Sat, 2010-12-18 at 02:41 +0100, Julien Nabet wrote: > >>Hello, > >> > >>Here is a patch for properties.h of framework > >>framework compiles ok. > >Looks good, thanks for this. Pushe

Re: [Libreoffice] [PATCH] cppcheck prefix operator in components

On Sun, Dec 26, 2010 at 01:10:29PM +0100, Julien Nabet wrote: > Hello, > > Here is a patch for cppcheck prefix operator in components > Compiling was ok > > Julien > (LGPLv3+ / MPL) Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.fre

Re: [Libreoffice] [PATCH] cppcheck cleaning in writer

On Sun, Dec 26, 2010 at 05:07:37PM +0100, Julien Nabet wrote: > Hello, > > Here is a patch for 2 memleaks + 1 assigned a value that is never used > Compiling was ok > > Julien > (LGPLv3+ / MPL) Pushed, thanks! D. ___ LibreOffice mailing list LibreOff

Re: [Libreoffice] [PATCH] code cleanup and fix typos in comments

On Sun, Dec 26, 2010 at 01:26:40AM +0900, Takeshi Abe wrote: > Hi, > > An Easy Hack at libs-core/desktop. > > Cheers, > -- Takeshi Abe Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailm

Re: [Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM in sw and toolkit

On Sat, Dec 25, 2010 at 01:17:12PM +0100, Julien Nabet wrote: > Hello, > > Here are 2 patches for RTL_CONSTASCII_USTRINGPARAM in sw and toolkit > Compiling was ok with HAVE_CXX0X forced (since I've got gcc < 4.5.1) > > Julien > (LGPLv3+ / MPL) Pushed, thanks! D.

Re: [Libreoffice] [PATCH] typo fix in helppacks.ulf

On Sun, Dec 19, 2010 at 07:59:57PM +0100, Andras Timar wrote: > Hi, > > Please review and commit. > > Thanks, > Andras Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libr

Re: [Libreoffice] [PATCH] cppcheck cleaning in svx

On Mon, Dec 27, 2010 at 10:22:19PM +0100, Julien Nabet wrote: > Hello, > > Here is a patch for cppcheck cleaning in svx > Compiling was ok > > (Sorry for the last message, i forgot to put the attachment). > > Julien > (LGPLv3+ / MPL) Pushed. D. ___ L

Re: [Libreoffice] [PATCH] [PUSHED] cppcheck cleaning in svx

___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in sw and toolkit

___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] typo fix in helppacks.ulf

___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] code cleanup and fix typos in comments

___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] cppcheck prefix operator in components

___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] cppcheck cleaning in writer

___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Updates for LightProof extension handling

On Mon, Dec 20, 2010 at 07:43:51PM +0100, Kálmán „KAMI” Szalai wrote: > Hi All, > > Following the changes introduced by OpenOffice.org 3.3 extension > handling. All extensions have to uncompressed to a folder with same name > as extension itself. > > Patch attached, > Please review it! > Looks

Re: [Libreoffice] [PATCH] [PUSHED] cppcheck cleaning in vcl

On Thu, Dec 30, 2010 at 06:43:12PM +0100, Julien Nabet wrote: > Hello, > > Here is a patch for cppcheck cleaning in vcl > Compiling was ok. > > I'm not sure if what I did about realloc pb in the file : > vcl/unx/source/gdi/xlfd_attr.cxx > was sufficient (even correct !). If Enlarge() failed, Ins

Re: [Libreoffice] [PATCH] [PUSHED] cppcheck cleaning in vcl

On Tue, Jan 04, 2011 at 08:23:36AM +0100, David Tardon wrote: > On Thu, Dec 30, 2010 at 06:43:12PM +0100, Julien Nabet wrote: > > Hello, > > > > Here is a patch for cppcheck cleaning in vcl > > Compiling was ok. > > > > I'm not sure if what I did about

Re: [Libreoffice] [PATCH] [PUSHED] new cppcheck cleaning in svx

On Fri, Dec 31, 2010 at 03:04:29PM +0100, Julien Nabet wrote: > Hello, > > Here is a new patch for cppcheck cleaning in svx > Compiling was ok > > I have no more this pb : > [./svdotxln.cxx:67]: (style) The class 'ImpSdrObjTextLink' does not > have a constructor. > > Julien > (LGPLv3+ / MPL) >

Re: [Libreoffice] Bogus comments removal from VCL Unix

On Sat, Jan 01, 2011 at 02:51:47PM +0200, Roth Robert wrote: > Patch co-licensed as usual under LGPLv3+, GPLv3+ and MPL licenses. > Patch made for the VCL directory, I think that's the libs-gui repository. > Robert Pushed, thanks! D. ___ LibreOffice mai

Re: [Libreoffice] [PATCH] CppCheck cleanliness in bootstrap

On Tue, Jan 04, 2011 at 10:41:26PM +0100, Guillaume Poussel wrote: > Hi everybody, > > I've started to look at the huge > listof "defects" that Cpp Check > show. I have corrected few things in bootstrap. > The rest should be false positive or errors in dmake/

Re: [Libreoffice] [PATCH] [PUSHED] CppCheck cleanliness in bootstrap

On Wed, Jan 05, 2011 at 09:10:51AM +0100, David Tardon wrote: > On Tue, Jan 04, 2011 at 10:41:26PM +0100, Guillaume Poussel wrote: > > Hi everybody, > > > > I've started to look at the huge > > list<http://libreoffice.boldandbusted.com/>of "defects&quo

Re: [Libreoffice] [PATCH] Remove DECLARE_LIST( EditList, AppWIn*)

On Wed, Jan 05, 2011 at 11:05:02AM +, Noel Power wrote: > Hi Joseph > On -10/01/37 20:59, Joseph Powers wrote: > >The attached patch compiles and stands up to my limited testing; however, > >it's a large patch and touches a lot of sensitive code so I want someone > >with better knowledge of

Re: [Libreoffice] [PATCH] some changes for better performance, writer.

On Tue, Jan 10, 2006 at 08:09:17PM -0300, Kayo Hamid wrote: > diff --git a/sw/source/core/access/acccell.cxx > b/sw/source/core/access/acccell.cxx > index dbd1b51..2479c5c 100644 > --- a/sw/source/core/access/acccell.cxx > +++ b/sw/source/core/access/acccell.cxx > @@ -121,7 +121,7 @@ SwAccessibleC

Re: [Libreoffice] [PATCH] some changes for better performance, writer.

On Mon, Jan 10, 2011 at 06:32:40AM +0100, David Tardon wrote: > On Tue, Jan 10, 2006 at 08:09:17PM -0300, Kayo Hamid wrote: > > diff --git a/sw/source/core/access/acccell.cxx > > b/sw/source/core/access/acccell.cxx > > index dbd1b51..2479c5c 100644 > > --- a/sw/sou

Re: [Libreoffice] segfault in libqa_unit.so test

On Fri, Jan 07, 2011 at 09:52:31AM +, Caolán McNamara wrote: > On Fri, 2011-01-07 at 03:21 +0100, Thomas Klausner wrote: > > Is that the end of the build? > > Yup, good news. > > > (Where did the nice graphics go? ;) ) > > > > Thank you! How do we continue with this? > > Well, make dev-ins

Re: [Libreoffice] [PUSHED, partial] Re: [PATCH] new cppcheck cleaning in cppu and cppuhelper + error in compilation

On Wed, Jan 12, 2011 at 01:12:19PM +, Caolán McNamara wrote: > On Tue, 2011-01-11 at 23:17 +0100, Julien Nabet wrote: > > It's better with the attachments :-) > > Hum, it all looks good except for the operator=, I mean, it compiles but > I don't think it *should* compile :-) it is changing the

Re: [Libreoffice] Debug build of sw vs system-libxml

On Thu, Jan 13, 2011 at 01:15:25AM +0100, Miklos Vajna wrote: > Hi, > > I needed the attached patch to get a debug build of the sw module. Does > it look sane and I can push it or do you have a better idea? > > The error message I get is included in the commit message. > > I put it to sw.mk afte

Re: [Libreoffice] css::table::BorderLine vs BorderLine2

On Fri, Jan 14, 2011 at 02:45:06PM +0100, Cédric Bosdonnat wrote: > Hello David, all, > > I just saw this commit: > http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=0d209ac289dd5c79da6950b4c01b0cec9b7fbe6d > > I would like to have no BorderLine object created, but only BorderLine2: >

Re: [Libreoffice] This will Blow you Away . Must Read !

On Fri, Jan 14, 2011 at 04:00:02PM -0600, Conchita Aldridge wrote: > Hi My name is Conchita > > > I am sending you this E-mail to inform you of this One–of-a-kind > > > System that is widely the fastest growing talk on the Internet. No > > > Gimmicks, No Get-rich-quick Schemes, Just a Rev

Re: [Libreoffice] [PATCH] [PUSHED] Remove some dead code

On Sun, Jan 16, 2011 at 07:28:48PM +0100, Thomas Arnhold wrote: > Removed some dead code in calc (mostly view). Pushed. Thanks for the patches! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listin

Re: [Libreoffice] [REVIEW] Sun Microsystems to TDF - fdo#31191

On Mon, Jan 17, 2011 at 12:02:46AM +0100, Rene Engelhard wrote: > Hi, > > On Sun, Jan 16, 2011 at 09:17:39PM +0100, Andras Timar wrote: > > A localizer found a reference to Sun Microsystems in a .desktop file on > > Linux. > > Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33191 > > Commit (ma

Re: [Libreoffice] [PATCH] [PUSHED] Cppcheck cleaning on oox

On Sun, Jan 16, 2011 at 10:00:47PM +0100, Julien Nabet wrote: > Hello, > > Here is a patch for some cppcheck cleaning on oox Pushed, thanks! > > In the file : > oox/source/drawingml/chart/objectformatter.cxx > in the line 930, there is this function > void EffectFormatter::convertFormatting( Pro

Re: [Libreoffice] Announce: gnumake in LibreOffice

On Mon, Jan 17, 2011 at 09:09:33AM +, Michael Meeks wrote: > Hi Jonathan, > > On Mon, 2011-01-17 at 08:20 +0100, Jonathan Aquilina wrote: > > Great work, but out of curiosity wouldn't it be better to use cmake > > instead since we are cross compiling for different platforms? > > In sho

Re: [Libreoffice] NEW [PATCH] i#116187: report left/right page margin setting ignored on Unix 64 bit

On Fri, Jan 21, 2011 at 08:25:40AM +0100, Lionel Elie Mamane wrote: > On Sat, Jan 15, 2011 at 08:00:05PM +, Caolán McNamara wrote: > > On Sat, 2011-01-15 at 05:59 +0100, Lionel Elie Mamane wrote: > >> Does not fit release blocker criteria, but would still be *very* nice > >> to have for the rel

Re: [Libreoffice] 2 questions

On Fri, Jan 21, 2011 at 08:18:45AM +0100, Julien Nabet wrote: > I try to debug the problem of the Alt key for Linux (when Alt key is > released, it opens the file menu) > I think (I'm not sure) the problem is in vcl in the unx part (since > it impacts only Linux not Windows and I don't know for Mac

Re: [Libreoffice] Break Failure with Application::ShowHelpStatusText()

On Fri, Jan 21, 2011 at 08:28:11AM -0800, Joseph Powers wrote: > It looks like this wasn't removed from some of the test code in > bootstrap/automation/util. I need to go to work and wont be back home until > late Saturday so, so I don't have time to fix. Just wanted to give someone a > heads up

Re: [Libreoffice] [PATCH] [PUSHED] ure: Some fixes to documentation (part 1)

On Sun, Jan 23, 2011 at 12:40:11PM +0200, Aurimas Fišeras wrote: > Affected folders: > offapi/com/sun/star/accessibility - offapi/com/sun/star/embed > > Fixes many spelling errors (checked with en_US spell checker). > Unifies spelling of some common words. > Replaces single quotes ('') with double

Re: [Libreoffice] [PATCH] [PUSHED] Translations of comments in writer/sw/inc

On Mon, Jan 24, 2011 at 06:51:55PM +0100, Christoph Herzog wrote: > From ac1f5f1b8160c32dffb7d05b93d8b4b4f72ffe47 Mon Sep 17 00:00:00 2001 > From: Christoph Herzog > Date: Mon, 24 Jan 2011 18:48:46 +0100 > Subject: [PATCH] Translations of comments in writer/sw/inc > Excellent! Just keep it comin

Re: [Libreoffice] [PATCH] [PUSHED] Removed unused codes and fix some typos

On Tue, Jan 25, 2011 at 05:05:43AM +0900, Takeshi Abe wrote: > Hi, > > They were in impress. > > Cheers, > -- Takeshi Abe Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/l

Re: [Libreoffice] [PATCH] [PUSHED] Translations of comments is sw/inc.

On Mon, Jan 24, 2011 at 10:26:47PM +0100, Christoph Herzog wrote: > From 5d52db1773557702eace21fab78fce4c6fe39f3c Mon Sep 17 00:00:00 2001 > From: Christoph Herzog > Date: Mon, 24 Jan 2011 22:18:42 +0100 > Subject: [PATCH] Translations of comments is sw/inc. > > patch (as always) under the LGPLv2

Re: [Libreoffice] Build issue with cppu

On Tue, Jan 25, 2011 at 11:17:26AM +0530, surensp...@gmail.com wrote: > Hi Dave, > > On Tue, Jan 25, 2011 at 10:42 AM, David Dumaresq wrote: > > > > > > I suggest you take a look at the advice under The Build Failed... What can > > I do? here, http://wiki.documentfoundation.org/Development/Nativ

Re: [Libreoffice] NEW [PATCH] i#116187: report left/right page margin setting ignored on Unix 64 bit

On Tue, Jan 25, 2011 at 10:09:43AM +0100, Cedric Bosdonnat wrote: > Hi David, > > What's the status of this patch? pushed or needs some tweaks? > Hi, AFAIK we used the original patch, i.e., casting to sal_Int32 at the place of use, for both 3-3 and 3-3-0. D. ___

Re: [Libreoffice] [Libreoffice-commits] .: vcl/source

On Tue, Jan 25, 2011 at 10:10:05AM -0500, Kevin Hunter wrote: > At 9:42am -0500 Tue, 25 Jan 2011, David Tardon wrote: > > vcl/source/fontsubset/cff.cxx |4 > > 1 file changed, 4 deletions(-) > > > >New commits: > >commit a1f7b2515a6bd09a5569735a1269a9a

Re: [Libreoffice] [PATCH] ww8: silence debug output with dbglevel=1

On Thu, Jan 27, 2011 at 01:04:00PM +0100, Miklos Vajna wrote: > Hi David, > > You recently had this dbglevel change. Here is a patch that brings the > ww8 codebase in sync with this: > > - #if OSL_DEBUG_LEVEL > 0 -> #if OSL_DEBUG_LEVEL > 1 > - OSL_TRACE() is already guarded with #if OSL_DEBUG_LEV

Re: [Libreoffice] LibreOffice and (La)Tex

On Fri, Jan 28, 2011 at 02:52:24AM +0300, Alexander wrote: > When user insert formula, LO can be use LaTeX and make vector graphics (SVG ? > Or may be EPS), > keep LaTeX source, put vector graphics in ODx and display it. This does > system-independent. > > In ODx can keep preamble and user can e

<    1   2   3   4   5   6   7   8   9   10   >