[Libreoffice-commits] core.git: download.lst external/pdfium solenv/flatpak-manifest.in

2021-05-12 Thread Miklos Vajna (via logerrit)
download.lst |4 ++-- external/pdfium/Library_pdfium.mk | 19 --- external/pdfium/README |2 ++ external/pdfium/cg-instead-of-carbon.patch.1 |3 +-- external/pdfium/inc/pch/precompiled_pdfium.hxx

[Libreoffice-commits] core.git: include/rtl

2021-05-12 Thread Stephan Bergmann (via logerrit)
include/rtl/string.hxx | 54 - 1 file changed, 45 insertions(+), 9 deletions(-) New commits: commit ad48b2b02f83eed41fb1eb8d16de7e804156fcf1 Author: Stephan Bergmann AuthorDate: Wed May 12 07:31:20 2021 +0200 Commit: Stephan Bergmann Com

[Libreoffice-commits] core.git: vcl/unx

2021-05-12 Thread Caolán McNamara (via logerrit)
vcl/unx/gtk3/gtksys.cxx | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) New commits: commit 0f76fccf16ed865c5af97082c1bc9c36eba986ad Author: Caolán McNamara AuthorDate: Tue May 11 20:08:54 2021 +0100 Commit: Caolán McNamara CommitDate: Wed May 12 09:4

[Libreoffice-commits] core.git: vcl/unx

2021-05-12 Thread Caolán McNamara (via logerrit)
vcl/unx/gtk3/gtksalmenu.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 0cf318d119682eebb655c0cbab648628dcefc1d1 Author: Caolán McNamara AuthorDate: Tue May 11 20:12:55 2021 +0100 Commit: Caolán McNamara CommitDate: Wed May 12 09:49:09 2021 +0200 gtk4: unset gtk_po

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2021-05-12 Thread Caolán McNamara (via logerrit)
vcl/inc/unx/gtk/gtkdata.hxx | 11 +++ vcl/unx/gtk3/gtkdata.cxx |7 +-- vcl/unx/gtk3/gtkinst.cxx | 30 +++--- vcl/unx/gtk3/gtkobject.cxx|6 +- vcl/unx/gtk3/gtksalmenu.cxx | 12 ++-

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2021-05-12 Thread Caolán McNamara (via logerrit)
vcl/inc/unx/gtk/gtkdata.hxx |9 +++ vcl/unx/gtk3/fpicker/SalGtkPicker.cxx | 25 +++-- vcl/unx/gtk3/gtkframe.cxx |6 -- vcl/unx/gtk3/gtkinst.cxx | 87 -- vcl/unx/gtk3/gtkobject.cxx|6 -- vcl/unx/gtk3/

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - external/pdfium

2021-05-12 Thread Andras Timar (via logerrit)
external/pdfium/AndroidNDK19.patch.1 | 16 external/pdfium/UnpackedTarball_pdfium.mk |2 ++ 2 files changed, 18 insertions(+) New commits: commit b7c967542c2d2bda4490ad021f932b0e3bdf3e3b Author: Andras Timar AuthorDate: Wed May 5 23:14:49 2021 +0200 Commit: An

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - configure.ac distro-configs/CPAndroidBranding.conf distro-configs/LibreOfficeAndroidAarch64.conf distro-configs/LibreOfficeAndroid.co

2021-05-12 Thread merttumer (via logerrit)
configure.ac |2 +- distro-configs/CPAndroidBranding.conf |1 + distro-configs/LibreOfficeAndroid.conf|1 + distro-configs/LibreOfficeAndroidAarch64.conf |1 + distro-configs/LibreOfficeAndroidX86.conf |1 + distro-configs/Li

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - configure.ac

2021-05-12 Thread Andras Timar (via logerrit)
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ebbf57c6a813942adbb736b2ba1b094b9cae6e5b Author: Andras Timar AuthorDate: Wed May 12 10:41:44 2021 +0200 Commit: Andras Timar CommitDate: Wed May 12 10:41:44 2021 +0200 Bump version to 6.4-38

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-6.4-38'

2021-05-12 Thread Andras Timar (via logerrit)
Tag 'cp-6.4-38' created by Andras Timar at 2021-05-12 08:53 + cp-6.4-38 Changes since cp-6.4-37-32: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listi

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - configure.ac

2021-05-12 Thread Andras Timar (via logerrit)
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a54519121e4cd00145933fceb1a71758d997ef6c Author: Andras Timar AuthorDate: Wed May 12 11:05:48 2021 +0200 Commit: Andras Timar CommitDate: Wed May 12 11:06:17 2021 +0200 Bump version to 6.4-39

[Libreoffice-commits] core.git: sfx2/uiconfig vcl/source

2021-05-12 Thread Gülşah Köse (via logerrit)
sfx2/uiconfig/ui/developmenttool.ui |2 +- vcl/source/window/layout.cxx|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 95a1ccff3a252315e1c2499331ded4bc2e660d54 Author: Gülşah Köse AuthorDate: Mon May 10 01:15:40 2021 +0300 Commit: Gülşah Köse

[Libreoffice-commits] core.git: include/sfx2 sfx2/source sfx2/uiconfig

2021-05-12 Thread Gülşah Köse (via logerrit)
include/sfx2/devtools/ObjectInspectorTreeHandler.hxx |5 sfx2/source/devtools/ObjectInspectorTreeHandler.cxx | 21 - sfx2/uiconfig/ui/developmenttool.ui | 359 +-- 3 files changed, 181 insertions(+), 204 deletions(-) New commits: commit db35b9086476259fa2

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sc/inc sc/qa sc/source

2021-05-12 Thread Dennis Francis (via logerrit)
sc/inc/column.hxx|1 sc/inc/document.hxx |2 sc/inc/table.hxx |2 sc/qa/unit/tiledrendering/tiledrendering.cxx |8 +- sc/source/core/data/column3.cxx | 108 ---

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sc/qa sc/source

2021-05-12 Thread Dennis Francis (via logerrit)
sc/qa/unit/tiledrendering/tiledrendering.cxx |8 +++ sc/qa/unit/ucalc.cxx | 19 +++--- sc/source/core/data/column3.cxx | 28 +++ 3 files changed, 40 insertions(+), 15 deletions(-) New commits: commit 4484ebc77acd

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sc/inc sc/source

2021-05-12 Thread Dennis Francis (via logerrit)
sc/inc/column.hxx|2 - sc/inc/document.hxx |2 - sc/inc/table.hxx |2 - sc/source/core/data/column3.cxx | 54 --- sc/source/core/data/documen3.cxx |8 ++--- sc/source/core/data/table3.cxx |4 +

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sc/qa

2021-05-12 Thread Dennis Francis (via logerrit)
sc/qa/unit/tiledrendering/tiledrendering.cxx | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) New commits: commit d8fab73e5f5ae5b53511d9e8903c6f11611803b2 Author: Dennis Francis AuthorDate: Mon May 10 20:51:12 2021 +0530 Commit: Dennis Francis CommitDate: Wed Ma

[Libreoffice-commits] core.git: toolkit/source vcl/source vcl/unx

2021-05-12 Thread Noel Grandin (via logerrit)
toolkit/source/awt/vclxwindow.cxx | 48 +- vcl/source/window/window.cxx | 11 +++- vcl/unx/gtk3/gtkframe.cxx | 10 +-- 3 files changed, 48 insertions(+), 21 deletions(-) New commits: commit 5aa60be574ece81b27c8f63e6e809871c694dba0 Aut

[Libreoffice-commits] core.git: Branch 'distro/vector/vector-7.0' - embeddedobj/CppunitTest_embeddedobj_msole.mk embeddedobj/Module_embeddedobj.mk embeddedobj/qa embeddedobj/source include/test svtool

2021-05-12 Thread Miklos Vajna (via logerrit)
embeddedobj/CppunitTest_embeddedobj_msole.mk | 48 + embeddedobj/Module_embeddedobj.mk|6 + embeddedobj/qa/cppunit/data/ole2.ole | 19 +++ embeddedobj/qa/cppunit/data/ole2.png |binary embeddedobj/qa/cppunit/data/reqif-ole2.xhtml |5 embeddedobj/qa/

[Libreoffice-commits] core.git: sw/source

2021-05-12 Thread Gülşah Köse (via logerrit)
sw/source/core/edit/edfcol.cxx | 10 -- 1 file changed, 10 deletions(-) New commits: commit b2f8032c43e298525ab7897f13baad9017a969ff Author: Gülşah Köse AuthorDate: Tue Apr 27 00:33:18 2021 +0300 Commit: Gülşah Köse CommitDate: Wed May 12 14:35:47 2021 +0200 Fix broken TO

[Libreoffice-commits] core.git: compilerplugins/clang

2021-05-12 Thread Stephan Bergmann (via logerrit)
compilerplugins/clang/buriedassign.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit 21f92ce72ada2ea92ef4997a7a0fae986f023b6c Author: Stephan Bergmann AuthorDate: Wed May 12 10:14:05 2021 +0200 Commit: Stephan Bergmann CommitDate: Wed May 12 14:36:59

[Libreoffice-commits] core.git: vcl/qa vcl/source

2021-05-12 Thread Miklos Vajna (via logerrit)
vcl/qa/cppunit/filter/ipdf/data/comment-end.pdf | 69 vcl/qa/cppunit/filter/ipdf/ipdf.cxx | 19 ++ vcl/source/filter/ipdf/pdfdocument.cxx |7 ++ 3 files changed, 94 insertions(+), 1 deletion(-) New commits: commit 6b1d5bafdc722d07d3dc49807

[Libreoffice-commits] core.git: configure.ac download.lst external/icu

2021-05-12 Thread Eike Rathke (via logerrit)
configure.ac|2 - download.lst|8 ++--- external/icu/UnpackedTarball_icu.mk |4 +- external/icu/icu4c-khmerbreakengine.patch.1 | 28 external/icu/ubsan.patch.1 | 38 ---

[Libreoffice-commits] core.git: vcl/unx

2021-05-12 Thread Caolán McNamara (via logerrit)
vcl/unx/gtk3/gtkinst.cxx | 100 ++- 1 file changed, 81 insertions(+), 19 deletions(-) New commits: commit 77cbb5b05c973323802a23c153100ef6cdb8868c Author: Caolán McNamara AuthorDate: Wed May 12 11:19:58 2021 +0100 Commit: Caolán McNamara Comm

[Libreoffice-commits] core.git: dictionaries

2021-05-12 Thread Marco Pinto (via logerrit)
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6a6225cea84b43ac0231333afbde89b399984322 Author: Marco Pinto AuthorDate: Wed May 12 14:36:01 2021 +0100 Commit: Gerrit Code Review CommitDate: Wed May 12 15:36:01 2021 +0200 Update git submodu

[Libreoffice-commits] dictionaries.git: en/changelog.txt en/description.xml en/en_AU.dic en/en_CA.dic en/en_GB.aff en/en_GB.dic en/en_US.dic en/en_ZA.aff en/en_ZA.dic en/package-description.txt en/REA

2021-05-12 Thread Marco Pinto (via logerrit)
en/README_en_AU.txt|6 en/README_en_CA.txt|6 en/README_en_GB.txt|4 en/README_en_US.txt|6 en/changelog.txt | 58 en/description.xml |2 en/en_AU.dic | 104 en/en_CA.dic | 100 en/en_GB.a

[Libreoffice-commits] core.git: chart2/source sfx2/source svx/inc sw/source

2021-05-12 Thread Noel Grandin (via logerrit)
chart2/source/controller/dialogs/DataBrowser.cxx |2 +- sfx2/source/dialog/infobar.cxx |2 +- svx/inc/galbrws2.hxx |2 +- sw/source/uibase/docvw/HeaderFooterWin.cxx |1 + sw/source/uibase/docvw/PageBreakWin.cxx |2 +-

[Libreoffice-commits] core.git: vcl/unx

2021-05-12 Thread Caolán McNamara (via logerrit)
vcl/unx/gtk3/gtkinst.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 47cb7376447b35ae6e235a147dfe558390484efb Author: Caolán McNamara AuthorDate: Wed May 12 12:54:43 2021 +0100 Commit: Caolán McNamara CommitDate: Wed May 12 15:55:02 2021 +0200 gtk4: renable provid

[Libreoffice-commits] core.git: vcl/unx

2021-05-12 Thread Caolán McNamara (via logerrit)
vcl/unx/gtk3/gtkframe.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 346abdee0c61612c2a7639a7fea28313f8a7742b Author: Caolán McNamara AuthorDate: Wed May 12 13:50:32 2021 +0100 Commit: Caolán McNamara CommitDate: Wed May 12 15:55:16 2021 +0200 gtk[3|4]: drop m_xFr

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2021-05-12 Thread Caolán McNamara (via logerrit)
vcl/inc/unx/gtk/gtkinst.hxx |2 +- vcl/unx/gtk3/gtkinst.cxx| 10 -- 2 files changed, 9 insertions(+), 3 deletions(-) New commits: commit b2fefcad3236970284e559ba8cd018511a8cacce Author: Caolán McNamara AuthorDate: Wed May 12 13:58:52 2021 +0100 Commit: Caolán McNamara

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2021-05-12 Thread Caolán McNamara (via logerrit)
vcl/inc/unx/gtk/gtkdata.hxx | 11 +++ vcl/unx/gtk3/gtkinst.cxx|4 +--- 2 files changed, 12 insertions(+), 3 deletions(-) New commits: commit 59ab855cdac009ea3b52fbdbabf110658e89c16d Author: Caolán McNamara AuthorDate: Wed May 12 14:07:12 2021 +0100 Commit: Caolán McNama

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2021-05-12 Thread Caolán McNamara (via logerrit)
vcl/inc/unx/gtk/gtkdata.hxx | 15 ++- vcl/unx/gtk3/gtkinst.cxx| 28 ++-- 2 files changed, 20 insertions(+), 23 deletions(-) New commits: commit b5c21b95e4b9801902ef9ed3464d09d70d7d1dcf Author: Caolán McNamara AuthorDate: Wed May 12 14:32:08 2021 +0

[Libreoffice-commits] core.git: sw/source

2021-05-12 Thread Bjoern Michaelsen (via logerrit)
sw/source/core/access/accnotextframe.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b0ae5fd236663f7e81af06a567ade8a2a745 Author: Bjoern Michaelsen AuthorDate: Sun May 9 01:30:40 2021 +0200 Commit: Bjoern Michaelsen CommitDate: Wed May 12 17:19:20 20

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - svl/source

2021-05-12 Thread Eike Rathke (via logerrit)
svl/source/numbers/zforfind.cxx | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) New commits: commit 88772bcf331152f24dde343ffe694c85fea8b6d3 Author: Eike Rathke AuthorDate: Mon May 10 16:51:21 2021 +0200 Commit: Caolán McNamara CommitDate: Wed May 1

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2021-05-12 Thread Caolán McNamara (via logerrit)
vcl/inc/unx/gtk/gtkdata.hxx |6 ++ vcl/unx/gtk3/gtkframe.cxx |5 - vcl/unx/gtk3/gtkinst.cxx| 25 +++-- vcl/unx/gtk3/gtkobject.cxx |2 +- vcl/unx/gtk3/gtksalmenu.cxx |6 +- 5 files changed, 19 insertions(+), 25 deletions(-) New commits: comm

[Libreoffice-commits] core.git: chart2/source

2021-05-12 Thread Noel Grandin (via logerrit)
chart2/source/view/main/ChartItemPool.cxx | 25 + 1 file changed, 25 insertions(+) New commits: commit f02a56b0f2a66b583e52dd91b548c666b3d4693c Author: Noel Grandin AuthorDate: Wed May 12 13:30:57 2021 +0200 Commit: Stephan Bergmann CommitDate: Wed May 12 17:44

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sw/source

2021-05-12 Thread Bjoern Michaelsen (via logerrit)
sw/source/core/access/accnotextframe.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b129ce4426d460963ace6c9e69c4b44e2a3615c2 Author: Bjoern Michaelsen AuthorDate: Sun May 9 01:30:40 2021 +0200 Commit: Caolán McNamara CommitDate: Wed May 12 18:34:22 2021

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sw/source

2021-05-12 Thread Mike Kaganski (via logerrit)
sw/source/uibase/uiview/view.cxx |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit 4c9e939eb5f994c63c71fb6cc70d8868e0499060 Author: Mike Kaganski AuthorDate: Tue May 11 20:58:50 2021 +0200 Commit: Mike Kaganski CommitDate: Wed May 12 18:53:19 2021 +0200

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

2021-05-12 Thread Michael Stahl (via logerrit)
sw/inc/unosett.hxx |5 +-- sw/qa/extras/unowriter/unowriter.cxx | 33 + sw/source/core/unocore/unosett.cxx | 22 -- sw/source/uibase/config/StoredChapterNumbering.cxx |2 - 4 files changed, 51

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/source

2021-05-12 Thread Mike Kaganski (via logerrit)
sc/source/ui/view/tabview3.cxx | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) New commits: commit 93e031dced1ea68c4bbd93cceb9e31ba9e0b3a3f Author: Mike Kaganski AuthorDate: Tue May 11 21:03:19 2021 +0200 Commit: Mike Kaganski CommitDate: Wed May 12 19:21:56 2021 +020

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - chart2/source sfx2/source svx/inc

2021-05-12 Thread Noel Grandin (via logerrit)
chart2/source/controller/dialogs/DataBrowser.cxx |2 +- sfx2/source/dialog/infobar.cxx |2 +- svx/inc/galbrws2.hxx |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit a5041c9102e41f9ec73d991686036eeeff200187 Author:

[Libreoffice-commits] core.git: accessibility/source basctl/source chart2/source dbaccess/source extensions/source forms/source include/vcl sc/source sd/source sfx2/source sw/source toolkit/inc toolki

2021-05-12 Thread Noel Grandin (via logerrit)
accessibility/source/extended/accessibletabbar.cxx |2 accessibility/source/standard/accessiblemenucomponent.cxx|2 basctl/source/accessibility/accessibledialogcontrolshape.cxx |2 basctl/source/accessibility/accessibledialogwindow.cxx |2 basctl/source/basi

[Libreoffice-commits] core.git: sc/qa

2021-05-12 Thread Xisco Fauli (via logerrit)
sc/qa/unit/ucalc.cxx | 125 +-- sc/qa/unit/ucalc_formula.cxx | 58 ++- sc/qa/unit/ucalc_sort.cxx| 14 +++- 3 files changed, 183 insertions(+), 14 deletions(-) New commits: commit 145b2d8ee131dca592a41f7b26341a542a23845b Auth

[Libreoffice-commits] core.git: emfio/qa emfio/source

2021-05-12 Thread Bartosz Kosiorek (via logerrit)
emfio/qa/cppunit/emf/EmfImportTest.cxx | 24 emfio/qa/cppunit/emf/data/TestPolyLineWidth.emf |binary emfio/source/reader/mtftools.cxx| 10 +- 3 files changed, 33 insertions(+), 1 deletion(-) New commits: commit b5ece3fbc7f878846298fd9

[Libreoffice-commits] core.git: sfx2/uiconfig

2021-05-12 Thread Caolán McNamara (via logerrit)
sfx2/uiconfig/ui/commandpopup.ui |1 + 1 file changed, 1 insertion(+) New commits: commit f99404da8b38955b4c1b99f76cfaefd0c19d5348 Author: Caolán McNamara AuthorDate: Wed May 12 16:40:26 2021 +0100 Commit: Caolán McNamara CommitDate: Wed May 12 20:45:49 2021 +0200 add truncate-

[Libreoffice-commits] core.git: bin/ui-converter-skeleton.py bin/ui-rules-enforcer.py

2021-05-12 Thread Caolán McNamara (via logerrit)
bin/ui-rules-enforcer.py |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) New commits: commit 2b4b532179725e69c8df7deceae9158b9beed560 Author: Caolán McNamara AuthorDate: Wed May 12 16:36:09 2021 +0100 Commit: Caolán McNamara CommitDate: Wed May 12 20:46:08 2021 +0200

[Libreoffice-commits] core.git: xmlsecurity/source

2021-05-12 Thread Caolán McNamara (via logerrit)
xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 512649f2fbaaa72d42d9a94ac5c414d2c37b36ec Author: Caolán McNamara AuthorDate: Wed May 12 16:47:47 2021 +0100 Commit: Caolán McNamara CommitDate: Wed May 12 20:46:31 2021 +02

[Libreoffice-commits] core.git: leak-suppress.txt

2021-05-12 Thread Noel Grandin (via logerrit)
leak-suppress.txt |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 16a17fc0951e77af357591deae71f8da50c03cae Author: Noel Grandin AuthorDate: Wed May 12 18:26:26 2021 +0200 Commit: Noel Grandin CommitDate: Wed May 12 21:48:24 2021 +0200 suppress more ba

[Libreoffice-commits] core.git: canvas/qa

2021-05-12 Thread Noel Grandin (via logerrit)
canvas/qa/cppunit/canvastest.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit dbd4110cc36011042c98549d997daa79e8065aba Author: Noel Grandin AuthorDate: Wed May 12 19:45:21 2021 +0200 Commit: Noel Grandin CommitDate: Wed May 12 21:48:42 2021 +0200 fix

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - emfio/qa emfio/source

2021-05-12 Thread Bartosz Kosiorek (via logerrit)
emfio/qa/cppunit/emf/EmfImportTest.cxx | 24 emfio/qa/cppunit/emf/data/TestPolyLineWidth.emf |binary emfio/source/reader/mtftools.cxx| 10 +- 3 files changed, 33 insertions(+), 1 deletion(-) New commits: commit 3ffc0afce0f26900a4e1d9f