Re: OUString is mutable?

2012-10-01 Thread David Tardon
Hi, On Fri, Sep 28, 2012 at 04:05:35PM +0200, Noel Grandin wrote: > > On 2012-09-28 16:00, Caolán McNamara wrote: > >On Fri, 2012-09-28 at 14:17 +0200, Noel Grandin wrote: > >>you can do this: > >> > >> void f(OUString s) { > >> s = "2"; > >> } > >> > >> OUString s = "1";

Please review https://gerrit.libreoffice.org/#/c/710/

2012-10-01 Thread Tor Lillqvist
I submitted it to gerrit by email, apparently that doesn't cause any email to get sent to this list, so doing that manually then. Yes, the "fix" is silly. Patches welcome. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists

Re: OUString is mutable?

2012-10-01 Thread Stephan Bergmann
On 09/28/2012 01:46 PM, Noel Grandin wrote: I don't really understand the point of not being able to mutate OUString in-place, but being able to overwrite it via the assignment operator? It seems to me it should be one or the other. Either OUString is immutable, and it cannot be assigned to, exc

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-10-01 Thread Libreoffice Gerrit user
sc/source/filter/oox/defnamesbuffer.cxx |4 1 file changed, 4 insertions(+) New commits: commit 115add85ea9e16623a3580e3343499d0ff444a45 Author: Markus Mohrhard Date: Fri Sep 28 21:01:14 2012 +0200 vba procedures and macro names will result in crash, fdo#55174 Change-Id:

[Libreoffice-commits] .: Branch 'feature/android-single-dso' - 9 commits - android/experimental filter/source lotuswordpro/source lotuswordpro/util sc/source sd/source svx/source sw/source xmloff/sour

2012-10-01 Thread Libreoffice Gerrit user
android/experimental/DocumentLoader/Makefile|4 +++- android/experimental/DocumentLoader/native-code.cxx | 10 ++ filter/source/svg/svgfilter.component |2 +- filter/source/svg/svgfilter.cxx |2 +- filter/source/t602/filterenv.cxx

[Libreoffice-commits] .: vcl/source

2012-10-01 Thread Libreoffice Gerrit user
vcl/source/window/menu.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 1558ee84dce09770ff80ad9984e84d6500b79bf5 Author: Caolán McNamara Date: Mon Oct 1 09:42:40 2012 +0100 menus are way too wide, wrong checkbox/radiobutton width Change-Id: Ib

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - svl/source

2012-10-01 Thread Libreoffice Gerrit user
svl/source/undo/undo.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit f5dce79d272b47886f16a422f985ee250d228649 Author: Stephan Bergmann Date: Fri Jan 27 14:58:19 2012 +0100 Do not move nCurUndoAction < 0. (Could easily happen when max undo step

[PUSHED-3-6] fix for fdo#54558, ext entries in extlst do not need to have a corresponding normal entry

2012-10-01 Thread Michael Meeks
Hi Markus, On Fri, 2012-09-28 at 23:24 +0200, Markus Mohrhard wrote: > after studying the ooxml spec again the right fix for the other crash > with the test document from fdo#54558 is that we need to handle > missing elements for the corresponding extLst. The ooxml spec allows > to have the ext en

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-10-01 Thread Libreoffice Gerrit user
sc/source/filter/oox/extlstcontext.cxx |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit 6232eeaa90643f2e067145296f8e97fb16f7ecf5 Author: Markus Mohrhard Date: Fri Sep 28 01:21:41 2012 +0200 ooxml spec allow ext ref to non existent entry, fdo#54558

Re: FDO Permissions

2012-10-01 Thread Michael Meeks
On Fri, 2012-09-28 at 10:33 -0700, bfo wrote: > This could be done on per project basis. Unfortunately with Oh ! if we know that this is easy to turn on on a per product basis (ie. a simple bugzilla setting just for our product); then that is trivial to get turned on. Can you co

[Libreoffice-commits] .: sw/qa writerfilter/source

2012-10-01 Thread Libreoffice Gerrit user
sw/qa/extras/rtfimport/data/fdo52475.rtf |5 + sw/qa/extras/rtfimport/rtfimport.cxx |9 + writerfilter/source/rtftok/rtfdocumentimpl.cxx |3 +-- 3 files changed, 15 insertions(+), 2 deletions(-) New commits: commit 91f02521b827bf51f04befd45c51736fe4072fba A

[PATCH] Update French spelling dictionary

2012-10-01 Thread Olivier R.
Hello *, Here is a patch to update the French spelling dictionary. Two noticable changes: 1. The spelling dictionary, which used to be licensed under MPL 1.1, LGPL, GPL, is now released under the MPL v2.0 only. 2. The extension identifier has been modified. Until now, there were 4 French

[PATCH] Change in core[libreoffice-3-6]: fdo#52475 fix import of RTF_CHCBPAT with value 0

2012-10-01 Thread Miklos Vajna (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/740 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/740/1 fdo#52475 fix import of RTF_CHCBPAT with value 0 0 means auto, and for fdo#50539, this value was ignored. However

Re: OUString is mutable?

2012-10-01 Thread Noel Grandin
On 2012-10-01 09:49, David Tardon wrote: I find it perfectly reasonable that a variable of a value type (as opposed to polymorphic type) is assignable. In fact, I would be surprised if it were not. Value types are supposed to mimic the behavior of primitive types; that is why copy constructor

Re: OUString is mutable?

2012-10-01 Thread Noel Grandin
On 2012-10-01 10:15, Stephan Bergmann wrote: Note that the rtl string functionality had originally been designed, arguably somewhat naively, after java.lang.String. On the Java platform, immutability of String is an important security measure. While that argument is irrelevant in a C/C++ cont

[Libreoffice-commits] .: sdext/CustomTarget_presenter.mk sdext/Extension_presenter.mk sdext/Module_sdext.mk sdext/source

2012-10-01 Thread Libreoffice Gerrit user
sdext/CustomTarget_presenter.mk | 41 ++ sdext/Extension_presenter.mk|4 sdext/Module_sdext.mk |1 sdext/source/minimizer/description.xml

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - vcl/aqua

2012-10-01 Thread Libreoffice Gerrit user
vcl/aqua/source/a11y/aqua11ywrapper.mm |4 1 file changed, 4 insertions(+) New commits: commit 887f67674108b5f45e7748f6fbbf1fa0131b0ba8 Author: Tor Lillqvist Date: Wed Sep 26 16:01:09 2012 +0300 Silly workaround for fdo#55156 I feel dirty now. Change-Id: I1cafb0

[PUSHED-3-6] Please review https://gerrit.libreoffice.org/#/c/710/

2012-10-01 Thread Michael Meeks
On Mon, 2012-10-01 at 10:54 +0300, Tor Lillqvist wrote: > I submitted it to gerrit by email, apparently that doesn't cause any > email to get sent to this list, so doing that manually then. > > Yes, the "fix" is silly. Patches welcome. Agreed; it's grim. OTOH it's unlikely to hurt a11y at

Re:[PUSHED] [REVIEW-3-6] fix for fdo#55174, con't crash durig oox import for vba procedure names or macro names

2012-10-01 Thread Noel Power
On 28/09/12 22:16, Markus Mohrhard wrote: Hey, [1] fixes a crash that happens if we try to import a vba procedure name or macro name as range name. The code does not create a ScRangeData for these names and we should not try to create formulas for them. This is a regression introduced by porting

[Libreoffice-commits] .: sdext/source

2012-10-01 Thread Libreoffice Gerrit user
sdext/source/pdfimport/wrapper/wrapper.cxx | 33 + 1 file changed, 15 insertions(+), 18 deletions(-) New commits: commit a900a4d70bb465e24c49a0183c60087328860e83 Author: Stephan Bergmann Date: Mon Oct 1 11:46:24 2012 +0200 Fail early if getPackageLocation fai

[PUSHED] Change in core[libreoffice-3-6]: Silly workaround for fdo#55156

2012-10-01 Thread Michael Meeks (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/710 Approvals: Michael Meeks: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/710 To unsubscribe, vis

Re: OUString is mutable?

2012-10-01 Thread Stephan Bergmann
On 10/01/2012 11:40 AM, Noel Grandin wrote: On 2012-10-01 10:15, Stephan Bergmann wrote: Note that the rtl string functionality had originally been designed, arguably somewhat naively, after java.lang.String. On the Java platform, immutability of String is an important security measure. While t

Re: Easy Hack -- fdo #44718

2012-10-01 Thread Michael Meeks
On Sun, 2012-09-30 at 20:04 -0700, Joel Madero wrote: > Can someone take a look at it real quick and see if you can > point to the right files and throw a comment in there? I added some pointers. > I'll keep looking for more easy hacks. > https://bugs.freedesktop.org/show_bug.cgi?id=4471

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2012-10-01 Thread Libreoffice Gerrit user
sw/source/ui/dbui/dbmgr.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 5b536e72f2a4e35275eb33317ec6b6e14845b75c Author: Lionel Elie Mamane Date: Sun Sep 30 08:35:03 2012 +0200 fdo#31405 CommandType is a LONG, so use a sal_Int32 to retrieve it

[Libreoffice-commits] .: crashrep/source

2012-10-01 Thread Libreoffice Gerrit user
crashrep/source/win32/soreport.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 11b2959680a219b1bb608806159a8da8f5f4b810 Author: Takeshi Abe Date: Sat Sep 29 08:33:27 2012 +0900 use "LibreOffice" as the default value of ProductKey for crashrep Chan

[Libreoffice-commits] .: configure.in

2012-10-01 Thread Libreoffice Gerrit user
configure.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8c089f59b83a80aa5c2c5cba8e9cf7bfbaf426a9 Author: Korrawit Pruegsanusak Date: Sat Sep 29 11:29:56 2012 +0700 configure.in: edit message checking for new GStreamer 1.0 to not duplicate the mes

[PUSHED] use "LibreOffice" as the default value of ProductKey for cra...

2012-10-01 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/721 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/721 To unsubscribe, vis

[PUSHED] configure.in: edit message checking for new GStreamer 1.0

2012-10-01 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/722 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/722 To unsubscribe, vis

[Libreoffice-commits] .: 8 commits - filter/source lotuswordpro/source lotuswordpro/util sc/source sd/source svx/source sw/source xmloff/source

2012-10-01 Thread Libreoffice Gerrit user
filter/source/svg/svgfilter.component|2 +- filter/source/svg/svgfilter.cxx |2 +- filter/source/t602/filterenv.cxx |4 filter/source/t602/t602filter.component |2 +- lotuswordpro/source/filter/genericfilter.cxx |2 +- lotuswordpro/uti

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - writerfilter/source

2012-10-01 Thread Libreoffice Gerrit user
writerfilter/source/rtftok/rtfdocumentimpl.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 52b6ab689bbeb2611af84b694a98282e58426345 Author: Miklos Vajna Date: Fri Sep 28 17:45:21 2012 +0200 fdo#52475 fix import of RTF_CHCBPAT with value 0 0 mean

[PUSHED] Change in core[libreoffice-3-6]: fdo#52475 fix import of RTF_CHCBPAT with value 0

2012-10-01 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/740 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/740 To unsubscribe, vis

Re: OUString is mutable?

2012-10-01 Thread Michael Meeks
Hi Noel, On Mon, 2012-10-01 at 11:32 +0200, Noel Grandin wrote: > David, I agree with you - what I'm really getting at here is that it > seems perfectly reasonable to me to fold the functionality of > OUStringBuffer into OUString, making our string classes that much simpler. > Otherwise we're go

[Libreoffice-commits] Changes to 'feature/unitymenus-quantal-fix'

2012-10-01 Thread Libreoffice Gerrit user
New branch 'feature/unitymenus-quantal-fix' available with the following commits: commit b8a243f100f79bd35081b3b188def148478d2d01 Author: Bjoern Michaelsen Date: Mon Oct 1 12:35:21 2012 +0200 some moving around of casts commit a088c832ac1969f1226460a961ffb8696676ace3 Author: Bjoern Michae

[Libreoffice-commits] .: i18npool/source

2012-10-01 Thread Libreoffice Gerrit user
i18npool/source/localedata/data/hu_HU.xml |2 ++ 1 file changed, 2 insertions(+) New commits: commit a07a4688d10737bd88d89ef38e12bc9b6074ffea Author: László Németh Date: Sat Sep 29 00:05:34 2012 +0200 Add back compatible Hungarian date format acceptance Change-Id: I6b6d62c

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-10-01 Thread Libreoffice Gerrit user
sc/source/filter/oox/formulabuffer.cxx | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) New commits: commit 1ba25c3ada91963f095c976764d68db039be0fd8 Author: Markus Mohrhard Date: Fri Sep 28 01:22:44 2012 +0200 fix vell value import from ooxml with array formulas,

Re: [PUSHED][REVIEW-3-6] fix for fdo#54558, crash during cached value import of

2012-10-01 Thread Noel Power
On 28/09/12 22:21, Markus Mohrhard wrote: Hey, [1] fixes a crash during the xlsx import of cached value for array formulas. The solution is to check that the cell exists and move the array formula import in front of the cached value import. Regards, Markus [1] http://cgit.freedesktop.org/libr

[PUSHED] Add back compatible Hungarian date format acceptance

2012-10-01 Thread Thorsten Behrens (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/720 Approvals: Thorsten Behrens: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/720 To unsubscribe,

Re: OUString is mutable?

2012-10-01 Thread Stephan Bergmann
On 10/01/2012 12:38 PM, Michael Meeks wrote: On Mon, 2012-10-01 at 11:32 +0200, Noel Grandin wrote: David, I agree with you - what I'm really getting at here is that it seems perfectly reasonable to me to fold the functionality of OUStringBuffer into OUString, making our string classes that much

optimising OUString for space

2012-10-01 Thread Noel Grandin
On 2012-10-01 12:38, Michael Meeks wrote: We could do some magic there; of course - space is a bit of an issue - we already pointlessly bloat bazillions of ascii strings into UCS-2 (nominally UTF-16) representations and nail a ref-count and length on the beginning. If you turn on the lifecycle

[Libreoffice-commits] .: Branch 'feature/android-single-dso' - filter/source

2012-10-01 Thread Libreoffice Gerrit user
filter/source/textfilterdetect/fdcomp.cxx |2 +- filter/source/textfilterdetect/textfd.component |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 332ff2a38817a2076b0b1098d17005dc95b770e6 Author: Tor Lillqvist Date: Mon Oct 1 13:29:38 2012 +0300 Pre

[Libreoffice-commits] .: filter/source

2012-10-01 Thread Libreoffice Gerrit user
filter/source/textfilterdetect/fdcomp.cxx |2 +- filter/source/textfilterdetect/textfd.component |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 256344d507dbcc22e1e371b8061ad5cfdf21cf98 Author: Tor Lillqvist Date: Mon Oct 1 13:29:38 2012 +0300 Pre

Re: optimising OUString for space

2012-10-01 Thread Stephan Bergmann
On 10/01/2012 01:02 PM, Noel Grandin wrote: That was something I was thinking about the other day - given than the bulk of our strings are pure 7-bit ASCII, it might be a worthwhile optimisation to store a bit that says "this string is 7-bit ASCII", and then store the string as a sequence of byte

[PUSHED-3-6] fdo#55379, handle the lifetime of mpCondFormat correctly

2012-10-01 Thread Michael Meeks
Hi Markus, On Fri, 2012-09-28 at 23:14 +0200, Markus Mohrhard wrote: > [1] fixes another problem with the cond format import for the old cond > format data structures. The style might be imported several times with > different ranges and therefore we may delete the mpCondFormat which is > then own

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-10-01 Thread Libreoffice Gerrit user
sc/source/filter/xml/xmlstyli.cxx | 11 +-- sc/source/filter/xml/xmlstyli.hxx |1 + 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit 2ec30db5f8a9b629b3a099ed8e4d3598567feceb Author: Markus Mohrhard Date: Fri Sep 28 20:14:17 2012 +0200 fetime of mpCondForm

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-10-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 55379, which changed state. Bug 55379 Summary: FILEOPEN CRASH for particular .ods https://bugs.freedesktop.org/show_bug.cgi?id=55379 What|Removed |Added

Re: OUString is mutable?

2012-10-01 Thread Michael Meeks
On Mon, 2012-10-01 at 12:55 +0200, Stephan Bergmann wrote: > > Fitting that inside the ABI is going to be quite fun; then again - we > > havn't played the old game of adjusting pointers to allocate magic data > > before the struct yet I guess. > > ...and I hope we never do. ;) ;-) o

Re: optimising OUString for space

2012-10-01 Thread Michael Meeks
On Mon, 2012-10-01 at 13:02 +0200, Noel Grandin wrote: > That was something I was thinking about the other day - given than the > bulk of our strings are pure 7-bit ASCII, it might be a worthwhile > optimisation to store a bit that says "this string is 7-bit ASCII", and > then store the string

Re: optimising OUString for space

2012-10-01 Thread Noel Grandin
On 2012-10-01 13:25, Michael Meeks wrote: The latest Java VM does this trick internally - it pretends that String is stored with an array of 16-bit values, but actually it stores them as UTF-8. Interesting - for all strings ? is there a pointer to the code / docs for that detail somewhe

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sdext/source

2012-10-01 Thread Libreoffice Gerrit user
sdext/source/pdfimport/inc/pdfihelper.hxx |4 + sdext/source/pdfimport/inc/pdfparse.hxx|3 sdext/source/pdfimport/misc/pwdinteract.cxx| 41 + sdext/source/pdfimport/pdfparse/pdfentries.cxx | 15 +++- sdext/source/pdfimport/wrapper/wrapper.cxx | 76 ++

[PUSHED] Change in core[libreoffice-3-6]: rhbz#826526 Inform user about unsupported PDF encryption for...

2012-10-01 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/719 Approvals: Miklos Vajna: Verified; Looks good to me, approved Thorsten Behrens: Looks good to me, approved -- To view, visit https://

Re: optimising OUString for space

2012-10-01 Thread Michael Stahl
On 01/10/12 13:02, Noel Grandin wrote: > > On 2012-10-01 12:38, Michael Meeks wrote: >> We could do some magic there; of course - space is a bit of an issue - >> we already pointlessly bloat bazillions of ascii strings into UCS-2 >> (nominally UTF-16) representations and nail a ref-count and len

[Libreoffice-commits] .: sc/source

2012-10-01 Thread Libreoffice Gerrit user
sc/source/ui/view/cellsh1.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8e01b2aca4aad3c4f366b3f8d385b3dbe9aaa886 Author: Michael Meeks Date: Mon Oct 1 12:51:27 2012 +0100 fdo#54940 - fix last small ergonomic issue. Change-Id: I305bf537a203389321

Re: optimising OUString for space

2012-10-01 Thread Noel Grandin
On 2012-10-01 13:47, Michael Stahl wrote: ... which brings me to another point: in a hypothetical future when we could efficiently create a UTF8String from a string literal in C++ without copying the darn thing, what should hypothetical operations to mutate the string's buffer do? We need ex

Re: optimising OUString for space

2012-10-01 Thread Michael Stahl
On 01/10/12 13:25, Michael Meeks wrote: > > On Mon, 2012-10-01 at 13:02 +0200, Noel Grandin wrote: >> That was something I was thinking about the other day - given than the >> bulk of our strings are pure 7-bit ASCII, it might be a worthwhile >> optimisation to store a bit that says "this string

[Libreoffice-commits] .: Branch 'feature/unitymenus-quantal-fix' - vcl/unx

2012-10-01 Thread Libreoffice Gerrit user
vcl/unx/gtk/window/gtkframe.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit 08df1f6202ddd159e865258af0ecc30fd758f929 Author: Bjoern Michaelsen Date: Mon Oct 1 14:01:25 2012 +0200 revoke the watch when dying diff --git a/vcl/unx/gtk/window/gtkframe.c

Re: optimising OUString for space

2012-10-01 Thread Michael Stahl
On 01/10/12 13:55, Noel Grandin wrote: > > On 2012-10-01 13:47, Michael Stahl wrote: >> ... which brings me to another point: in a hypothetical future when we >> could efficiently create a UTF8String from a string literal in C++ >> without copying the darn thing, what should hypothetical operati

[REVIEW-3-6] 3x calc cond-format patches

2012-10-01 Thread Michael Meeks
Hi guys, These three together (worked on by Markus & myself) improve some of the ergonomics around the conditional formatting dialog, and fix a minor sizing issue. I'd love to get them into -3-6 - review/sign-off appreciated; the slightly larger fix is a squash of three from maste

Re: [PUSHED] fdo#51304: dung out bogus boilerplate

2012-10-01 Thread Thorsten Behrens
Anurag Jain wrote: > Removed some '@author' for java source file and removed some commented code > founded when removing the '@author' > Lovely, thanks for that - pushed to master. Cheers, -- Thorsten pgpKb4JN2gfvE.pgp Description: PGP signature ___

Re: LibreOffice idea or concept .

2012-10-01 Thread Michael Meeks
Hi Mariano, On Fri, 2012-09-28 at 15:19 -0300, Mariano Gaudix wrote: > This ismy concept of graphical Interface for LibreOffice . > Written in Gtk 3.0 is a small POC First - thanks for taking the time to create that, it looks pretty :-) Secondly - the question

Re: optimising OUString for space

2012-10-01 Thread Noel Grandin
On 2012-10-01 14:06, Michael Stahl wrote: Or are you talking about memory management? The current OUString class allocates a new character buffer for every mutation, I assume we'd keep that strategy. you mean if i have some string and then add !a" "b" "c" to it it will re-allocate 3 times? tha

Re: optimising OUString for space

2012-10-01 Thread Noel Grandin
On 2012-10-01 13:58, Michael Stahl wrote: On 01/10/12 13:25, Michael Meeks wrote: The only problem with a change there is our ABI - which explicitly exposes the encoding of that. the right time to do it is for LO4. sadly nobody has signed up for that yet :( ... (while there are volunte

LibreOffice Community invites to Munich Hackfest

2012-10-01 Thread Florian Effenberger
LibreOffice Community invites to Munich Hackfest City of Munich LiMux project hosts Hackfest late November Fostering the developer community of the free office suite The LibreOffice Community today announces the next Hackfest, taking place in Munich, Germany from November 23rd to 25th. With dev

Re: OUString is mutable?

2012-10-01 Thread Michael Stahl
On 01/10/12 11:40, Noel Grandin wrote: > > On 2012-10-01 10:15, Stephan Bergmann wrote: >> Note that the rtl string functionality had originally been designed, >> arguably somewhat naively, after java.lang.String. On the Java >> platform, immutability of String is an important security measure.

[Libreoffice-commits] .: 4 commits - starmath/inc starmath/qa starmath/source

2012-10-01 Thread Libreoffice Gerrit user
starmath/inc/cursor.hxx |2 starmath/inc/parse.hxx |2 starmath/inc/visitors.hxx | 19 +--- starmath/qa/cppunit/test_nodetotextvisitors.cxx | 10 +- starmath/source/accessibility.cxx | 92 +

[Libreoffice-commits] .: 5 commits - bridges/CustomTarget_gcc3_ios_arm.mk Repository.mk sal/inc sc/CppunitTest_sc_annotationshapeobj.mk sc/CppunitTest_sc_cellrangeobj.mk sc/CppunitTest_sc_chart_regres

2012-10-01 Thread Libreoffice Gerrit user
Repository.mk |6 -- bridges/CustomTarget_gcc3_ios_arm.mk |3 +-- sal/inc/sal/mathconf.h | 10 -- sc/CppunitTest_sc_annotationshapeobj.mk|3 ++- sc/CppunitTest_sc_cellrangeobj.mk |3 ++- sc/CppunitTes

Re: optimising OUString for space

2012-10-01 Thread Michael Stahl
On 01/10/12 14:23, Noel Grandin wrote: > > On 2012-10-01 13:58, Michael Stahl wrote: >> On 01/10/12 13:25, Michael Meeks wrote: >> >> The only problem with a change there is our ABI - which explicitly >> exposes the encoding of that. >> the right time to do it is for LO4. sadly nobody has si

[Libreoffice-commits] .: Branch 'feature/android-single-dso' - 2 commits - android/experimental avmedia/source avmedia/util

2012-10-01 Thread Libreoffice Gerrit user
android/experimental/DocumentLoader/Makefile|2 ++ android/experimental/DocumentLoader/native-code.cxx | 10 ++ avmedia/source/framework/soundhandler.cxx |2 +- avmedia/source/gstreamer/avmediagstreamer.component |2 +- avmedia/source/gstreamer/gstuno.cxx

Re: optimising OUString for space

2012-10-01 Thread Noel Grandin
On 2012-10-01 14:45, Michael Stahl wrote: guess you could comment out operator[], that should find lots of convertible call sites Don't we have some kind of deprecated warning system in C++ ? Would be less disruptive :-) Disclaimer: http://www.peralex.com/disclaimer.html _

[Libreoffice-commits] .: avmedia/source avmedia/util

2012-10-01 Thread Libreoffice Gerrit user
avmedia/source/framework/soundhandler.cxx |2 +- avmedia/source/gstreamer/avmediagstreamer.component |2 +- avmedia/source/gstreamer/gstuno.cxx |2 +- avmedia/source/quicktime/avmediaQuickTime.component |2 +- avmedia/source/quicktime/quicktimeuno.mm

[Libreoffice-commits] .: 2 commits - sw/qa writerfilter/source

2012-10-01 Thread Libreoffice Gerrit user
sw/qa/extras/ooxmlimport/data/n782345.docx|binary sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 13 + writerfilter/source/dmapper/DomainMapper.cxx | 10 ++ writerfilter/source/dmapper/SettingsTable.cxx | 10 ++ writerfilter/source/dmapper/SettingsTable.hxx

[Libreoffice-commits] .: Branch 'feature/killsdf' - accessibility/prj avmedia/prj basctl/prj basic/prj chart2/prj connectivity/prj crashrep/prj dbaccess/prj desktop/prj extensions/prj filter/prj forms

2012-10-01 Thread Libreoffice Gerrit user
accessibility/prj/build.lst |2 +- avmedia/prj/build.lst|2 +- basctl/prj/build.lst |2 +- basic/prj/build.lst |2 +- chart2/prj/build.lst |2 +- connectivity/prj/build.lst |2 +- crashrep/prj/build.lst |2 +- dbaccess/prj/build

[Libreoffice-commits] .: Branch 'feature/killsdf' - dictionaries/prj

2012-10-01 Thread Libreoffice Gerrit user
dictionaries/prj/build.lst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 400f46de9cfe71fc30b37b837674b29fb73c42b3 Author: Andras Timar Date: Mon Oct 1 15:19:10 2012 +0200 translations is a source-only module Change-Id: Icf73391e23617a8a07f386c724851

[Libreoffice-commits] .: Branch 'feature/killsdf' - helpcontent2/prj

2012-10-01 Thread Libreoffice Gerrit user
helpcontent2/prj/build.lst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 81aebc649231119e4fecf72c0565784d0703175e Author: Andras Timar Date: Mon Oct 1 15:19:11 2012 +0200 translations is a source-only module Change-Id: I85a8d170b83d1b0cf872a1fe7a216

[Libreoffice-commits] .: filter/source

2012-10-01 Thread Libreoffice Gerrit user
filter/source/pdf/pdfexport.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 968ed85d7304fe0044d3f82af20ae7190ad3c33d Author: Stephan Bergmann Date: Mon Oct 1 15:42:13 2012 +0200 fdo#54225: PDFExport::mbSignPDF potentially used uninitialized Chan

Re: optimising OUString for space

2012-10-01 Thread Michael Meeks
On Mon, 2012-10-01 at 14:23 +0200, Noel Grandin wrote: > Perhaps we need to split out some preparatory tasks? > For example > - fix code that directly accesses the underlying buffer Sure ! > - create an external iterator class (which would currently be a thin > wrapper around int) f

[Bug 54157] LibreOffice 3.7 most annoying bugs

2012-10-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 54225, which changed state. Bug 54225 Summary: MAILMERGEe-mail as PDF sends damaged documents https://bugs.freedesktop.org/show_bug.cgi?id=54225 What|Removed |Added

Re: OUString is mutable?

2012-10-01 Thread Michael Stahl
On 01/10/12 11:32, Noel Grandin wrote: > > On 2012-10-01 09:49, David Tardon wrote: >> I find it perfectly reasonable that a variable of a value type (as >> opposed to polymorphic type) is assignable. In fact, I would be >> surprised if it were not. Value types are supposed to mimic the >> behav

Re: optimising OUString for space

2012-10-01 Thread Stephan Bergmann
On 10/01/2012 02:45 PM, Michael Stahl wrote: On 01/10/12 14:23, Noel Grandin wrote: On 2012-10-01 13:58, Michael Stahl wrote: The only problem with a change there is our ABI - which explicitly exposes the encoding of that. the right time to do it is for LO4. sadly nobody has signed up

Re: optimising OUString for space

2012-10-01 Thread Stephan Bergmann
On 10/01/2012 01:47 PM, Michael Stahl wrote: ... which brings me to another point: in a hypothetical future when we could efficiently create a UTF8String from a string literal in C++ without copying the darn thing, what should hypothetical operations to mutate the string's buffer do? If we cont

[REVIEW-3-6] Fix for fdo#55417

2012-10-01 Thread Noel Power
This makes sure alignment and protection specified at a cell style are exported ( basically it seems for alignment & protectecton we need the hard cell attributes need to match those specified in the cell style ). The documentation in the spec is inconclusive but after some playing around with

[REVIEW 3-6] fdo#55418

2012-10-01 Thread Noel Power
This one was quite hard to reproduce. The problem is that the 'xfId' written out for the cellstyle is sometimes incorrect, worse of course was that mostly it was correct. Additionally just to improve the debugging experience the way the lists get laid out it seems even when it didn't work it co

[Libreoffice-commits] .: Branch 'feature/killsdf' - config_host.mk.in configure.in sdext/CustomTarget_presenter.mk sdext/Extension_minimizer.mk sdext/Extension_pdfimport.mk sdext/Extension_presenter.m

2012-10-01 Thread Libreoffice Gerrit user
config_host.mk.in |1 configure.in | 45 + sdext/CustomTarget_presenter.mk|4 --- sdext/Extension_minimizer.mk |4 --- sdext/Extension_pdfimport.mk |4 --- sdext/Extension_presenter.mk |

Re: FDO Permissions

2012-10-01 Thread bfo
Michael Meeks-2 wrote > On Fri, 2012-09-28 at 10:33 -0700, bfo wrote: >> This could be done on per project basis. Unfortunately with > Oh ! if we know that this is easy to turn on on a per product basis > (ie. a simple bugzilla setting just for our product); then that is > trivial to get tur

Release 3.5.7 RC1 as final (was: [Libreoffice-qa] [ANN] LibreOffice 3.5.7 RC1 test builds available)

2012-10-01 Thread Thorsten Behrens
Fridrich Strba wrote: > Builds are now being uploaded to a public (but non-mirrored - so don't > spread news too widely!) place, as soon as they're available. Grab > them here: > > http://dev-builds.libreoffice.org/pre-releases/ > There were no bugs reported against this version, and we see no p

Re: optimising OUString for space

2012-10-01 Thread Norbert Thiebaud
On Mon, Oct 1, 2012 at 9:05 AM, Stephan Bergmann wrote: > Note that in the common case of accessing (i.e., searching for, etc.) 7-bit > ASCII content in a string, regardless of whether it is internally > represented as UTF-8 or UTF-16, going via an operator[] interface that > operates directly on

[Libreoffice-commits] .: config_host.mk.in configure.in sdext/CustomTarget_presenter.mk sdext/Extension_minimizer.mk sdext/Extension_pdfimport.mk sdext/Extension_presenter.mk sdext/Library_presenter.m

2012-10-01 Thread Libreoffice Gerrit user
config_host.mk.in |1 configure.in | 45 + sdext/CustomTarget_presenter.mk|4 --- sdext/Extension_minimizer.mk |4 --- sdext/Extension_pdfimport.mk |4 --- sdext/Extension_presenter.mk |

Re: optimising OUString for space

2012-10-01 Thread Stephan Bergmann
On 10/01/2012 05:29 PM, Norbert Thiebaud wrote: removal of the need to have 2 set of classes (one for SBCS and one for UCS-2) Note that it might still be useful to keep a "heavyweight" distinction (like different sets of classes) between the concepts of "byte-serializations of sequences of en

[PATCH] OUString and RTL_CONSTASCII_US... cleanup in basctl

2012-10-01 Thread Ricardo Montania (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/741 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/741/1 OUString and RTL_CONSTASCII_US... cleanup in basctl Change-Id: I440d245d013873ec2830280ad01a4d0625fc4c1a --- M bas

Re: --headless broken with --enable-headless

2012-10-01 Thread Michael Meeks
Hi Riccardo, On Fri, 2012-09-28 at 20:26 +0200, Riccardo Magliocchetti wrote: > > Here you go, you'll find the valgrind output sans all the zlib / python > > related errors. Thanks a lot! > > update to git 7a3a8a254363801bf6893b23d67f86a7461f8f3b and more or less > same valgrind errors. See atta

[PATCH] Remove unused methods

2012-10-01 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/742 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/742/1 Remove unused methods Just a cleanup. Change-Id: I8fc47c39ede4e5b06af2144667ede5e9c2d5b397 Signed-off-by: Marcos

[PATCH] Remove blocks of code that will never execute("#if 0" blocks...

2012-10-01 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/743 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/743/1 Remove blocks of code that will never execute("#if 0" blocks) These blocks of code will never execute. So we can s

[Libreoffice-commits] .: 2 commits - starmath/inc starmath/source xmlsecurity/source

2012-10-01 Thread Libreoffice Gerrit user
starmath/inc/caret.hxx |2 - starmath/inc/node.hxx| 20 ++--- starmath/source/cursor.cxx | 34 +++ starmath/source/mathmlexport.cxx | 16 +- starmath/source/mat

Re: [REVIEW-3-6] 3x calc cond-format patches

2012-10-01 Thread Markus Mohrhard
Hey, 2012/10/1 Michael Meeks : > Hi guys, > > These three together (worked on by Markus & myself) improve some of > the > ergonomics around the conditional formatting dialog, and fix a minor > sizing issue. > > I'd love to get them into -3-6 - review/sign-off appreciated; the > sl

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 2 commits - sc/source

2012-10-01 Thread Libreoffice Gerrit user
sc/source/ui/condformat/condformatdlg.cxx | 39 +- 1 file changed, 18 insertions(+), 21 deletions(-) New commits: commit 6315839cec5c82c9b650d9e4581a79ec6db92603 Author: Michael Meeks Date: Fri Sep 28 12:43:47 2012 +0100 auto-expand the first conditional form

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - editeng/source

2012-10-01 Thread Libreoffice Gerrit user
editeng/source/editeng/editdoc.hxx |2 +- editeng/source/editeng/impedit3.cxx | 17 + 2 files changed, 6 insertions(+), 13 deletions(-) New commits: commit 618795f83936a1d07ba3cd415f041b1698623bba Author: Jan Holesovsky Date: Mon Sep 24 12:22:54 2012 -0400 n#707779:

[PUSHED-3-6] [REVIEW 3-6] n#707779: Fix overflowing of left margin value in editeng when negative

2012-10-01 Thread Thorsten Behrens
Jan Holesovsky wrote: > Can you please review and push > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=d953cc27fc5da5e612b1dc4c29707c09d17fc643 > Done, nice catch. Cheers, -- Thorsten pgpIlLNiTJDg9.pgp Description: PGP signature ___ Libr

[Libreoffice-commits] .: editeng/source

2012-10-01 Thread Libreoffice Gerrit user
editeng/source/editeng/editdoc.cxx | 15 +++ editeng/source/editeng/editdoc.hxx |9 ++--- 2 files changed, 17 insertions(+), 7 deletions(-) New commits: commit f3f706274172879324884e845629ef74b2e2e443 Author: Thorsten Behrens Date: Mon Oct 1 19:33:34 2012 +0200 Outli

Re: --headless broken with --enable-headless

2012-10-01 Thread Riccardo Magliocchetti
Hi Michael, Il 01/10/2012 18:11, Michael Meeks ha scritto: Hi Riccardo, On Fri, 2012-09-28 at 20:26 +0200, Riccardo Magliocchetti wrote: Here you go, you'll find the valgrind output sans all the zlib / python related errors. Thanks a lot! update to git 7a3a8a254363801bf6893b23d67f86a7461f8f3

[PUSHED] [PATCH 2/3] fdo#51304: Remove @author annotation and commented code

2012-10-01 Thread Thorsten Behrens
guilherme@gmail.com wrote: > This patch removes '@author' annotation, code in comments > and adjust some empty catches. It's cleanup patch > Hi José Guilherme, partially pushed - I left the hunks commenting empty methods as FIXME instead of removing them straight away unapplied. If the method

Re: [PUSHED] soltools conversion to gbuild

2012-10-01 Thread Thorsten Behrens
Mark pushed (went via gerrit) -- Thorsten pgpK5NqtKe8pX.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

  1   2   >