Hi Markus
Thanks a lot of taking care !
I also identified the source code you pointed, but my skills stucked me
> I think a solution would be really necessary since this loop needs
> around 40% of one core on my fast development computer and Laurent
> mentioned around 40% of his whole cpu time( s
On 01/27/2012 06:34 AM, Lionel Elie Mamane wrote:
On Thu, Jan 26, 2012 at 10:24:52PM +0100, Thorsten Behrens wrote:
Michael Meeks wrote:
AA: + do the easiest roll-back possible to cleanup the
canvas publishing issue in 3.5.0 (Thorsten)
Anyway - commit on master is here:
h
Hi Lionel,
Le 27/01/12 06:58, Lionel Elie Mamane a écrit :
> I just did that in master in commit
> b86c6ac65c9fae4da5fc8faf1ed194007de37afc
Thanks,
Alex
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/ma
Stephan Bergmann wrote:
> >I'd have preferred if you just removed the "published" tag and did not
> >also remove documentation-in-comment, as in:
> [...]
>
> Indeed. I reviewed and cherry-picked this to -3-5, lumping together
> the original revert with Thorsten's follow-up
>
Thanks Stephan - yep
> And indeed, in configure.in it looks like COMEX is nowadays only set on
> Windows, left empty on all other platforms (that was probably different in
> the past, and somebody cleaned up too aggressively).
That somebody must be me...
> So, all the Solaris
> checks in solenv/inc/unx.mk should pr
in the original commit by thorsten 9and not 'fixed by Stephan's)
--- a/offapi/com/sun/star/drawing/framework/ConfigurationChangeEvent.idl
+++ b/offapi/com/sun/star/drawing/framework/ConfigurationChangeEvent.idl
@@ -35,8 +35,9 @@ module com { module sun { module star { module uno {
interface XInterf
On Fri, Jan 27, 2012 at 06:55:38AM +0100, Lionel Elie Mamane wrote:
> On Thu, Jan 26, 2012 at 02:41:06PM +0100, Alex Thurgood wrote:
>
> > Perhaps I misunderstood what François' commits were supposed to do,
> > but I thought that the Adabas db stuff had been pulled out of the
> > compilation seque
https://bugs.freedesktop.org/show_bug.cgi?id=35673
Bug 35673 depends on bug 38542, which changed state.
Bug 38542 Summary: FORMATTING TABLE double borders incompatibility with old
LibO / OOo Versions
https://bugs.freedesktop.org/show_bug.cgi?id=38542
What|Old Value
On 01/27/2012 12:11 AM, Markus Mohrhard wrote:
- the problem is in
connectivity/source/drivers/mozab/bootstrap/MNSInit.cxx:228-235
-- the loop is sleeping for 1 ms and therefore running a thousand
times per second without doing any real work because there are no
events
Since this also affects Lo
On 01/27/2012 09:46 AM, Norbert Thiebaud wrote:
in the original commit by thorsten 9and not 'fixed by Stephan's)
--- a/offapi/com/sun/star/drawing/framework/ConfigurationChangeEvent.idl
+++ b/offapi/com/sun/star/drawing/framework/ConfigurationChangeEvent.idl
@@ -35,8 +35,9 @@ module com { module
On Thu, 2012-01-26 at 18:21 +0100, Michael Stahl wrote:
> On 26/01/12 14:20, Eike Rathke wrote:
> > Hi,
> >
> > please review and cherry-pick to 3-5, 3.5.0 and 3-4
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=34315e7ec4062f9521cd19951b5f7f6ad9ce0d2e
> >
> > Resolves https://bugs.fr
On Fri, Jan 27, 2012 at 2:56 AM, Stephan Bergmann wrote:
> On 01/27/2012 09:46 AM, Norbert Thiebaud wrote:
>>
>> in the original commit by thorsten 9and not 'fixed by Stephan's)
>> --- a/offapi/com/sun/star/drawing/framework/ConfigurationChangeEvent.idl
>> +++ b/offapi/com/sun/star/drawing/framewo
On Fri, 2012-01-27 at 09:56 +0100, Stephan Bergmann wrote:
> I'm not happy with this, either, but all the additional changes brought
> in with Thorsten's commits appeared to me to be minuscule and harmless,
> so I would not bother to clean them up further, at least not on -3-5-0.
So you
On Fri, Jan 27, 2012 at 3:41 AM, Michael Meeks wrote:
>
> On Fri, 2012-01-27 at 09:56 +0100, Stephan Bergmann wrote:
>> I'm not happy with this, either, but all the additional changes brought
>> in with Thorsten's commits appeared to me to be minuscule and harmless,
>> so I would not bother to cle
On Fri, 2012-01-27 at 10:19 +0530, Muthu Subramanian K wrote:
> Its nice to see those patches. But, it will be nice to see/use the
> tools/scripts directly
So - -really- I'm less convinced of that. As I said - this busts our
history.
It is true that we did a big whitespace cleanu
Hi Muthu,
Its nice to see those patches. But, it will be nice to see/use the
tools/scripts directly? Especially if they can be hooked to git (like
the current white space/tabs removal ones)?
First I noticed, that ( () ) did only appear in two cases: SAL_THROW( ()
) and THROWS( () )
As I wan
pushed on 3-5-0 as
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=13ce4a57c1d20a767a7f4d818f063b19b95b5d48
Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/l
Norbert Thiebaud wrote:
> pushed on 3-5-0 as
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=13ce4a57c1d20a767a7f4d818f063b19b95b5d48
>
Thanks a lot!
- adding customary tag to thread.
-- Thorsten
pgpYzJlcUcMIV.pgp
Description: PGP signature
__
On Fri, 2012-01-27 at 06:58 +0100, Lionel Elie Mamane wrote:
> I just did that in master in commit
> b86c6ac65c9fae4da5fc8faf1ed194007de37afc
Lets just delete both the adabas backend and ui thingy entirely and not
wimp around with building them but not installing them. If we ever need
them back th
Hi Stephan,
On 2012-01-26 at 18:13 +0100, Stephan Bergmann wrote:
> > + only cherry-picking from libreoffice-3-5 branch
> > + 2 additional reviews needed; 2nd reviewer pushes
>
> Is that to be interpreted as, once a commit has reached libreoffice-3-5
> (where it already needed original
On Thu, Jan 26, 2012 at 3:52 PM, Eike Rathke wrote:
> Hi,
>
> On Thursday, 2012-01-26 15:45:15 +, Caolán McNamara wrote:
>
>> On Thu, 2012-01-26 at 13:52 +0100, Andras Timar wrote:
>> > Please review and cherry-pick to libreoffice-3-5-0
>>
>> Pushed to 3-5 now, need another ack for 3.5.0 I pre
> So - -really- I'm less convinced of that. As I said - this busts our
> history.
Yes, I very well agree with this - I have faced problems with the
history before. But, I was actually referring to specifically the git
hooks - which might be helpful in catching typos?
>
> So - as I sai
---
basegfx/inc/basegfx/tuple/b2ituple.hxx |7
basegfx/source/tuple/b2ituple.cxx | 48
unusedcode.easy|6
3 files changed, 0 insertions(+), 61 deletions(-)
diff --git a/basegfx/inc/basegfx/tuple/b2ituple.hxx
b/base
---
basegfx/inc/basegfx/vector/b2ivector.hxx | 65 -
basegfx/source/vector/b2ivector.cxx | 67 --
unusedcode.easy |7 ---
3 files changed, 0 insertions(+), 139 deletions(-)
diff --git a/basegfx/inc/baseg
---
basegfx/inc/basegfx/polygon/b3dpolygon.hxx |7 +---
basegfx/inc/basegfx/polygon/b3dpolypolygon.hxx | 10 +-
basegfx/source/polygon/b3dpolygon.cxx | 40
basegfx/source/polygon/b3dpolypolygon.cxx | 28
unusedcode.easy
Hi Andras,
On Thursday, 2012-01-26 23:08:25 +0100, Andras Timar wrote:
> >
> >
> > Is that really supposed to be '.' separator and not ISO 8601 '-'?
> >
>
> It is just a version string... It is not parsed as date.
Thanks, I slipped past the "version" and got drawn to the date string
instead
On Fri, 2012-01-27 at 16:42 +0530, Muthu Subramanian K wrote:
> Yes, I very well agree with this - I have faced problems with the
> history before. But, I was actually referring to specifically the git
> hooks - which might be helpful in catching typos?
Mea culpa; I should have read your
Hi all,
if happens that the changes I made a few months ago aren't really mature
and will need more love. I reverted them in master, and it would be cool
if someone could review / cherry-pick it in 3.5 and 3.5.0.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e9ec6d58b58739ce43ff563fd78c
On 27/01/12 13:14, Cedric Bosdonnat wrote:
> Hi all,
>
> if happens that the changes I made a few months ago aren't really mature
> and will need more love. I reverted them in master, and it would be cool
> if someone could review / cherry-pick it in 3.5 and 3.5.0.
>
> http://cgit.freedesktop.org
Hi Kohei,
On Thursday, 2012-01-26 22:37:14 -0500, Kohei Yoshida wrote:
> So, I took a second look at this, and came up with the attached version
> which I think is better and more correct than the first one. This one
> will correctly honor the delete note flag, and also maintains the option
> of
Hi
Attached patch converts ScCustomShow to use std::vector.
Not exactly sure how these kinds of classes that extend tools/List
should be converted.
I exposed an accessor method PagesVector(), but I'm happy to modify the
patch if there is a better idiom.
Code is contributed under MPL+/LGPL+/G
Hi,
In my build from last night's pull and make clean, I'm seeing the
following Java exception thrown when executing the Agenda Wizard :
===
=== Note: An Exception was thrown which should have ===
=== caused a crash. I caught it. Please repor
Cedric Bosdonnat píše v Pá 27. 01. 2012 v 13:14 +0100:
> Hi all,
>
> if happens that the changes I made a few months ago aren't really mature
> and will need more love. I reverted them in master, and it would be cool
> if someone could review / cherry-pick it in 3.5 and 3.5.0.
>
> http://cgit.fre
2012/1/27 Petr Mladek :
> Cedric Bosdonnat píše v Pá 27. 01. 2012 v 13:14 +0100:
>> Hi all,
>>
>> if happens that the changes I made a few months ago aren't really mature
>> and will need more love. I reverted them in master, and it would be cool
>> if someone could review / cherry-pick it in 3.5 a
On Friday 27 of January 2012, Muthu Subramanian K wrote:
> Hello Alexander,
>
> Its nice to see those patches. But, it will be nice to see/use the
> tools/scripts directly? Especially if they can be hooked to git (like
> the current white space/tabs removal ones)?
Are you seriously suggesting tha
Jan Holesovsky píše v Pá 27. 01. 2012 v 11:54 +0100:
> Hi Stephan,
>
> On 2012-01-26 at 18:13 +0100, Stephan Bergmann wrote:
>
> > > + only cherry-picking from libreoffice-3-5 branch
> > > + 2 additional reviews needed; 2nd reviewer pushes
> >
> > Is that to be interpreted as, once a commit
2012/1/26 Michael Meeks :
> * Indian localisation issuse / patch (Caolan)
> + happy with the patches, Windows specific issue
> + need another review for -3-5-0
> + no underlying bug lurking here.
> AA: + re-test under Windows and push to -3-5-0 (Andras)
Done.
Best regards
Cedric Bosdonnat píše v Pá 27. 01. 2012 v 10:01 +0100:
> The minutes were transformed into a night... but I'm ok with your
> patches and pushed them to 3.5 and master. 2 more reviews to have them
> into 3.5.0.
What commits are we talking about? Please, list all changes that need to
be cherry picke
On Fri, 2012-01-27 at 14:01 +0100, Michael Stahl wrote:
> if it's not done, then i agree we should revert it asap;
> pushed to libreoffice-3-5:
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=7fbfed6539d607b34fb19c48ea418b2e16454de2
I'm happy with the code reversion,
2012/1/27 Caolán McNamara :
> On Fri, 2012-01-27 at 14:01 +0100, Michael Stahl wrote:
>> if it's not done, then i agree we should revert it asap;
>> pushed to libreoffice-3-5:
>>
>> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=7fbfed6539d607b34fb19c48ea418b2e16454de2
>
On 01/27/2012 02:27 PM, Petr Mladek wrote:
Heh, I am getting really scared by the flood of patches waiting for
3-5-0 approval. Some are not trivial and it is getting dangerous.
Yes.
But if you think / feel that actually one additional would be enough, I
guess we can talk about that at one of
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi
How can I write a help file to fix
https://bugs.freedesktop.org/show_bug.cgi?id=44792
(help for new math function CSC, CSCH, SEC, SECH..)
I can write it easily, but I need a tool to generate the xml for the
help file.
My plan is to add the help
2012/1/27 Andras Timar :
> 2012/1/27 Caolán McNamara :
>> On Fri, 2012-01-27 at 14:01 +0100, Michael Stahl wrote:
>>> if it's not done, then i agree we should revert it asap;
>>> pushed to libreoffice-3-5:
>>>
>>> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=7fbfed6539d
Hi Noel,
On Fri, 2012-01-27 at 15:05 +0200, Noel Grandin wrote:
> Attached patch converts ScCustomShow to use std::vector.
I suppose you meant S*d*CustomShow. Anyway that typo accidentally got my
attention. :-)
> Not exactly sure how these kinds of classes that extend tools/List
> should be co
On Fri, 2012-01-27 at 14:06 +0100, Alex Thurgood wrote:
> I was under the impression that these wizards had all been converted to
> Python ?
Ho hum, that work is ongoing, and we're still stuck with the Java
versions I'm afraid (for now). The python stuff turned out (after I bust
a gut pa
On 18/01/12 13:33, Cedric Bosdonnat wrote:
> Hi Michael,
>
> On Tue, 2012-01-17 at 22:23 +0100, Michael Stahl wrote:
>> On 13/01/12 18:07, Cedric Bosdonnat wrote:
>>> Hi all,
>>>
>>> Could some of the other Writer gurus have a look at this patch: it
>>> should fix the crasher though it may not be
Hey,
>
> * unit test framework issues (Markus)
> + we are missing an important feature
> + cppunit development appears dead/stalled for 2+ yrs
> + but we support system-cppunit
> + can we not just declare ourselves the new up-stream
> for cppunit (Lione
Hi Kohei,
On Friday, 2012-01-27 09:53:50 -0500, Kohei Yoshida wrote:
> 4) Last point. List takes ownership of the contained objects, which
> means it automatically deletes those objects when destroyed. When you
> use vector, that convenience is gone, so you'll need to manually delete
> the cont
On Fri, 2012-01-27 at 16:46 +0100, Eike Rathke wrote:
> Actually no, List does not take ownership of objects and does not
> delete
> upon destruction! Ownership is only with SV_DECL_PTRARR_DEL and
> SV_DECL_PTRARR_SORT_DEL
Ah! Well, another reason why a class like this should be killed for
good.
I managed to hack together a "solaris.mk" file (by copying unxgcc.mk
and making a few "SUN" changes) and that got me a little further ...
then on compiling nss I had to modify
./unxsogi.pro/misc/build/nss-3.12.8/mozilla/security/coreconf/SunOS5.mk
and remove all the NS_USE_GCC if's (or rather every
On 27/01/12 16:44, Markus Mohrhard wrote:
> Hey,
>
>>
>> * unit test framework issues (Markus)
>>+ we are missing an important feature
>>+ cppunit development appears dead/stalled for 2+ yrs
>>+ but we support system-cppunit
>>+ can we not just declare ourse
On Tuesday 24 of January 2012, Stephan Bergmann wrote:
> On 01/24/2012 04:40 PM, Lubos Lunak wrote:
> > I intend to put just a short note to the documentation in sal/log.hxx
> > pointing to this file (so that additions wouldn't trigger rebuilds), but
> > I'm not sure where to put the file itself.
Hi,
we moved the used configuration from ~/.libreoffice to
~/.config/libreoffice between LO-3.4 and 3.5 on Linux. Unfortunately,
the old configuration is not migrated. I have finally got time to dig
into it again. The result is the attached patch. It works well here.
Another solution would be to
Hi,
I made a typo in my soffice.bin/soffice.exe icon reduction patch, so
Writer/Web has the wrong application icon under Windows in rc2. The
following commit fixes it.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=764674700d35d86890e3538039209f0397015096
Not a big deal, but a user has s
Hi there,
Thanks for that, nice work :-)
Is it possible that you missed the first patch in this series ? I had
to tweak the unusedcode.easy file so this applied, no problem but just
wondered. Pushed it ...
Thanks,
Michael.
--
michael.me...@suse.com <><
On Fri, 2012-01-27 at 12:23 +0100, Alexander Bergmann wrote:
> ---
> basegfx/inc/basegfx/vector/b2ivector.hxx | 65 -
> basegfx/source/vector/b2ivector.cxx | 67
> --
> unusedcode.easy |7 ---
> 3 files
On Fri, 2012-01-27 at 12:50 +0100, Alexander Bergmann wrote:
> ---
> basegfx/inc/basegfx/polygon/b3dpolygon.hxx |7 +---
> basegfx/inc/basegfx/polygon/b3dpolypolygon.hxx | 10 +-
> basegfx/source/polygon/b3dpolygon.cxx | 40
>
> basegfx/source/po
This patch removes unused code as listed in unusedcode.easy
From 7696cfebc875621dd68cbc65dc45772e530a79e7 Mon Sep 17 00:00:00 2001
From: Santiago Martinez
Date: Fri, 27 Jan 2012 21:45:33 +0100
Subject: [PATCH] Remove unused code as listed in unusedcode.easy
---
sc/source/ui/vba/vbachart.cxx |
Hi there,
I'd like to have the attached patch pushed to the 3-5 branch and
preferably to the 3-5-0 branch as well.
It fixes
https://bugs.freedesktop.org/show_bug.cgi?id=45084
I haven't committed this yet to master, since I wanted to have someone
else's opinion first. To the best of my knowled
these commits fix ODF import bugs described in fdo#38542 (regressions
from LO 3.3) and were already backported to libreoffice-3-5 by Cedric;
they want to be in libreoffice-3-5-0 and libreoffice-3-4 as well:
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=7cda0a56bf3f9d09
Hi,
> Shows a number of likely candidates; connecting to the 'ModifyHdl'
> and running the validator on the name, removing characters if it not valid
> might work; but of course.
>
> git grep SetModifyHdl
>
> for some instances of that; possibly we don't want to stop user inpu
Hi,
Here is a simple patch which includes a more informative error message
when the user enters an invalid sheet name in calc.
The exact wording can be debated. I opted for a more flowing message
instead of having a list, this seems to be consistent with the other
error/info messages in calc.
/Alb
Hello guys,
Forwarding this to ux-advise. Could you please have a look? Thanks :-)
On Sat, Jan 28, 2012 at 07:19, Albert Thuswaldner
wrote:
> Hi,
> Here is a simple patch which includes a more informative error message
> when the user enters an invalid sheet name in calc.
> The exact wording can
Hello,
Cppchecks reports this :
core/sd/source/ui/view/outlview.cxx
1623duplicateExpression style Same expression on both sides of '&&'.
Here are the lines :
1622 case tools::EventMultiplexerEvent::EID_PAGE_ORDER:
1623 if (mpOutliner != NULL && mpDoc!=N
Hi Julien,
28.01.2012 11:12, julien2412 пишет:
So either the duplicated part (obviously "mpOutliner != NULL") could be
simply removed
or perhaps the author thought about this :
mpOutlineViewShell != NULL
mpOutlineViewShell is initialized and dereferenced in the ctor, and
keeps its value al
65 matches
Mail list logo
