Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread Stephan Bergmann
On 01/22/2012 10:03 PM, Fridrich Strba wrote: Let us see what Stephan answers in the Windows bug. Fridrich, What Windows bug do you mean? Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/lis

Re: [Libreoffice] [PATCH] Replace ENSURE_OR_* macros with regular code.

2012-01-23 Thread Muthu Subramanian K
Hello Marcel, Thank you for the nice patch. Before pushing, it would be great to understand the reason behind replacing the macro with regular code. I believe the macro would help in improving code readability (and of course the code size) - in my understanding. Any particular reason, please? Tha

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread Lionel Elie Mamane
On Mon, Jan 23, 2012 at 09:02:16AM +0100, Stephan Bergmann wrote: > On 01/22/2012 10:03 PM, Fridrich Strba wrote: >> Let us see what Stephan answers in the Windows bug. > What Windows bug do you mean? https://bugs.freedesktop.org/show_bug.cgi?id=45058 -- Lionel _

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread Stephan Bergmann
On 01/22/2012 11:02 PM, Lionel Elie Mamane wrote: LD_LIBRARY_PATH envvar? With GNU ld, it is the only one I see. MacOS X has "@executable_path" which is *exactly* what we want in this situation: It is replaced by the path to the directory containing the *main* executable, not the path to the shar

Re: [Libreoffice] [Pushed] [PATCH] Removed LineListBox methods listed in unusedcode.easy

2012-01-23 Thread Muthu Subramanian K
Pushed! Thank you for the patch! Looking for more :) On 01/22/2012 05:44 PM, Mariusz Dykierek wrote: > Hi, > > Attached patch removes: > - LineListBox::GetEntryLine1 > - LineListBox::GetEntryLine2 > - LineListBox::GetEntryDistance > - LineListBox::GetSelectEntryLine1 > - LineListBox::GetSele

libreoffice@lists.freedesktop.org

2012-01-23 Thread Muthu Subramanian K
Thanks for the patch! On 01/22/2012 06:01 PM, Mariusz Dykierek wrote: > Attached patch removes > NfCurrencyEntry::ApplyVariableInformation(NfCurrencyEntry const&) as > listed in unusedcode.easy. > > > > > ___ > LibreOffice mailing list > LibreOffice

Re: [Libreoffice] [Pushed] [License Statement] [PATCH] EasyHack: remove obsolete BOOTSTRAP defines

2012-01-23 Thread Muthu Subramanian K
Pushed. Thank you for your patch. Looking for more! :) http://cgit.freedesktop.org/libreoffice/core/commit/?id=7735b09b5e10e366ffb3a156790316ea0ccfa0a0 On 01/22/2012 05:21 PM, Thomas Collerton wrote: > Hello, this patch addresses the EasyHack described > at https://bugs.freedesktop.org/show_bug.c

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread Fridrich Strba
Hello, On 23/01/12 09:07, Stephan Bergmann wrote: In the --with-openldap case, postgresql-sdbc-impl.uno.so contained in the postgresql-sdbc oxt links against some other lib than libldap50.so? One more reason to change it from an extension into a proper part of LO, I would say. I second Stephan

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread Stephan Bergmann
On 01/23/2012 09:07 AM, Stephan Bergmann wrote: One more reason to change it from an extension into a proper part of LO, I would say. Lionel, what do you think about changing the extension into an integral part of LO 3.5? It should make all problems go away (on all platforms; at least so I w

Re: [Libreoffice] Win-x86@6-fast tinderbox build help from core branch? was: ooo_custom_images to icon-themes

2012-01-23 Thread Jan Holesovsky
Hi Korrawit, On 2012-01-20 at 18:25 +0700, Korrawit Pruegsanusak wrote: > > By the way, I seem to have broken at least one tinderbox which seems > > to have been building from the libo 3.5 branch of core, but is still > > using help's master (which is now incompatible). The machine is: > > > >>

[Libreoffice] Build error in helpcontent2

2012-01-23 Thread Riccardo Magliocchetti
Hello, i'm trying to build libreoffice from git but it gives me an error in helpcontent2: Entering /home/rm/src/libo/helpcontent2/source/auxiliary echo aux_langdirs:=en-US > ../../unxlngi6.pro/inc/aux_langs.mk echo help_exist:=en-US > ../../unxlngi6.pro/inc/help_exist.mk rm -f ../../unxlngi6.

Re: [Libreoffice] .: sal/inc sal/osl

2012-01-23 Thread Petr Mladek
Michael Meeks píše v Pá 20. 01. 2012 v 17:34 +: > On Fri, 2012-01-20 at 17:06 +0100, Michael Stahl wrote: > > > +#if defined(__GNUC__) && (__GNUC__ < 3) > > > +struct ::stat a_stat, b_stat; > > > +#else > > > +struct stat a_stat, b_stat; > > > +#endif > > > > do we really need to have

Re: [Libreoffice] Build error in helpcontent2

2012-01-23 Thread David Tardon
On Mon, Jan 23, 2012 at 10:02:43AM +0100, Riccardo Magliocchetti wrote: > Hello, > > i'm trying to build libreoffice from git but it gives me an error in > helpcontent2: > > Entering /home/rm/src/libo/helpcontent2/source/auxiliary > > echo aux_langdirs:=en-US > ../../unxlngi6.pro/inc/aux_langs.m

Re: [Libreoffice] Build error in helpcontent2

2012-01-23 Thread Riccardo Magliocchetti
Il 23/01/2012 10:05, David Tardon ha scritto: On Mon, Jan 23, 2012 at 10:02:43AM +0100, Riccardo Magliocchetti wrote: Hello, i'm trying to build libreoffice from git but it gives me an error in helpcontent2: Entering /home/rm/src/libo/helpcontent2/source/auxiliary echo aux_langdirs:=en-US> .

[Libreoffice] How to discover a toolbutton callback function?

2012-01-23 Thread Rodolfo
Given a label of a toolbuton how can I discover which method it trigger? I can't find the "Increase Font" thing (I'd like to fix this bug https://bugs.freedesktop.org/show_bug.cgi?id=35862 ) Regards, Rodolfo ___ LibreOffice mailing list LibreOffice@lists

Re: [Libreoffice] Compiling question by a complete beginner

2012-01-23 Thread David Tardon
On Sat, Jan 21, 2012 at 10:49:10PM +0200, Barış Akkurt wrote: > Hi, I'm a complete beginner in LibreOffice development and at the compiling > step now. I tried instructions here: > http://wiki.documentfoundation.org/Development/Native_Build But compilation > failed while building the moz module. I

Re: [Libreoffice] [Libreoffice-qa] weird shortcut key for repeat action in Writer

2012-01-23 Thread Cedric Bosdonnat
On Mon, 2012-01-23 at 06:29 +0100, Jean-Baptiste Faure wrote: > Hi all, > > In LO 3.4.5 and LO 3.5.0 rc1+ we have a weird shortcut key in Writer in > the menu Edit > Repeat. It is the word "Encore". We have that for the UI > in French and even for the UI in English. > This shortcut key "Encore" i

Re: [Libreoffice] How to discover a toolbutton callback function?

2012-01-23 Thread Michael Meeks
Hi Rodolfo, On Mon, 2012-01-23 at 07:12 -0200, Rodolfo wrote: > Given a label of a toolbuton how can I discover which method it trigger? That's a really good question :-) > I can't find the "Increase Font" thing (I'd like to fix this bug > https://bugs.freedesktop.org/show_bug.cgi?id=358

Re: [Libreoffice] [Libreoffice-qa] weird shortcut key for repeat action in Writer

2012-01-23 Thread Michael Meeks
On Mon, 2012-01-23 at 10:25 +0100, Cedric Bosdonnat wrote: > That one is a bug. The keycode com::sun::star::awt::Key::REPEAT is > assigned to that menu entry... and it ends up being translated with the > Sun keyboard key (see that file [0]). Ho hum; nasty :-) > That brings several questi

Re: [Libreoffice] [PATCH] Replace ENSURE_OR_* macros with regular code.

2012-01-23 Thread Marcel Metz
Hello Muthu, On 23.01.2012 09:19, Muthu Subramanian K wrote: > Before pushing, it would be great to understand the reason behind > replacing the macro with regular code. Sure thing. The reason why I replaced the ENSURE_OR_* macros with regular code was the replacement of the OSL_ENSURE macro with

Re: [Libreoffice] Problem with clipboard paste in 3.5

2012-01-23 Thread Petr Cisar
Hello I did some tests, I tried to put some debug printouts to file clone/libs-gui/dtrans/source/generic/clipboardmanager.cxx, but never seen one while running LO. Also I tried to use gdb, but this file is not among the sources gdb loaded, and libdtrans is not in info sharedlibrary printout whe

Re: [Libreoffice] [Libreoffice-qa] weird shortcut key for repeat action in Writer

2012-01-23 Thread Pedro Lino
Hi Michael, all Well - I guess the -idea- is prolly to try to show the user the key > that is written on their keyboard, rather than a generic 'Ctrl' for > Control - it can show 'Control' (if that is what is written there) or > somesuch. > I think it would make sense for different countri

Re: [Libreoffice] [Libreoffice-qa] weird shortcut key for repeat action in Writer

2012-01-23 Thread Stefan Knorr (Astron)
Hi all, >> That brings several questions to me: how comes the translation of the >> key names is depending on the keyboard model? I have a normal french >> keyboard with en-US locale and en-US libreoffice build. > >        Well - I guess the -idea- is prolly to try to show the user the key > that

[Libreoffice] Use $(GPERF) not gperf

2012-01-23 Thread Baptiste Daroussin
Hi, With the new gmake build work the bug #32195 has been reintroduce in some part: The folloing fixes the one I have found so far: http://people.freebsd.org/~bapt/0001-use-GPERF-instead-of-using-gperf-from-path.patch As ususal, it respect all the license that fits the best libreoffice :) regar

Re: [Libreoffice] [Libreoffice-qa] weird shortcut key for repeat action in Writer

2012-01-23 Thread Pedro Lino
Hi Stefan, all > All we should need is localised versions of key names like Ctrl, Del, > Ins (that are on almost every keyboard [1], but whose names can > change) and global versions of key names for > alphanumeric/script-specific keys (which might not be on every > keyboard, but whose names are

Re: [Libreoffice] [PUSHED] Use $(GPERF) not gperf

2012-01-23 Thread Miklos Vajna
On Mon, Jan 23, 2012 at 11:31:14AM +0100, Baptiste Daroussin wrote: > With the new gmake build work the bug #32195 has been reintroduce in some > part: > > The folloing fixes the one I have found so far: > http://people.freebsd.org/~bapt/0001-use-GPERF-instead-of-using-gperf-from-path.patch > A

Re: [Libreoffice] Use $(GPERF) not gperf

2012-01-23 Thread Baptiste Daroussin
On Mon, Jan 23, 2012 at 11:31:14AM +0100, Baptiste Daroussin wrote: > Hi, > > With the new gmake build work the bug #32195 has been reintroduce in some > part: > > The folloing fixes the one I have found so far: > http://people.freebsd.org/~bapt/0001-use-GPERF-instead-of-using-gperf-from-path.p

Re: [Libreoffice] .: sw/source

2012-01-23 Thread Michael Stahl
On 29/12/11 00:39, Miklos Vajna wrote: > sw/source/filter/ww8/rtfattributeoutput.cxx | 297 > +--- > sw/source/filter/ww8/rtfexport.cxx | 74 +++--- > sw/source/filter/ww8/rtfexportfilter.cxx|2 > sw/source/filter/ww8/rtfimportfilter.cxx|2 >

[Libreoffice] gbuild: variables in user makefiles

2012-01-23 Thread Michael Stahl
hi Stephan, On 21/01/12 22:17, Michael Stahl wrote: > commit e2b3be6416df0c8913b2d6bb32c34fe162a0a019 > Author: Michael Stahl > Date: Sat Jan 21 19:36:01 2012 +0100 > > officecfg: namespace prefix make variable FILES if you have to define variables in user makefiles (and in officecfg ther

Re: [Libreoffice] .: sal/inc sal/osl

2012-01-23 Thread Michael Stahl
On 23/01/12 10:03, Petr Mladek wrote: > Michael Meeks píše v Pá 20. 01. 2012 v 17:34 +: >> On Fri, 2012-01-20 at 17:06 +0100, Michael Stahl wrote: +#if defined(__GNUC__) && (__GNUC__ < 3) +struct ::stat a_stat, b_stat; +#else +struct stat a_stat, b_stat; +#endif

Re: [Libreoffice] [Libreoffice-qa] weird shortcut key for repeat action in Writer

2012-01-23 Thread Stefan Knorr (Astron)
Hi Pedro, > That would be too simple. See my example in the previous email. > You would need to match the keys for EACH keyboard model, regardless of > Locale. Well, that doesn't scale (at least I can't believe it does), as it would probably make adding keyboard layout stuff a full-time job and a

Re: [Libreoffice] [PUSHED] send-feedback patch (was: Re: minutes of ESC call ...)

2012-01-23 Thread Thorsten Behrens
> let me get to that tomorrow first thing! > Sorry for the lag - patch is fine as-is I think, let's add the startcenter icon etc. as/when they arrive. Let's push this to -3-5 after the 3.5.0 branch-off. Cheers, -- Thorsten pgp2HFln1DVu9.pgp Description: PGP signature _

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 38177, which changed state. Bug 38177 Summary: Closing parent Base window leaves wizard generated table, query, report or form window in orphaned state https://bugs.freedesktop.org/show_bug.cgi?id=38177 What

[Libreoffice] [REVIEW][3-5] artificial italic and vertical/rotated text

2012-01-23 Thread Caolán McNamara
I'd like to get http://cgit.freedesktop.org/libreoffice/core/commit/?id=8f23e9813daae808aa2a81250b5e414dc57a3394 into 3-5. Fixes (seems to anyway) the out-of-order glyph rotation and skew-for-artifical-bold, i.e. https://bugs.freedesktop.org/show_bug.cgi?id=44856 Test case of qadevOOo/testdocs/ver

Re: [Libreoffice] validation documents for writer

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 12:28 +0200, Noel Grandin wrote: > I thought someone was running a test-bot that downloaded all of the > documents from bugzilla and loaded them? This would be ./bin/get-bugzilla-attachments-by-mimetype but its currently tuned for the mime-types I was interested in collecting

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread Lionel Elie Mamane
On Mon, Jan 23, 2012 at 09:07:13AM +0100, Stephan Bergmann wrote: > On 01/22/2012 11:02 PM, Lionel Elie Mamane wrote: >> OTOH, even if we find a good way to handle "library load path" >> issue, it still does not solve the problem of how the .oxt will >> work with a LibreOffice compiled with --with

Re: [Libreoffice] [PUSHED] send-feedback patch

2012-01-23 Thread Ivan Timofeev
Hi Thorsten, 23.01.2012 15:40, Thorsten Behrens пишет: Sorry for the lag - patch is fine as-is I think, let's add the startcenter icon etc. as/when they arrive. Thanks for reviewing/pushing! I was afraid that the hard-coded url is not fine, because I saw another urls in instsetoo_native/util

[Libreoffice] [PUSHED]PATCH] Same expression on both sides of || in if condition at libreoffice@lists.freedesktop.org (cppcheck)

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 23:21 +0100, Mariusz Dykierek wrote: > I guess this is what author intended. Yeah, well with Minutes->Nanosec anyway, looks like the intention. Pushed now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedes

[Libreoffice] [PUSHED][PATCH] A copy-paste bug detected by cppcheck at sdext/source/presenter/PresenterTimer.cxx:512

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 22:25 +0100, Mariusz Dykierek wrote: > Attached patch fixes a copy-paste error in the condition. > Seconds used twice instead of Hours. Ah indeed, good catch, looks good to me. Pushed now, thanks for this. C. ___ LibreOffice mail

[Libreoffice] [PUSHED][REVIEW] fdo#44983 Fix RTF import of \paperh and \paperw

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 21:56 +0100, Miklos Vajna wrote: > Hi, > > See > http://cgit.freedesktop.org/libreoffice/core/commit/?id=c39e891d4dc963d2cac9843b426494e4dc490278 > > Could somebody sign-off and push to -3-5, please? Looks sane to me, pushed to 3-5 now. C.

Re: [Libreoffice] [Pushed] Removed LineListBox methods listed in unusedcode.easy

2012-01-23 Thread Niko Rönkkö
Hi! On 23.01.2012 10:26, Muthu Subramanian K wrote: Pushed! Thank you for the patch! The only problem is that these entries will come back when the "call catcher" magician Caolán regenerates the unusedcode.easy list next time. -- RN ___ LibreOffice

[Libreoffice] [PUSHED 3-5] Re: Use $(GPERF) not gperf

2012-01-23 Thread Michael Stahl
On 23/01/12 12:15, Baptiste Daroussin wrote: > On Mon, Jan 23, 2012 at 11:31:14AM +0100, Baptiste Daroussin wrote: >> Hi, >> >> With the new gmake build work the bug #32195 has been reintroduce in some >> part: >> >> The folloing fixes the one I have found so far: >> http://people.freebsd.org/~ba

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread Stephan Bergmann
On 01/23/2012 01:45 PM, Lionel Elie Mamane wrote: Users loose the feature to use a newer PostgreSQL-SDBC with an older LibreOffice. But Fridrich and you agree it fixes all our issues, so OK, I consent to it. I'm happy to let you and/or Fridrich do the change. Doing it. Lionel, do you have a re

Re: [Libreoffice] [Pushed] Removed LineListBox methods listed in unusedcode.easy

2012-01-23 Thread Mariusz Dykierek
These should not (as they were actually removed in the source). As for the others, mentioned in other patch: "[PATCH] Removed nonexistent items from unusedcode.easy" A simple "grep -v suppress.list in.txt > unusedcode.easy" should do the trick. One more file to maintain, but false positives would

Re: [Libreoffice] [PATCH] Removed nonexistent items from unusedcode.easy

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 11:41 +0100, Mariusz Dykierek wrote: > Hi, > > Attached patch removes from "unusedcode.easy" a number of methods that cannot > be found in the > sources within the "core" directory. > > Can someone more experienced than I am confirm that items: > - CIcc*::* > - boost::gre

Re: [Libreoffice] sc_unoapi failure

2012-01-23 Thread Eike Rathke
Hi Stephan, On Monday, 2012-01-23 11:44:43 +0100, Stephan Bergmann wrote: > On 01/23/2012 11:38 AM, Stephan Bergmann wrote: > >The Linux-RHEL6-x86_64@14-with-check tinderbox is consistently failing > >with a crash in sc_unoapi in all the builds since the one whose failure > >mail is at the end of

Re: [Libreoffice] [ANN] LibreOffice 3.5.0 RC1 available

2012-01-23 Thread Thorsten Behrens
Pedro wrote: > "WARNING for Windows users: The Release Candidate will uninstall your > current stable build and replace it. If you do not wish this to happen but > still would like to test this Release you should follow the instructions for > installing in parallel > http://wiki.documentfoundation.

Re: [Libreoffice] Mozldap switch: --with-openldap to go away?

2012-01-23 Thread Rene Engelhard
Hi, On Mon, Jan 23, 2012 at 01:38:45PM +0100, Lionel Elie Mamane wrote: > I'm not sure if Debian configures LO with --with-openldap for a Because we didn't want to link with Mozilas libldap509.so (which evben isn't properly SONAMEd) and have a dependency on Mozilla for that. And that OpenLDAP is

Re: [Libreoffice] Easyhack : updating biblio.odb

2012-01-23 Thread Caolán McNamara
On Sat, 2012-01-21 at 12:36 -0800, julien2412 wrote: > Hello again, > > I discussed about it on IRC, there's nothing to do . > I updated the "completed task" page to remove this task. > I must have made something wrong with git or else but I don't want to do > this task again. These were the two

Re: [Libreoffice] [PUSHED][REVIEW][3-5] artificial italic and vertical/rotated text

2012-01-23 Thread Eike Rathke
Hi Caolán, On Monday, 2012-01-23 12:33:57 +, Caolán McNamara wrote: > I'd like to get > http://cgit.freedesktop.org/libreoffice/core/commit/?id=8f23e9813daae808aa2a81250b5e414dc57a3394 > into 3-5. Fixes (seems to anyway) the out-of-order glyph rotation and > skew-for-artifical-bold, i.e. > ht

Re: [Libreoffice] Flat ODF usage in Git [Was: concept for c++ based subsequenttests]

2012-01-23 Thread Niko Rönkkö
Only one query; I wonder whether we should be using the flat (fods) file-type for these tests - so we can read meaningful diffs to them in the git history. +1 for this... ... and I also think that all ODF files in git repos should be in Flat ODFormat so that the Git can track them easily

[Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

2012-01-23 Thread Stephan Bergmann
As discussed in the recent thread starting at "rpath / ... for extensions (and the case of PostgreSQL-SDBC)," it looks like the two bugs * "postgresql-sdbc doesn't

Re: [Libreoffice] "Found duplicate branches for if and else" in dbtree.cxx

2012-01-23 Thread Michael Stahl
On 21/01/12 08:53, julien2412 wrote: > Hello, > > Cppcheck reported this : > core/sw/source/ui/dbui/dbtree.cxx > 349 duplicateBranch style Found duplicate branches for if and else. > > if(bTable)<--- Found duplicate branches for if and > else. >

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread Lionel Elie Mamane
On Mon, Jan 23, 2012 at 02:20:31PM +0100, Stephan Bergmann wrote: > On 01/23/2012 01:45 PM, Lionel Elie Mamane wrote: >> Users loose the feature to use a newer PostgreSQL-SDBC with an >> older LibreOffice. But Fridrich and you agree it fixes all our >> issues, so OK, I consent to it. I'm happy to

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-23 Thread Caolán McNamara
On Tue, 2012-01-17 at 11:40 -0800, julien2412 wrote: > There was an extra semicolon after the while on the patch. Even if i re read > several times the code, I just missed it too and needed gdb to see it ! Now > it works better :-) *groan*, that was dumb of me. > Do you want to commit/push it you

Re: [Libreoffice] Flat ODF usage in Git [Was: concept for c++ based subsequenttests]

2012-01-23 Thread Michael Stahl
On 23/01/12 15:20, Niko Rönkkö wrote: >> Only one query; I wonder whether we should be using the flat (fods) >> file-type for these tests - so we can read meaningful diffs to them in >> the git history. > > +1 for this... > and I also think that all ODF files in git repos should be in Fl

Re: [Libreoffice] About fdo#42543

2012-01-23 Thread Caolán McNamara
On Sat, 2011-11-26 at 08:29 -0800, julien2412 wrote: > Hello, > > By taking a look at the bug fdo#42543 (major/high NEW Report Designer Wizard > missing Label display and editing capability) Is this still busted btw ? C. ___ LibreOffice mailing list L

Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

2012-01-23 Thread Michael Stahl
On 23/01/12 15:21, Stephan Bergmann wrote: > The attached > 0001-Changed-postgresql-sdbc-from-bundled-oxt-to-proper-o.patch (against > recent libreoffice-3-5) does just that. It builds fine on Linux and > produces installation sets that properly contain the various files for > the postgresql-s

Re: [Libreoffice] "Found duplicate branches for if and else" in dbtree.cxx

2012-01-23 Thread Caolán McNamara
On Fri, 2012-01-20 at 23:53 -0800, julien2412 wrote: > I took a look at the git history, it's been there since the initial commit > on 2000. > > So either the if(bTable) is useless or something's missing. I have no clues, but seeing as its been like that since pre 2000, might as well just remove

Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

2012-01-23 Thread Fridrich Strba
On 23/01/12 15:21, Stephan Bergmann wrote: Feel free to review for inclusion in LO 3.5. (I can do the actual push in case enough reviewers approve.) Go for it ! F. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedeskt

Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

2012-01-23 Thread Stephan Bergmann
On 01/23/2012 03:33 PM, Michael Stahl wrote: On 23/01/12 15:21, Stephan Bergmann wrote: The attached 0001-Changed-postgresql-sdbc-from-bundled-oxt-to-proper-o.patch (against recent libreoffice-3-5) does just that. It builds fine on Linux and produces installation sets that properly contain the

Re: [Libreoffice] Flat ODF usage in Git [Was: concept for c++ based subsequenttests]

2012-01-23 Thread Markus Mohrhard
Hello Niko, 2012/1/23 Niko Rönkkö : >>        Only one query; I wonder whether we should be using the flat (fods) >> file-type for these tests - so we can read meaningful diffs to them in >> the git history. > > > +1 for this... > ... and I also think that all ODF files in git repos should be in F

Re: [Libreoffice] bug in rc1

2012-01-23 Thread Petr Mladek
Cor Nouws píše v Pá 20. 01. 2012 v 20:25 +0100: > Hi Luc, > > Luc Castermans wrote (20-01-12 19:54) > > > Where to put translation bugs? > > all here > http://wiki.documentfoundation.org/BugReport > and info here > http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-2 You might

[Libreoffice] [REVIEW][3-5][3-4] resolved rhbz#783556 crash in Calc interpreter

2012-01-23 Thread Eike Rathke
Hi, please review and cherry-pick to 3-5 and 3-4 http://cgit.freedesktop.org/libreoffice/core/commit/?id=a7769e27849b74102e11540d7753576528323114 Resolves https://bugzilla.redhat.com/show_bug.cgi?id=783556 crash in Calc interpreter for external reference matrix. Thanks Eike -- LibreOffice Ca

Re: [Libreoffice] [libreoffice-l10n] Re: [Libreoffice-qa] [ANN] LibreOffice 3.5.0 RC1 pre-available

2012-01-23 Thread Petr Mladek
Luc Castermans píše v Čt 19. 01. 2012 v 17:45 +0100: > Just yesterday installed beta3, today rc1. Where/how can I find out > the differences ? All commit summaries are listed at http://download.documentfoundation.org/libreoffice/src/commit-log-libreoffice-3-5-release-3.5.0.1.log The commits with

Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

2012-01-23 Thread Lionel Elie Mamane
On Mon, Jan 23, 2012 at 03:21:30PM +0100, Stephan Bergmann wrote: > * > "postgresql-sdbc doesn't work on LO 3.5RC1 win32" > * > "PostgreSQL-SDBC fails to load on Unix / official binaries: mis

Re: [Libreoffice] Build error in helpcontent2

2012-01-23 Thread Pim Bollen
On Monday 23 January 2012 10:05:22 David Tardon wrote: > > You need to update the help repository. > > cd clone/help > git pull -r > > D. It does not help for me: [ pim@laptop-pim 1 ~/work/bootstrap master %]] cd clone/help/ [ pim@laptop-pim 0 ~/work/bootstrap/clone/help master]] git pull -r Cu

Re: [Libreoffice] Blocker in 3.5.0Beta3?

2012-01-23 Thread Petr Mladek
[via Document Foundation Mail Archive] píše v St 18. 01. 2012 v 09:00 -0800: > Hi all > > While installing LO 3.5.0Beta3 today in my Win XP Home x86 pt-PT > netbook I noticed that the installer only starts in Portuguese for a > brief second and then switches to English. > > I had never tried a

Re: [Libreoffice] Build error in helpcontent2

2012-01-23 Thread Andras Timar
Hi Pim, 2012/1/23 Pim Bollen : > On Monday 23 January 2012 10:05:22 David Tardon wrote: >> >> You need to update the help repository. >> >> cd clone/help >> git pull -r >> >> D. > > It does not help for me: > [ pim@laptop-pim 1 ~/work/bootstrap master %]] cd clone/help/ > [ pim@laptop-pim 0 ~/work

Re: [Libreoffice] Blocker in 3.5.0Beta3?

2012-01-23 Thread Andras Timar
Hi Petr, 2012/1/23 Petr Mladek : > [via Document Foundation Mail Archive] píše v St 18. 01. 2012 v 09:00 > -0800: >> Hi all >> >> While installing LO 3.5.0Beta3 today in my Win XP Home x86 pt-PT >> netbook I noticed that the installer only starts in Portuguese for a >> brief second and then switch

Re: [Libreoffice] .: sal/inc sal/osl

2012-01-23 Thread Michael Meeks
On Mon, 2012-01-23 at 12:35 +0100, Michael Stahl wrote: > ah, yes, that's about what i expected; also, for MacOSX gcc 4.0.1 is > used, which is AFAIK the oldest one. Great. > > So, I think that it is perfectly fine to remove support for GCC 2. > > i'd be very, very surprised if anything

Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

2012-01-23 Thread Stephan Bergmann
On 01/23/2012 04:16 PM, Lionel Elie Mamane wrote: "only fixed" is exaggerated. Maybe "most cleanly fixed". I came rather late to this discussion, so may miss some point completely. If you know of a non-hacky fix that does not require giving up the oxt, I'd be more than happy to not do the ch

[Libreoffice] REMINDER: Release 3.5.0-rc2 from libreoffice-3-5 branch

2012-01-23 Thread Petr Mladek
Hi, please note that the commit deadline for 3.5.0-rc2 is today, January 23, 2012. The branch libreoffice-3-5-0 is going to be created the day after. It will be used for 3.5.0-rc3 that should be 3.5.0-final. Only commits with 3 reviewers will be allowed for that branch. See also http://wiki.docu

Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] [PUSHED 3-5] fdo#45032 Calc export to HTML

2012-01-23 Thread Kohei Yoshida
On Sun, 2012-01-22 at 20:24 +0100, Eike Rathke wrote: > Hi, > > Please review and cherry-pick to 3.5.0 and 3-4 > http://cgit.freedesktop.org/libreoffice/core/commit/?id=d180de79b82d1a73cfd914dd9a1524109c5e78ee > > Resolves https://bugs.freedesktop.org/show_bug.cgi?id=45032 > Calc export to HTML w

Re: [Libreoffice] DisposedException on storeToURL

2012-01-23 Thread Caolán McNamara
On Mon, 2011-11-07 at 11:35 -0500, Grover Blue wrote: > I filed the following bug, but I'm hoping to get some help a bit > sooner. > > https://bugs.freedesktop.org/show_bug.cgi?id=42314 Works for me unfortunately. Would need a standalone reproducer program I think, e.g. backtrace suggests that ta

Re: [Libreoffice] [REVIEWED][PUSHED 3-5][PUSHED3-4] resolved rhbz#783556 crash in Calc interpreter

2012-01-23 Thread Kohei Yoshida
On Mon, 2012-01-23 at 16:03 +0100, Eike Rathke wrote: > Hi, > > please review and cherry-pick to 3-5 and 3-4 > http://cgit.freedesktop.org/libreoffice/core/commit/?id=a7769e27849b74102e11540d7753576528323114 > > Resolves https://bugzilla.redhat.com/show_bug.cgi?id=783556 crash in > Calc interpret

Re: [Libreoffice] [Libreoffice-qa] weird shortcut key for repeat action in Writer

2012-01-23 Thread Pedro Lino
Hi Rimas, all I think you'd just have to choose which label to use. Correctly matching > key names with the keyboard model is hardly impossible. I would say you'd > just have to choose whether to use Inserir or Insert, and stick to that > choice. Which strings you would choose would be completely

Re: [Libreoffice] sc_unoapi failure

2012-01-23 Thread Kohei Yoshida
On Mon, 2012-01-23 at 11:51 -0500, Kohei Yoshida wrote: > maItems.erase(maItems.end() - 1); Thanking a bit further, maybe changing that to maItems.erase(maItems.begin() + nIndex); should fix the crash? -- Kohei Yoshida, LibreOffice hacker, Calc ___

[Libreoffice] gnumake / header install & timestamps ...

2012-01-23 Thread Michael Meeks
Hi Alex, On Sat, 2012-01-21 at 18:01 +0100, Alex Thurgood wrote: > Just reporting back to say that it built fine in the end. Thanks for the report - it's really good to get these confirmations of extraordinary problems. I saw one over the weekend - where clearly code had been partially re

Re: [Libreoffice] [REVIEW][3-5][PUSHED] let postgresql-sdbc find its dependencies

2012-01-23 Thread Stephan Bergmann
On 01/23/2012 03:41 PM, Fridrich Strba wrote: Go for it ! Pushed now as with a few additional changes: fixed a typo in postgresql/makefile.mk that caused the -impl lib's UNO s

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||33302 --- Comment #123 from Petr Mladek 2

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||44719 --- Comment #124 from Petr Mladek 2

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #125 from Petr Mladek 2012-01-23 09:36:16 PST --- (In reply to comment #114) > Can I nominate Bug 34531 Let's leave it outside the list for now. I am not sure how many users are affected. The bug has already got some attention. It wo

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||40539 --- Comment #126 from Petr Mladek 2

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #127 from Petr Mladek 2012-01-23 10:01:22 PST --- (In reply to comment #105) > users from opennet.ru very complain on this bug: > Bug 40540 - FILESAVE During DOC export drawing is lost The objects are somehow special. Normal drawing

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 GerardF changed: What|Removed |Added Depends on||45067 --- Comment #128 from GerardF 2012-01-2

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #129 from Petr Mladek 2012-01-23 10:16:41 PST --- (In reply to comment #104) > possible regression, if confirmed: > Bug 44863 - Calc EDITING: when recovered after crash, impossible to enter into > cells Great catch. Well, let's leave

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread drew
On Mon, 2012-01-23 at 15:28 +0100, Lionel Elie Mamane wrote: > On Mon, Jan 23, 2012 at 02:20:31PM +0100, Stephan Bergmann wrote: > > On 01/23/2012 01:45 PM, Lionel Elie Mamane wrote: > > >> Users loose the feature to use a newer PostgreSQL-SDBC with an > >> older LibreOffice. But Fridrich and you

[Libreoffice] [Bug 41883] MinGW port Most Annoying Bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41883 --- Comment #12 from Rainer Bielefeld 2012-01-23 10:22:52 PST --- I add "Bug 44489 - MinGW: Will not launch" -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You ar

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||44863 --- Comment #130 from Petr Mladek 2

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||44862 --- Comment #131 from Petr Mladek 2

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on|44863 | -- Configure bugmail: https://bugs.freed

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 44862, which changed state. Bug 44862 Summary: Writer EDITING: LibO crashes when attempt to copy-paste from Calc and undo results https://bugs.freedesktop.org/show_bug.cgi?id=44862 What|Old Value

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #132 from Petr Mladek 2012-01-23 10:37:01 PST --- (In reply to comment #102) > possible regression, if confirmed: > Bug 44856 - Calc: font on screen looks corrupted It has been fixed in the meantime. -- Configure bugmail: https://b

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #133 from Petr Mladek 2012-01-23 11:18:55 PST --- (In reply to comment #100) > Possible regression from 3.3.4 if confirmed: > Bug 44829 - Impress EDITING: Undo not works when change master page Nice catch. I see it also with 3.4.5. I

[Libreoffice] [REVIEW] rhbz#746174 ODF export: numbering restart lost

2012-01-23 Thread Michael Stahl
the following fix for libreoffice-3.5: seems that under very special circumstances we don't export a list restart if the paragraph has only the restart flag set but no start value set. not a regression as far as i can tell; broken since OOo 3.0.1 at least. fixed on master: http://cgit.freedeskt

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread Stephan Bergmann
On 01/23/2012 06:51 PM, drew wrote: These are not scriptable tests..but if I can get a daily build with the update I'll do it all against pg and push the tests and results up to the wiki ASAP. FYI, the changes to postgresql-sdbc should be in LO 3.5 rc2 as well as in any master builds that are

Re: [Libreoffice] sc_unoapi failure

2012-01-23 Thread Eike Rathke
Hi Kohei, On Monday, 2012-01-23 11:55:15 -0500, Kohei Yoshida wrote: > > maItems.erase(maItems.end() - 1); > > Thanking a bit further, maybe changing that to > > maItems.erase(maItems.begin() + nIndex); > > should fix the crash? It did, muchas gracias :-) Eike -- LibreOffice

[Libreoffice] [PUSHED] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-23 Thread julien2412
Pushed on master and 3.5 branch. Julien. Caolán : I didn't succeed in putting you as the git author. Don't hesitate to update it :-) -- View this message in context: http://nabble.documentfoundation.org/PATCH-proposed-fix-for-fdo-44040-seems-iterator-issue-only-tp3659513p3682917.html Sent from

[Libreoffice] Handling ordering problem when properties are set one by one

2012-01-23 Thread Lubos Lunak
Hello, I have a bug that's related to databases in Writer (menu->Edit->Exchange Database and RES_HIDDENTXTFLD). The code that triggers it does a copy of the document in order to do the necessary substitutions there (well, this all is at least how I understand it) and during the copying it co

  1   2   >