[Libreoffice] Changes in tools causes build failure on Ubuntu Oneiric

2012-01-20 Thread Alex Thurgood
Hi all, It appears that the following change : diff --git a/tools/source/stream/strmunx.cxx b/tools/source/stream/strmunx.cxx index 850eedc..031aaa5 100644 --- a/tools/source/stream/strmunx.cxx +++ b/tools/source/stream/strmunx.cxx @@ -146,7 +146,7 @@ sal_Bool InternalStreamLock::LockFile( sal

Re: [Libreoffice] [Libreoffice-commits] .: connectivity/source "WaE: fix misc. SvStream operator problems."

2012-01-20 Thread Alex Thurgood
Le 19/01/2012 23:51, Stephan Bergmann a écrit : Hi Stephan, On 01/19/2012 11:19 PM, Alex Thurgood wrote: In file included from /home/alex/LODEV/core/tools/source/stream/strmsys.cxx:33:0: /home/alex/LODEV/core/tools/source/stream/strmunx.cxx: In static member function ‘static sal_Bool Interna

Re: [Libreoffice] [PUSHED][REVIEW] fdo#44915 missing MSI localizations

2012-01-20 Thread Fridrich Strba
Thanks, Andras, Cherry-picked with my signoff. F. On 19/01/12 23:33, Andras Timar wrote: Hi, https://bugs.freedesktop.org/show_bug.cgi?id=44915 This bug first looked mysterious, then limitation of MSI format was suspected. Fortunately it was not the case. Only a tool, msiinfo.exe has a limit

[Libreoffice] [REVIEW: 3.5] fdo#44947 not localizable strings

2012-01-20 Thread David Tardon
Hi all, commit a13d3436852a28c50a36c4ebd26c0e0c4fd9718c fixes https://bugs.freedesktop.org/show_bug.cgi?id=44947 , adding 12 localizable strings that were left out previously because they were passed as macro arguments (hey everyone: do not do this! Our tools are dumb and cannot handle it .-) Cou

Re: [Libreoffice] [REVIEW: 3.5] fdo#44947 not localizable strings

2012-01-20 Thread David Tardon
On Fri, Jan 20, 2012 at 10:09:30AM +0100, David Tardon wrote: > Hi all, > > commit a13d3436852a28c50a36c4ebd26c0e0c4fd9718c fixes Add commit 614feec5481ee618bea98dabab2df0281995385e to that, because I forgot git commit --amend -a -C HEAD before pushing... D. _

Re: [Libreoffice] Changes in tools causes build failure on Ubuntu Oneiric

2012-01-20 Thread Michael Meeks
Hi Alex, On Fri, 2012-01-20 at 09:18 +0100, Alex Thurgood wrote: > It appears that the following change : ... > Now causes my build to fail on Oneiric after a pull and make clean > yesterday evening. If you read git log; you'll see that the change to sal and the change to tools happened

Re: [Libreoffice] Changes in tools causes build failure on Ubuntu Oneiric

2012-01-20 Thread Alexander Thurgood
Le 20/01/12 10:57, Michael Meeks a écrit : Hi Michael, > > If you read git log; you'll see that the change to sal and the change > to tools happened at the same time. So it's rather unclear how that can > be. > > Are you building from the top-level with a 'make' ? can you confirm >

Re: [Libreoffice] [REVIEWED] fdo#44947 not localizable strings

2012-01-20 Thread Andras Timar
Hi, 2012/1/20 David Tardon : > On Fri, Jan 20, 2012 at 10:09:30AM +0100, David Tardon wrote: >> Hi all, >> >> commit a13d3436852a28c50a36c4ebd26c0e0c4fd9718c fixes > > Add commit 614feec5481ee618bea98dabab2df0281995385e to that, because I > forgot git commit --amend -a -C HEAD before pushing... >

Re: [Libreoffice] [REVIEWED] fdo#44947 not localizable strings

2012-01-20 Thread Andras Timar
2012/1/20 Andras Timar : > Hi, > > 2012/1/20 David Tardon : >> On Fri, Jan 20, 2012 at 10:09:30AM +0100, David Tardon wrote: >>> Hi all, >>> >>> commit a13d3436852a28c50a36c4ebd26c0e0c4fd9718c fixes >> >> Add commit 614feec5481ee618bea98dabab2df0281995385e to that, because I >> forgot git commit --

[Libreoffice] Blanket license for contributions to LibreOffice project

2012-01-20 Thread Mariusz Dykierek
Hi All, All my previous and future contributions to the LibreOffice project are licensed under the terms of the LGPLv3+ / MPL. -- Best regards, Mariusz Dykerek ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.o

[Libreoffice] Win-x86@6-fast tinderbox build help from core branch? was: ooo_custom_images to icon-themes

2012-01-20 Thread Korrawit Pruegsanusak
Hello Norbert, Jan, On Mon, Jan 16, 2012 at 20:48, Stefan Knorr (Astron) wrote: [snip] > By the way, I seem to have broken at least one tinderbox which seems > to have been building from the libo 3.5 branch of core, but is still > using help's master (which is now incompatible). The machine is: >

Re: [Libreoffice] [REVIEW][3-4] date change regression fdo#44385

2012-01-20 Thread Noel Power
Hi Andrew, My primary concerns 1. Change in behavior that may break existing code. the intent of the patch is to restore the previous behaviour ( by previous behaviour I mean before integration of the feature that erroneously removed the 'special' processing for '+' for dates ). Additionally

Re: [Libreoffice] [REVIEW][3-4] date change regression fdo#44385

2012-01-20 Thread Noel Grandin
On 2012-01-20 13:32, Noel Power wrote: [*] table of behaviour in vba, pre the bug being introduced and post patch msoold behaviour present date + numDate Date Dat

Re: [Libreoffice] [REVIEW][3-4] date change regression fdo#44385

2012-01-20 Thread Andrew Douglas Pitonyak
On 01/20/2012 06:32 AM, Noel Power wrote: Hi Andrew, My primary concerns 1. Change in behavior that may break existing code. the intent of the patch is to restore the previous behaviour ( by previous behaviour I mean before integration of the feature that erroneously removed the 'special' pr

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #115 from mal 2012-01-20 05:44:22 PST --- (In reply to comment #114) > Can I nominate Bug 34531 > > Not letting the Smartboard ink layer get above an Impress presentation on a > second screen makes Impress pretty useless in most scho

[Libreoffice] [REVIEW] Fixing page break button flickering

2012-01-20 Thread Cedric Bosdonnat
Hi all, Moving the mouse over the page break line simply makes the button flicker... it's then not possible to see or click on it. The bug has only been reported on this list and ux-advise. This is caused by the following commit: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-

Re: [Libreoffice] [REVIEW] Fix RTF import of dotted and word underline

2012-01-20 Thread Cedric Bosdonnat
Hi Miklos, Your patch is OK for me. I just cherry-picked it and pushed it. -- Cedric On Fri, 2012-01-20 at 01:40 +0100, Miklos Vajna wrote: > Hi, > > See > http://cgit.freedesktop.org/libreoffice/core/commit/?id=370fc96b92e59d35c2eb2e14fd77eb14bfc72fd4 > > Could somebody sign-off and push to -

Re: [Libreoffice] [REVIEW][3-4] date change regression fdo#44385

2012-01-20 Thread Noel Power
On 20/01/12 13:40, Andrew Douglas Pitonyak wrote: On 01/20/2012 06:32 AM, Noel Power wrote: note there is a mistake in the table below [*] table of behaviour in vba, pre the bug being introduced and post patch msoold behaviour present

Re: [Libreoffice] .: sal/inc sal/osl

2012-01-20 Thread Michael Stahl
On 19/01/12 18:04, Michael Meeks wrote: > sal/inc/osl/detail/file.h |6 -- > sal/osl/unx/file_stat.cxx | 20 ++-- > 2 files changed, 10 insertions(+), 16 deletions(-) > > New commits: > commit c5d4f4967e5d9d0220fadf3f313ddc35002cdf27 > Author: Michael Meeks > Date: Th

Re: [Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn

2012-01-20 Thread Kohei Yoshida
On Fri, 2012-01-20 at 15:15 +0200, Noel Grandin wrote: > Hi > > this patch passes valgrind tests in the sc module, and passes a global > make check. Yup. All looks green. Nice work. :-) Before I push, could you verify that you are submitting this patch under GPLv3+/LGPLv3+/MPL1.1+ licenses?

[Libreoffice] review [3-5] regression fdo#44385

2012-01-20 Thread Noel Power
This patch was already reviewed for 3.4 ( but is equally valid for 3.5 ) Presumably a new review ( and +1 ) is needed for this? thanks Noel Note: on master we are currently doing something different ( at least tweaking the date behaviour a little more.. ) 0001-restore-special-DATE-handli

Re: [Libreoffice] .: sal/inc sal/osl

2012-01-20 Thread Michael Meeks
On Fri, 2012-01-20 at 17:06 +0100, Michael Stahl wrote: > > +#if defined(__GNUC__) && (__GNUC__ < 3) > > +struct ::stat a_stat, b_stat; > > +#else > > +struct stat a_stat, b_stat; > > +#endif > > do we really need to have ifdefs for GCC 2 in LO? Probably not :-) I just re-used wh

[Libreoffice] [PUSHED] Re: review [3-5] regression fdo#44385

2012-01-20 Thread Michael Stahl
On 20/01/12 18:27, Noel Power wrote: > This patch was already reviewed for 3.4 ( but is equally valid for 3.5 > ) Presumably a new review ( and +1 ) is needed for this? hmm.. dunno; pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=7c18b784ce1e6a5e71e978cd3c896b2

[Libreoffice] [PUSHED] Re: [PATCH] [REVIEW-3-5] fdo#44025 isLast() erroneously returns true

2012-01-20 Thread Michael Stahl
On 19/01/12 20:47, Lionel Elie Mamane wrote: > Attached patch fixes fdo#44025; the original symptom is "search in a > database does not go beyond prefetch window". The underlying reason is > that dbaccess::ORowSetCache::isLast() returns true on the last line of > the *prefetch* *window* even if it

[Libreoffice] License statement

2012-01-20 Thread Santiago Martinez
Hi, all my contributions to the LibreOffice project are done under the terms of the LGPLv3+/ MPL1.1 licenses. Best regards, Santiago Martinez ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/l

[Libreoffice] bug in rc1

2012-01-20 Thread Luc Castermans
Gents, Where to put translation bugs? I noticed in 3,5rc1 Dutch that after: Insert -> Fields -> Pagenumber -- Luc Castermans mailto:luc.casterm...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.o

[Libreoffice] [PATCH] Remove unused code

2012-01-20 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From aea46d66c3f360782436ff53150d92877b687a45 Mon Sep 17 00:00:00 2001 From: Santiago Martinez Date: Fri, 20 Jan 2012 19:42:48 +0100 Subject: [PATCH] Removed unused code as listed in unusedcode.easy --- filter/inc/filter/msfilter/mstool

Re: [Libreoffice] bug in rc1

2012-01-20 Thread Luc Castermans
Gents, Where to put translation bugs? I noticed in 3,5rc1 Dutch that   after: Menu Text in document Invoegen -> Velden -> Paginanummer Paginanummers Invoegen -> Velden -> Aantal Pagina''s

[Libreoffice] [ANN] LibreOffice 3.5.0 RC1 available

2012-01-20 Thread Thorsten Behrens
Dear Community, The Document Foundation is happy to announce the first release candidate of LibreOffice 3.5.0. The upcoming 3.5 will be our third major release line, packed with many exciting new features. Please be aware that LibreOffice 3.5.0 RC1 is not ready for production use, you should conti

[Libreoffice] [PATCH] Remove unused code

2012-01-20 Thread Santiago Martinez
From b42ee34845fdaf5e794a8b9319cf5a736fcbf653 Mon Sep 17 00:00:00 2001 From: Santiago Martinez Date: Fri, 20 Jan 2012 20:06:44 +0100 Subject: [PATCH] Remove unused code. --- unusedcode.easy |1 - vcl/inc/vcl/vclevent.hxx|1 - vcl/source/app/vclevent.cxx |4 3 fi

Re: [Libreoffice] bug in rc1

2012-01-20 Thread Cor Nouws
Hi Luc, Luc Castermans wrote (20-01-12 19:54) Where to put translation bugs? all here http://wiki.documentfoundation.org/BugReport and info here http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-2 -- - Cor - http://nl.libreoffice.org ___

[Libreoffice] [PUSHED] Re: [PATCH] Translate German comments

2012-01-20 Thread Michael Stahl
On 20/01/12 13:50, Philipp Weissenbacher wrote: > Hi lo-devs, > Some more translations ... thanks, pushed (with some tweaks) notes: - "Vorlage" can mean either "template" (if it's a document) or "style" if it's some content element (the latter are called *FmtColl in writer) - there is no "too les

Re: [Libreoffice] [PATCH] Remove unused code

2012-01-20 Thread Michael Stahl
On 20/01/12 19:56, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy thanks Santiago for the patch, pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7ce98f34150d430b12804eb9796e4142b7c6517c ___ LibreO

Re: [Libreoffice] [PATCH] Remove unused code

2012-01-20 Thread Michael Stahl
On 20/01/12 20:13, Santiago Martinez wrote: > -VclEventListeners2::~VclEventListeners2() > -{ > -} i'm not sure this is right; if a destructor of a class is unused, but its other methods are used, then that usually indicates a memory leak: the destructor is never called because all instances are

Re: [Libreoffice] [ANN] LibreOffice 3.5.0 RC1 available

2012-01-20 Thread Pedro
Thorsten Behrens wrote > > Please be aware that LibreOffice 3.5.0 RC1 is not ready for production > use, > you should continue to use LibreOffice 3.4.5 for that. > The following sentence (or similar) should be added when announcing a Release Candidadate: "WARNING for Windows users: The Releas

Re: [Libreoffice] [PATCH] Remove unused code

2012-01-20 Thread Stephan Bergmann
On 01/20/2012 09:57 PM, Michael Stahl wrote: i'm not sure this is right; if a destructor of a class is unused, but its other methods are used, then that usually indicates a memory leak: the destructor is never called because all instances are leaked. It might make sense to treat destructors spe

Re: [Libreoffice] [ANN] LibreOffice 3.5.0 RC1 available

2012-01-20 Thread Cor Nouws
Pedro wrote (20-01-12 22:01) The following sentence (or similar) should be added when announcing a Release Candidadate: [...] I think that this problem does not apply to Mac and Linux, right? I think it does. Luckily the release notes, clearly linked and advised from the pre-release download

Re: [Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn

2012-01-20 Thread Noel Grandin
I hereby confirm that this and my future contributions are licensed under GPLv3+/LGPLv3+/MPL1.1+ The problem was in ScColumn::Resize I was calling vector::resize when the correct call is vector::reserve At some point I should rename the ScColumn::Resize method to match the std::vector naming --

Re: [Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn

2012-01-20 Thread Kohei Yoshida
Hi Noel, On Sat, 2012-01-21 at 00:01 +0200, Noel Grandin wrote: > I hereby confirm that this and my future contributions are licensed > under GPLv3+/LGPLv3+/MPL1.1+ Thanks for the confirmation. Just pushed to master, with my follow-up changes (as I mentioned in my earlier post). > The problem w

Re: [Libreoffice] [PATCH/REVIEW-3-4] Backport reading AES-encrypted ODF 1.2 documents (as genereated by LibO 3.5)

2012-01-20 Thread Cor Nouws
Cor Nouws wrote (21-11-11 13:57) Hi Michael, It'd be great if that final text ended up at: http://wiki.documentfoundation.org/ReleaseNotes/3.5 Yes, that's the kind of page where I do this for. to describe the feature in 3.5, and that you'd want an updated 3.4.x to interop with it for this

Re: [Libreoffice] [PATCH] Remove unused code

2012-01-20 Thread Eike Rathke
Hi Michael, On Friday, 2012-01-20 21:57:25 +0100, Michael Stahl wrote: > > -VclEventListeners2::~VclEventListeners2() > > -{ > > -} > > i'm not sure this is right; if a destructor of a class is unused, but > its other methods are used, then that usually indicates a memory leak: > the destructor

Re: [Libreoffice] [PUSHED][PATCH] Remove unused code

2012-01-20 Thread Eike Rathke
Hi, On Friday, 2012-01-20 21:53:57 +0100, Michael Stahl wrote: > thanks Santiago for the patch, pushed: Marking thread [PUSHED] Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD p

[Libreoffice] [REVIEW 3-4] resolve fdo#43725 crash

2012-01-20 Thread Eike Rathke
Hi, Attached is a backport to 3-4 of http://cgit.freedesktop.org/libreoffice/core/commit/?id=6198fcd7064180a0bf8a6d67f63f784610aa9ba8 Please review and cherry-pick to 3-4, this resolves https://bugs.freedesktop.org/show_bug.cgi?id=43725 crash when saving document after having added a sheet Eik

Re: [Libreoffice] [REVIEW][3-4] date change regression fdo#44385

2012-01-20 Thread Andrew Douglas Pitonyak
On 01/20/2012 10:30 AM, Noel Power wrote: On 20/01/12 13:40, Andrew Douglas Pitonyak wrote: On 01/20/2012 06:32 AM, Noel Power wrote: note there is a mistake in the table below [*] table of behaviour in vba, pre the bug being introduced and post patch mso

[Libreoffice] packimages: many files not found

2012-01-20 Thread Korrawit Pruegsanusak
Hello all, >From a tinderbox success build log [1] of master branch, we have these errors: packimages: file ´/Volumes/Raid0/core/icon-themes/galaxy/res/addresspilot.png´ not found packimages: file ´/Volumes/Raid0/core/icon-themes/galaxy/scanner/handle.png´ not found packimages: file ´/Volumes/Rai

Re: [Libreoffice] [PUSHED} [REVIEW 3-4] resolve fdo#43725 crash

2012-01-20 Thread Norbert Thiebaud
On Fri, Jan 20, 2012 at 7:34 PM, Eike Rathke wrote: > Hi, > > Attached is a backport to 3-4 of > http://cgit.freedesktop.org/libreoffice/core/commit/?id=6198fcd7064180a0bf8a6d67f63f784610aa9ba8 > > Please review and cherry-pick to 3-4, this resolves > https://bugs.freedesktop.org/show_bug.cgi?id=4

[Libreoffice] "Found duplicate branches for if and else" in dbtree.cxx

2012-01-20 Thread julien2412
Hello, Cppcheck reported this : core/sw/source/ui/dbui/dbtree.cxx 349 duplicateBranch style Found duplicate branches for if and else. if(bTable)<--- Found duplicate branches for if and else. InsertEntry(sName, pParent);