Spotted some mistakes in calc patch.
>From e7db01344f8fef4ca2f2f59868736033d0126b1b Mon Sep 17 00:00:00 2001
From: Maciej Rumianowski
Date: Mon, 18 Jul 2011 09:22:57 +0200
Subject: [PATCH] Get rid of SvULongs in calc
Instead of SvULongs use ::std::vector < sal_uLong >
---
.../itemsetwrapper/Data
Hi Matúš, Hi Tor,
On Mon, 18 Jul 2011 00:32:49 -0600
"Tor Lillqvist"
wrote:
> Hmm, I looked at the first patch, and I definitely don't think we
> should re-introduce some Hamburg-specific stuff that we don't
> understand, want or need. Not even OOo at Apache will (once they have
> something they
On Fri, 2011-07-15 at 16:35 +0100, Noel Power wrote:
> Hi Caolán
>
> could you have a look at this patch
> http://cgit.freedesktop.org/libreoffice/writer/commit/?id=95351a519bec2833f5d936c20e3916a4e283b0f6
>
> This should be a nice stroll down memory lane for you as it seems
> related to http://
On Mon, 2011-07-18 at 02:04 +0900, Takeshi Abe wrote:
> I would like to introduce my pet project libo-basic-mode:
> https://github.com/tabe/libo-basic-mode
> so that it can obtain your kind review.
Nice :-) I wonder how best to distribute these developer tools - the
python gdb bindings ar
Hi Caolan,
On Sun, 2011-07-17 at 11:22 +0100, Caolán McNamara wrote:
> Where an extra "utl" string is to be prefixed to the stock
> component_getFactory entry point string to give an entry point of
Which makes me wonder: does callcatcher cope with eliding
foo_component_ prefixed methods w
Andras Timar píše v Čt 14. 07. 2011 v 23:00 +0200:
> Hi Petr,
>
> 2011.07.12. 16:02 keltezéssel, Petr Mladek írta:
> > there have been created the libreoffice-3.4.2.1 tag for 3.4.2-rc1 release.
> > The corresponding official builds will be available by the end of the week.
> >
> > See the attache
Hi Matus,
On Sat, 2011-07-16 at 23:18 +0200, Matúš Kukan wrote:
> It seems to be unused also in VCLTestTool. At least I could not grep
> aVersionString from
Ah - but aVersionString is a widget - so this gets displayed in the
dialog as a FixedText - without anyone else needing to do anythi
Hi,
the attached patch fixes two problems found when calling make
distro-pack-install" as normal user.
It would be great to get it into libreoffice-3-4-2 branch.
Best Regards,
Petr
>From 64653bcd8c1f1deeb8483e0d3e4ee8768a807b5d Mon Sep 17 00:00:00 2001
From: Petr Mladek
Date: Mon, 18 Jul 201
Hi Laurent,
On Fri, 2011-07-15 at 19:41 +0200, Laurent Godard wrote:
> Here is my first patch and want at first thanks a lot everybody who
> helped me starting my build and especially Kohei for his patience and
> deep knowledge in calc. Kohei is a great mentor :-)
First - welcome ! :-) it
Hi Petr,
On Mon, 2011-07-18 at 12:39 +0200, Petr Mladek wrote:
> the attached patch fixes two problems found when calling make
> distro-pack-install" as normal user.
Both look fine / trivial to me, I've pushed to libreoffice-3-4, two
more reviews needed for libreoffice-3-4-2.
Tha
On Sun, Jul 17, 2011 at 11:22:45AM +0100, Caolán McNamara wrote:
> On Sun, 2011-07-17 at 08:13 +0200, Francois Tigeot wrote:
> >
> > It seems like OTempFileService, defined and implemented in
> > libs-gui/unotools/source/ucbhelper is unused.
> >
> > There's no mention of this name elsewhere in th
On Mon, 18 Jul 2011 11:51:29 +0100
Michael Meeks
wrote:
> Both look fine / trivial to me, I've pushed to
> libreoffice-3-4, two more reviews needed for libreoffice-3-4-2.
Looks fine to me too. One more review needed for 3-4-2.
Best,
Bjoern
--
https://launchpad.net/~bjoern-michaelsen
Hi Mike,
On Fri, 2011-07-15 at 12:34 -0700, Mike Eberdt wrote:
> This patch eliminates a "test: : bad number" diagnostic on FreeBSD.
> Contributed under LGPL3+/MPL.
Thanks; I pushed it, and then updated it to use:
if test "z$EUID" = "z0" -a "z`uname -o 2>/dev/null`" = "zCygwin"; then
Hi MIke, *,
On Fri, Jul 15, 2011 at 9:34 PM, Mike Eberdt wrote:
>
> Configure.in eventually gets parsed by /bin/sh, and on Free/Net/OpenBSD
> /bin/sh is not synonymous with bash. Therefore, bash-isms in configure.in
> can be problematic.
I don't understand your patch then.
-if test "$EUID" -eq
On Wed, 2011-07-13 at 11:17 +0800, jeffrey chang wrote:
> Hi,
>
> Second patch for bug. Now the undo statement for "Insert Horizontal
> Rule" replaces "Insert horizontal ruler".
Hi Jeffrey,
Sorry it took so long to attend to your patch. I've applied and pushed
to master, but I did change your c
On Thu, 2011-07-14 at 10:31 +0200, David Tardon wrote:
> Nitpick, unrelated to the review: you may want to disable operator= for
> storage_filled_linear (and storage_filled_nested_array too), because its
> use would cause double delete.
Good point. Done (on master for the next release). Thanks
Hello Troy,
Digging mailing-list archive and just glancing at your patch,
isn't this patch against fdo#33960 ?
(https://bugs.freedesktop.org/show_bug.cgi?id=33960)
IMHO it isn't likely to be 33898.
Best Regards,
--
Korrawit Pruegsanusak
___
LibreOffice
Hi Michael,
Thank you for your suggestion!
On Mon, 18 Jul 2011 11:22:38 +0100, Michael Meeks
wrote:
>
> On Mon, 2011-07-18 at 02:04 +0900, Takeshi Abe wrote:
>> I would like to introduce my pet project libo-basic-mode:
>> https://github.com/tabe/libo-basic-mode
>> so that it can obtain your ki
Hi Laurent,
On Fri, 2011-07-15 at 19:41 +0200, Laurent Godard wrote:
> thanks in advance for your review and thank a lot again to Kohei
Oh, thanks a lot for working on this performance optimization! :-)
As I've already been involved in reviewing your changes & giving you
code pointers etc, your
Hi Takeshi,
On Mon, 2011-07-18 at 23:22 +0900, Takeshi Abe wrote:
> Thank you for your suggestion!
Hey - no problem; I think once we have a place for misc. system tools,
it'll be much easier to get them widely packaged, and add to them.
> On Mon, 18 Jul 2011 11:22:38 +0100, Michael Meeks
Hi there,
On Fri, 2011-07-15 at 00:55 +0200, Markus Mohrhard wrote:
> So one review needed to get it into 3.4.2. It is an quite important
> fix as we got several reports where people reported they thought that
> calc froze and switched back to 3.3.2.
So:
git diff --numstat 0_5_2..0_5_3
Hi,
the below patches should fix two more problems reported by Andy. I would
like to get them into libreoffice-3-4-2 branch.
Best Regards,
Petr
>From 7b202653f352a6c1bd18066bc71c93b1a5b33c13 Mon Sep 17 00:00:00 2001
From: Petr Mladek
Date: Mon, 18 Jul 2011 16:48:49 +0200
Subject: [PATCH 2/3] d
Hi guys,
On Sat, 2011-07-16 at 01:08 +0200, Jonas Finnemann Jensen wrote:
> Please let me know if it looks problematic
> Looks great :)
I'd like to get Miklos' crasher fix pair (just a couple of null pointer
checks) back-ported from libreoffice-3-4 into libreoffice-3-4-2, so far
J
Andreas Radke píše v Ne 17. 07. 2011 v 21:26 +0200:
> 1) I have to pass yes to the install process due to some overwritten
> files: yes | make DESTDIR=${srcdir}/fakeinstall distro-pack-install
>
> Installer finished
[...]
> Copying GNOME icons ..
> chmod: cannot operate on dangling symlink
> `/b
Yifan Jiang píše v Po 18. 07. 2011 v 10:46 +0800:
> Hi Petr,
>
> Is there a constant rule for checking the exact version from UI directly? For
> example,
>
> Help->About
>
> LibreOffice 3.4 340m1(Build:103)
>
> At the moment, it looks the Build:103 means 3.4.1 RC 3. Does it reliable
> enough?
On Wed, 2011-07-13 at 21:32 +0100, Noel Power wrote:
> +1 and applied to 3.4 ( and master ) branch(s)
And a last time - and pushed for 3.4.2.
Thanks,
Michael.
--
michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot
Hi Kohei,
On Fri, 2011-07-15 at 09:48 +0100, Noel Power wrote:
> looks fine to me +1, one more needed for 3.4.2
Ditto here; much preferred to creating that new temporary DPObject :-)
I've merged to libreoffice-3-4-2. I closed the bug too ;-)
Thanks,
Michael.
--
On Mon, 2011-07-18 at 11:25 +0100, Michael Meeks wrote:
> Hi Caolan,
>
> On Sun, 2011-07-17 at 11:22 +0100, Caolán McNamara wrote:
> > Where an extra "utl" string is to be prefixed to the stock
> > component_getFactory entry point string to give an entry point of
>
> Which makes me wonder:
On Mon, 2011-07-18 at 10:25 -0400, Kohei Yoshida wrote:
> I'd also
> like to push this to the -3-4 branch, but let me just do a quick test on
> ODS import of named ranges to make sure if works, then I'll push.
And I'm glad I did. This change unfortunately causes a problem on
global named range i
Michael Meeks píše v Po 18. 07. 2011 v 15:59 +0100:
> Hi guys,
>
> On Sat, 2011-07-16 at 01:08 +0200, Jonas Finnemann Jensen wrote:
> > Please let me know if it looks problematic
> > Looks great :)
>
> I'd like to get Miklos' crasher fix pair (just a couple of null pointer
> checks)
Hi,
please note that the commit deadline for 3.4.2-rc2 is today, Jul 18,
2011. It will be used as LO-3.4.2 final if no blocker is reported.
See also
http://wiki.documentfoundation.org/ReleasePlan#3.4_release
http://wiki.documentfoundation.org/Release_Criteria
http://wiki.documentfoundation.org/De
Am Mon, 18 Jul 2011 12:39:26 +0200
schrieb Petr Mladek :
> Hi,
>
> the attached patch fixes two problems found when calling make
> distro-pack-install" as normal user.
>
> It would be great to get it into libreoffice-3-4-2 branch.
>
>
> Best Regards,
> Petr
>
>
Booth issues seem fixed for m
Hi all,
According to a discussion on the Japanese local mailing list,
the following issue may prevent some users from migrating
to 3.4.x series:
https://bugs.freedesktop.org/show_bug.cgi?id=38095
I am not yet sure how it works in 3.3.x, but at least for Calc
on master, there seems a gap around de
Am Mon, 18 Jul 2011 16:58:03 +0200
schrieb Petr Mladek :
> Hi,
>
> the below patches should fix two more problems reported by Andy. I
> would like to get them into libreoffice-3-4-2 branch.
>
> Best Regards,
> Petr
>
>
The first patch works as expected.
The second patch doesn't fix the file
Michael Meeks píše v Po 18. 07. 2011 v 16:36 +0100:
> Hi Kohei,
>
> On Fri, 2011-07-15 at 09:48 +0100, Noel Power wrote:
> > looks fine to me +1, one more needed for 3.4.2
>
> Ditto here; much preferred to creating that new temporary DPObject :-)
> I've merged to libreoffice-3-4-2. I closed
For a long time now we see lots of files installed with permission 444
and 555 in ArchLinux. We are not sure if this is caused by a bug in our
chroot environment using fakeroot or due to the LibO installer. Because of
the missing write permission our build tools fail to strip the symbols.
So we app
On Mon, 2011-07-18 at 11:47 -0400, Kohei Yoshida wrote:
> On Mon, 2011-07-18 at 10:25 -0400, Kohei Yoshida wrote:
>
> > I'd also
> > like to push this to the -3-4 branch, but let me just do a quick test on
> > ODS import of named ranges to make sure if works, then I'll push.
>
> And I'm glad I di
Nino Novak píše v Čt 14. 07. 2011 v 22:48 +0200:
> Am Donnerstag, 14. Juli 2011, um 14:29:53 schrieb Florian Effenberger:
>
> > The list of fixed bugs in this release is here:
> >
> > http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffi
> > ce-3-4-release-3.4.2.1.log
>
> for a c
Hello,
What have I done this week?
- Work on the agenda wizard. I wanted it to be done about last weekend but
there's a bug ( which affects the java wizard on master too ) and it took me
a while to find it out. I reported the bug here:
https://bugs.freedesktop.org/show_bug.cgi?id=39313. I don't t
Noel Power píše v Pá 15. 07. 2011 v 09:44 +0100:
> On 15/07/11 08:27, Tor Lillqvist wrote:
> >>> Review, sign-off etc appreciated.
> > /me raises hand. One more needed for the 3-4-2 branch.
> >
> pushed to 3.4.2
Heh. the above line was quite hidden ;-)
Just updated the subject accordingly.
Best
Am Mon, 18 Jul 2011 18:11:00 +0200
schrieb Andreas Radke :
> Am Mon, 18 Jul 2011 12:39:26 +0200
> schrieb Petr Mladek :
>
> > Hi,
> >
> > the attached patch fixes two problems found when calling make
> > distro-pack-install" as normal user.
> >
> > It would be great to get it into libreoffice-3
Dear all,
Hi. This is imacat from Taiwan. I received a mail from some friend
in Canonical, Taiwan. What do you think about this, to change the title
from "LibreOffice Calc" to "LibreOffice Calc Spreadsheet"?
I know that this is technically very easy. The problem is: Is this
appropria
On 07/17/11 23:47, Tor Lillqvist wrote:
Would it not be simpler to change the -eq to = ? Anyway, good catch!
--tml
I guess I didn't go that route because my brain tends to avoid the "zFoo"
= "zBar" construct if possible. But yes, I should have written it in the
form that Michael Meeks check
Hi Petr,
Am Montag, 18. Juli 2011, um 18:33:06 schrieben Sie:
> Nino Novak píše v Čt 14. 07. 2011 v 22:48 +0200:
> > Am Donnerstag, 14. Juli 2011, um 14:29:53 schrieb Florian
Effenberger:
> > > The list of fixed bugs in this release is here:
> > >
> > > http://dev-builds.libreoffice.org/pre-rele
Petr Mladek píše v Po 18. 07. 2011 v 16:58 +0200:
> Hi,
>
> the below patches should fix two more problems reported by Andy. I would
> like to get them into libreoffice-3-4-2 branch.
One more fix. We finally install /usr/bin/soffice into $DESTDIR. We need
to put it into the file list as well.
B
Andreas Radke píše v Po 18. 07. 2011 v 18:40 +0200:
> Am Mon, 18 Jul 2011 18:11:00 +0200
> schrieb Andreas Radke :
>
> > Am Mon, 18 Jul 2011 12:39:26 +0200
> > schrieb Petr Mladek :
> >
> > > Hi,
> > >
> > > the attached patch fixes two problems found when calling make
> > > distro-pack-install"
Andreas Radke píše v Po 18. 07. 2011 v 18:26 +0200:
> For a long time now we see lots of files installed with permission 444
> and 555 in ArchLinux. We are not sure if this is caused by a bug in our
> chroot environment using fakeroot or due to the LibO installer. Because of
> the missing write per
Hi Maciej,
First of all, thanks for submitting your patches. I've done my review
of both of your patches, and I'll leave my comments below.
First, for your svl patch:
1) in SfxIntegerListItem::GetList(), you do
+rList.insert( aIt, m_aList[n] );
but you can simply call push_back here t
On Mon, 2011-07-18 at 19:39 +0200, Nino Novak wrote:
> just piped it through the following sed script to obtain Wiki markup:
>
> s/fdo#[0-9]*/{{\0}}/g
> s/bnc#[0-9]*/{{\0}}/g
> s/i#[0-9]*/{{\0}}/g
> s/i#/issue#/g
> s/^\+ \(.*\)$/== \1 ==/
> s/^. /* /
I've been using rhbz# for Fedora/RHEL rel
On Tue, 2011-07-19 at 01:14 +0900, Takeshi Abe wrote:
> Hi all,
>
> According to a discussion on the Japanese local mailing list,
> the following issue may prevent some users from migrating
> to 3.4.x series:
> https://bugs.freedesktop.org/show_bug.cgi?id=38095
>
> I am not yet sure how it works
Hello Michael, Kohei,
I feel extremely uncomfortable (personally) introducing a couple of
> thousands of LOC change between RC1 and final for 3.4.2. We're in a
> triple review mode because our changes will not get much testing before
> they are unleashed on tens of thousands of new people p
On Mon, 2011-07-18 at 15:53 +0100, Michael Meeks wrote:
> Hi there,
>
> On Fri, 2011-07-15 at 00:55 +0200, Markus Mohrhard wrote:
> > So one review needed to get it into 3.4.2. It is an quite important
> > fix as we got several reports where people reported they thought that
> > calc froze and swi
Hello all,
How can I build *rpm installation set under CentOS 5.6?
I know that
./autogen.sh --with-distro=LibreOfficeLinux --with-lang="vi"
--with-max-jobs=20 --with-num-cpus=5 --with-package-format="rpm deb"
--without-junit --with-gcc-speedup=ccache --prefix=$HOME
make
make install
make dev-ins
On Mon, 18 Jul 2011 19:39:31 +0200
Nino Novak wrote:
> s/fdo#[0-9]*/{{\0}}/g
> s/bnc#[0-9]*/{{\0}}/g
> s/i#[0-9]*/{{\0}}/g
> s/i#/issue#/g
> s/^\+ \(.*\)$/== \1 ==/
> s/^. /* /
FWIW, I use /lp#[0-9]*/ for the rare launchpad fix.
Best,
Bjoern
--
https://launchpad.net/~bjoern-michaelsen
Nice, you've almost fixed all of them expect some *rc files:
-r--r--r-- 1 root root 126 Jul 18 22:01
/build/pkg/libreoffice-common/usr/lib/libreoffice/ure/bin/versionrc
-r--r--r-- 1 root root 1.1K Jul 18 22:01
/build/pkg/libreoffice-common/usr/lib/libreoffice/basis3.4/program/unorc
-r--r--r-- 1
Hi Mike,
On 07/18/11 04:23, Michael Meeks wrote:
Hi Mike,
On Fri, 2011-07-15 at 12:34 -0700, Mike Eberdt wrote:
This patch eliminates a "test: : bad number" diagnostic on FreeBSD.
Contributed under LGPL3+/MPL.
Thanks; I pushed it, and then updated it to use:
if test "z$EUID" = "z0"
Hi Christian,
On 07/18/11 04:56, Christian Lohmaier wrote:
Hi MIke, *,
On Fri, Jul 15, 2011 at 9:34 PM, Mike Eberdt wrote:
Configure.in eventually gets parsed by /bin/sh, and on Free/Net/OpenBSD
/bin/sh is not synonymous with bash. Therefore, bash-isms in configure.in
can be problematic.
Hi Caolán,
On Mon, 18 Jul 2011 21:20:02 +0100, Caolán McNamara wrote:
> On Tue, 2011-07-19 at 01:14 +0900, Takeshi Abe wrote:
>> Hi all,
>>
>> According to a discussion on the Japanese local mailing list,
>> the following issue may prevent some users from migrating
>> to 3.4.x series:
>> https:/
I'd like someone doing a Unix build to review this for me. I compile Mac and
this is Unix only code so I don't just want to push and hope...
Thanks,
Joe P.
0001-Replace-List-with-std-vector-ImplBmpObj.patch
Description: Binary data
___
LibreOffice m
Hi TaTung, all!
Sorry for answering so late ...
Am Samstag, den 16.07.2011, 21:40 +0700 schrieb Ta Duc Tung:
> On 07/16/2011 07:29 PM, Christoph Noack wrote:
[...]
> >> We are trying to hack into this easy hack
> >> https://bugs.freedesktop.org/show_bug.cgi?id=38830
> >> We're still studying sour
> So as long as the OS check is first, we don't evaluate $EUID except on Cygwin.
But it wasn't as such the existence or not of $EUID that was the problem here,
was it? The problem was the use of -eq operator when the left-hand side of the
operator, "$EUID" , was an empty string and thus not a nu
On Mon, Jul 18, 2011 at 12:28:55PM -0400, Kohei Yoshida wrote:
> On Mon, 2011-07-18 at 11:47 -0400, Kohei Yoshida wrote:
> > On Mon, 2011-07-18 at 10:25 -0400, Kohei Yoshida wrote:
> >
> > > I'd also
> > > like to push this to the -3-4 branch, but let me just do a quick test on
> > > ODS import of
> My 'dmake' fu is basically non-existent, so I haven't poked at this seriously
> yet. [...] a transition is underway to GNU make
Oh, (unfortunately) you have it backwards regarding the complexity;)
dmake is mostly a normal make with few special features. Understanding how
things work in the ol
On Mon, Jul 18, 2011 at 05:33:56PM -0700, Mike Eberdt wrote:
> Hi Christian,
>
> On 07/18/11 04:56, Christian Lohmaier wrote:
> >
> >Hi MIke, *,
> >
> >On Fri, Jul 15, 2011 at 9:34 PM, Mike Eberdt wrote:
> >>
> >>Configure.in eventually gets parsed by /bin/sh, and on Free/Net/OpenBSD
> >>/bin/sh
64 matches
Mail list logo
