Re: unused code in Calc source?

2015-05-04 Thread Eike Rathke
Hi Winfried, On Friday, 2015-05-01 13:04:02 +0200, Winfried Donkers wrote: > In sc/inc/compiler.hxx, struct AddInMap a member bMapDupToInternal is defined. > As far as I can see, it is not really used in the code. Indeed, it is unused, I don't actually recall when and how it was exactly used. >

unused code in Calc source?

2015-05-01 Thread Winfried Donkers
Hi, In sc/inc/compiler.hxx, struct AddInMap a member bMapDupToInternal is defined. As far as I can see, it is not really used in the code. That is, in sc/source/core/tool/odffmap.cxx it gets a value, but that seems unused. The only use I can find, is in a comment in sc/source/filter/excel/xlform

[PUSHED] Delete unused code in one file.

2013-04-18 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3446 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3446 To unsubscribe, vi

[PUSHED] Remove unused code

2013-04-18 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3447 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3447 To unsubscribe, visit

[PATCH] Remove unused code

2013-04-17 Thread Michael Dunphy (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3447 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3447/1 Remove unused code Change-Id: Id4ce1d003db61374ba68f807090860595178b562 --- M chart2/source/controller/dialogs

[PATCH] Delete unused code in one file.

2013-04-17 Thread Golnaz Irannejad (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3446 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/3446/1 Delete unused code in one file. Change-Id: Ib468dd87e1624bd02b4d190699cd864514664229 --- M chart2/source

[PATCH] remove unused code.

2013-04-02 Thread navin patidar (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3167 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3167/1 remove unused code. A request (rReq) having anyone of following SID SID_ATTR_CHAR_FONTHEIGHT

[PUSHED] remove unused code svtools/bmpmaker

2013-03-21 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2868 Approvals: Noel Power: Verified; Looks good to me, approved LibreOffice gerrit bot: Verified Thomas Arnhold: Verified; Looks good to me,

[PATCH] remove unused code svtools/bmpmaker

2013-03-20 Thread David Ostrovsky (via Code Review)
David Ostrovsky has created a new patch set by issuing a rebase in Gerrit (#4). Change subject: remove unused code svtools/bmpmaker .. remove unused code svtools/bmpmaker Investigated the usage of bmpmaker for fdo#39445

[PUSHED] Remove unused code

2012-09-24 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/682 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/682 To unsubscribe, visit

[PATCH] Remove unused code

2012-09-23 Thread Olivier Hallot (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/682 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/682/1 Remove unused code According to unusedcode.easy Change-Id: I31edd26d8ee7934b47ed7bf5ec6c07e1b8c5c5e9 --- M sd

remove unused code

2012-09-08 Thread Norbert Thiebaud (via Code Review)
Norbert Thiebaud has abandoned this change. Change subject: remove unused code .. Patch Set 1: Abandoned per kohei's request -- To view, visit https://gerrit.libreoffice.org/516 To unsubscribe, visit

[PATCH] remove unused code

2012-08-30 Thread Gerrit
>From Babati Bence : Babati Bence has uploaded a new change for review. Change subject: remove unused code .. remove unused code Change-Id: I49e84449a0ea1f77ff4d14b3631aeb7670d4f4e7 --- M sd/inc/pglink.hxx M sd/source/c

[PUSHED] unusedcode.easy: remove recently unused code

2012-08-23 Thread Gerrit
>From Andras Timar : Andras Timar has submitted this change and it was merged. Change subject: unusedcode.easy: remove recently unused code .. unusedcode.easy: remove recently unused code Change

[PATCH] unusedcode.easy: remove recently unused code

2012-08-18 Thread Gerrit
>From Thomas Arnhold : Thomas Arnhold has uploaded a new change for review. Change subject: unusedcode.easy: remove recently unused code .. unusedcode.easy: remove recently unused code Change

Re: [RESOLVED] Delete-unused-code-TypeDescriptor_Init_Impl.patch

2012-05-03 Thread Thorsten Behrens
Finishing up thread. -- Thorsten pgpMmYpnm54Rp.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Remove unused code (24)

2012-04-30 Thread Caolán McNamara
On Sun, 2012-04-29 at 16:16 +0800, Elton Chung wrote: > Hi there, > This patch removes 1 unused method. Looks good to me, pushed now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailm

[PATCH] Remove unused code (24)

2012-04-29 Thread Elton Chung
- Remove-unused-code-24.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [RESOLVED] Delete-unused-code-ImpSvtData-ImpSvtData

2012-04-27 Thread Thorsten Behrens
Obsoleted by Caolan's ImpSvtData refactor. No Dtor in the new impl. -- Thorsten pgpnTNsR2pSPW.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Delete-unused-code-TypeDescriptor_Init_Impl.patch

2012-04-26 Thread Stephan Bergmann
On 04/25/2012 10:48 PM, Stephan Bergmann wrote: On 04/25/2012 05:29 PM, Caolán McNamara wrote: On Wed, 2012-04-25 at 00:11 +0100, José Santiago Jiménez Sarmiento caolanm->sbergman: That leaky TypeDescriptor_Init_Impl is back to haunt you. What would you prefer ?, use it, loose it, hide it ? #l

Re: Delete-unused-code-TypeDescriptor_Init_Impl.patch

2012-04-25 Thread Stephan Bergmann
On 04/25/2012 05:29 PM, Caolán McNamara wrote: On Wed, 2012-04-25 at 00:11 +0100, José Santiago Jiménez Sarmiento caolanm->sbergman: That leaky TypeDescriptor_Init_Impl is back to haunt you. What would you prefer ?, use it, loose it, hide it ? #libreoffice-dev: Jan 05 12:02:47 LibreOffice (cor

Re: [PUSHED] unused code

2012-04-25 Thread José Santiago Jiménez Sarmiento
Ok, thanks! El 25 de abril de 2012 16:25, Caolán McNamara escribió: > On Tue, 2012-04-24 at 16:12 -0400, Kohei Yoshida wrote: > > FWIW it was already like that in 3.5. > > Its been like that since Sep 2000. screw it, I ain't changing it now > just because the symmetry would be pleasing :-). So,

Re: [PUSHED] 0001-Delete-unused-code-CertificateExtension_XmlSecImpl-s.patch

2012-04-25 Thread José Santiago Jiménez Sarmiento
Ok! Thanks!!! El 25 de abril de 2012 16:19, Jesús Corrius escribió: > Hi, > > On Wed, Apr 25, 2012 at 12:27 AM, José Santiago Jiménez Sarmiento > wrote: > > Hello! I am begginer in software libre colaboration. > > I hope I can enter fully into this world and in the future be a good > > collabor

Re: [RESOLVED][PATCH] Remove unused code (ImpSvtData)

2012-04-25 Thread Caolán McNamara
On Tue, 2012-04-24 at 15:02 -0700, Javier Catala wrote: > Hi everyone, > > this patch removes the unused destructor in the ImpSvtData class, as listed > in unusedcode.easy See http://lists.freedesktop.org/archives/libreoffice/2012-April/030785.html for the gotcha with unused destructors. I'll re

Re: Delete-unused-code-TypeDescriptor_Init_Impl.patch

2012-04-25 Thread Caolán McNamara
On Wed, 2012-04-25 at 00:11 +0100, José Santiago Jiménez Sarmiento caolanm->sbergman: That leaky TypeDescriptor_Init_Impl is back to haunt you. What would you prefer ?, use it, loose it, hide it ? C. ___ LibreOffice mailing list LibreOffice@lists.freede

Re: [PUSHED] unused code

2012-04-25 Thread Caolán McNamara
On Tue, 2012-04-24 at 16:12 -0400, Kohei Yoshida wrote: > FWIW it was already like that in 3.5. Its been like that since Sep 2000. screw it, I ain't changing it now just because the symmetry would be pleasing :-). So, patch applied as it is. caolanm->jimenezsarmiento: thanks for this, pushed now

[PUSHED] 0001-Delete-unused-code-CertificateExtension_XmlSecImpl-s.patch

2012-04-25 Thread Jesús Corrius
Hi, On Wed, Apr 25, 2012 at 12:27 AM, José Santiago Jiménez Sarmiento wrote: > Hello! I am begginer in software libre colaboration. > I hope I can enter fully into this world and in the future be a good > collaborator. > Thanks. This one looks good. Thank you :) Please don't forget to send a me

Re: [RESOLVED][PATCH] Remove unused code (ImpSvtData)

2012-04-25 Thread Caolán McNamara
On Wed, 2012-04-25 at 13:47 +0100, Caolán McNamara wrote: > We should try and fix the leak and call the destructor somewhere rather > than removing the destructor. Refactored now to not leave that gotcha in the unusedcode.easy list. Fixed. C. ___ Libre

[PUSHED] Removed unused code from vcl

2012-04-25 Thread Jesús Corrius
rr...@gmail.com [mailto:jcorr...@gmail.com] En nombre de Jesús > Corrius > Enviado el: miércoles, 25 de abril de 2012 15:56 > Para: Vicente Vendrell > CC: libreoffice@lists.freedesktop.org > Asunto: Re: [PATCH] Removed unused code from vcl > > On Wed, Apr 25, 2012 at 2:16 PM, Vicente Vendre

Re: [PATCH] Removed unused code from vcl

2012-04-25 Thread Jesús Corrius
On Wed, Apr 25, 2012 at 2:16 PM, Vicente Vendrell wrote: > Here is the patch from unused method Dialog::Dialog(Window*, ResId const&) Looks good. Can you confirm this patches are under the LGPLv3+/MPL+ licenses? -- Jesús Corrius ___ LibreOffice mail

[PATCH] Removed unused code from vcl

2012-04-25 Thread Vicente Vendrell
Here is the patch from unused method Dialog::Dialog(Window*, ResId const&) Have a nice day! 0001-Removed-usused-method-Dialog-Dialog-Window-ResId-con.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org h

Re: [PATCH] Remove unused code (ImpSvtData)

2012-04-25 Thread Caolán McNamara
On Wed, 2012-04-25 at 05:16 -0700, Javier Catala wrote: > Hi everyone, > > This patch removes unused destructor in the ImpSvtData class, as listed in > unusedcode.easy Yeah, but see unusedcode.README and "f". If the constructor used, but the destructor is unused. Then its probably a leak and we

[PATCH] Remove unused code (ImpSvtData)

2012-04-25 Thread Javier Catala
Hi everyone, This patch removes unused destructor in the ImpSvtData class, as listed in unusedcode.easy From bdfc550685d238a62602a4f93da0ab804d77b2f6 Mon Sep 17 00:00:00 2001 From: Javier Catala Date: Tue, 24 Apr 2012 20:24:17 +0200 Subject: [PATCH] Remove unused ImpSvtData destructor. Committe

Delete-unused-code-TypeDescriptor_Init_Impl.patch

2012-04-24 Thread José Santiago Jiménez Sarmiento
cuenta el medio ambiente antes de decidir imprimir este correo. **Please, consider the environment before deciding to print this e-mail.* 0001-Delete-unused-code-TypeDescriptor_Init_Impl.patch Description: Binary data ___ LibreOffice mailing list

Delete-unused-code-ImpSvtData-ImpSvtData

2012-04-24 Thread José Santiago Jiménez Sarmiento
cuenta el medio ambiente antes de decidir imprimir este correo. **Please, consider the environment before deciding to print this e-mail.* 0001-Delete-unused-code-ImpSvtData-ImpSvtData.patch Description: Binary data ___ LibreOffice mailing list LibreOffice

0001-Delete-unused-code-CertificateExtension_XmlSecImpl-s.patch

2012-04-24 Thread José Santiago Jiménez Sarmiento
-unused-code-CertificateExtension_XmlSecImpl-s.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code (ImpSvtData)

2012-04-24 Thread Javier Catala
Hi everyone, this patch removes the unused destructor in the ImpSvtData class, as listed in unusedcode.easy From bdfc550685d238a62602a4f93da0ab804d77b2f6 Mon Sep 17 00:00:00 2001 From: Javier Catala Date: Tue, 24 Apr 2012 20:24:17 +0200 Subject: [PATCH] Remove unused ImpSvtData destructor. Comm

Re: unused code

2012-04-24 Thread Kohei Yoshida
Hi Caolan, On Tue, Apr 24, 2012 at 3:22 PM, Caolán McNamara wrote: > On Tue, 2012-04-24 at 19:03 +0100, José Santiago Jiménez Sarmiento > > What bothers me about the unused GetNextVisPortion in editeng is that > GetPrevVisPortion is not unused, and in > EditView::SetSelection I wonder if the *sec

Re: unused code

2012-04-24 Thread Caolán McNamara
On Tue, 2012-04-24 at 19:03 +0100, José Santiago Jiménez Sarmiento What bothers me about the unused GetNextVisPortion in editeng is that GetPrevVisPortion is not unused, and in EditView::SetSelection I wonder if the *second* GetPrevVisPortion should have been GetNextVisPortion all along. caolan

Re: [PUSHED][PATCH] Removed unused code from editeng

2012-04-24 Thread Caolán McNamara
Looks good, pushed, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Remove unused code (sc)

2012-04-24 Thread Caolán McNamara
On Mon, 2012-04-23 at 19:39 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy looks good, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org h

[PATCH] Removed unused code from editeng

2012-04-24 Thread Vicente Vendrell
0001-Removed-unused-code-from-editeng.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Remove unused code

2012-04-24 Thread Caolán McNamara
On Sun, 2012-04-22 at 20:48 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy Looks good, pushed. Thanks for this. It bothers me a little that there was a addListener and a removeListener where the addListener is used while removeListener is unused.

Re: [PUSHED][PATCH] Remove unused code in dpitemdata

2012-04-24 Thread Caolán McNamara
On Mon, 2012-04-23 at 19:27 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy Looks good to me, pushed. Thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org h

Re: [PUSHED] PATCH: Remove unused code from editing

2012-04-24 Thread Caolán McNamara
On Tue, 2012-04-24 at 07:21 +0100, Vicente Rafael Estévez Vacas wrote: > Did I correct it and send it back to? No need, fixed now. > Yeah right, I will confirm the terms of license LGPLv3 + / MPL + > combination. Great, thanks. C. ___ LibreOffice m

Re: [PUSHED] PATCH: Remove unused code from editing

2012-04-23 Thread Vicente Rafael Estévez Vacas
ation. Sorry for my English. De: Caolán McNamara Para: Vicente Rafael Estévez Vacas CC: "libreoffice@lists.freedesktop.org" Enviado: Martes 24 de abril de 2012 0:22 Asunto: Re: [PUSHED] PATCH: Remove unused code from editing On Mon, 2012-04-23

Re: [PUSHED] PATCH: Remove unused code from editing

2012-04-23 Thread Caolán McNamara
On Mon, 2012-04-23 at 17:13 +0100, Vicente Rafael Estévez Vacas wrote: > Asunto: PATCH: Remove unused code from editing Basically good. Though you need to build after your make your changes to pick up that there's a small mixup between the unused sdr::contact::ViewObjectContactOfUn

[PATCH] Remove unused code (sc)

2012-04-23 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-sc.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code in dpitemdata

2012-04-23 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-dpitemdata.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

PATCH: Remove unused code from editing

2012-04-23 Thread Vicente Rafael Estévez Vacas
- Mensaje reenviado - De: Vicente Rafael Estévez Vacas Para: ""libreoffice-boun...@lists.freedesktop.org"" CC: Estévez Vacas Vicente Enviado: Lunes 23 de abril de 2012 13:39 Asunto: PATCH: Remove unused code from editing Thanks 0001-PATCH-Remove-unused-cod

PATCH: Remove unused code from editeng

2012-04-23 Thread Ferran Vidal i Marginet
4 Mon Sep 17 00:00:00 2001 From: Ferran Vidal Date: Sat, 21 Apr 2012 13:34:26 +0200 Subject: [PATCH] Removed unused code from editeng --- editeng/source/editeng/editdoc.cxx |5 - editeng/source/editeng/editdoc.hxx |1 - 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/ed

Re: [Pushed] PATCH: Remove unused code

2012-04-22 Thread Muthu Subramanian K
Pushed. Thank you! On 04/23/2012 12:44 AM, Ferran Vidal i Marginet wrote: Hello, These is the patch that I've created. Licence: made available under the MPL/LGPLv3+ Ferran Vidal ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://

Re: [Pushed] [PATCH] Remove unused code (vlc)

2012-04-22 Thread Muthu Subramanian K
Thank you! On 04/23/2012 02:06 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code (vlc)

2012-04-22 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-vlc.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

PATCH: Remove unused code

2012-04-22 Thread Ferran Vidal i Marginet
From: Ferran Vidal Date: Sun, 22 Apr 2012 21:10:08 +0200 Subject: [PATCH] Remove unused code --- sc/inc/dbdata.hxx |1 - sc/source/core/tool/dbdata.cxx |5 - unusedcode.easy|1 - 3 files changed, 0 insertions(+), 7 deletions(-) diff --git a/s

[PATCH] Remove unused code

2012-04-22 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-sw.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] PATCH: Remove unused code from "Spreadsheet-application-code"

2012-04-21 Thread Caolán McNamara
On Sat, 2012-04-21 at 17:20 +0100, Ferran Vidal i Marginet wrote: > Hello, > These is the patch that I've created. Looks good, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mai

PATCH: Remove unused code from "Spreadsheet-application-code"

2012-04-21 Thread Ferran Vidal i Marginet
2012 18:08:11 +0200 Subject: [PATCH] Remove unused code from "Spreadsheet application code" --- sc/inc/cell.hxx |1 - sc/source/core/data/cell.cxx |5 - unusedcode.easy |2 -- 3 files changed, 0 insertions(+), 8 deletions(-) diff --git a/sc/in

Re: [PATCH] unusedcode.easy: Removed unused code

2012-04-20 Thread Miklos Vajna
On Thu, Apr 19, 2012 at 11:52:48PM +0200, Xavi Escriche Galindo wrote: > -UnoControlModel::UnoControlModel() > -:UnoControlModel_Base() > -,MutexAndBroadcastHelper() > -,OPropertySetHelper( BrdcstHelper ) > -,maDisposeListeners( *this ) > -,maContext( ::comphelper::getProcessS

[PUSHED] Removed unused code formula::ArgInput::GetArgSelection

2012-04-20 Thread Jesús Corrius
On Thu, Apr 19, 2012 at 5:30 PM, wrote: > Hi all, > > All of my past, present and future contributions to LibreOffice may be > licensed under the MPL/LGPLv3+ dual license. > Pushed. Thanks :) -- Jesús Corrius ___ LibreOffice mailing list LibreOffice

[PATCH] unusedcode.easy: Removed unused code

2012-04-20 Thread Xavi Escriche Galindo
0001-Remove-unused-code-function-UnoControlModel-UnoContr.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: Removed unused code formula::ArgInput::GetArgSelection

2012-04-19 Thread jaime . navarro
Hi all, All of my past, present and future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Thanks. Michael Meeks ha escrito: Hi Jaime, We need a blanket license statement that all the code you contribute is made available under the terms of the MPL/

Re: Removed unused code formula::ArgInput::GetArgSelection

2012-04-19 Thread Michael Meeks
Hi Jaime, We need a blanket license statement that all the code you contribute is made available under the terms of the MPL/LGPLv3+ dual license so we can link you into: http://wiki.documentfoundation.org/Development/Developers Can you send that to this list ? An

Removed unused code formula::ArgInput::GetArgSelection

2012-04-19 Thread Jaime Navarro Santapau
Salvo indicado de otro modo más arriba / Unless stated otherwise above: International Business Machines, S.A. Santa Hortensia, 26-28, 28002 Madrid Registro Mercantil de Madrid; Folio 1; Tomo 1525; Hoja M-28146 CIF A28-010791 0001-Removed-unused-code-formula-ArgInput-GetArgSelection.patch

Re: [PUSHED][PATCH] Removing unused code

2012-04-16 Thread Caolán McNamara
On Sun, 2012-04-15 at 19:47 +0200, Laure Garcí­a Linde wrote: > ___ Looks good, pushed now. Thanks for this. I think this is your first patch, so can you confirm this patch is under our preferred LGPLv3+/MPL combo ? Typical procedure is to send a sort o

Re: [PUSHED][PATCH] Remove unused code (sc)

2012-04-16 Thread Caolán McNamara
On Mon, 2012-04-16 at 20:10 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy looks good, pushed. Thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org h

Re: [PUSHED][PATCH] Remove unused code (connectivity)

2012-04-16 Thread Caolán McNamara
On Sat, 2012-04-14 at 19:34 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy pushed, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mail

Re: [PUSHED][PATCH] Remove unused code (sd)

2012-04-16 Thread Caolán McNamara
On Sat, 2012-04-14 at 20:14 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy looks good, pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mail

[PATCH] Remove unused code (sc)

2012-04-16 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-sc.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Removing unused code

2012-04-16 Thread Laure Garcí­a Linde
>From ade2a4ad180eac9e72e5104fd8e0ef9014847bec Mon Sep 17 00:00:00 2001 From: Laureano G. Linde Date: Sun, 15 Apr 2012 18:47:57 +0200 Subject: [PATCH] Removed StgHeader::SetClassId(ClsId const &) --- sot/source/sdstor/stgelem.cxx |6 -- sot/source/sdstor/stgelem.hxx |1 - 2 files ch

[PATCH] Remove unused code (sd)

2012-04-14 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-sd.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code (connectivity)

2012-04-14 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-connectivity.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] Remove unused code (oox)

2012-04-13 Thread Miklos Vajna
Hi Santiago, On Thu, Apr 12, 2012 at 08:04:19PM +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy Thanks for this. Given that this code used to be in oox, it still lives in the oox namespace, though I think it makes more sense to mention the r

[PATCH] Remove unused code (oox)

2012-04-12 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-oox.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Remove unused code (oox)

2012-04-10 Thread Caolán McNamara
On Sun, 2012-04-08 at 21:56 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy Yup, pushed now. Well, actually Julien removed the same code and got in first. C. ___ LibreOffice mailing list LibreOff

[PATCH] Remove unused code (oox)

2012-04-08 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-oox.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Re: [PATCH] Remove unused code (vcl)

2012-04-06 Thread Matúš Kukan
Hello, On 4 April 2012 17:14, Thomas Collerton wrote: > Hello all, > this patch removes unused code in the Slider class as listed in > unusedcode.easy Looks good => pushed Thanks, Matúš ___ LibreOffice mailing list LibreOffice@lists.fre

[PUSHED] Re: [PATCH] remove unused code (oox)

2012-04-05 Thread Jan Holesovsky
Hi Petr, Petr Vorel píše v Po 02. 04. 2012 v 16:18 +0200: > removed unused classes from oox. Pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=07ff032c805835355ff0dff75b8ad534dfb770e9 Thank you! :-) Regards, Kendy ___ LibreOffice mail

Re: [Pushed] [PATCH] Remove unused code (svx)

2012-04-05 Thread Muthu Subramanian K
Pushed. Thank you! On 04/05/2012 12:10 AM, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy > > > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists

[PATCH] Remove unused code (svx)

2012-04-04 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-svx.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code (vcl)

2012-04-04 Thread Thomas Collerton
Hello all, this patch removes unused code in the Slider class as listed in unusedcode.easy 0001-Remove-unused-code-vcl.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

[PATCH] remove unused code (oox)

2012-04-02 Thread Petr Vorel
Hi there, removed unused classes from oox. Regards, Petr >From b4350501d1fe85da2cce5750b480e33eb6409301 Mon Sep 17 00:00:00 2001 From: Petr Vorel Date: Mon, 2 Apr 2012 11:40:06 +0200 Subject: [PATCH] remove unused code (oox) --- oox/inc/oox/dump/dumperbase.hxx | 18 -- oox/inc/oox/d

Re: [PUSHED][PATCH] remove unused code (oox)

2012-03-29 Thread Caolán McNamara
On Thu, 2012-03-29 at 15:23 +0200, Petr Vorel wrote: > Hi there, > > removed unused methods pushed, thanks for these C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] remove unused code (oox)

2012-03-29 Thread Petr Vorel
Hi there, removed unused methods, hope better this time. Regards, Petr >From 2d8c47fede9ec6842a98663f16c4efa70f833e22 Mon Sep 17 00:00:00 2001 From: Petr Vorel Date: Thu, 29 Mar 2012 11:54:36 +0200 Subject: [PATCH] remove unused code (oox) --- oox/inc/oox/dump/dffdumper.hxx |

Re: [PUSHED][PATCH] Remove unused code (connectivity)

2012-03-29 Thread Caolán McNamara
On Wed, 2012-03-28 at 21:51 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy Looks good, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org h

Re: [PUSHED][PATCH] Remove unused code in sqlnode

2012-03-29 Thread Caolán McNamara
On Wed, 2012-03-28 at 21:31 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy Look good, pushed now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mail

Re: [PUSHED][PATCH] remove unused code (oox, sc)

2012-03-28 Thread Petr Vorel
> FWIW, if a class has only one constructor and that constructor is unused > then it indicates that the whole class (except perhaps for any static > methods it might have) should be possible to be removed. Sorry, I'll think more next time. Petr ___ LibreO

[PATCH] Remove unused code (connectivity)

2012-03-28 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-connectiviy.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code in sqlnode

2012-03-28 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 75344c3cb19be787fce45bd06ad93a971e0b5292 Mon Sep 17 00:00:00 2001 From: Santiago Martinez Date: Wed, 28 Mar 2012 21:28:07 +0200 Subject: [PATCH] Remove unused code in sqlnode --- connectivity/inc/connectivity/sqlnode.hxx |2

Re: [PUSHED][PATCH] remove unused code (oox, sc)

2012-03-28 Thread Caolán McNamara
On Wed, 2012-03-28 at 16:23 +0200, Petr Vorel wrote: > Hi there, > > yet another remove unused code patch. Pushed now, thanks for this. FWIW, if a class has only one constructor and that constructor is unused then it indicates that the whole class (except perhaps for any static methods

[PATCH] remove unused code (oox, sc)

2012-03-28 Thread Petr Vorel
Hi there, yet another remove unused code patch. Regards, Petr >From 38a7f343736f7049d28aae132307eba02a019f27 Mon Sep 17 00:00:00 2001 From: Petr Vorel Date: Wed, 28 Mar 2012 11:20:18 +0200 Subject: [PATCH] remove unused code (oox, sc) --- oox/inc/oox/drawingml/textparagraphproperties.

Re: [PUSHED][PATCH] Remove unused code (l10ntools)

2012-03-27 Thread Caolán McNamara
On Tue, 2012-03-27 at 21:20 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy looks good, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org h

[PATCH] Remove unused code (l10ntools)

2012-03-27 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 85de68332e5419fbf2ef58957a9c11f588fad6c1 Mon Sep 17 00:00:00 2001 From: Santiago Martinez Date: Tue, 27 Mar 2012 21:16:50 +0200 Subject: [PATCH] Remove unused code in l10ntools. --- l10ntools/inc/xmlparse.hxx|6

Re: [PUSHED][PATCH] remove unused code (oox, sc)

2012-03-27 Thread Caolán McNamara
On Tue, 2012-03-27 at 16:27 +0200, Petr Vorel wrote: > Hi there, > > another bits of unused code removed. looks good, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freede

[PATCH] remove unused code (oox, sc)

2012-03-27 Thread Petr Vorel
Hi there, another bits of unused code removed. Regards, Petr >From e31c211d2ebb7cde8a260ec0bcef5359c0c1db8f Mon Sep 17 00:00:00 2001 From: Petr Vorel Date: Tue, 27 Mar 2012 11:03:09 +0200 Subject: [PATCH] remove unused code (oox, sc) --- oox/inc/oox/dump/dumperbase.hxx |

Re: [PUSHED][PATCH] remove unused code (oox)

2012-03-26 Thread Caolán McNamara
On Sun, 2012-03-25 at 20:43 +0200, Petr Vorel wrote: > Hi there, > > removed some code from oox. Pushed, looks good. I suspect that this will have a bit of a cascade effect and a pile more stuff will become available for removal on the next run. C. __

Re: [PUSHED][PATCH] Remove unused code (svtools)

2012-03-26 Thread Caolán McNamara
On Sun, 2012-03-25 at 18:29 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy looks good, hopefully nothing is used there under windows, but if it is we'll know soon enough :-), pushed. C. ___ Lib

Re: [PUSHED][PATCH] Remove unused code (xmloff)

2012-03-26 Thread Caolán McNamara
On Sat, 2012-03-24 at 01:03 +0100, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy great, pushed now, thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.

Re: [PUSHED][PATCH] Remove unused code (vlc)

2012-03-26 Thread Caolán McNamara
On Fri, 2012-03-23 at 22:07 +0100, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy looks good, pushed now, thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.

Re: [PUSHED][PATCH] Remove unused code (scaddins)

2012-03-26 Thread Caolán McNamara
On Fri, 2012-03-23 at 21:42 +0100, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy looks good, pushed now, thanks for that. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org h

  1   2   3   4   >