Re: the inevitable C formatting/brace style flamewar

2012-10-09 Thread Lubos Lunak
On Friday 17 of August 2012, Jan Holesovsky wrote: > Hi Michael, > > Michael Stahl píše v Čt 16. 08. 2012 v 19:07 +0200: > > if memory serves i've reviewed 2 patches in the last 3 months or so that > > added a statement to a 1-line then or else clause that was indented but > > did not have braces,

Re: the inevitable C formatting/brace style flamewar

2012-08-16 Thread Jan Holesovsky
Hi Michael, Michael Stahl píše v Čt 16. 08. 2012 v 19:07 +0200: > if memory serves i've reviewed 2 patches in the last 3 months or so that > added a statement to a 1-line then or else clause that was indented but > did not have braces, and the author indented his new line and forgot the > braces.

Re: the inevitable C formatting/brace style flamewar

2012-08-16 Thread Bjoern Michaelsen
On Thu, Aug 16, 2012 at 08:17:11PM +0200, Jean-Tiare LE BIGOT wrote: > Hi, > > Since the flamewar is already going on :p, is it OK not put a space > after '(' nor > before ')' in test and calls? > > I find this more readable whitout the spaces... I agree, but opinions differ on that one. Wisely,

Re: the inevitable C formatting/brace style flamewar

2012-08-16 Thread Jean-Tiare LE BIGOT
Hi, Since the flamewar is already going on :p, is it OK not put a space after '(' nor before ')' in test and calls? I find this more readable whitout the spaces... Le 2012-08-16 20:12, Bjoern Michaelsen a écrit : Hi Michael, first: Thanks for keeping an old StarDivision tradition alive! On

Re: the inevitable C formatting/brace style flamewar

2012-08-16 Thread Bjoern Michaelsen
Hi Michael, first: Thanks for keeping an old StarDivision tradition alive! On Thu, Aug 16, 2012 at 07:07:38PM +0200, Michael Stahl wrote: > apparently somebody thought it a great idea to mandate Allman style for Someone has an evil grin on his face. > 1) if the condition is long, then put the

Re: the inevitable C formatting/brace style flamewar

2012-08-16 Thread Norbert Thiebaud
On Thu, Aug 16, 2012 at 12:07 PM, Michael Stahl wrote: > so this: > >> if( pCT->pInsBox ) >> { >> pCT->pInsBox->GetTabLines().push_back( pNewLine ); >> } >> else >> { >> pCT->pTblNd->GetTable().GetTabLines().push_back( pNewLine ); >> } > > could be much shor

the inevitable C formatting/brace style flamewar

2012-08-16 Thread Michael Stahl
On 16/08/12 18:22, Stephan Bergmann wrote: > On 08/16/2012 06:13 PM, Michael Meeks wrote: >> Looks sensible :-) pushed to -3-6 (though I personally loathe burning >> two lines of non-renewable vspace for no good reason ;-). you are _half_ right: burning 2 lines for that is silly :) > The "{"