Re: tdf#74702 2/2

On 8 Jul 2019, at 9:06 pm, Tomaž Vajngerl wrote: > > Hi, > > On 06.07.19 19:59, Adrien Ollier wrote: > > > Well IMHO the problem that you even have to think about this is that > OutputDevice is a enormous class, and then you have to deal with another even > more enormous subclass vcl::Wi

RE: tdf#74702 2/2

De : Michael Stahl Envoyé : mercredi 10 juillet 2019 11:25 À : Adrien Ollier; Tomaž Vajngerl Cc : libreoffice@lists.freedesktop.org Objet : Re: tdf#74702 2/2 On 09.07.19 22:54, Adrien Ollier wrote: > *De :* Michael Stahl > On 08.07.19 13:06, Tomaž Va

RE: tdf#74702 2/2

De : Tomaž Vajngerl Envoyé : mercredi 10 juillet 2019 06:46 À : Adrien Ollier Cc : libreoffice@lists.freedesktop.org Objet : Re: tdf#74702 2/2 Hi, On Wed, Jul 10, 2019 at 5:54 AM Adrien Ollier mailto:adr.oll...@hotmail.fr>> wrote: Also, let's take

Re: tdf#74702 2/2

On 09.07.19 22:54, Adrien Ollier wrote: *De :* Michael Stahl On 08.07.19 13:06, Tomaž Vajngerl wrote: Well IMHO the problem that you even have to think about this is that OutputDevice is a enormous class, and then you have to deal with another even more enormous subclass vcl::Window, which s

Re: tdf#74702 2/2

Hi, On Wed, Jul 10, 2019 at 5:54 AM Adrien Ollier wrote: > > Also, let's take a concrete example: > > > https://opengrok.libreoffice.org/xref/core/vcl/source/control/edit.cxx?r=d00ee2cb > void Edit::Draw(O

RE: tdf#74702 2/2

De : Michael Stahl Envoyé : lundi 8 juillet 2019 13:15 À : Tomaž Vajngerl; Adrien Ollier Cc : libreoffice@lists.freedesktop.org Objet : Re: tdf#74702 2/2 On 08.07.19 13:06, Tomaž Vajngerl wrote: > Hi, > > On 06.07.19 19:59, Adrien Oll

Re: tdf#74702 2/2

On 08.07.19 13:06, Tomaž Vajngerl wrote: Hi, On 06.07.19 19:59, Adrien Ollier wrote: Well IMHO the problem that you even have to think about this is that OutputDevice is a enormous class, and then you have to deal with another even more enormous subclass vcl::Window, which shoul

Re: tdf#74702 2/2

Hi, On 06.07.19 19:59, Adrien Ollier wrote: > Well IMHO the problem that you even have to think about this is that OutputDevice is a enormous class, and then you have to deal with another even more enormous subclass vcl::Window, which should never be a subclass of OutputDevice in the first

Re: tdf#74702 2/2

On Monday 08 of July 2019, Michael Stahl wrote: > On 06.07.19 19:59, Adrien Ollier wrote: Please do not split emails randomly into halves, it just makes it confusing. > well there are some options: > > 1) keep tag enums > + conditions are fast > - violates the purity of object-oriented

Re: tdf#74702 2/2

On 06.07.19 19:59, Adrien Ollier wrote: So to close bug #74702, we require to keep the real type of any OutputDevice* a function gets as argument. If we are in a function g(OutputDevice*), we must rewind to its caller f(OutputDevice*), and so on until a(OutputDevice*) which is called after cr

tdf#74702 2/2

So to close bug #74702, we require to keep the real type of any OutputDevice* a function gets as argument. If we are in a function g(OutputDevice*), we must rewind to its caller f(OutputDevice*), and so on until a(OutputDevice*) which is called after creation of an instance of a subclass of Out