Re: sd: disable pdf import tests

2019-12-17 Thread Stephan Bergmann
On 17/12/2019 16:20, Ashod Nakashian wrote: Fair enough. I think we can still keep your patch, but restore the defines (i.e. keep them disabled) and I'll a comment/fixme (after you merge) that we should restore these tests to work with PDFium etc. Fair enough. Pushed as

Re: sd: disable pdf import tests

2019-12-17 Thread Ashod Nakashian
On 12/17/19 9:52 AM, Stephan Bergmann wrote: On 17/12/2019 15:29, Ashod Nakashian wrote: So these tests aren't really useful anymore. They should be modified to do import+break and then check the results. But that isn't straight-forward and I ran out of time to do it. In which case it would

Re: sd: disable pdf import tests

2019-12-17 Thread Stephan Bergmann
On 17/12/2019 15:29, Ashod Nakashian wrote: So these tests aren't really useful anymore. They should be modified to do import+break and then check the results. But that isn't straight-forward and I ran out of time to do it. In which case it would be great if you could either remove the non-us

Re: sd: disable pdf import tests

2019-12-17 Thread Ashod Nakashian
[++kendy] On 12/17/19 2:18 AM, Stephan Bergmann wrote: On 17/12/2019 01:46, Ashod Nakashian wrote: On 12/16/19 11:59 AM, Stephan Bergmann wrote: What's the reason for this change, and/or are there plans to enable the tests again?  (`git log -SIMPORT_PDF_ELEMENTS` shows this to be the only com

Re: sd: disable pdf import tests

2019-12-16 Thread Stephan Bergmann
On 17/12/2019 01:46, Ashod Nakashian wrote: On 12/16/19 11:59 AM, Stephan Bergmann wrote: What's the reason for this change, and/or are there plans to enable the tests again?  (`git log -SIMPORT_PDF_ELEMENTS` shows this to be the only commit ever mentioning that identifier, so the tests are in

Re: sd: disable pdf import tests

2019-12-16 Thread Ashod Nakashian
Hi Stephan, On 12/16/19 11:59 AM, Stephan Bergmann wrote: What's the reason for this change, and/or are there plans to enable the tests again?  (`git log -SIMPORT_PDF_ELEMENTS` shows this to be the only commit ever mentioning that identifier, so the tests are indeed disabled since then.)

Re: sd: disable pdf import tests

2019-12-16 Thread Stephan Bergmann
On 16/12/2019 17:59, Stephan Bergmann wrote: What's the reason for this change, and/or are there plans to enable the tests again? (see "Re-enable PDF import tests" in case we want to re-enable them) ___ L

sd: disable pdf import tests

2019-12-16 Thread Stephan Bergmann
commit f03ca93665fa974c5be2d9ca7082cb64ceafd7f8 Author: Ashod Nakashian Date: Sun May 20 22:31:36 2018 -0400 sd: disable pdf import tests Change-Id: Iaee679d2ff322c67d081185588103d5685fa970a diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx index