Re: sc: test failure depending on order of execution

2023-03-08 Thread Xisco Fauli
Hello Miklos, On 8/3/23 9:09, Miklos Vajna wrote: Hi Xisco, On Fri, Mar 03, 2023 at 12:43:38PM +0100, Xisco Fauli wrote: Unfortunately I don't feel brave enough to change this. Is there anyone familiar with this part of the code willing to give it a try? otherwise, I can at least report it i

Re: sc: test failure depending on order of execution

2023-03-08 Thread Miklos Vajna
Hi Xisco, On Fri, Mar 03, 2023 at 12:43:38PM +0100, Xisco Fauli wrote: > Unfortunately I don't feel brave enough to change this. Is there anyone > familiar with this part of the code willing to give it a try? otherwise, I > can at least report it in Bugzilla so it doesn't get lost Please see if

Re: sc: test failure depending on order of execution

2023-03-03 Thread Xisco Fauli
Hello Miklos, On 3/3/23 8:56, Miklos Vajna wrote: Hmm, it feels like this is an improvement, but the root cause is why we have a static counter for charts in the first place. Do you know where is that counter? There are two, the one for sc is in sc/source/filter/excel/xeescher.cxx:1607, added

Re: sc: test failure depending on order of execution

2023-03-02 Thread Miklos Vajna
Hi Xisco, On Thu, Mar 02, 2023 at 09:31:24AM +0100, Xisco Fauli wrote: > Yes, you were right. There is a static counter that increments the chart > export file names so it failed to find 'xl/charts/chart1.xml' because it was > exported as 'xl/charts/chart2.xml' > > Markus already added a mechan

Re: sc: test failure depending on order of execution

2023-03-02 Thread Xisco Fauli
Hi Miklos On 27/2/23 8:18, Miklos Vajna wrote: My first guess would be some static variable, but who knows. Yes, you were right. There is a static counter that increments the chart export file names so it failed to find 'xl/charts/chart1.xml' because it was exported as 'xl/charts/chart2.xml'

Re: sc: test failure depending on order of execution

2023-02-26 Thread Miklos Vajna
Hi Xisco, On Fri, Feb 24, 2023 at 02:40:23PM +0100, Xisco Fauli wrote: > it seems there is a test in sc/qa/unit/subsequent_export_test2.cxx that > fails depending on the order of execution. > > If testTdf121260 is executed before testTdf107586, then it passes, > otherwise, it fails with > > ##

sc: test failure depending on order of execution

2023-02-24 Thread Xisco Fauli
Hello, it seems there is a test in sc/qa/unit/subsequent_export_test2.cxx that fails depending on the order of execution. If testTdf121260 is executed before testTdf107586, then it passes, otherwise, it fails with ##Failure Location unknown## : Error Test name: ScExportTest2::testTdf121260