Re: rtl::OUString::compareToAscii is dangerous

2013-03-20 Thread d . ostrovsky
Quoting Stephan Bergmann : On 03/19/2013 06:37 PM, Stephan Bergmann wrote: I apologize in advance for any remaining occurrences that my build didn't catch. (Where is the gerrit tinderbox trigger when one needs them?) Currently only gerrit admins can schedule gerrit verification build. But

Re: rtl::OUString::compareToAscii is dangerous

2013-03-20 Thread Stephan Bergmann
On 03/19/2013 06:37 PM, Stephan Bergmann wrote: On 03/19/2013 06:29 PM, Noel Grandin wrote: On Tue, Mar 19, 2013 at 6:54 PM, Stephan Bergmann wrote: * compareToAscii(char cosnt * asciiStr, sal_Int32 maxLength) does a shortened comparison of only up to maxLength characters of *this and the give

Re: rtl::OUString::compareToAscii is dangerous

2013-03-19 Thread Stephan Bergmann
On 03/19/2013 06:29 PM, Noel Grandin wrote: On Tue, Mar 19, 2013 at 6:54 PM, Stephan Bergmann wrote: * compareToAscii(char cosnt * asciiStr, sal_Int32 maxLength) does a shortened comparison of only up to maxLength characters of *this and the given asciiStr. Maybe this one should be renamed t

Re: rtl::OUString::compareToAscii is dangerous

2013-03-19 Thread Noel Grandin
On Tue, Mar 19, 2013 at 6:54 PM, Stephan Bergmann wrote: > > * compareToAscii(char cosnt * asciiStr, sal_Int32 maxLength) does a > shortened comparison of only up to maxLength characters of *this and the > given asciiStr. > Maybe this one should be renamed to something like "compareLeftToAscii" ?

rtl::OUString::compareToAscii is dangerous

2013-03-19 Thread Stephan Bergmann
There are two overloads of rtl::OUString::compareToAscii: * compareToAscii(char const * asciiStr) does a full comparison of *this and the given asciiStr. * compareToAscii(char cosnt * asciiStr, sal_Int32 maxLength) does a shortened comparison of only up to maxLength characters of *this and th