[SOLVED] Re: remove_if for nothing in dbdata.cxx (sc module)

2015-01-02 Thread julien2412
Fix pushed (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=31e82d9f6f07335a2526bd44956eebfcaf0a289d) Thank you Stephan and Kohei! -- View this message in context: http://nabble.documentfoundation.org/remove-if-for-nothing-in-dbdata-cxx-sc-module-tp4134249p4134907.html Sent from the

Re: remove_if for nothing in dbdata.cxx (sc module)

2015-01-02 Thread julien2412
Hi Stephan First thank you for your feedback. After some discussion with Kohei about this idea, he suggested to create a deleteOnTab function directly in AnonDBs class, here's the patch: https://gerrit.libreoffice.org/#/c/13723/ (just thinking I had asked to Kohei if we should use "FindByTable" as

Re: remove_if for nothing in dbdata.cxx (sc module)

2015-01-02 Thread Stephan Bergmann
On 01/02/2015 03:21 PM, Stephan Bergmann wrote: So looks like AnonDBs should also export the underlying ptr_vector's ranged erase. ...or even export ptr_vector's erase_if ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.free

Re: remove_if for nothing in dbdata.cxx (sc module)

2015-01-02 Thread Stephan Bergmann
On 12/28/2014 05:08 PM, julien2412 wrote: Hello, I noticed this part: 889 void ScDBCollection::DeleteOnTab( SCTAB nTab ) 890 { ... 908 remove_if(maAnonDBs.begin(), maAnonDBs.end(), func); 909 } "remove_if" is useless since there's no erase. I thought about adding an "era

Re: remove_if for nothing in dbdata.cxx (sc module)

2014-12-28 Thread Will Entriken
UNSUBSCRIBE On Sun, Dec 28, 2014 at 11:08 AM, julien2412 wrote: > Hello, > > I noticed this part: > 889 void ScDBCollection::DeleteOnTab( SCTAB nTab ) > 890 { > ... > 908 remove_if(maAnonDBs.begin(), maAnonDBs.end(), func); > 909 } > > "remove_if" is useless since there's no

remove_if for nothing in dbdata.cxx (sc module)

2014-12-28 Thread julien2412
Hello, I noticed this part: 889 void ScDBCollection::DeleteOnTab( SCTAB nTab ) 890 { ... 908 remove_if(maAnonDBs.begin(), maAnonDBs.end(), func); 909 } "remove_if" is useless since there's no erase. I thought about adding an "erase" by taking example of this http://en.wikipedi