Hi Kendy,
On Mon, Jul 27, 2015 at 11:29:29AM +0200, Jan Holesovsky
wrote:
> https://wiki.documentfoundation.org/Development/Unit_Tests
>
> with two things:
>
> * list of areas that have "No fix without a unit test" rule (Miklos, I
> believe you have the same rule in the import/export filters
Hi Moggi, all,
Markus Mohrhard píše v So 25. 07. 2015 v 02:10 +0200:
> Additionally I consider the "it's insane to rejecting this on the
> grounds of unit tests" a quite direct personal attack. Normally I
> would have tried to talk directly with someone who pushes such a patch
> but after such a
Markus Mohrhard wrote:
> I'd appreciate if it is discussed in the ESC as I think that no
> patch should be pushed if a core developer likes to see a test or
> some more discussion.
>
Quite. And there was a -1 from me as well & an (unanswered, open)
question.
On the other hand, we do seem to have
On Sat, 2015-07-25 at 12:15 +0200, Markus Mohrhard wrote:
> would be required for the tests ? [ if it is easy to test
> then ... worse style I guess ].
>
> Writing a XShape test only requires to create a test document that
> shows the changed code. Hopefully everyone fixing a bug h
Hey Michael,
I hope you don't mind me butting in again.
On Sat, 2015-07-25 at 08:17 +0100, Michael Meeks wrote:
> Hi Markus,
>
> On Fri, 2015-07-24 at 18:22 +0200, Markus Mohrhard wrote:
> > so it is now the second time that despite me requesting a unit test in
> > a gerrit review request a pat
On Sat, Jul 25, 2015 at 9:17 AM, Michael Meeks
wrote:
> Hi Markus,
>
> On Fri, 2015-07-24 at 18:22 +0200, Markus Mohrhard wrote:
> > so it is now the second time that despite me requesting a unit test in
> > a gerrit review request a patch has been pushed.
>
> Sounds like bad style. Then
Hi Markus,
On Fri, 2015-07-24 at 18:22 +0200, Markus Mohrhard wrote:
> so it is now the second time that despite me requesting a unit test in
> a gerrit review request a patch has been pushed.
Sounds like bad style. Then again - how many man-hours do we expect
would be required for the te
Hi,
It was far easier to do the test than I thought. I pushed the test to
gerrit [1].
Sorry for all the trouble.
[1]: https://gerrit.libreoffice.org/#/c/17344/
Regard, Tomaž
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.f
Hi Marcus,
On Sat, Jul 25, 2015 at 1:22 AM, Markus Mohrhard
wrote:
> Hey guys,
>
> so it is now the second time that despite me requesting a unit test in a
> gerrit review request a patch has been pushed.
> I only care marginally if you do it in code that I don't maintain but I will
> revert it e
He Kendy,
On Fri, Jul 24, 2015 at 9:14 PM, Jan Holesovsky wrote:
> Hi Bjoern, Moggi,
>
> Bjoern Michaelsen píše v Pá 24. 07. 2015 v 19:51 +0200:
>
> > > On Friday, 2015-07-24 18:22:34 +0200, Markus Mohrhard wrote:
> > > > I'd appreciate a decision by the ESC to either stop this behavior or
> to
Jan Holesovsky píše v Pá 24. 07. 2015 v 21:14 +0200:
> I'll try to ressurect the
> gerrit issue entry in the meantime so that Laurent knows.
https://gerrit.libreoffice.org/#/c/17343
All the best,
Kendy
___
LibreOffice mailing list
LibreOffice@lists.fr
Hi Bjoern, Moggi,
Bjoern Michaelsen píše v Pá 24. 07. 2015 v 19:51 +0200:
> > On Friday, 2015-07-24 18:22:34 +0200, Markus Mohrhard wrote:
> > > I'd appreciate a decision by the ESC to either stop this behavior or to
> > > tell me to shut up! In the second case I will take it as another sign that
On Fri, Jul 24, 2015 at 06:45:39PM +0200, Eike Rathke wrote:
> On Friday, 2015-07-24 18:22:34 +0200, Markus Mohrhard wrote:
> > I'd appreciate a decision by the ESC to either stop this behavior or to
> > tell me to shut up! In the second case I will take it as another sign that
> > the project does
Hi,
On Friday, 2015-07-24 18:22:34 +0200, Markus Mohrhard wrote:
> so it is now the second time that despite me requesting a unit test in a
> gerrit review request a patch has been pushed.
> I only care marginally if you do it in code that I don't maintain but I
> will revert it every single time
Hey guys,
so it is now the second time that despite me requesting a unit test in a
gerrit review request a patch has been pushed.
I only care marginally if you do it in code that I don't maintain but I
will revert it every single time when it is in code that I maintain.
I'd appreciate a decision
15 matches
Mail list logo
