Re: proposition for patch in CommonSalLayout.cxx

2021-03-09 Thread julien2412
Stanisław Jeśmanowicz wrote >> > This is not always the case, because if a platform didn't include > graphite2 shaper in its HarfBuzz > implementaion, you won't have it anyway ( like ./configure > --with-graphite2=no ) > Even if you set it the shapers list (as in > https://cgit.freedesktop.org/li

Re: proposition for patch in CommonSalLayout.cxx

2021-03-09 Thread julien2412
Stanisław Jeśmanowicz wrote > ... > Thank you for your advice, but getting familiar with gerrit on top of git > would take some time for > me now. > I hope, that some of your developers could commit this patch for me in vcl > module. > It is simple and won't harm anything. > But people could benef

Re: proposition for patch in CommonSalLayout.cxx

2021-03-09 Thread Ilmari Lauhakangas
On 9.3.2021 20.51, Stanisław Jeśmanowicz wrote: On 3/9/21 6:34 PM, julien2412 wrote: Stanisław Jeśmanowicz wrote ... Thank you for your advice, but getting familiar with gerrit on top of git would take some time for me now. I hope, that some of your developers could commit this patch for me

Re: proposition for patch in CommonSalLayout.cxx

2021-03-09 Thread Stanisław Jeśmanowicz
On 3/9/21 6:34 PM, julien2412 wrote: Stanisław Jeśmanowicz wrote ... Thank you for your advice, but getting familiar with gerrit on top of git would take some time for me now. I hope, that some of your developers could commit this patch for me in vcl module. It is simple and won't harm anything

Re: proposition for patch in CommonSalLayout.cxx

2021-03-09 Thread Stanisław Jeśmanowicz
Hello Julien, On 3/9/21 9:18 AM, julien2412 wrote: Hello, In addition to what Miklos indicated, I think you may be interested in https://wiki.documentfoundation.org/Development/GetInvolved. Indeed, it seems you've already downloaded sources, built and tried to fix a problem with a patch. So you

Re: proposition for patch in CommonSalLayout.cxx

2021-03-09 Thread Stanisław Jeśmanowicz
Hello Miklos, On 3/9/21 9:14 AM, Miklos Vajna wrote: Hi Stan, On Mon, Mar 08, 2021 at 03:50:21PM +0100, Stanisław Jeśmanowicz wrote: Dear all, I noticed that LibreOffice is using the hard coded harfbuzz shapers list in CommonSalLayout.cxx file (line 470). I recommend the patch attached to b

Re: proposition for patch in CommonSalLayout.cxx

2021-03-09 Thread julien2412
Hello, In addition to what Miklos indicated, I think you may be interested in https://wiki.documentfoundation.org/Development/GetInvolved. Indeed, it seems you've already downloaded sources, built and tried to fix a problem with a patch. So you only need now a gerrit account and submit your licens

Re: proposition for patch in CommonSalLayout.cxx

2021-03-09 Thread Miklos Vajna
Hi Stan, On Mon, Mar 08, 2021 at 03:50:21PM +0100, Stanisław Jeśmanowicz wrote: > Dear all, > > I noticed that LibreOffice is using the hard coded harfbuzz shapers list in > CommonSalLayout.cxx file (line 470). > I recommend the patch attached to be more flexible. > This take all possible shape

proposition for patch in CommonSalLayout.cxx

2021-03-08 Thread Stanisław Jeśmanowicz
Dear all, I noticed that LibreOffice is using the hard coded harfbuzz shapers list in CommonSalLayout.cxx file (line 470). I recommend the patch attached to be more flexible. This take all possible shapers in a given HarfBuzz implementation. This also allows the use of newly created shapers. J