RE: patch removing Labels.xcu out of configuration

2013-02-18 Thread Michael Meeks
Hi Winfried, On Mon, 2013-02-18 at 08:43 +0100, Winfried Donkers wrote: > I get an exception > (warn:legacy.osl:24509:1:unotools/source/config/configitem.cxx:58: > Exception from GetNodeNames: *['Avery A4']) which can well be the cause > of not > being able to overwrite existing labels.

RE: patch removing Labels.xcu out of configuration

2013-02-17 Thread Winfried Donkers
Hi Matus, Michael, > Well, overwriting existing labels does not work I think, but it did not before > either, so.. I think that's fine. > If you would like to fix this, poke IMPL_LINK_NOARG(SwSaveLabelDlg, > OkHdl) in sw/source/ui/envelp/labfmt.cxx Maybe if(RET_YES != eRet) makes > it return befor

RE: [PUSHED] patch removing Labels.xcu out of configuration

2013-02-14 Thread Winfried Donkers
Hi Matus, > Well, overwriting existing labels does not work I think, but it did not before > either, so.. I think that's fine. > If you would like to fix this, poke IMPL_LINK_NOARG(SwSaveLabelDlg, > OkHdl) in sw/source/ui/envelp/labfmt.cxx Maybe if(RET_YES != eRet) makes > it return before saving

Re: patch removing Labels.xcu out of configuration

2013-02-14 Thread Matúš Kukan
On 13 February 2013 22:05, Michael Meeks wrote: > Wrt. the saving issue - it'd be interesting to see what happens in > SwLabelConfig::SaveLabel as you step through that when clicking 'Ok' in > the relevant dialog. Are we failing to add the node ? are we somehow not > committing it or somet

Re: [PUSHED] patch removing Labels.xcu out of configuration

2013-02-14 Thread Matúš Kukan
On 14 February 2013 11:00, Winfried Donkers wrote: > A great improvement! > If there are any leftovers (like perhaps the not being able to save modified > labels, as I read somewhere in your mails) for which you don't have time or > interest to look into yourself, I'm willing to assist. > (That

RE: [PUSHED] patch removing Labels.xcu out of configuration

2013-02-14 Thread Michael Meeks
On Thu, 2013-02-14 at 11:00 +0100, Winfried Donkers wrote: > A great improvement! Hey - glad you're watching :-) > If there are any leftovers (like perhaps the not being able to save > modified labels, as I read somewhere in your mails) for which you > don't have time or interest to look

RE: [PUSHED] patch removing Labels.xcu out of configuration

2013-02-14 Thread Winfried Donkers
Hi Matus, > > I've finished my first patch on reducing configuration data > > There were a few corner-case packaging pieces of interest that > needed fixing on a from-clean build but it's pushed now :-) A great improvement! If there are any leftovers (like perhaps the not being able to sav

[PUSHED] patch removing Labels.xcu out of configuration

2013-02-14 Thread Michael Meeks
Hi Matus, On Wed, 2013-02-13 at 21:04 +0100, Matúš Kukan wrote: > I've finished my first patch on reducing configuration data There were a few corner-case packaging pieces of interest that needed fixing on a from-clean build but it's pushed now :-) Good work, Mic

Re: patch removing Labels.xcu out of configuration

2013-02-13 Thread Michael Meeks
Hi Matus, On Wed, 2013-02-13 at 21:04 +0100, Matúš Kukan wrote: > I've finished my first patch on reducing configuration data and > decided to send it this way. It looks lovely ! :-) thanks for that. > It seems to work, although not as I was expecting. > You still can't save modified lab