So I see we're going to revert my "long->salInt32" commit - which I'm fine
with, it's better that we get our testing tools back on a even keel.
But it is as well to acknowledge that we are only hiding these flaws, not
solving them - all of the overflow and other integer issues we saw here,
exist c
On 05/04/18 09:53, Stephan Bergmann wrote:
I propose that we revisit the "long->sal_Int32 in tools/gen.hxx" commit
and change to sal_Int64 instead:
doing that now as <https://gerrit.libreoffice.org/#/c/52471/>
"sal_Int32->
On Thu, 2018-04-05 at 09:53 +0200, Stephan Bergmann wrote:
> <https://cgit.freedesktop.org/libreoffice/core/commit/?id=8bc951daf79
> decbd8a599a409c6d33c5456710e0>
> "long->sal_Int32 in tools/gen.hxx" changed tools/gen.hxx classes
> like Point and Rect from being
<https://cgit.freedesktop.org/libreoffice/core/commit/?id=8bc951daf79decbd8a599a409c6d33c5456710e0>
"long->sal_Int32 in tools/gen.hxx" changed tools/gen.hxx classes like
Point and Rect from being based on long members to being based on
sal_Int32 members. It was probably a go
