Re: help in writing tests

2020-01-26 Thread Regina Henschel
Hi Shivam, Shivam Kumar Singh schrieb am 26-Jan-20 um 18:24: Also ,  tdf123684 is very similar to tdf123841 , Check for an object and inspect its style to be FillStyle_NONE, I used the code and have submitted a patch https://gerrit.libreoffice.org/c/core/+/87440 and here is the build https:/

Re: help in writing tests

2020-01-26 Thread Shivam Kumar Singh
Hi Regina ,Miklos, all, Thanks for the great help and the code pointers . I tried to modify the code from SdImportTest::testTdf97808() in sd/qa/unit/import-tests.cxx. In the code for tdf97808 a line is inspected and using the property getPropertyValue("Style") it was checked if it is equal to the

Re: help in writing tests

2020-01-26 Thread Shivam Kumar Singh
Hi Regina ,Miklos, all, Thanks for the great help and the code pointers . I tried to modify the code from SdImportTest::testTdf97808() in sd/qa/unit/import-tests.cxx. In the code for tdf97808 a line is inspected and using the property getPropertyValue("Style") it was checked if it is equal to the

Re: help in writing tests

2020-01-23 Thread Regina Henschel
I had some private mails with Shivam. I have suggested to create a new document and verify, that the default style has filling NONE. default style --> style, which is "Object without fill" in the UI ___ LibreOffice mailing list LibreOffice@lists.fre

Re: help in writing tests

2020-01-23 Thread Regina Henschel
Hi all, I had some private mails with Shivam. I have suggested to create a new document and verify, that the default style has filling NONE. Code pointers for that are: new document: use loadFromDesktop with pseudo URL privat:factory/sdraw getting a style: SdImportTest::testTdf97808() in sd/

Re: help in writing tests

2020-01-23 Thread Miklos Vajna
Hi Shivam, [ First, please let's keep the discussion on the mailing list, not in private. ] On Mon, Jan 20, 2020 at 02:28:34PM +0530, Shivam Kumar Singh wrote: > Thanks for you reply .Following is the patch that I had submitted . > https://gerrit.libreoffice.org/c/core/+/86944 > > Also, Is it

Re: help in writing tests

2020-01-20 Thread Miklos Vajna
Hi Shivam, On Sun, Jan 19, 2020 at 01:37:47AM +0530, Shivam Kumar Singh wrote: > My patch for tdf#123847 has been pushed to master and now I need to write > unit test for the bug . I went through the wiki but am still having trouble > writing one.Could anyone guide me through which kind of test

Re: help in writing tests

2020-01-19 Thread Ilmari Lauhakangas
Shivam Kumar Singh kirjoitti 18.1.2020 klo 22.07: Hi all, My patch for tdf#123847 has been pushed to master and now I need to write unit test for the bug . I went through the wiki but am still having trouble writing one.Could anyone guide me through which kind of test I need to do and how to d

help in writing tests

2020-01-18 Thread Shivam Kumar Singh
Hi all, My patch for tdf#123847 has been pushed to master and now I need to write unit test for the bug . I went through the wiki but am still having trouble writing one.Could anyone guide me through which kind of test I need to do and how to do that ? Thanks. Sincerely , Shivam _