Re: compiler plugin

2017-01-20 Thread Stephan Bergmann
On 01/20/2017 05:17 PM, Norbert Thiebaud wrote: On Fri, Jan 20, 2017 at 3:16 AM, Stephan Bergmann wrote: What appears to be missing is a "normal" (not Gerrit-triggered) bot running that setup on master, so that a broken master wrt that setup can be spotted (and acted upon) more quickly. Today,

Re: compiler plugin

2017-01-20 Thread Norbert Thiebaud
On Fri, Jan 20, 2017 at 3:16 AM, Stephan Bergmann wrote: > On 07/12/2016 09:32 AM, Norbert Thiebaud wrote: >> >> I've enabled an additional build for gerrit doing clang + plugins on linux >> we will see how that perform in average. >> preliminary observation is that there is way to much churn in t

Re: compiler plugin

2017-01-20 Thread Stephan Bergmann
On 01/20/2017 11:29 AM, Jan Iversen wrote: Today, a broken master is only spotted when somebody tracks down a broken Gerrit build to be due to a broken master (or when somebody doing their own local build with a sufficiently similar setup spots it). That can delay fixing unnecessarily, causing m

Re: compiler plugin

2017-01-20 Thread Jan Iversen
> Today, a broken master is only spotted when somebody tracks down a broken > Gerrit build to be due to a broken master (or when somebody doing their own > local build with a sufficiently similar setup spots it). That can delay > fixing unnecessarily, causing many developers to meanwhile base t

Re: compiler plugin

2017-01-20 Thread Stephan Bergmann
On 07/12/2016 09:32 AM, Norbert Thiebaud wrote: I've enabled an additional build for gerrit doing clang + plugins on linux we will see how that perform in average. preliminary observation is that there is way to much churn in the plugins for this to be viable at this time What appears to be

Re: compiler plugin

2017-01-16 Thread Stephan Bergmann
On 07/13/2016 11:18 AM, Stephan Bergmann wrote: So my proposal would be as follows: First, check whether enabling compiler_check=content or the compiler_check=string:X setup (and increasing the ccache size if necessary and possible) gives good-enough performance. If not, restrict commits to com

Re: compiler plugin

2016-09-12 Thread Stephan Bergmann
On 07/12/2016 09:32 AM, Norbert Thiebaud wrote: I've enabled an additional build for gerrit doing clang + plugins on linux we will see how that perform in average. preliminary observation is that there is way to much churn in the plugins for this to be viable at this time The newly set up

Re: compiler plugin

2016-07-15 Thread Lineikosen
The Compiler Plugin is used to compile the sources of your project. Since 3.0, the default compiler is javax.tools.JavaCompiler (if you are using java 1.6) and is used to compile Java sources. If you want to force the plugin using javac, you must configure the plugin option forceJavacCompilerUse

Re: compiler plugin

2016-07-14 Thread Stephan Bergmann
On 07/13/2016 06:07 PM, Norbert Thiebaud wrote: On Wed, Jul 13, 2016 at 7:00 AM, Stephan Bergmann wrote: Not necessarily. Consider a change being discussed between an author and a reviewer, leading to the author generating multiple revisions of the change. To track the differences between the

Re: compiler plugin

2016-07-13 Thread Norbert Thiebaud
On Wed, Jul 13, 2016 at 7:00 AM, Stephan Bergmann wrote: > Not necessarily. Consider a change being discussed between an author and a > reviewer, leading to the author generating multiple revisions of the change. > To track the differences between the revisions, it is best if there's no > rebases

Re: compiler plugin

2016-07-13 Thread Stephan Bergmann
ocation? Do you confuse "compiler_check=string:value" with "compiler_check=a command string"? What I suggest is: 1/ allow the plugins to be built standalone and delivered (ideally, spin it in a sub-module). Allow configure.ac to use a 'external version of the compiler plu

Re: compiler plugin

2016-07-13 Thread Norbert Thiebaud
ng 15,000 X 200MB = 3TB per build is going to be a waste. compiler_check=string is no better since that would actually run these as external process for each ccache invocation bearing in mind that a build is north of 15K of theses... What I suggest is: 1/ allow the plugins to be built standalone and

Re: compiler plugin

2016-07-13 Thread Stephan Bergmann
On 07/12/2016 09:32 AM, Norbert Thiebaud wrote: so I ran some number... after upgrading ccache clang+pluging+dbgutil (time result in minutes.. elapsed/user/system) cold: 33/840/50 hot: 9/79/14 no-op: 4/46/1 clang+dbgutil (no plugins) cold: 26/605/46 hot: 9/79/14 no-op: 4/46/1 gcc-dbgutil c

compiler plugin

2016-07-12 Thread David Ostrovsky
On Tue, Jul 12, 2016 at 02:58:35PM +0200, Stephan Bergmann wrote: > where the first link, is the > one to the results of the new Clang+plugins bot. However, it is unclear to > me how to navigate from that page to the relevant information about the > f

Re: compiler plugin

2016-07-12 Thread Miklos Vajna
Hi, On Tue, Jul 12, 2016 at 02:58:35PM +0200, Stephan Bergmann wrote: > where the first link, is the > one to the results of the new Clang+plugins bot. However, it is unclear to > me how to navigate from that page to the relevant information about t

Re: compiler plugin

2016-07-12 Thread Stephan Bergmann
On 07/12/2016 09:32 AM, Norbert Thiebaud wrote: I've enabled an additional build for gerrit doing clang + plugins on linux So Jenkins comments on Gerrit changes now contain two links, one to the results of the three old bots (Linux, OS X, Windows) and one to the results of the new Clang+plugi

compiler plugin

2016-07-12 Thread Norbert Thiebaud
so I ran some number... after upgrading ccache clang+pluging+dbgutil (time result in minutes.. elapsed/user/system) cold: 33/840/50 hot: 9/79/14 no-op: 4/46/1 clang+dbgutil (no plugins) cold: 26/605/46 hot: 9/79/14 no-op: 4/46/1 gcc-dbgutil cold: 28/621/97 hot: 9/79/14 no-op: 4/45/1 note: n

[PUSHED] fdo#60148 Clean up warnings from the Clang compiler plugin

2013-03-06 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2544 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2544 To unsubscribe, visit

Re: [PATCH] fdo#60148 Clean up warnings from the Clang compiler plugin

2013-03-05 Thread Ngo Cao Cuong
t; To pull it, you can do: > > git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/2544/1 > > fdo#60148 Clean up warnings from the Clang compiler plugin > > Cleaned all the warnings from loplugin. Some warnings come from the untar > downl

[PATCH] fdo#60148 Clean up warnings from the Clang compiler plugin

2013-03-04 Thread Cao Cuong Ngo (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2544 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/2544/1 fdo#60148 Clean up warnings from the Clang compiler plugin Cleaned all the warnings from loplugin. Some

Re: [PATCH] Introducing compiler plugin support

2012-10-12 Thread Lubos Lunak
On Tuesday 09 of October 2012, Lubos Lunak wrote: > On Friday 05 of October 2012, Lubos Lunak wrote: > > Hello, > > > > attached is my implementation of basic build support for using Clang > > compiler plugin during building LO. I'm posting it here first in case

Re: [PATCH] Introducing compiler plugin support

2012-10-09 Thread Caolán McNamara
On Tue, 2012-10-09 at 17:26 +0200, Lubos Lunak wrote: > - there is a warning about unused variables of types marked SAL_WARN_UNUSED > plus some C++ std classes ; quite a number of hits. Feel free to tag all > those Point, Rectangle, etc. classes with it too, as long as it's certain for > the cla

Re: [PATCH] Introducing compiler plugin support

2012-10-09 Thread Michael Stahl
> On Monday 08 of October 2012, Michael Stahl wrote: >> On 05/10/12 18:22, Lubos Lunak wrote: >>> +$(CLANGOUTDIR)/compileplugin.so: $(2) >>> +$(CLANGOUTDIR)/compileplugin.so: CLANGOBJS += $(2) >>> + >>> +$(CLANGOUTDIR)/compileplugin.so: $(CLANGOBJS) >> >> there's a bit of redundancy there. > > Th

Re: [PATCH] Introducing compiler plugin support

2012-10-09 Thread Lubos Lunak
On Friday 05 of October 2012, Lubos Lunak wrote: > Hello, > > attached is my implementation of basic build support for using Clang > compiler plugin during building LO. I'm posting it here first in case our > build system people have different ideas to how I have integrat

Re: [PATCH] Introducing compiler plugin support

2012-10-08 Thread Michael Stahl
On 05/10/12 18:22, Lubos Lunak wrote: > > Hello, > > attached is my implementation of basic build support for using Clang > compiler > plugin during building LO. I'm posting it here first in case our build system > people have different ideas to how I have integra

[PATCH] Introducing compiler plugin support

2012-10-05 Thread Lubos Lunak
Hello, attached is my implementation of basic build support for using Clang compiler plugin during building LO. I'm posting it here first in case our build system people have different ideas to how I have integrated it in the build system, if there are no comments, I will pu