Hi Mohammed,
On 06/06/17 13:07, Mohammed Abdul Azeem wrote:
> Now I read it again, I'm rather skeptical that:
>
> +if( !maUsedBuffers.empty() )
...
> is helpful. I'm not sure that we can re-use these buffers
> efficiently
> here - perhaps its better jus
Hi Michael,
On Tue, Jun 6, 2017 at 12:10 AM, Michael Meeks
wrote:
> Hi Mohammed,
>
> Now I read it again, I'm rather skeptical that:
>
> +if( !maUsedBuffers.empty() )
> +{
> +pProducedBuffer = maUsedBuffers.front();
> +maUsedBuffers.pop();
> +
On 05/06/17 21:20, Kohei Yoshida wrote:
> I'm afraid I don't have any advice here that I can give off the top of
> my head.
Fair enough =)
> I would probably have to spend some considerable amount of time
> researching before I could even come up with something tangible. :-(
No
On Mon, 2017-06-05 at 21:14 +0100, Michael Meeks wrote:
> Hi Kohei,
>
> On 05/06/17 20:54, Kohei Yoshida wrote:
> >
> > On Mon, 2017-06-05 at 19:40 +0100, Michael Meeks wrote:
> > >
> > > Suggests (input from Kohei appreciated) - that we may
> > > need to
> > > do a new
> > > 'seek' each
Hi Kohei,
On 05/06/17 20:54, Kohei Yoshida wrote:
> On Mon, 2017-06-05 at 19:40 +0100, Michael Meeks wrote:
>> Suggests (input from Kohei appreciated) - that we may need to
>> do a new
>> 'seek' each time we come to reading some bytes from the underlying
>> package/ stream - to ensure that
On Mon, 2017-06-05 at 19:40 +0100, Michael Meeks wrote:
> Suggests (input from Kohei appreciated) - that we may need to
> do a new
> 'seek' each time we come to reading some bytes from the underlying
> package/ stream - to ensure that no other thread is messing with our
> underlying stream
On 5 June 2017 at 20:40, Michael Meeks wrote:
>
> Sooo ... I think your code is golden; but we're going to need to
> fix
> the package/ code to avoid the bug.
>
> https://bugs.documentfoundation.org/show_bug.cgi?id=97597#c28
>
> Suggests (input from Kohei appreciated) - that we ma
Hi Mohammed,
Just a few more esthetic comments =) on a nice patch.
+size_t mnPos;
+size_t mnStreamSize;
+
+Buffer maInUseBuffer;
+int mnOffset;
I'd love to see some doxygen comments:
size_t mnPos; /// position in stream
int mnOffset; /// position
