Re: Whitespace and other stylistic changes

2016-09-25 Thread Norbert Thiebaud
On Sun, Sep 25, 2016 at 1:14 PM, Maarten Bosmans wrote: > > So my question is: how far away from a functional change is it > desired/allowed to make stylistic changes for consistency? Is that the > whole file, class, function, scope block, statement or line? my two cents: 1/ it is ok to do such

Whitespace and other stylistic changes

2016-09-25 Thread Maarten Bosmans
Hi devs, On a recent gerrit patch submission of mine, Markus Mohrhard added the following comment: > Please don't mix style changes with functional changes. So please split the > patch into 3: the actual change mentioned in the commit msg, the translations > and the whitespace change. > > Actua