Re: [PUSHED:3-5] Re: Two Python 2.x regressions in LibreOffice 3.5.1RC1

2012-03-13 Thread Petr Mladek
Caolán McNamara píše v Po 12. 03. 2012 v 13:50 +: > On Fri, 2012-03-09 at 15:48 +0100, Michael Stahl wrote: > > On 07/03/12 11:37, Michael Stahl wrote: > > > > > PS: please somebody review the above 2 commits and backport to > > > libreoffice-3-5. > > > > additionally this one is necessary >

Re: [REVIEW][3-5] Re: Two Python 2.x regressions in LibreOffice 3.5.1RC1

2012-03-12 Thread David Bolen
Michael Stahl writes: > thanks for bringing these regressions to this list; in my experience > usually QA people aren't very fond of looking at API issues. Thanks for committing the patches (plus handling the regression introduced by the proposed patch in fdo#46926). > unfortunately it's probab

Re: [REVIEWED][REVIEW][3-5] Re: Two Python 2.x regressions in LibreOffice 3.5.1RC1

2012-03-12 Thread Caolán McNamara
On Fri, 2012-03-09 at 15:48 +0100, Michael Stahl wrote: > On 07/03/12 11:37, Michael Stahl wrote: > > > PS: please somebody review the above 2 commits and backport to > > libreoffice-3-5. > > additionally this one is necessary Full three patches cherry-picked to 3-5 now. C. ___

Re: [REVIEW][3-5] Re: Two Python 2.x regressions in LibreOffice 3.5.1RC1

2012-03-09 Thread Alexander Thurgood
Le 09/03/12 15:48, Michael Stahl a écrit : Hi Michael, > On 07/03/12 11:37, Michael Stahl wrote: > >> PS: please somebody review the above 2 commits and backport to >> libreoffice-3-5. > > additionally this one is necessary which fixes incompatibility with > Python 3 that was introduced by the

Re: [REVIEW][3-5] Re: Two Python 2.x regressions in LibreOffice 3.5.1RC1

2012-03-09 Thread Michael Stahl
On 07/03/12 11:37, Michael Stahl wrote: > PS: please somebody review the above 2 commits and backport to > libreoffice-3-5. additionally this one is necessary which fixes incompatibility with Python 3 that was introduced by the fix above: http://cgit.freedesktop.org/libreoffice/core/commit/?id=0

[REVIEW][3-5] Re: Two Python 2.x regressions in LibreOffice 3.5.1RC1

2012-03-07 Thread Michael Stahl
On 04/03/12 00:45, David Bolen wrote: > I've run into two regressions (from 3.4.5) when using LibreOffice > 3.5.1RC1 with the internal Python interpreter (though I believe it will > affect any Python 2.x user), both apparently unintended consequences of > an earlier Python 3 compatibility commit.

Two Python 2.x regressions in LibreOffice 3.5.1RC1

2012-03-03 Thread David Bolen
I've run into two regressions (from 3.4.5) when using LibreOffice 3.5.1RC1 with the internal Python interpreter (though I believe it will affect any Python 2.x user), both apparently unintended consequences of an earlier Python 3 compatibility commit. I'm pretty sure these were present in 3.5.0 bu