Re: SfxItemSet::HasItem method

2012-02-07 Thread Kohei Yoshida
On Tue, 2012-02-07 at 17:26 +0100, Miklos Vajna wrote: > I've introduced a few usage of HasItem in > sw/source/filter/ww8/rtfattributeoutput.cxx, so checking if sw builds > after your changes may make sense. ;-) Yup, I've noticed. :-) Thanks for mentioning. sw should build, as I've double-check

Re: SfxItemSet::HasItem method

2012-02-07 Thread Miklos Vajna
On Tue, Feb 07, 2012 at 11:13:44AM -0500, Kohei Yoshida wrote: > But then now that you mention it, maybe you have a point, and I agree > that having an extra & may make it more obvious that it's an optional > argument. > > I'll make that change. I've introduced a few usage of HasItem in sw/sour

Re: SfxItemSet::HasItem method

2012-02-07 Thread Kohei Yoshida
On Tue, 2012-02-07 at 13:56 +0100, Lubos Lunak wrote: > On Monday 06 of February 2012, Kohei Yoshida wrote: > > Hi there, > > > > I've just added a new method to SfxItemSet to provide an easy way to > > check whether or not an item is already set, and if it's already set, > > get that item. Here i

Re: SfxItemSet::HasItem method

2012-02-07 Thread Caolán McNamara
On Mon, 2012-02-06 at 14:49 -0500, Kohei Yoshida wrote: > Just FYI. FWIW, sw/source/filter/ww8/writerhelper.hxx HasItem is sort of similar, and there's some other stuff in there (written a long time ago) which might have some utility up higher. No guarantees. C. _

Re: SfxItemSet::HasItem method

2012-02-07 Thread Lubos Lunak
On Monday 06 of February 2012, Kohei Yoshida wrote: > Hi there, > > I've just added a new method to SfxItemSet to provide an easy way to > check whether or not an item is already set, and if it's already set, > get that item. Here is what I've added: > > bool SfxItemSet::HasItem(sal_uInt16 nWhich,

SfxItemSet::HasItem method

2012-02-06 Thread Kohei Yoshida
Hi there, I've just added a new method to SfxItemSet to provide an easy way to check whether or not an item is already set, and if it's already set, get that item. Here is what I've added: bool SfxItemSet::HasItem(sal_uInt16 nWhich, const SfxPoolItem*& rpItem) const { return SFX_ITEM_SET ==