Re: ScPostIt revision

2015-06-22 Thread Eike Rathke
Hi Mike, On Saturday, 2015-06-20 10:31:51 +1000, Mike Kaganski wrote: > >>1. *Ordinary* objects: they belong to one and only one cell in a document. > >>They don't share anything with no other *ordinary* note, nor with > >>*clipboard* notes. But they always share data with *undo* notes. > >You'll

Re: ScPostIt revision

2015-06-19 Thread Mike Kaganski
Hello Eike, thank you very much for your notes! 6/20/2015 2:44 AM, Eike Rathke пишет: I think that there are only three distinct types of notes out there: There *are* or there *should be*? I tried to look for places where currently ScPostIt is used, and only found these types of usage. So,

Re: ScPostIt revision

2015-06-19 Thread Eike Rathke
Hi Mike, On Friday, 2015-06-19 20:19:10 +1000, Mike Kaganski wrote: > >>So, I thought it's manifestation of obscure interface/protocol of the > >>objects that leads to broken conditions when implementers use them. > >>Currently I'm evaluating possible changes to (mainly) ScPostIt that > >>would

Re: ScPostIt revision

2015-06-19 Thread Mike Kaganski
Hello Kohei, I hoped very much that you could take a look at this and comment here. Thank you! 6/19/2015 11:42 AM, Kohei Yoshida пишет: On Wed, 2015-06-17 at 20:20 +1000, Mike Kaganski wrote: Another crash that I haven't issued to bugzilla (it would only add up to those already mentioned; do

Re: ScPostIt revision

2015-06-19 Thread Mike Kaganski
Hello Markus, thank you very much for your comments! 6/19/2015 3:17 AM, Markus Mohrhard пишет: On Wed, Jun 17, 2015 at 12:20 PM, Mike Kaganski mailto:mike.kagan...@collabora.com>> wrote: So, I thought it's manifestation of obscure interface/protocol of the objects that leads to broke

Re: ScPostIt revision

2015-06-18 Thread Kohei Yoshida
On Thu, 2015-06-18 at 21:42 -0400, Kohei Yoshida wrote: > incremental approaches would help, not a big-bang > re-design. And as I'm sure people are getting sick of me saying this, but more unit tests around the note bugs would be a huge step in the right direction. Have a great day! Kohei

Re: ScPostIt revision

2015-06-18 Thread Kohei Yoshida
On Wed, 2015-06-17 at 20:20 +1000, Mike Kaganski wrote: > Hello! > > While working on tdf#89226, I found out that there are a number of > places in calc where ScPostIt's, as well as the SdrCaptionObj's > (controlled by ScPostIt) are used after delete. > > Turns out that quite a few regressions

Re: ScPostIt revision

2015-06-18 Thread Markus Mohrhard
Hey, On Wed, Jun 17, 2015 at 12:20 PM, Mike Kaganski wrote: > Hello! > > While working on tdf#89226, I found out that there are a number of places > in calc where ScPostIt's, as well as the SdrCaptionObj's (controlled by > ScPostIt) are used after delete. > > Turns out that quite a few regressi

ScPostIt revision

2015-06-17 Thread Mike Kaganski
Hello! While working on tdf#89226, I found out that there are a number of places in calc where ScPostIt's, as well as the SdrCaptionObj's (controlled by ScPostIt) are used after delete. Turns out that quite a few regressions issued in bugzilla are rooted to that. To number a few: tdf#89226