Re: ScChangeTrackingExportHelper, SvNumberFormatter

2012-11-30 Thread Noel Grandin
On 2012-11-30 11:51, Michael Meeks wrote: On Thu, 2012-11-29 at 22:49 +0100, Eike Rathke wrote: A pointer wouldn't change much, defaulting to NULL wouldn't make sense anyway as then the caller wouldn't know what number type was detected and what format index to apply. Sigh - I guess so

Re: ScChangeTrackingExportHelper, SvNumberFormatter

2012-11-30 Thread Michael Meeks
On Thu, 2012-11-29 at 22:49 +0100, Eike Rathke wrote: > A pointer wouldn't change much, defaulting to NULL wouldn't make sense > anyway as then the caller wouldn't know what number type was detected > and what format index to apply. Sigh - I guess so; I wonder if there is a magic compiler

Re: ScChangeTrackingExportHelper, SvNumberFormatter

2012-11-29 Thread Eike Rathke
Hi Michael, On Thursday, 2012-11-29 20:26:29 +, Michael Meeks wrote: > > nIndex needs to be initialized for IsNumberFormat(), usually 0 for > > current locale and general number format, if it isn't the method assumes > > an arbitrary number format it tries to match against if general > > dete

Re: ScChangeTrackingExportHelper, SvNumberFormatter

2012-11-29 Thread Michael Meeks
On Thu, 2012-11-29 at 20:14 +0100, Eike Rathke wrote: > nIndex needs to be initialized for IsNumberFormat(), usually 0 for > current locale and general number format, if it isn't the method assumes > an arbitrary number format it tries to match against if general > detection fails. If it

Re: ScChangeTrackingExportHelper, SvNumberFormatter

2012-11-29 Thread Eike Rathke
Hi Stephan, On Thursday, 2012-11-29 17:24:44 +0100, Stephan Bergmann wrote: > Trying to build recent master on Windows with --enable-werror fails with > > >c:\lo\core\sc\source\filter\xml\xmlchangetrackingexporthelper.cxx(268) : > >warning C4701: potentially uninitialized local variable 'fTempV

ScChangeTrackingExportHelper, SvNumberFormatter

2012-11-29 Thread Stephan Bergmann
Trying to build recent master on Windows with --enable-werror fails with c:\lo\core\sc\source\filter\xml\xmlchangetrackingexporthelper.cxx(268) : error C2220: warning treated as error - no 'object' file generated c:\lo\core\sc\source\filter\xml\xmlchangetrackingexporthelper.cxx(268) : warning