Hi all,
so I reverted some stuff. The rest looks still sane to me (despite the
fact that it's a huge removal ;).
So string problems should not occur due to these changes, because all
removals where a resource id was set in the hrc and the string in the
src file - and at a first look were "un
Hi Thomas,
On Wed, 2012-07-18 at 21:33 +0200, Thomas Arnhold wrote:
> as Markus stated in dc05a825e71316e6f602e5c8dfcd3d10ecb6252f those
> string cleanups aren't save. I've had the illusion, that by compiling
> and "quick checking" all of it got tested (mostly by compiling).
Ah ... ;-)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Special attention to translatable resources if there is any in the
batch. My recent master build lost some localized string in the
navigator. Not lethal, though.
Em 20-07-2012 09:24, Thomas Arnhold escreveu:
> Ok. To be absolutely sure I bring all my
Hi Eike,
On 07/19/2012 09:29 PM, Eike Rathke wrote:
Some values are used as results of calculations, for example for the
specific case of the Navigator (SCSTR_CONTENT_GRAPHIC, ...) the
resources are obtained in a loop based on SCSTR_CONTENT_ROOT, see
sc/source/ui/navipi/content.cxx ScContentTree
On Thu, 2012-07-19 at 23:05 +0200, Michael Stahl wrote:
> since probably there's no good reason why loading resources may fail,
> perhaps it would be a good idea to turn this one into an assert() that
> aborts, so developers pay attention.
Yeah, thought about doing this myself.
Where I often see
On 19/07/12 21:29, Eike Rathke wrote:
> Hi Thomas,
>
> On Wednesday, 2012-07-18 21:33:26 +0200, Thomas Arnhold wrote:
>> Is there any way to get a real checkup what string and definitions
>> are in use at all?! If not it would be safer to revert all of this
>> cleanup. Even if that's very sad...
Hi Thomas,
On Wednesday, 2012-07-18 21:33:26 +0200, Thomas Arnhold wrote:
> But that there are strings in use, which are never referenced in the
> source or at compile time (so that the compiler would complain) is
> some kind of strange. Or do I just not understand this?!
Some values are used as
Hi Folks,
as Markus stated in dc05a825e71316e6f602e5c8dfcd3d10ecb6252f those
string cleanups aren't save. I've had the illusion, that by compiling
and "quick checking" all of it got tested (mostly by compiling). Because
there were complains, if I removed too much. I didn't touch things like
S
