Re: Request for review of draft: Resolvable comments in Writer

2019-06-21 Thread Jim MacArthur
Hi Regina, On 20/06/2019 18:35, Regina Henschel wrote: Hi Jim, Jim MacArthur schrieb am 20-Jun-19 um 17:30: I have a draft patch series which adds the ability to mark comments in Writer as resolved. This has had some discussion on https://bugs.documentfoundation.org/show_bug.cgi?id=119228. <

Re: Request for review of draft: Resolvable comments in Writer

2019-06-20 Thread Jim MacArthur
On 20/06/2019 18:44, Jan-Marek Glogowski wrote: Am 20.06.19 um 19:35 schrieb Regina Henschel: I cannot see the patches. Do you have used "submit-draft"? In that case you need to add reviewer. The better idea would be to just publish them and set yourself a -2 review (AKA no merge). That's how

Re: Request for review of draft: Resolvable comments in Writer

2019-06-20 Thread Jan-Marek Glogowski
Am 20.06.19 um 19:35 schrieb Regina Henschel: > I cannot see the patches. Do you have used "submit-draft"? In that case you > need > to add reviewer. The better idea would be to just publish them and set yourself a -2 review (AKA no merge). That's how we commonly push WIP and draft stuff, if we r

Re: Request for review of draft: Resolvable comments in Writer

2019-06-20 Thread Jim MacArthur
On 20/06/2019 18:35, Regina Henschel wrote: Hi Jim, Jim MacArthur schrieb am 20-Jun-19 um 17:30: I have a draft patch series which adds the ability to mark comments in Writer as resolved. This has had some discussion on https://bugs.documentfoundation.org/show_bug.cgi?id=119228.

Re: Request for review of draft: Resolvable comments in Writer

2019-06-20 Thread Regina Henschel
Hi Jim, Jim MacArthur schrieb am 20-Jun-19 um 17:30: I have a draft patch series which adds the ability to mark comments in Writer as resolved. This has had some discussion on https://bugs.documentfoundation.org/show_bug.cgi?id=119228.

Request for review of draft: Resolvable comments in Writer

2019-06-20 Thread Jim MacArthur
I have a draft patch series which adds the ability to mark comments in Writer as resolved. This has had some discussion on https://bugs.documentfoundation.org/show_bug.cgi?id=119228. The patches are https://gerrit.libreoffice.org/#/c