Re: unique_ptr header question

2017-04-24 Thread Bjoern Michaelsen
Hi, On Mon, Apr 24, 2017 at 09:43:16AM +0200, Stephan Bergmann wrote: > Another reason why a missing include of a standard library header may go > unnoticed with some toolchains but not with others is that the standard > allows C++ headers to include other C++ headers, so the relevant header may >

Re: unique_ptr header question

2017-04-24 Thread Chris Sherlock
On 24 Apr 2017, at 5:43 pm, Stephan Bergmann wrote: > >> On 04/24/2017 01:14 AM, Markus Mohrhard wrote: >> The patch that you referenced is correct and the code compiles because >> header files are recursively included. So if any of the header files in the >> include chain contains an "#include

Re: unique_ptr header question

2017-04-24 Thread Stephan Bergmann
On 04/24/2017 01:14 AM, Markus Mohrhard wrote: The patch that you referenced is correct and the code compiles because header files are recursively included. So if any of the header files in the include chain contains an "#include std::unique_ptr will be available in that translation unit. An

Re: unique_ptr header question

2017-04-23 Thread Markus Mohrhard
hey, On Mon, Apr 24, 2017 at 1:04 AM, Chris Sherlock wrote: > Hi all, > > I'm getting some build failures on Jenkins. It seems there is a > compilation failure because there are a number of files that use > std::unique_ptr but done include . > > I think it may have come from here: > > https://ge