Re: proposed easyhack: converting c++ unit tests from JUnit to CppUnit

2012-04-02 Thread Stephan Bergmann
On 04/02/2012 05:49 PM, Markus Mohrhard wrote: 2012/4/2 Stephan Bergmann: And once these better tests offer coverage comparable to the old ones, we can finally ditch them. I would prefer an incremental process here, but that is just my opinion. I think it makes sense every time a interface is

Re: proposed easyhack: converting c++ unit tests from JUnit to CppUnit

2012-04-02 Thread Markus Mohrhard
2012/4/2 Stephan Bergmann : > On 04/02/2012 01:29 PM, Noel Grandin wrote: >> >> So moving them to CppUnit would at least be a step in the right direction? > > > I don't think simply rewriting them from Java to C++ in their current form > is worth it.  It would be better to replace them with better

Re: proposed easyhack: converting c++ unit tests from JUnit to CppUnit

2012-04-02 Thread Stephan Bergmann
On 04/02/2012 01:29 PM, Noel Grandin wrote: So moving them to CppUnit would at least be a step in the right direction? I don't think simply rewriting them from Java to C++ in their current form is worth it. It would be better to replace them with better tests. And once these better tests of

Re: proposed easyhack: converting c++ unit tests from JUnit to CppUnit

2012-04-02 Thread Noel Grandin
On 2012-04-02 13:43, Michael Stahl wrote: sure, as long as you're not just blindly translating the stupid qadevOOo test to C++; Ah, but that's why it's an __EasyHack__ :-) But yes, I agree, building upon such a change to improve the test infrastructure is a better idea. Disclaimer: http://

Re: proposed easyhack: converting c++ unit tests from JUnit to CppUnit

2012-04-02 Thread Michael Stahl
On 02/04/12 13:29, Noel Grandin wrote: > > > On 2012-04-02 13:16, Michael Stahl wrote: >> the tests that are implemented in the "qadevOOo" module (aka "unoapi" >> tests, run via various $MODULE/qa/unoapi/$MODULE.sce files) are pretty >> awful in general and replacing them with something better

Re: proposed easyhack: converting c++ unit tests from JUnit to CppUnit

2012-04-02 Thread Noel Grandin
On 2012-04-02 13:16, Michael Stahl wrote: there are however various UNO API tests that are written in Java with JUnit, i guess you're talking about those. That is correct. the tests that are implemented in the "qadevOOo" module (aka "unoapi" tests, run via various $MODULE/qa/unoapi/$MODULE.

Re: proposed easyhack: converting c++ unit tests from JUnit to CppUnit

2012-04-02 Thread Michael Stahl
On 26/03/12 11:56, Noel Grandin wrote: > Hi > > I note that some of the C++ unit tests are being run from JUnit, which > seems counter-intuitive. writing C++ unit tests in Java would be rather impossible. there are however various UNO API tests that are written in Java with JUnit, i guess you'r

Re: proposed easyhack: converting c++ unit tests from JUnit to CppUnit

2012-03-26 Thread Michael Meeks
On Mon, 2012-03-26 at 11:56 +0200, Noel Grandin wrote: > I note that some of the C++ unit tests are being run from JUnit, which > seems counter-intuitive. :-) > Is there is a good reason for this, or would it simplify matters to > convert them to CppUnit? Everything we convert