Re: forward RTL_CONTEXT_foo logging to SAL_INFO in default debugging

2013-04-22 Thread Stephan Bergmann
On 04/22/2013 01:17 PM, Bjoern Michaelsen wrote: On Mon, Apr 22, 2013 at 01:04:30PM +0200, Stephan Bergmann wrote: On 04/17/2013 04:45 PM, Bjoern Michaelsen wrote: On Wed, Apr 17, 2013 at 04:13:15PM +0200, Stephan Bergmann wrote: What good is the intermediate move? That is, was there at least

Re: forward RTL_CONTEXT_foo logging to SAL_INFO in default debugging

2013-04-22 Thread Bjoern Michaelsen
On Mon, Apr 22, 2013 at 01:04:30PM +0200, Stephan Bergmann wrote: > On 04/17/2013 04:45 PM, Bjoern Michaelsen wrote: > >On Wed, Apr 17, 2013 at 04:13:15PM +0200, Stephan Bergmann wrote: > >>What good is the intermediate move? That is, was there at least one > >>situation in which it would have hel

Re: forward RTL_CONTEXT_foo logging to SAL_INFO in default debugging

2013-04-22 Thread Stephan Bergmann
On 04/17/2013 04:45 PM, Bjoern Michaelsen wrote: On Wed, Apr 17, 2013 at 04:13:15PM +0200, Stephan Bergmann wrote: What good is the intermediate move? That is, was there at least one situation in which it would have helped your debugging if an existing RTL_LOGFILE_* call had been behaving like

Re: forward RTL_CONTEXT_foo logging to SAL_INFO in default debugging

2013-04-17 Thread Bjoern Michaelsen
On Wed, Apr 17, 2013 at 04:13:15PM +0200, Stephan Bergmann wrote: > What good is the intermediate move? That is, was there at least one > situation in which it would have helped your debugging if an > existing RTL_LOGFILE_* call had been behaving like SAL_LOG? Yes, there had been: I was trying to

Re: forward RTL_CONTEXT_foo logging to SAL_INFO in default debugging

2013-04-17 Thread Tor Lillqvist
I am more and more starting to be of the opinion that all debugging printouts, SAL_INFO() (or RTL_foo) are mostly useless once the bug or misfeature you have been chasing (for which you have added the debugging logging) has been found and fixed;) If and when later some other bug in the same area

Re: forward RTL_CONTEXT_foo logging to SAL_INFO in default debugging

2013-04-17 Thread Stephan Bergmann
On 04/17/2013 03:39 PM, Bjoern Michaelsen wrote: please note: https://gerrit.libreoffice.org/#/c/3421/ and raise any violent opposition to this move here, if there is no such opposition on the ESC call, Im going to push it tommorrow. The rationale (beyond what is in the commit message) is as