Re: fdo#55814: unit test is missing

2013-05-02 Thread Michael Stahl
On 01/05/13 23:33, David Ostrovsky wrote: > On 30.04.2013 23:46, Stephan Bergmann wrote: >> On 04/29/2013 11:42 PM, David Ostrovsky wrote: >>> cli_ure is failing to compile here atm. >> >> How's it failing for you exactly? I'd hope it does work now, across >> various Windows build configurations.

Re: fdo#55814: unit test is missing

2013-05-01 Thread David Ostrovsky
On 30.04.2013 23:46, Stephan Bergmann wrote: On 04/29/2013 11:42 PM, David Ostrovsky wrote: cli_ure is failing to compile here atm. How's it failing for you exactly? I'd hope it does work now, across various Windows build configurations. yes, after you've fixed it ;-) so, with this patch

Re: fdo#55814: unit test is missing

2013-04-30 Thread Stephan Bergmann
On 04/29/2013 11:42 PM, David Ostrovsky wrote: cli_ure is failing to compile here atm. How's it failing for you exactly? I'd hope it does work now, across various Windows build configurations. Stephan ___ LibreOffice mailing list LibreOffice@list

Re: fdo#55814: unit test is missing

2013-04-29 Thread David Ostrovsky
On 29.04.2013 09:41, Stephan Bergmann wrote: Is it really working on all platforms, incl. Windows? If yes, why is sw/Module_sw.mk still ifneq ($(DISABLE_PYTHON),TRUE) ifneq ($(OS),WNT) $(eval $(call gb_Module_add_subsequentcheck_targets,sw,\ PythonTest_sw_python \ )) endif endif good cat

Re: fdo#55814: unit test is missing

2013-04-29 Thread Stephan Bergmann
On 04/27/2013 12:40 PM, David Ostrovsky wrote: so I migrated the fdo#55814 java unit test to python: sw/qa/complex/writer/VarFields.java sw/qa/python/var_fields.py "comment out storeToURL() as it

Re: fdo#55814: unit test is missing

2013-04-29 Thread Stephan Bergmann
On 04/27/2013 12:40 PM, David Ostrovsky wrote: Python test machinery (in process) is up and running on system and internal python and on all platforms. Many thanks to Michael S. and Stephan for helping out with this! Is it really working on all platforms, incl. Windows? If yes, why is sw/Modu

Re: fdo#55814: unit test is missing

2013-04-27 Thread David Ostrovsky
Hi, On Fri, 2013-03-22 at 10:58 +0100, Miklos Vajna wrote: > Hi David, > > On Thu, Mar 21, 2013 at 10:42:27AM +0100, David Ostrovsky wrote: > > I wonder if it would make sense to establish > > Python_test machinery in our build system to be able to write such and > > many other tests in python in

Re: fdo#55814: unit test is missing

2013-03-22 Thread Miklos Vajna
Hi David, On Thu, Mar 21, 2013 at 10:42:27AM +0100, David Ostrovsky wrote: > And yes i am going to migrate it to C++ as you argued that it would be > easier to debug then java. I wonder if it would make sense to establish > Python_test machinery in our build system to be able to write such and >

Re: fdo#55814: unit test is missing

2013-03-21 Thread David Ostrovsky
Hi Miklos, On Mon, 2013-03-18 at 11:18 +0100, Miklos Vajna wrote: > Hi David, > > On Sat, Mar 09, 2013 at 02:29:54PM +0100, David Ostrovsky > wrote: > > I wonder why we don't have any unit test for that part of code? > > We do have one: > > http://cgit.freedesktop.org/libreoffice/core/commit/

Re: fdo#55814: unit test is missing

2013-03-18 Thread Miklos Vajna
Hi David, On Sat, Mar 09, 2013 at 02:29:54PM +0100, David Ostrovsky wrote: > I wonder why we don't have any unit test for that part of code? We do have one: http://cgit.freedesktop.org/libreoffice/core/commit/?id=10e02dfdffb5ef3a02a40b52c6cda176f7f4447c It's just not testing the case we have

Re: fdo#55814: unit test is missing

2013-03-11 Thread Terrence Enger
On Mon, 2013-03-11 at 13:28 +, Michael Meeks wrote: > No-one wrote it yet ? :-) it's hardish to implemnt writer unit-tests > even now ? ( at least my attempt at auto-testing the red-lining also ran > into the ground inconclusively before I could write code to test the > specific issue tha

Re: fdo#55814: unit test is missing

2013-03-11 Thread Michael Meeks
On Sat, 2013-03-09 at 14:29 +0100, David Ostrovsky wrote: > i've been told yesterday that the usage of writer is severly restricted. > All versions since 3.5 are affected. There is a bug for it: > https://bugs.freedesktop.org/show_bug.cgi?id=55814 Nasty. > I wonder why we don't have any