Re: cppcheck algorithm suggestions

2021-01-25 Thread Dr. David Alan Gilbert
* Lubo?? Lu???k (l.lu...@collabora.com) wrote: > On Saturday 23 of January 2021, Dr. David Alan Gilbert wrote: > > Hi, > > What are peoples feelings for cppcheck's suggestions for stl algorithms? > > In https://gerrit.libreoffice.org/c/core/+/109846 I did a 'any_of' > > and a 'accumulate' that it

Re: cppcheck algorithm suggestions

2021-01-25 Thread Luboš Luňák
On Saturday 23 of January 2021, Dr. David Alan Gilbert wrote: > Hi, > What are peoples feelings for cppcheck's suggestions for stl algorithms? > In https://gerrit.libreoffice.org/c/core/+/109846 I did a 'any_of' > and a 'accumulate' that it suggested; the any_of does look better, > the accumulat

Re: cppcheck algorithm suggestions

2021-01-25 Thread Miklos Vajna
Hi Dave, On Sat, Jan 23, 2021 at 09:36:57PM +, "Dr. David Alan Gilbert" wrote: > What are peoples feelings for cppcheck's suggestions for stl algorithms? > In https://gerrit.libreoffice.org/c/core/+/109846 I did a 'any_of' > and a 'accumulate' that it suggested; the any_of does look bette