Re: Weekly report about character border

2013-07-21 Thread Zolnai Tamás
Hi all, This week I managed to solve the initial difficulties of character border painting: - Change the size of the text portion which has border. (three distinct size attribute: height, ascent and size) - Part of the top border hanged out from the text portion (use SwAlignRect) - Calculati

Re: Weekly report about character border

2013-07-15 Thread Zolnai Tamás
Hi all, In the previous week I started to implement the painting. Some special problem came up, which might give me a hard time. The first very annoying one stem from the unpunctuality of the recent border painting (frame painting). It seems the border primitives are shifted toward the origo w

Re: Weekly report about character border

2013-07-15 Thread Zolnai Tamás
Hi all, In the previous week I started to implement the painting. Some special problem came up, which might give me a hard time. The first very annoying one stem from the unpunctuality of the recent border painting (frame painting). It seems the border primitives are shifted toward the origo w

Re: Weekly report about character border

2013-07-08 Thread Miklos Vajna
On Mon, Jul 08, 2013 at 06:03:42PM +0200, Zolnai Tamás wrote: > I referred only one commit's sha1 but that commit is in master so I think > it will not be a problem, will be? No, it's not a big problem. After the rebase is done (but before push), you can even run 'git rebase -i ', change "pick"

Re: Weekly report about character border

2013-07-08 Thread Zolnai Tamás
2013/7/8 Miklos Vajna > Hi Tamas, > > On Sun, Jul 07, 2013 at 09:08:54PM +0200, Zolnai Tamás < > zolnaitamas2...@gmail.com> wrote: > > Questions which came up this week: > > - How does the frame class hierarchy look like (inheritance, base and > > derived classes)? > > - Should we make a new

Re: Weekly report about character border

2013-07-08 Thread Miklos Vajna
Hi Tamas, On Sun, Jul 07, 2013 at 09:08:54PM +0200, Zolnai Tamás wrote: > Questions which came up this week: > - How does the frame class hierarchy look like (inheritance, base and > derived classes)? > - Should we make a new type of frame and add it to the existent frame > hierarchy? A fram

Re: Weekly report about character border

2013-07-07 Thread Zolnai Tamás
Hi all, Notes of this third week. It starts become clear how to solve painting of character border. I read the code and see that painting of character background is solved by SwTxtPaintInfo. I intend to implement character border in such way that the background fills out all the place inside the b

Re: Weekly report about character border

2013-07-01 Thread Zolnai Tamás
Hi, Cedric, > - How does the system store attributes? (SwFmt, SwAttrSet, > > SwAttrStack) > > You got the proper classes. If you need some help to debug the > SfxItemSet, you can have a look at my old gdbinit here (function > dump_psfxitemset): > > > http://cgit.freedesktop.org/libreoffice/build

Re: Weekly report about character border

2013-07-01 Thread Zolnai Tamás
Yes, layout already has the way using borders. Let's see how does it work, maybe all aspect of border (shadow and spacing too) can added at one go. 2013/7/1 Miklos Vajna > On Mon, Jul 01, 2013 at 09:17:02AM +0200, Cedric Bosdonnat < > cedric.bosdon...@free.fr> wrote: > > > This is an interestin

Re: Weekly report about character border

2013-07-01 Thread Miklos Vajna
On Mon, Jul 01, 2013 at 09:17:02AM +0200, Cedric Bosdonnat wrote: > > This is an interesting question, yes. My opinion is that it would be > > good to do this in VCL ("font"), so not only Writer can benefit from > > this, but later also other applications. > > Well, I was originally more thinkin

Re: Weekly report about character border

2013-07-01 Thread Miklos Vajna
On Sun, Jun 30, 2013 at 06:35:07PM +0200, Zolnai Tamás wrote: > - How can we implement character border? (two distinct solution: font or > layout frame) This is an interesting question, yes. My opinion is that it would be good to do this in VCL ("font"), so not only Writer can benefit from thi

Re: Weekly report about character border

2013-06-30 Thread Zolnai Tamás
Hi all, Some notes about my progress in the second week. In this week I added the "Borders" tab page to the character dialog and so the UI part of the implementation works. After this I started to learn about character attributes, fonts and layout. Questions of this week (some of them are answere

Re: Weekly report about character border

2013-06-24 Thread Miklos Vajna
Hi Tamas, On Sun, Jun 23, 2013 at 06:33:01PM +0200, Zolnai Tamás wrote: > Up to now I just make some cleanup commits in the code belonging to these > questions: > http://cgit.freedesktop.org/libreoffice/core/log/?h=feature/gsoc-writer-char-borders Nice, great to see your progress! A nitpick: i