Re: PVS-Studio report

2024-11-27 Thread Natalia Elsher
What kind of dal? Lentil? On Wed, 27 Nov 2024 at 2:32 PM, Xisco Fauli wrote: > Hello, > > Unfortunately now it's flagging a lot of issues like > > const SfxBoolItem* pStateItem = dynamic_cast( pItem ); > assert(pStateItem); // SfxBoolItem expected > if (pStateItem) > ↑ V547 Expression 'pStateIt

Re: PVS-Studio report

2024-11-27 Thread Xisco Fauli
Hello, Unfortunately now it's flagging a lot of issues like const SfxBoolItem* pStateItem = dynamic_cast( pItem  ); assert(pStateItem); // SfxBoolItem expected if (pStateItem) ↑ V547 Expression 'pStateItem' is always true. which is not ideal either, so I updated the report again without //V_AS

Re: PVS-Studio report

2024-11-25 Thread Xisco Fauli
Hello, On 21/11/24 13:41, Caolán McNamara wrote: On Thu, 2024-11-21 at 12:51 +0100, Xisco Fauli wrote: -> it can be fixed with https://pvs-studio.com/en/docs/manual/0040/#IDBD1CC960F7 Do I read it right, that it just has to see the comment somewhere, e.g. if added to include/sal/config.h to tr

Re: PVS-Studio report

2024-11-21 Thread Caolán McNamara
On Thu, 2024-11-21 at 12:51 +0100, Xisco Fauli wrote: > -> it can be fixed with > https://pvs-studio.com/en/docs/manual/0040/#IDBD1CC960F7 Do I read it right, that it just has to see the comment somewhere, e.g. if added to include/sal/config.h to treat all asserts like that ? > bool bDropDown =