Re: Modernizing atomics

2015-10-27 Thread Stephan Bergmann
On 10/26/2015 06:14 PM, Ashod Nakashian wrote: As a transitional phase, we can maintain the same interface but with std:atomic as the implementation. osl/interlck.h is part of the stable URE interface. While the osl_atomic_inc-/decrement macros are marked as INTERNAL and should arguably not

Re: Modernizing atomics

2015-10-26 Thread Norbert Thiebaud
On Mon, Oct 26, 2015 at 5:30 PM, Ashod Nakashian wrote: > Not sure which horror you are referring to (surely you meant 'our', for the > collective codebase). Yes, I meant 'our', sorry. > > on Windows and if it improves things in the profiler, I'll submit a patch > for consideration. > I think it

Re: Modernizing atomics

2015-10-26 Thread Ashod Nakashian
Thanks Norbert for the detailed reply. Some comments below. On Mon, Oct 26, 2015 at 5:28 PM, Norbert Thiebaud wrote: > On Mon, Oct 26, 2015 at 2:56 PM, Ashod Nakashian > wrote: > > On Mon, Oct 26, 2015 at 2:21 PM, Norbert Thiebaud > > wrote: > >> > >> On Mon, Oct 26, 2015 at 1:00 PM, Ashod Nak

Re: Modernizing atomics

2015-10-26 Thread Norbert Thiebaud
On Mon, Oct 26, 2015 at 2:56 PM, Ashod Nakashian wrote: > On Mon, Oct 26, 2015 at 2:21 PM, Norbert Thiebaud > wrote: >> >> On Mon, Oct 26, 2015 at 1:00 PM, Ashod Nakashian >> wrote: >> > On Mon, Oct 26, 2015 at 1:35 PM, Norbert Thiebaud >> > wrote: >> >> >> >> On Mon, Oct 26, 2015 at 12:14 PM,

Re: Modernizing atomics

2015-10-26 Thread Ashod Nakashian
On Mon, Oct 26, 2015 at 2:21 PM, Norbert Thiebaud wrote: > On Mon, Oct 26, 2015 at 1:00 PM, Ashod Nakashian > wrote: > > On Mon, Oct 26, 2015 at 1:35 PM, Norbert Thiebaud > > wrote: > >> > >> On Mon, Oct 26, 2015 at 12:14 PM, Ashod Nakashian > >> wrote: > >> > OSL provides atomic helpers (osl_

Re: Modernizing atomics

2015-10-26 Thread Norbert Thiebaud
On Mon, Oct 26, 2015 at 1:00 PM, Ashod Nakashian wrote: > On Mon, Oct 26, 2015 at 1:35 PM, Norbert Thiebaud > wrote: >> >> On Mon, Oct 26, 2015 at 12:14 PM, Ashod Nakashian >> wrote: >> > OSL provides atomic helpers (osl_atomic_xxx) in the form of a GNU >> > builtin >> > (where available) or a p

Re: Modernizing atomics

2015-10-26 Thread Ashod Nakashian
On Mon, Oct 26, 2015 at 1:35 PM, Norbert Thiebaud wrote: > On Mon, Oct 26, 2015 at 12:14 PM, Ashod Nakashian > wrote: > > OSL provides atomic helpers (osl_atomic_xxx) in the form of a GNU builtin > > (where available) or a platform-specific implementation. > > > > Any reason for not using modern

Re: Modernizing atomics

2015-10-26 Thread Norbert Thiebaud
On Mon, Oct 26, 2015 at 12:14 PM, Ashod Nakashian wrote: > OSL provides atomic helpers (osl_atomic_xxx) in the form of a GNU builtin > (where available) or a platform-specific implementation. > > Any reason for not using modern std::atomic (besides possible lack of > volunteers) ? > > > As a trans