Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-18 Thread Maarten Hoes
On Tue, May 17, 2022 at 10:53 AM Michael Stahl wrote: > On 15.05.22 15:00, Maarten Hoes wrote: > > I guess that 'git bisect run' considers things a 'success' if the build > > succeeds (zero exit code), and a 'failure' if the build fails (non zero > > exit code). Duh. But I don't get the impressio

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-18 Thread Maarten Hoes
On Tue, May 17, 2022 at 11:42 AM Michael Stahl wrote: > On 13.05.22 16:42, Maarten Hoes wrote: > > So to sum it up, with only gcc installed, the gcov build works if I > modify : > > > > external/expat/ExternalProject_expat.mk > > external/liborcus/ExternalProject_liborcus.mk > > > > and add : > >

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-17 Thread Michael Stahl
On 13.05.22 16:42, Maarten Hoes wrote: So to sum it up, with only gcc installed, the gcov build works if I modify : external/expat/ExternalProject_expat.mk external/liborcus/ExternalProject_liborcus.mk and add : CFLAGS += -fprofile-arcs -ftest-coverage CXXFLAGS += -fprofile-arcs -ftest-coverag

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-17 Thread Michael Stahl
On 15.05.22 15:00, Maarten Hoes wrote: I guess that 'git bisect run' considers things a 'success' if the build succeeds (zero exit code), and a 'failure' if the build fails (non zero exit code). Duh. But I don't get the impression that it matters to git what it exactly was that made the build f

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-16 Thread Maarten Hoes
On Sun, May 15, 2022 at 3:00 PM Maarten Hoes wrote: > > I guess that 'git bisect run' considers things a 'success' if the build > succeeds (zero exit code), and a 'failure' if the build fails (non zero > exit code). Duh. But I don't get the impression that it matters to git what > it exactly was

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-15 Thread Maarten Hoes
Hi, On Wed, May 11, 2022 at 9:07 PM Thorsten Behrens wrote: > Hi Maarten, > > Maarten Hoes wrote: > > I personally do not know enough about the build system to figure out how > to > > correct this. Any and all help in trying to make this work again would be > > appreciated. > > > Beyond what Lu

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-13 Thread Maarten Hoes
On Fri, May 13, 2022 at 4:42 PM Maarten Hoes wrote: > > Judging by the comments, it looks like clang for skia is only enforced on > Windows and Mac (comment : '#Skia is the default on Windows and Mac, so > hard-require Clang.', around line 12177 in configure.ac). > > Sorry, that may not have been

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-13 Thread Maarten Hoes
On Fri, May 13, 2022 at 3:06 PM Stephan Bergmann wrote: > Just performance, I think. Luboš should know the details. > Ok. Then for my use case, it would not really be that much of an issue to compile with gcc instead. Maybe your solution for now is --disable-skia? > Perhaps, or at least a wo

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-13 Thread Stephan Bergmann
On 5/13/22 14:43, Maarten Hoes wrote: As far as I can tell right now, using gcc to build everything would be the ideal situation for my use case. But of course, I don't know why the decision was made to always build skia with clang instead of gcc: does the build fail with gcc, does it compile b

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-13 Thread Maarten Hoes
On Fri, May 13, 2022 at 10:37 AM Stephan Bergmann wrote: > On 5/12/22 15:44, Maarten Hoes wrote: > > What I *think* I see happening, is that the '-fprofile-arcs > > -ftest-coverage -lgcov' flags are correctly being set on the > > commandlines, up until were the error occurs, which is where (i thi

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-13 Thread Stephan Bergmann
On 5/12/22 15:44, Maarten Hoes wrote: What I *think* I see happening, is that the '-fprofile-arcs -ftest-coverage -lgcov' flags are correctly being set on the commandlines, up until were the error occurs, which is where (i think) linking against libpng is attempted (see error below). I tried se

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-12 Thread Maarten Hoes
On Thu, May 12, 2022 at 8:47 AM Stephan Bergmann wrote: > On 5/11/22 21:07, Maarten Hoes wrote: > > I also added '--with-parallelism=1' to ./autogen.sh, to make the output > > of 'make' a little clearer and easier to read. > > ...or, for a parallelizing make invocation, pass -O (aka > --output-sy

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-12 Thread Maarten Hoes
On Thu, May 12, 2022 at 8:42 AM Stephan Bergmann wrote: > On 5/11/22 21:07, Maarten Hoes wrote: > > I just noticed: reading back the error more carefully, I noticed it's > > clang that generated the error, even though I didn't specifically tried > > to compile with clang. (I had both clang and gc

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-11 Thread Stephan Bergmann
On 5/11/22 21:07, Maarten Hoes wrote: I also added '--with-parallelism=1' to ./autogen.sh, to make the output of 'make' a little clearer and easier to read. ...or, for a parallelizing make invocation, pass -O (aka --output-sync=target)

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-11 Thread Stephan Bergmann
On 5/11/22 21:07, Maarten Hoes wrote: I just noticed: reading back the error more carefully, I noticed it's clang that generated the error, even though I didn't specifically tried to compile with clang. (I had both clang and gcc installed). For better or worse, external/skia forcefully uses Cl

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-11 Thread Maarten Hoes
Ah. I added the flags to 2 files, listed below, and rebuild. It builds now. I'm not too sure if the edits below are entirely placed in the right way or in the right place, but it does make the build work ;) external/liborcus/ExternalProject_liborcus.mk external/expat/ExternalProject_expat.mk Th

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-11 Thread Luboš Luňák
On Wednesday 11 of May 2022, Maarten Hoes wrote: > Thanks. > > > I just noticed: reading back the error more carefully, I noticed it's clang > that generated the error, even though I didn't specifically tried to > compile with clang. (I had both clang and gcc installed). I uninstalled > clang and o

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-11 Thread Maarten Hoes
Thanks. I just noticed: reading back the error more carefully, I noticed it's clang that generated the error, even though I didn't specifically tried to compile with clang. (I had both clang and gcc installed). I uninstalled clang and only left gcc to see if that made any difference, and I still

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-11 Thread Thorsten Behrens
Hi Maarten, Maarten Hoes wrote: > I personally do not know enough about the build system to figure out how to > correct this. Any and all help in trying to make this work again would be > appreciated. > Beyond what Lubos suggested, and assuming your error happens fairly quickly - you might want t

Re: Compiling LO for lcov/gcov code coverage fails (gb_GCOV=YES)

2022-05-11 Thread Luboš Luňák
On Wednesday 11 of May 2022, Maarten Hoes wrote: > Hi, > > > I'm trying to build LibreOffice on Linux (Fedora 36) with the appropriate > flags set for 'lcov/gcov code coverage' (how many / which lines of the > codebase get executed by running the test suite 'make check'). Normally you > would set t