Re: Building skia with clang(-cl)

Hi, Am 09.06.20 um 08:45 schrieb Michael Weghorn: > Yes, you mentioned that indeed; I was just referring to the part of the > email I quoted where you were mentioning what would happen if -gtk3 was > made non-optional in Debian. Ah, right, that was more like "loud thinking". I don't like to force

Re: Building skia with clang(-cl)

On 09/06/2020 08.32, Rene Engelhard wrote: > Hi, > > Am 09.06.20 um 08:18 schrieb Michael Weghorn: >> On 08/06/2020 15.16, Rene Engelhard wrote: >>> (I consider the existence of gen a problem, too, maybe I should just >>> make -gtk3 a non-optional part. >>> >>> But still then afaik the desktop det

Re: Building skia with clang(-cl)

Hi, Am 09.06.20 um 08:18 schrieb Michael Weghorn: > On 08/06/2020 15.16, Rene Engelhard wrote: >> (I consider the existence of gen a problem, too, maybe I should just >> make -gtk3 a non-optional part. >> >> But still then afaik the desktop detector will still use "gen" on e.g. >> fluxbox or so, d

Re: Building skia with clang(-cl)

On 08/06/2020 15.16, Rene Engelhard wrote: > (I consider the existence of gen a problem, too, maybe I should just > make -gtk3 a non-optional part. > > But still then afaik the desktop detector will still use "gen" on e.g. > fluxbox or so, didn't actually check lately?) IIRC, Caolán mentioned tha

Re: Building skia with clang(-cl)

Hi, Am 08.06.20 um 12:12 schrieb Luboš Luňák: > But as long as Skia is used only by VCL gen backend this really doesn't > matter in practice. We could probably even default to --disable-skia on Linux > and it wouldn't make much of a difference for users. I don't mind here either default but pleas

Re: Building skia with clang(-cl)

On Monday 08 of June 2020, Stephan Bergmann wrote: > On 23/04/2020 11:46, Miklos Vajna wrote: > > In short, I would like to hear what others think about using clang(-cl) > > for building skia. > > > > Why? See this video from Lubos, showing skia raster performance on > > Windows:

Re: Building skia with clang(-cl)

On 23/04/2020 11:46, Miklos Vajna wrote: In short, I would like to hear what others think about using clang(-cl) for building skia. Why? See this video from Lubos, showing skia raster performance on Windows: . Above is clang-cl, below is MSVC. The reason for the dif

Re: Building skia with clang(-cl)

Hi Thorsten, On Thu, Apr 23, 2020 at 04:42:17PM +0200, Thorsten Behrens wrote: > No objections, but I'd much prefer to have release and normal builds > use the same compiler then. If it's easy to add in VS2019, let's make > it a prerequisite & fail hard otherwise. Now

Re: Building skia with clang(-cl)

On 24/04/2020 09:47, Mike Kaganski wrote: On 23.04.2020 17:42, Thorsten Behrens wrote: Miklos Vajna wrote: 1) Make the warning more visible, i.e. a yellow warning at the end of configure, that is actually noticed by most people. 2) Make the warning an error in case of release builds (or someth

Re: Building skia with clang(-cl)

On 23/04/2020 15:48, Luboš Luňák wrote: Just for completeness, there's one more option, and that's using Clang-cl instead of MSVC for everything. E.g. Mozilla does it, it is already possible to build LO that way (and I think Stephan does that regularly?). I'm not promoting this option though

Re: Building skia with clang(-cl)

Hi Mike, On Fri, Apr 24, 2020 at 10:47:35AM +0300, Mike Kaganski wrote: > But we don't prevent people building using clang/gcc/msvc in general, > regardless of the actual compiler used in release? I believe the point was "avoid unnecessary difference between release and dev builds", there is va

Re: Building skia with clang(-cl)

On 23.04.2020 17:42, Thorsten Behrens wrote: > Miklos Vajna wrote: >> 1) Make the warning more visible, i.e. a yellow warning at the end of >> configure, that is actually noticed by most people. >> >> 2) Make the warning an error in case of release builds (or something >> like that). >> > No object

Re: Building skia with clang(-cl)

Hi Miklos, Miklos Vajna wrote: > 1) Make the warning more visible, i.e. a yellow warning at the end of > configure, that is actually noticed by most people. > > 2) Make the warning an error in case of release builds (or something > like that). > No objections, but I'd much prefer to have release

Re: Building skia with clang(-cl)

On Thursday 23 of April 2020, Miklos Vajna wrote: > Hi, > > In short, I would like to hear what others think about using clang(-cl) > for building skia. Just for completeness, there's one more option, and that's using Clang-cl instead of MSVC for everything. E.g. Mozilla does it, it is already p

Re: Building skia with clang(-cl)

On 23.04.2020 12:46, Miklos Vajna wrote: > 1) Make the warning more visible, i.e. a yellow warning at the end of > configure, that is actually noticed by most people. That looks natural to me, and is easy to change in configure.ac. I don't think that any non-standard warnings in configure.ace (i.e